Hi,
I'd like to know, can I use old ovs-ofctl(wdp codebase) with new OVS(ovs
2.3.0)? And do I need to advertise the OF variant(1.0 or 1.3) to OVS? If yes
then how?
Regards,
Abhijit
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailma
The original message was received at Fri, 5 Jun 2015 16:32:09 +0700
from whos.amung.us [218.30.188.166]
- The following addresses had permanent fatal errors -
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/de
Sorry but unfortunately I could not get the patch on the ML.
Created the following pull request instead:
https://github.com/openvswitch/ovs/pull/49 .
Thank you,
Alin.
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
>
> When tx queue is shared among CPUS,the pkts always be flush in
> 'netdev_dpdk_eth_send'
> So it is unnecessarily for flushing in netdev_dpdk_rxq_recv Otherwise tx will
> be accessed without locking
Are you seeing a specific bug or is this just to account for a device with
less queues than pmd
Alin,
I do not see Alessandro's signed-off. Can you please add.
On Fri, Jun 5, 2015 at 5:16 AM, Alin Serdean
wrote:
> Sorry but unfortunately I could not get the patch on the ML.
> Created the following pull request instead:
> https://github.com/openvswitch/ovs/pull/49 .
>
> Thank you,
> Alin.
Until now, when two tunnels had an identical configuration, both of them
were assigned OpenFlow ports, but only one of those OpenFlow ports was
functional. With this commit, only one of the two (or more) identically
configured tunnels will be assigned an OpenFlow port number.
Reported-by: Keith H
Wow, thanks for figuring that out!
I think that these changes are OK.
I'll fold them into my patch and repost.
On Thu, Jun 04, 2015 at 02:13:51AM -0700, Andy Zhou wrote:
> By bumb luck, I noticed that 'ofproto->backer->tnl_count' will affect
> how ovs_native_tunneling_is_on() gives its answer.
Andy, I added you as co-author on this, can you give me a Signed-off-by
for your contribution?
On Fri, Jun 05, 2015 at 08:13:28AM -0700, Ben Pfaff wrote:
> Until now, when two tunnels had an identical configuration, both of them
> were assigned OpenFlow ports, but only one of those OpenFlow ports
On Wed, Jun 03, 2015 at 11:21:50PM -0700, Alex Wang wrote:
> OVS datapath has check which prevents the installation of flow
> that matches VLAN TCI but does not have exact match for VLAN_CFI
> bit. However, the ovs userspace does not enforce it, so OpenFlow
> flow like "vlan_tci=0x000a/0x0fff,acti
Thx for the reference, exactly what i want,
Will change the solution~
Thanks,
Alex Wang,
On Fri, Jun 5, 2015 at 8:24 AM, Ben Pfaff wrote:
> On Wed, Jun 03, 2015 at 11:21:50PM -0700, Alex Wang wrote:
> > OVS datapath has check which prevents the installation of flow
> > that matches VLAN TCI bu
On Fri, May 29, 2015 at 04:00:27PM +0530, saloni.jai...@gmail.com wrote:
> From: Saloni Jain
>
> This commit enables the eviction mechanism on the basis of importance as
> per the openflow specification 1.4.
>
> "ovs-ofctl -O OpenFlow14 mod-table evict"
> Enable eviction on of . Eviction adds
On Wed, May 27, 2015 at 10:34:31AM +0200, Mijo Safradin wrote:
> Commit 7a6cf343a410d77e05ebd7bf5b5ade52803879ae raised the MAXFD
> limit from 7500 to 65535.
>
> Signed-off-by: Mijo Safradin
Applied, thanks!
___
dev mailing list
dev@openvswitch.org
htt
On Thu, May 14, 2015 at 08:04:02PM -0700, Shashank Shanbhag wrote:
> > It's unusual to dynamically allocate an ovs_list head. I would
> > ordinarily just declare 'tables' as a plain ovs_list instead of a
> > pointer.
> >
> > Do you think there is much value in maintaining the order of table
> > up
On Sat, May 16, 2015 at 07:46:59PM -0700, shashank.shanb...@gmail.com wrote:
> From: Shashank Shanbhag
>
> Fix replace-flows and diff-flows to modify/diff flows in multiple tables.
> Add a --tables option that allows the user to specify a comma-separated
> list of table indexes to replace/diff.
>
Hi Ben,
Thanks.
I thought there are only hidden flows, and not hidden tables.
We are reading all tables from 0 to OFPTT_MAX-1.
But, I see what you're saying. I can probably use OFPMP_TABLE_FEATURES
(openflow1.4 spec Section 7.3.5.6) to get all the configured tables. Will
this ensure the hidden ta
Use xzalloc instead of xmalloc for some key structure allocations in
ofproto-dpif (viz. ofproto_dpif, ofport_dpif and rule_dpif) so as to
prevent uninitialized values in these structures. Also add seat belts
around these structure allocations.
Signed-off-by: Sabyasachi Sengupta
---
diff --git
On Tue, May 19, 2015 at 10:02 AM, Alin Serdean
wrote:
> This patch implements two functionalities needed for an active manager:
> 1. ARP lookup
> 2. Next hop
>
> The first functionality relies on the internal Windows API:
> https://urldefense.proofpoint.com/v2/url?u=https-3A__msdn.microsoft.com_en
How about this?
diff --git a/lib/match.c b/lib/match.c
index 7d0b409..e34572d 100644
--- a/lib/match.c
+++ b/lib/match.c
@@ -360,6 +360,10 @@ match_set_dl_tci(struct match *match, ovs_be16 tci)
void
match_set_dl_tci_masked(struct match *match, ovs_be16 tci, ovs_be16 mask)
{
+if (mask && mas
Sure.
Alin.
-Mesaj original-
De la: Gurucharan Shetty [mailto:shet...@nicira.com]
Trimis: Friday, June 5, 2015 9:00 PM
Către: Alin Serdean
Cc: dev@openvswitch.org
Subiect: Re: [ovs-dev] [PATCH] ARP lookup and next hop functionality on windows
On Tue, May 19, 2015 at 10:02 AM, Alin Serde
Sure.
Alin.
-Mesaj original-
De la: Gurucharan Shetty [mailto:shet...@nicira.com]
Trimis: Friday, June 5, 2015 5:57 PM
Către: Alin Serdean
Cc: dev@openvswitch.org; Nithin Raju; Eitan Eliahu
Subiect: Re: [PATCH v6] This commit adds the windows installer to the OVS tree.
Alin,
I do not s
Thank you for your kindness.
Signed-off-by: Andy Zhou
On Fri, Jun 5, 2015 at 8:14 AM, Ben Pfaff wrote:
> Andy, I added you as co-author on this, can you give me a Signed-off-by
> for your contribution?
>
> On Fri, Jun 05, 2015 at 08:13:28AM -0700, Ben Pfaff wrote:
>> Until now, when two tunnels
Add the library iphlpapi to the appveyor.yml build script.
Signed-off-by: Alin Gabriel Serdean
---
appveyor.yml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/appveyor.yml b/appveyor.yml
index a14f0fc..863b561 100644
--- a/appveyor.yml
+++ b/appveyor.yml
@@ -39,5 +39,5 @@ bu
I just sent the fix: http://openvswitch.org/pipermail/dev/2015-June/056007.html
.
Sorry for the failing build.
I will repost the pull request after this one is merged.
Thanks,
Alin.
-Mesaj original-
De la: dev [mailto:dev-boun...@openvswitch.org] În numele Alin Serdean
Trimis: Friday,
Thanks for the suggestons, all applied in the v3 series I’ll post soon.
Jarno
> On May 20, 2015, at 11:26 AM, Romain Lenglet
> wrote:
>
> Jarno,
> Thanks a lot for this updated patch, this will be very useful.
> Sorry, I don’t feel comfortable reviewing the other patches.
>
> Acked-by: Roma
> On May 29, 2015, at 8:58 PM, Ben Pfaff wrote:
>
> On Mon, May 18, 2015 at 04:10:25PM -0700, Jarno Rajahalme wrote:
>> The new ovs-ofctl 'bundle' command accepts files similar to
>> 'add-flows', but each line can optionally start with 'add', 'modify',
>> 'delete', 'modify_strict', or 'delete_st
On Fri, Jun 5, 2015 at 11:39 AM, Alin Serdean
wrote:
> Add the library iphlpapi to the appveyor.yml build script.
>
> Signed-off-by: Alin Gabriel Serdean
Thanks, applied!
> ---
> appveyor.yml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/appveyor.yml b/appveyor.yml
> i
The older version is no longer available for download.
Signed-off-by: Gurucharan Shetty
---
appveyor.yml |6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/appveyor.yml b/appveyor.yml
index 863b561..ebd937b 100644
--- a/appveyor.yml
+++ b/appveyor.yml
@@ -15,9 +15,9 @@
Acked-by: Alin Serdean .
-Mesaj original-
De la: dev [mailto:dev-boun...@openvswitch.org] În numele Gurucharan Shetty
Trimis: Friday, June 5, 2015 10:27 PM
Către: dev@openvswitch.org
Cc: Gurucharan Shetty
Subiect: [ovs-dev] [PATCH] appveyor: Add a newer ssl link.
The older version is no
On Fri, Jun 5, 2015 at 2:21 PM, Alin Serdean
wrote:
> Acked-by: Alin Serdean .
Thank you, applied!
>
>
> -Mesaj original-
> De la: dev [mailto:dev-boun...@openvswitch.org] În numele Gurucharan Shetty
> Trimis: Friday, June 5, 2015 10:27 PM
> Către: dev@openvswitch.org
> Cc: Gurucharan Shet
We set this field flag for the cases when an out_port should be
parsed, but failed to make use of it.
Two test cases needed to be updated due to use of out_port in flow
add, while out_port is legal for flow deletes only.
Suggested-by: Ben Pfaff
Signed-off-by: Jarno Rajahalme
---
lib/ofp-parse.
This series adds support for atomic flow mod bundles with classifier
versioning.
Changes since v2:
- F_OUT_PORT parsing is fixed as per Ben's suggestion (patch 01).
- ovs-ofctl 'bundle' command added in v2 is now folded in to the
existing 'add-flow' and 'add-flows' commands. Flow mods are
e
Weirdest things can bother you at night when you try to sleep ;-)
Now we have function triples such as add_flow_begin(),
add_flow_finish(), and add_flow_revert(), where a modification is
started in *_begin(), which can fail, and when successful can be
either made permanent with *_finish(), or canc
All existing ovs-ofctl flow mod commands now take an optional
'--bundle' argument, which executes the flow mods as a single
transaction. OpenFlow 1.4+ is implicitly assumed when '--bundle' is
specified.
ovs-ofctl 'add-flow' and 'add-flows' commands now accept flow
specifications that start with a
This patch allows classifier rules to become visible and invisible in
specific versions. A 'version' is defined as a positive monotonically
increasing integer, which never wraps around.
The new 'visibility' attribute replaces the prior 'to_be_removed' and
'visible' attributes.
When versioning is
The traversal of the list of identical rules from the lookup threads
is fragile in the list head is removed during the list traversal.
This patch simplifies the implementation of that list by making the
list NULL terminated, singly linked RCU-protected list. By having the
NULL at the end there is
Signed-off-by: Jarno Rajahalme
---
ofproto/ofproto-dpif-xlate.c | 17 -
ofproto/ofproto-dpif.c | 43 +-
ofproto/ofproto-dpif.h |5 -
ofproto/ofproto-provider.h |6 ++
ofproto/ofproto.c|5
Handling evictions was broken in the previous patches. Eviction took
place early in the commit, and actually inappropriately bumped the
version number too early. Now eviction is treated much like a flow
modification, where a new rule replaces the old one, but just without
any 'inheritance' from th
Each rule is now added or deleted in a specific tables version. Flow
tables are versioned with a monotonically increasing 64-bit integer,
where positive values are valid version numbers.
Rule modifications are implemented as an insertion of a new rule and a
deletion of the old rule, both taking p
The final flow stats are available only after there are no references
to the rule. Postpone sending the flow removed message until the
final stats are available.
Signed-off-by: Jarno Rajahalme
---
include/openflow/openflow-common.h |2 ++
lib/ofp-print.c|1 +
ofproto
Classifier's rule count now contains temporary duplicates and rules
whose deletion has been deferred. Maintain a new 'n_flows' count in
struct oftable to as the count of rules in the latest version.
Signed-off-by: Jarno Rajahalme
---
ofproto/connmgr.c |2 +-
ofproto/ofproto-provide
struct match in ofputil_flow_mod uses a lot of space, when used for a
stored bundle message. This patch adds a new struct
ofputil_miniflow_mod, that uses a minimatch instead of match in hopes
of using less memory when handling large bundles.
Signed-off-by: Jarno Rajahalme
---
lib/match.c
Add support for port mods in an OpenFlow 1.4 bundle, as required for
the minimum support level by the OpenFlow 1.4 specification. If the
bundle includes port mods, it may not specify the OFPBF_ATOMIC flag.
Port mods and flow mods in a bundle are always applied in order and
the consecutive flow mod
> On Jun 5, 2015, at 12:55 PM, Jarno Rajahalme wrote:
>
>> This will be really nice, thanks for implementing it.
>>
>> (Now, to find out why there are three more commits...)
>
>
> Will post a v3 with the rest of the series soon.
v3 posted!
Have a nice weekend,
Jarno
Rebased and added the sign off:
https://github.com/openvswitch/ovs/pull/50
Alin.
-Mesaj original-
De la: dev [mailto:dev-boun...@openvswitch.org] În numele Alin Serdean
Trimis: Friday, June 5, 2015 9:20 PM
Către: Gurucharan Shetty
Cc: dev@openvswitch.org
Subiect: Re: [ovs-dev] [PATCH v6]
My environment is in VMware
OS: CentOS 7ovs: compiled by git masterDPDK: 2.0.0qemu:2.3.0
qemu conecting ovs by vhost-userOne NIC bind to ovs
When I send pkts from qemu to VMware`s NIC by using iperf3, Segmentation falt
occurs
Do you need to see the backtrace? I forget to save it, if need, I will
Layout of my Email is
wrong*RTFSC*--From:钢锁0310
Time:2015 Jun 6 (Sat) 08:30To:Gray, Mark D
, d...@openvswitch.com
Subject:[ovs-dev] 答复: [PATCH] netdev-dpdk: Do not flush
tx queue which is
Message could not be delivered
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
> On Jun 5, 2015, at 15:08, Jarno Rajahalme wrote:
>
(Snip)
>
> - Bundles now support also port mods, but only for non-atomic bundles.
> The reason for this is that we have
Add "no" here.
> easy way of making port status
> changes atomic w.r.t. classifier version number changes (patch 12)
Don't underestimate the value of a bug fix.
Thanks, I applied this patch, with the sign-off, to master.
On Fri, Jun 05, 2015 at 11:23:23AM -0700, Andy Zhou wrote:
> Thank you for your kindness.
>
> Signed-off-by: Andy Zhou
>
> On Fri, Jun 5, 2015 at 8:14 AM, Ben Pfaff wrote:
> > Andy, I added
On Fri, Jun 05, 2015 at 10:41:48AM -0700, Shashank Shanbhag wrote:
> I thought there are only hidden flows, and not hidden tables.
> We are reading all tables from 0 to OFPTT_MAX-1.
>
> But, I see what you're saying. I can probably use OFPMP_TABLE_FEATURES
> (openflow1.4 spec Section 7.3.5.6) to g
On Fri, Jun 05, 2015 at 10:48:30AM -0700, Sabyasachi Sengupta wrote:
>
> Use xzalloc instead of xmalloc for some key structure allocations in
> ofproto-dpif (viz. ofproto_dpif, ofport_dpif and rule_dpif) so as to
> prevent uninitialized values in these structures. Also add seat belts
> around thes
On Fri, Jun 05, 2015 at 12:55:41PM -0700, Jarno Rajahalme wrote:
>
> > On May 29, 2015, at 8:58 PM, Ben Pfaff wrote:
> > I'm a little surprised to see the new "error_reporter" callback
> > function. Can you explain a little?
>
> Within a bundle we are now streaming the flow mods without waiting
Ah, I see the out_of_memory code.. I'd resend without the NULL checks (with
just the conversion to xzalloc).
---
Nuage Networks Business Unit, Alcatel-Lucent,
755 Ravendale Drive, Mountain View, CA, 94043
Mailstop: 1127, Ph: 1-650-623-3461
On Fri, 5 Jun 2015, Ben Pfaff wrote:
On Fri, Jun 05
Use xzalloc instead of xmalloc for some key structure allocations in
ofproto-dpif (viz. ofproto_dpif, ofport_dpif and rule_dpif) so as to
prevent uninitialized values in these structures.
Signed-off-by: Sabyasachi Sengupta
---
diff --git a/ofproto/ofproto-dpif.c b/ofproto/ofproto-dpif.c
index
This will still change the user's intent (and change the flows that the
user sets up), breaking some of the forms described in meta-flow.h.
This is closer to what I had in mind:
diff --git a/ofproto/ofproto-dpif-xlate.c b/ofproto/ofproto-dpif-xlate.c
index 71b8bef..41a03ef 100644
--- a/ofproto/of
On Thu, Jun 04, 2015 at 01:52:16PM -0700, Andy Zhou wrote:
> Currently, 'ovs-appctl tnl/ports/show' command won't display gre port
> name correctly. Since netdev_vport_get_dpif_port() will not always
> set the 'namebuf' it receives. Should use the name by its return
> value instead. Found by inspec
We got a crash of ovs-vswitchd.
I start ovs following the instructions of INSTALL.DPDK.md, with the ovs master
code.
In my enironment, there are four cpu cores, the "real_n_txq" of dpdk port is 1
and "txq_needs_locking" is "true""...ovs-vsctl add-br br0 -- set bridge br0
datapath_type=netdevovs
Ignoring the result of this function means that the caller is quite likely
blindly using the character array passed in, instead of the return value,
which leads to latent bugs.
This would have prevented one of the bugs fixed by commit "tunneling: Fix a
tunnel name display bug".
CC: Andy Zhou
Sig
On Fri, Jun 05, 2015 at 09:49:47PM -0700, Sabyasachi Sengupta wrote:
>
>
> Use xzalloc instead of xmalloc for some key structure allocations in
> ofproto-dpif (viz. ofproto_dpif, ofport_dpif and rule_dpif) so as to
> prevent uninitialized values in these structures.
>
> Signed-off-by: Sabyasachi
On Fri, Jun 5, 2015 at 10:00 PM, Ben Pfaff wrote:
> This will still change the user's intent (and change the flows that the
> user sets up), breaking some of the forms described in meta-flow.h.
>
> This is closer to what I had in mind:
>
> diff --git a/ofproto/ofproto-dpif-xlate.c b/ofproto/ofpro
Group chaining hasn't been supported, so we shouldn't report that it is.
(This is a good demonstration of why I don't like feature bits like this.
It's too easy for even well-intentioned implementers to get them wrong.)
Signed-off-by: Ben Pfaff
---
This is intended for branch-2.3, even though the
On Fri, Jun 05, 2015 at 10:36:55PM -0700, Alex Wang wrote:
> On Fri, Jun 5, 2015 at 10:00 PM, Ben Pfaff wrote:
>
> > This will still change the user's intent (and change the flows that the
> > user sets up), breaking some of the forms described in meta-flow.h.
> >
> > This is closer to what I had
Requested-by: Vinllen Chen
Signed-off-by: Ben Pfaff
---
AUTHORS | 1 +
ofproto/ofproto-dpif-xlate.c | 29 +++--
ofproto/ofproto-dpif.c | 13 -
tests/ofproto-dpif.at| 12 +++-
4 files changed, 11 insertions(+), 44 del
On Wed, Jun 03, 2015 at 04:02:43PM +0900, Takashi Yamamoto wrote:
> hi,
>
> On Wed, Jun 3, 2015 at 3:36 PM, Ben Pfaff wrote:
> > We have the following comment in ofproto-dpif-xlate.c:
> >
> > /* Prevent nested translation of OpenFlow groups.
> > *
> > * OpenFlow allows t
Yeah, later, with a test, ~
On Fri, Jun 5, 2015 at 10:43 PM, Ben Pfaff wrote:
> On Fri, Jun 05, 2015 at 10:36:55PM -0700, Alex Wang wrote:
> > On Fri, Jun 5, 2015 at 10:00 PM, Ben Pfaff wrote:
> >
> > > This will still change the user's intent (and change the flows that the
> > > user sets up),
On Wed, Jun 03, 2015 at 04:49:14PM -0300, Thadeu Lima de Souza Cascardo wrote:
> Support IGMPv3 messages with multiple records. Make sure all IGMPv3
> messages go through slow path, since they may carry multiple multicast
> addresses, unlike IGMPv2.
>
> Tests done:
>
> * multiple addresses in IGM
Sorry the last e-mail had wrong output format.
We got a crash of ovs-vswitchd.I start ovs following the instructions of
INSTALL.DPDK.md, with the ovs master code.In my enironment, there are four cpu
cores, the "real_n_txq" of dpdk port is 1 and "txq_needs_locking" is "true"
...ovs-vsctl add-br br
67 matches
Mail list logo