[ovs-dev] [PATCH 1/8] bridge: Publish error count in database's rstp_statistics.

2015-02-19 Thread Ben Pfaff
The lower layers count errors but until now nothing actually reported them. Found by inspection. Signed-off-by: Ben Pfaff --- vswitchd/bridge.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/vswitchd/bridge.c b/vswitchd/bridge.c index 297c0dd..a143be1 100644 --- a/v

[ovs-dev] [PATCH 0/8] Initial OVN design documentation

2015-02-19 Thread Ben Pfaff
Most of this series is minor bug fixes and documentation improvements. These are ready for review. The part you actually care about, though, is the final patch that provides an initial stab at some preliminary design documentation for the OVN project. Feedback is honestly appreciated. Ben Pfaff

[ovs-dev] [PATCH 2/8] vswitch: Document columns that had been previously overlooked.

2015-02-19 Thread Ben Pfaff
A fair number of columns had been overlooked. This documents them. The patch is smaller than it appears because this rearranges the STP and RSTP documentation to group configuration, status, and statistics together in the documentation for clarity. Signed-off-by: Ben Pfaff --- vswitchd/vswitch

[ovs-dev] [PATCH 3/8] vtep: Document the ipaddr column in the Mcast_Macs_Local table.

2015-02-19 Thread Ben Pfaff
This had been overlooked. Signed-off-by: Ben Pfaff --- vtep/vtep.xml | 4 1 file changed, 4 insertions(+) diff --git a/vtep/vtep.xml b/vtep/vtep.xml index 80fc99d..7ed7f43 100644 --- a/vtep/vtep.xml +++ b/vtep/vtep.xml @@ -776,6 +776,10 @@ addresses of the appropriate VTEP(s).

[ovs-dev] [PATCH 4/8] ovsdb-doc: Flag an error when a table or a column is left undocumented.

2015-02-19 Thread Ben Pfaff
This should make it harder to forget documentation. Signed-off-by: Ben Pfaff --- ovsdb/ovsdb-doc | 23 --- 1 file changed, 20 insertions(+), 3 deletions(-) diff --git a/ovsdb/ovsdb-doc b/ovsdb/ovsdb-doc index 6200915..b670452 100755 --- a/ovsdb/ovsdb-doc +++ b/ovsdb/ovsdb-do

[ovs-dev] [PATCH 6/8] ovsdb-doc: Factor out nroff formatting into a separate Python module.

2015-02-19 Thread Ben Pfaff
This will make it cleaner to add another build-time program that generates nroff from XML. Signed-off-by: Ben Pfaff --- ovsdb/ovsdb-doc | 135 +--- python/automake.mk | 6 ++ python/build/__init__.py | 0 python/build/nroff.py| 196 +

[ovs-dev] [PATCH 5/8] ovsdb-doc: Get manpage name from the XML file instead of command line.

2015-02-19 Thread Ben Pfaff
This seems like a better place for it. Signed-off-by: Ben Pfaff --- ovsdb/ovsdb-doc | 18 -- vswitchd/automake.mk | 1 - vswitchd/vswitch.xml | 2 +- vtep/automake.mk | 1 - vtep/vtep.xml| 2 +- 5 files changed, 10 insertions(+), 14 deletions(-) diff --git a

[ovs-dev] [PATCH 7/8] xml2nroff: New program to generate a manpage from XML input.

2015-02-19 Thread Ben Pfaff
I really can't stand nroff syntax. This makes it possible to install nroff but write in a more sensible XML syntax. The following commit adds the first user. Signed-off-by: Ben Pfaff --- Makefile.am | 1 + build-aux/xml2nroff | 110

[ovs-dev] [PATCH 8/8] [RFC] ovn: Start work on design documentation.

2015-02-19 Thread Ben Pfaff
This commit adds preliminary design documentation for Open Virtual Network, or OVN, a new OVS-based project to add support for virtual networking to OVS, initially with OpenStack integration. This initial design has been influenced by many people, including (in alphabetical order) Aaron Rosen, Chr

Re: [ovs-dev] [PATCH 8/8] [RFC] ovn: Start work on design documentation.

2015-02-19 Thread Ben Pfaff
On Thu, Feb 19, 2015 at 12:12:26AM -0800, Ben Pfaff wrote: > This commit adds preliminary design documentation for Open Virtual Network, > or OVN, a new OVS-based project to add support for virtual networking to > OVS, initially with OpenStack integration. > > This initial design has been influenc

[ovs-dev] [neutron] [ovs-dev] [PATCH 8/8] [RFC] ovn: Start work on design Documentation.

2015-02-19 Thread Miguel Ángel Ajo
Thank you Ben!, Cross posting [1] to openstack list /neutron. [1] http://benpfaff.org/~blp/dist-docs. On Thursday, 19 de February de 2015 at 09:13, Ben Pfaff wrote: > On Thu, Feb 19, 2015 at 12:12:26AM -0800, Ben Pfaff wrote: > > This commit adds preliminary design documentation for Open Vi

[ovs-dev] Returned mail: see transcript for details

2015-02-19 Thread m-mat
l]Cƒì ”¼¸'®/`mk¼›ìы©¨[ÜߌUh£7`×ño¦ÑìÒÍø9 ìƞeÇ üNH¥oÍH¡ãÒ ö,0”¹VDšÊ¥jEöp±(W¡^¦|9izæÊþ/Œúý¨WH°oˆ>}¯Ã b–l[¥¤åënöt¯Pª ­jµG ÁžCRÌjb±® ’'ÛG¥µˆâæ/ƅñ–We¯P³…±Á‘_–ÍÉ †‘écfi ’tz´>^NÅ`ž¸%d«i~˜~àÞsèq³LÛ"'‰iŒ¦ñw¾¯û>¸VRÌóÀX͘¢¤CârˆÌKÁnß[î¯&aUø—#_¾ƒÌ† a¨GcŽRïU4ڈΙÇ÷mÓ3$–÷46.í¡,Êàq _

Re: [ovs-dev] [PATCH 8/8] [RFC] ovn: Start work on design ocumentation.

2015-02-19 Thread Miguel Ángel Ajo
Hi Ben, I specially liked the VIF port lifecycle, looks good to me, Ionly miss some “port_security” concepts we have in neutron, which I guess could have been deliberately omitted for a start. In neutron we have something called security groups, and every port belongs to 1 or more sec

Re: [ovs-dev] [PATCH 1/8] bridge: Publish error count in database's rstp_statistics.

2015-02-19 Thread Gurucharan Shetty
On Thu, Feb 19, 2015 at 12:12 AM, Ben Pfaff wrote: > The lower layers count errors but until now nothing actually reported them. > > Found by inspection. > > Signed-off-by: Ben Pfaff Acked-by: Gurucharan Shetty > --- > vswitchd/bridge.c | 8 +--- > 1 file changed, 5 insertions(+), 3 deletio

Re: [ovs-dev] [PATCH 3/8] vtep: Document the ipaddr column in the Mcast_Macs_Local table.

2015-02-19 Thread Gurucharan Shetty
On Thu, Feb 19, 2015 at 12:12 AM, Ben Pfaff wrote: > This had been overlooked. > > Signed-off-by: Ben Pfaff I did not about this column. Acked-by: Gurucharan Shetty > --- > vtep/vtep.xml | 4 > 1 file changed, 4 insertions(+) > > diff --git a/vtep/vtep.xml b/vtep/vtep.xml > index 80fc99d..

Re: [ovs-dev] [PATCH 4/8] ovsdb-doc: Flag an error when a table or a column is left undocumented.

2015-02-19 Thread Gurucharan Shetty
On Thu, Feb 19, 2015 at 12:12 AM, Ben Pfaff wrote: > This should make it harder to forget documentation. > > Signed-off-by: Ben Pfaff Nice! Acked-by: Gurucharan Shetty > --- > ovsdb/ovsdb-doc | 23 --- > 1 file changed, 20 insertions(+), 3 deletions(-) > > diff --git a/ovsdb

Re: [ovs-dev] [PATCH 5/8] ovsdb-doc: Get manpage name from the XML file instead of command line.

2015-02-19 Thread Gurucharan Shetty
On Thu, Feb 19, 2015 at 12:12 AM, Ben Pfaff wrote: > This seems like a better place for it. > > Signed-off-by: Ben Pfaff Acked-by: Gurucharan Shetty > --- > ovsdb/ovsdb-doc | 18 -- > vswitchd/automake.mk | 1 - > vswitchd/vswitch.xml | 2 +- > vtep/automake.mk | 1 -

Re: [ovs-dev] [PATCH 2/8] vswitch: Document columns that had been previously overlooked.

2015-02-19 Thread Gurucharan Shetty
On Thu, Feb 19, 2015 at 12:12 AM, Ben Pfaff wrote: > A fair number of columns had been overlooked. This documents them. > > The patch is smaller than it appears because this rearranges the STP and > RSTP documentation to group configuration, status, and statistics together > in the documentation

Re: [ovs-dev] [PATCH 6/8] ovsdb-doc: Factor out nroff formatting into a separate Python module.

2015-02-19 Thread Gurucharan Shetty
I don't understand nroff well enough to review patch 6 and patch 7. If anyone else is up for it, please review. On Thu, Feb 19, 2015 at 12:12 AM, Ben Pfaff wrote: > This will make it cleaner to add another build-time program that generates > nroff from XML. > > Signed-off-by: Ben Pfaff > --- >

[ovs-dev] Mail System Error - Returned Mail

2015-02-19 Thread riesenf
Vc¹õ–¿ùªF¤j×]ÏcFòÛØ|uŽkâ¨cBƒê&>tJ¯›VJôù*cªù‘Öø õÅ¢Ç.yHGnàȟðtGé NQ¯ÜÑ[¼¡wžš{FÛ²<6Ça²3±Ä_×ÓêSÛ#èz/;ÅWU¾Ë¤l7¾´•.2ŽfÙû±O^á’æV` ëŒPв­xa›åŒ©,Øá§(í¦¦fYs VoÙïu‰0õ7ÙÚ`‘‡7,&Ѳåøx25²Ÿ½dØrii̺ƸTxàQ¦–¹ƒSwäc{c½ç )”`ëq—0Xl›' “J‹˜{áÙx±çøàDܤ,â“f†œŒê#ÛQÅ8üëE˜ä¼ù„Tžf¶IÆÎa]1ü£­áý9‰•ÒáÊs¢´°ì}'®ÅkF‡»‚ÞKÈÀ5±KŠŽÚ

[ovs-dev] RETURNED MAIL: DATA FORMAT ERROR

2015-02-19 Thread frank
Your message could not be delivered ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH 1/8] bridge: Publish error count in database's rstp_statistics.

2015-02-19 Thread Russell Bryant
On 02/19/2015 03:12 AM, Ben Pfaff wrote: > The lower layers count errors but until now nothing actually reported them. > > Found by inspection. > > Signed-off-by: Ben Pfaff > --- > vswitchd/bridge.c | 8 +--- > 1 file changed, 5 insertions(+), 3 deletions(-) > > diff --git a/vswitchd/bridg

Re: [ovs-dev] [PATCH 1/8] bridge: Publish error count in database's rstp_statistics.

2015-02-19 Thread Russell Bryant
On 02/19/2015 10:34 AM, Russell Bryant wrote: > On 02/19/2015 03:12 AM, Ben Pfaff wrote: >> The lower layers count errors but until now nothing actually reported them. >> >> Found by inspection. >> >> Signed-off-by: Ben Pfaff >> --- >> vswitchd/bridge.c | 8 +--- >> 1 file changed, 5 insertio

Re: [ovs-dev] [PATCH 6/8] ovsdb-doc: Factor out nroff formatting into a separate Python module.

2015-02-19 Thread Russell Bryant
On 02/19/2015 07:02 AM, Gurucharan Shetty wrote: > I don't understand nroff well enough to review patch 6 and patch 7. If > anyone else is up for it, please review. I don't either, but this one looks like just a code move. It looks good to me. My only thought was about adding something about try

Re: [ovs-dev] [PATCH 6/8] ovsdb-doc: Factor out nroff formatting into a separate Python module.

2015-02-19 Thread Gurucharan Shetty
On Thu, Feb 19, 2015 at 9:09 AM, Ben Pfaff wrote: > On Thu, Feb 19, 2015 at 11:00:56AM -0500, Russell Bryant wrote: >> On 02/19/2015 07:02 AM, Gurucharan Shetty wrote: >> > I don't understand nroff well enough to review patch 6 and patch 7. If >> > anyone else is up for it, please review. >> >> I

Re: [ovs-dev] [PATCH 6/8] ovsdb-doc: Factor out nroff formatting into a separate Python module.

2015-02-19 Thread Ben Pfaff
On Thu, Feb 19, 2015 at 11:00:56AM -0500, Russell Bryant wrote: > On 02/19/2015 07:02 AM, Gurucharan Shetty wrote: > > I don't understand nroff well enough to review patch 6 and patch 7. If > > anyone else is up for it, please review. > > I don't either, but this one looks like just a code move.

Re: [ovs-dev] [PATCH 1/8] bridge: Publish error count in database's rstp_statistics.

2015-02-19 Thread Ben Pfaff
On Thu, Feb 19, 2015 at 10:45:21AM -0500, Russell Bryant wrote: > On 02/19/2015 10:34 AM, Russell Bryant wrote: > > On 02/19/2015 03:12 AM, Ben Pfaff wrote: > >> The lower layers count errors but until now nothing actually reported them. > >> > >> Found by inspection. > >> > >> Signed-off-by: Ben P

Re: [ovs-dev] [PATCH 2/8] vswitch: Document columns that had been previously overlooked.

2015-02-19 Thread Ben Pfaff
On Thu, Feb 19, 2015 at 04:00:43AM -0800, Gurucharan Shetty wrote: > On Thu, Feb 19, 2015 at 12:12 AM, Ben Pfaff wrote: > > A fair number of columns had been overlooked. This documents them. > > > > The patch is smaller than it appears because this rearranges the STP and > > RSTP documentation to

Re: [ovs-dev] [PATCH 7/8] xml2nroff: New program to generate a manpage from XML input.

2015-02-19 Thread Russell Bryant
On 02/19/2015 03:12 AM, Ben Pfaff wrote: > I really can't stand nroff syntax. This makes it possible to install > nroff but write in a more sensible XML syntax. > > The following commit adds the first user. > > Signed-off-by: Ben Pfaff > --- > Makefile.am | 1 + > build-aux/xml2nroff

Re: [ovs-dev] [PATCH 6/8] ovsdb-doc: Factor out nroff formatting into a separate Python module.

2015-02-19 Thread Ben Pfaff
On Thu, Feb 19, 2015 at 09:12:07AM -0800, Gurucharan Shetty wrote: > On Thu, Feb 19, 2015 at 9:09 AM, Ben Pfaff wrote: > > On Thu, Feb 19, 2015 at 11:00:56AM -0500, Russell Bryant wrote: > >> On 02/19/2015 07:02 AM, Gurucharan Shetty wrote: > >> > I don't understand nroff well enough to review pat

Re: [ovs-dev] [PATCH 2/8] vswitch: Document columns that had been previously overlooked.

2015-02-19 Thread Jarno Rajahalme
I’ll look in to this, Jarno On Feb 19, 2015, at 9:22 AM, Ben Pfaff wrote: > On Thu, Feb 19, 2015 at 04:00:43AM -0800, Gurucharan Shetty wrote: >> On Thu, Feb 19, 2015 at 12:12 AM, Ben Pfaff wrote: >>> A fair number of columns had been overlooked. This documents them. >>> >>> The patch is s

Re: [ovs-dev] [PATCH 1/8] bridge: Publish error count in database's rstp_statistics.

2015-02-19 Thread Russell Bryant
On 02/19/2015 12:19 PM, Ben Pfaff wrote: > On Thu, Feb 19, 2015 at 10:45:21AM -0500, Russell Bryant wrote: >> On 02/19/2015 10:34 AM, Russell Bryant wrote: >>> On 02/19/2015 03:12 AM, Ben Pfaff wrote: The lower layers count errors but until now nothing actually reported them. Found b

Re: [ovs-dev] [PATCH 1/8] bridge: Publish error count in database's rstp_statistics.

2015-02-19 Thread Ben Pfaff
On Thu, Feb 19, 2015 at 12:41:48PM -0500, Russell Bryant wrote: > On 02/19/2015 12:19 PM, Ben Pfaff wrote: > > On Thu, Feb 19, 2015 at 10:45:21AM -0500, Russell Bryant wrote: > >> On 02/19/2015 10:34 AM, Russell Bryant wrote: > >>> On 02/19/2015 03:12 AM, Ben Pfaff wrote: > The lower layers co

[ovs-dev] [PATCH] CodingStyle: recommend PEP 8 for Python code

2015-02-19 Thread Russell Bryant
Add a new section about Python code to the coding style document. Suggest that all new Python code should adhere to the PEP 8 standard. Also include a reference to tools that can quickly check code for style issues. Signed-off-by: Russell Bryant --- CodingStyle.md | 7 +++ 1 file changed, 7

Re: [ovs-dev] [PATCH 1/8] bridge: Publish error count in database's rstp_statistics.

2015-02-19 Thread Russell Bryant
On 02/19/2015 12:47 PM, Ben Pfaff wrote: > On Thu, Feb 19, 2015 at 12:41:48PM -0500, Russell Bryant wrote: >> On 02/19/2015 12:19 PM, Ben Pfaff wrote: >>> On Thu, Feb 19, 2015 at 10:45:21AM -0500, Russell Bryant wrote: On 02/19/2015 10:34 AM, Russell Bryant wrote: > On 02/19/2015 03:12 AM,

[ovs-dev] [PATCH] ovsdb-idlc: constify 'char **'

2015-02-19 Thread Russell Bryant
Update the logic used in constify() to add const to a 'char **' while still excluding all other cases of more than one level of indirection. This results in adding const to a parameter of a generated setter function where we're generally passing in array of constant strings. As a result, this patc

Re: [ovs-dev] [PATCH] CodingStyle: recommend PEP 8 for Python code

2015-02-19 Thread Ben Pfaff
On Thu, Feb 19, 2015 at 01:03:53PM -0500, Russell Bryant wrote: > Add a new section about Python code to the coding style document. > Suggest that all new Python code should adhere to the PEP 8 standard. > Also include a reference to tools that can quickly check code for > style issues. > > Signed

Re: [ovs-dev] [PATCH] ovsdb-idlc: constify 'char **'

2015-02-19 Thread Ben Pfaff
On Thu, Feb 19, 2015 at 01:10:51PM -0500, Russell Bryant wrote: > Update the logic used in constify() to add const to a 'char **' while > still excluding all other cases of more than one level of indirection. > > This results in adding const to a parameter of a generated setter > function where we

Re: [ovs-dev] [PATCH 1/8] bridge: Publish error count in database's rstp_statistics.

2015-02-19 Thread Ben Pfaff
On Thu, Feb 19, 2015 at 02:02:49AM -0800, Gurucharan Shetty wrote: > On Thu, Feb 19, 2015 at 12:12 AM, Ben Pfaff wrote: > > The lower layers count errors but until now nothing actually reported them. > > > > Found by inspection. > > > > Signed-off-by: Ben Pfaff > Acked-by: Gurucharan Shetty Tha

Re: [ovs-dev] [PATCH 2/8] vswitch: Document columns that had been previously overlooked.

2015-02-19 Thread Ben Pfaff
I decided to apply this, but I'd still like to improve the documentation further if possible, so when you get a chance please review the RSTP documentation in vswitch.xml. On Thu, Feb 19, 2015 at 09:48:15AM -0800, Jarno Rajahalme wrote: > I?ll look in to this, > > Jarno > > On Feb 19, 2015, at

Re: [ovs-dev] [PATCH 3/8] vtep: Document the ipaddr column in the Mcast_Macs_Local table.

2015-02-19 Thread Ben Pfaff
On Thu, Feb 19, 2015 at 02:57:44AM -0800, Gurucharan Shetty wrote: > On Thu, Feb 19, 2015 at 12:12 AM, Ben Pfaff wrote: > > This had been overlooked. > > > > Signed-off-by: Ben Pfaff > I did not about this column. > Acked-by: Gurucharan Shetty Thanks! Applied. _

Re: [ovs-dev] [PATCH 4/8] ovsdb-doc: Flag an error when a table or a column is left undocumented.

2015-02-19 Thread Ben Pfaff
On Thu, Feb 19, 2015 at 03:14:25AM -0800, Gurucharan Shetty wrote: > On Thu, Feb 19, 2015 at 12:12 AM, Ben Pfaff wrote: > > This should make it harder to forget documentation. > > > > Signed-off-by: Ben Pfaff > Nice! > Acked-by: Gurucharan Shetty Thanks! Applied. __

Re: [ovs-dev] [PATCH 6/8] ovsdb-doc: Factor out nroff formatting into a separate Python module.

2015-02-19 Thread Ben Pfaff
On Thu, Feb 19, 2015 at 09:23:55AM -0800, Ben Pfaff wrote: > On Thu, Feb 19, 2015 at 09:12:07AM -0800, Gurucharan Shetty wrote: > > On Thu, Feb 19, 2015 at 9:09 AM, Ben Pfaff wrote: > > > On Thu, Feb 19, 2015 at 11:00:56AM -0500, Russell Bryant wrote: > > >> On 02/19/2015 07:02 AM, Gurucharan Shet

Re: [ovs-dev] [PATCH 5/8] ovsdb-doc: Get manpage name from the XML file instead of command line.

2015-02-19 Thread Ben Pfaff
On Thu, Feb 19, 2015 at 03:25:15AM -0800, Gurucharan Shetty wrote: > On Thu, Feb 19, 2015 at 12:12 AM, Ben Pfaff wrote: > > This seems like a better place for it. > > > > Signed-off-by: Ben Pfaff > Acked-by: Gurucharan Shetty Thanks! Applied. ___ dev

Re: [ovs-dev] [PATCH 6/8] ovsdb-doc: Factor out nroff formatting into a separate Python module.

2015-02-19 Thread Gurucharan Shetty
On Thu, Feb 19, 2015 at 9:23 AM, Ben Pfaff wrote: > On Thu, Feb 19, 2015 at 09:12:07AM -0800, Gurucharan Shetty wrote: >> On Thu, Feb 19, 2015 at 9:09 AM, Ben Pfaff wrote: >> > On Thu, Feb 19, 2015 at 11:00:56AM -0500, Russell Bryant wrote: >> >> On 02/19/2015 07:02 AM, Gurucharan Shetty wrote: >

Re: [ovs-dev] [PATCH 7/8] xml2nroff: New program to generate a manpage from XML input.

2015-02-19 Thread Ben Pfaff
On Thu, Feb 19, 2015 at 12:24:42PM -0500, Russell Bryant wrote: > On 02/19/2015 03:12 AM, Ben Pfaff wrote: > > I really can't stand nroff syntax. This makes it possible to install > > nroff but write in a more sensible XML syntax. > > > > The following commit adds the first user. > > > > Signed-

[ovs-dev] [PATCH] ovsdb-doc: Add license and copyright notice.

2015-02-19 Thread Ben Pfaff
The copyright dates are taken from "git log --follow ovsdb/ovsdb-doc", considering only Nicira authors' changes. (Only one change was from a non-Nicira author anyhow.) Signed-off-by: Ben Pfaff --- ovsdb/ovsdb-doc | 14 ++ 1 file changed, 14 insertions(+) diff --git a/ovsdb/ovsdb-

[ovs-dev] [PATCH 0/7] UFID feature backport from Linux.

2015-02-19 Thread Joe Stringer
This patch series backports the UFID changes from the Linux 3.19 tree to the OVS tree. Joe Stringer (5): datapath: Refactor ovs_nla_fill_match(). datapath: Refactor ovs_flow_tbl_insert(). datapath: Use sw_flow_key_range for key ranges. compat: Add genlmsg_parse() helper function. datapat

[ovs-dev] [PATCH 3/7] datapath: Use sw_flow_key_range for key ranges.

2015-02-19 Thread Joe Stringer
These minor tidyups make a future patch a little tidier. Signed-off-by: Joe Stringer Acked-by: Pravin B Shelar Signed-off-by: David S. Miller --- datapath/flow_table.c | 20 +--- 1 file changed, 9 insertions(+), 11 deletions(-) diff --git a/datapath/flow_table.c b/datapath/f

[ovs-dev] [PATCH 1/7] datapath: Refactor ovs_nla_fill_match().

2015-02-19 Thread Joe Stringer
Refactor the ovs_nla_fill_match() function into separate netlink serialization functions ovs_nla_put_{unmasked_key,mask}(). Modify ovs_nla_put_flow() to handle attribute nesting and expose the 'is_mask' parameter - all callers need to nest the flow, and callers have better knowledge about whether i

[ovs-dev] [PATCH 4/7] compat: Add genlmsg_parse() helper function.

2015-02-19 Thread Joe Stringer
The first user will be the next patch. Signed-off-by: Joe Stringer Acked-by: Pravin B Shelar Signed-off-by: David S. Miller --- acinclude.m4 |1 + datapath/linux/compat/include/net/genetlink.h | 11 +++ 2 files changed, 12 insertions(+) diff --gi

[ovs-dev] [PATCH 2/7] datapath: Refactor ovs_flow_tbl_insert().

2015-02-19 Thread Joe Stringer
Rework so that ovs_flow_tbl_insert() calls flow_{key,mask}_insert(). This tidies up a future patch. Signed-off-by: Joe Stringer Acked-by: Pravin B Shelar Signed-off-by: David S. Miller --- datapath/flow_table.c | 21 ++--- 1 file changed, 14 insertions(+), 7 deletions(-) dif

[ovs-dev] [PATCH 7/7] datapath: Fix masked key serialization.

2015-02-19 Thread Joe Stringer
From: Pravin B Shelar Fix typo where mask is used rather than key. Fixes: 74ed7ab9264("openvswitch: Add support for unique flow IDs.") Reported-by: Joe Stringer Signed-off-by: Pravin B Shelar --- datapath/flow_netlink.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/da

[ovs-dev] [PATCH 5/7] datapath: Add support for unique flow IDs.

2015-02-19 Thread Joe Stringer
Previously, flows were manipulated by userspace specifying a full, unmasked flow key. This adds significant burden onto flow serialization/deserialization, particularly when dumping flows. This patch adds an alternative way to refer to flows using a variable-length "unique flow identifier" (UFID).

[ovs-dev] [PATCH 6/7] datapath: Initialize unmasked key and uid len.

2015-02-19 Thread Joe Stringer
From: Pravin B Shelar Flow alloc needs to initialize unmasked key pointer. Otherwise it can crash kernel trying to free random unmasked-key pointer. general protection fault: [#1] SMP 3.19.0-rc6-net-next+ #457 Hardware name: Supermicro X7DWU/X7DWU, BIOS 1.1 04/30/2008 RIP: 0010:[] [] kfree

Re: [ovs-dev] [PATCH 6/8] ovsdb-doc: Factor out nroff formatting into a separate Python module.

2015-02-19 Thread Ben Pfaff
On Thu, Feb 19, 2015 at 11:07:18AM -0800, Gurucharan Shetty wrote: > On Thu, Feb 19, 2015 at 9:23 AM, Ben Pfaff wrote: > > On Thu, Feb 19, 2015 at 09:12:07AM -0800, Gurucharan Shetty wrote: > >> On Thu, Feb 19, 2015 at 9:09 AM, Ben Pfaff wrote: > >> > On Thu, Feb 19, 2015 at 11:00:56AM -0500, Rus

Re: [ovs-dev] [PATCH 7/8] xml2nroff: New program to generate a manpage from XML input.

2015-02-19 Thread Russell Bryant
On 02/19/2015 02:08 PM, Ben Pfaff wrote: > I'll repost the patch separately; here's an incremental: Incremental changes look good to me, thanks! -- Russell Bryant ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

[ovs-dev] [PATCH v2 1/2] xml2nroff: New program to generate a manpage from XML input.

2015-02-19 Thread Ben Pfaff
I really can't stand nroff syntax. This makes it possible to install nroff but write in a more sensible XML syntax. The following commit adds the first user. Signed-off-by: Ben Pfaff --- Makefile.am |1 + build-aux/xml2nroff | 123 ++

[ovs-dev] [PATCH v2 0/2] Initial OVN design documentation, take 2

2015-02-19 Thread Ben Pfaff
v1->v2: - Patches 1 through 6 applied and dropped. - Patch 7 revised according to Russell Bryant's suggestions. - Patch 8 is unchanged. Ben Pfaff (2): xml2nroff: New program to generate a manpage from XML input. [RFC] ovn: Start work on design documentation. Makefile.am

[ovs-dev] [PATCH v2 2/2] [RFC] ovn: Start work on design documentation.

2015-02-19 Thread Ben Pfaff
This commit adds preliminary design documentation for Open Virtual Network, or OVN, a new OVS-based project to add support for virtual networking to OVS, initially with OpenStack integration. This initial design has been influenced by many people, including (in alphabetical order) Aaron Rosen, Chr

Re: [ovs-dev] [PATCH v2 1/2] xml2nroff: New program to generate a manpage from XML input.

2015-02-19 Thread Ben Pfaff
On Thu, Feb 19, 2015 at 11:16:12AM -0800, Ben Pfaff wrote: > I really can't stand nroff syntax. This makes it possible to install > nroff but write in a more sensible XML syntax. > > The following commit adds the first user. > > Signed-off-by: Ben Pfaff Applied to master based on Russell Bryan

Re: [ovs-dev] [PATCH 00/14] UDP tunneling backports

2015-02-19 Thread Pravin Shelar
On Wed, Feb 18, 2015 at 7:02 PM, Jesse Gross wrote: > This series backports much of the UDP tunnel infrastructure, ultimately > in support of syncing Geneve with upstream and providing outer UDP > checksum support. > > During the backporting process, I realized that there are several > other lurki

[ovs-dev] [V2] ovs-sandbox: Add an option to allow running ovs-vswitchd under gdb

2015-02-19 Thread Andy Zhou
It is some times useful to leverage the sandbox facility to experiment and explore the internals of ovs-vswitchd. Since GDB requires console access for user inputs, this patch launch an xterm for GDB, The main terminal continue to run the sub-shell as before. Exiting the sub-shell will also kill t

Re: [ovs-dev] [PATCH 00/14] UDP tunneling backports

2015-02-19 Thread Jesse Gross
On Thu, Feb 19, 2015 at 11:29 AM, Pravin Shelar wrote: > On Wed, Feb 18, 2015 at 7:02 PM, Jesse Gross wrote: >> This series backports much of the UDP tunnel infrastructure, ultimately >> in support of syncing Geneve with upstream and providing outer UDP >> checksum support. >> >> During the backp

Re: [ovs-dev] [PATCH] ovsdb-doc: Add license and copyright notice.

2015-02-19 Thread Thomas Graf
On 02/19/15 at 11:10am, Ben Pfaff wrote: > The copyright dates are taken from "git log --follow ovsdb/ovsdb-doc", > considering only Nicira authors' changes. (Only one change was from > a non-Nicira author anyhow.) > > Signed-off-by: Ben Pfaff Acked-by: Thomas Graf

Re: [ovs-dev] [PATCH v2 2/2] [RFC] ovn: Start work on design documentation.

2015-02-19 Thread Thomas Graf
This is a first high level review. I'll be digging into the schema next. On 02/19/15 at 11:16am, Ben Pfaff wrote: > + > + > + The Cloud Management System, as defined above. > + > + > + > + > + The OVN/CMS Plugin is the component of the CMS that > + interfaces to OV

Re: [ovs-dev] [PATCH] ovsdb-doc: Add license and copyright notice.

2015-02-19 Thread Ben Pfaff
On Thu, Feb 19, 2015 at 09:52:47PM +0100, Thomas Graf wrote: > On 02/19/15 at 11:10am, Ben Pfaff wrote: > > The copyright dates are taken from "git log --follow ovsdb/ovsdb-doc", > > considering only Nicira authors' changes. (Only one change was from > > a non-Nicira author anyhow.) > > > > Signe

Re: [ovs-dev] [V2] ovs-sandbox: Add an option to allow running ovs-vswitchd under gdb

2015-02-19 Thread Ben Pfaff
On Thu, Feb 19, 2015 at 11:41:48AM -0800, Andy Zhou wrote: > It is some times useful to leverage the sandbox facility to experiment > and explore the internals of ovs-vswitchd. Since GDB requires console > access for user inputs, this patch launch an xterm for GDB, The main > terminal continue to

Re: [ovs-dev] [PATCH v2 2/2] [RFC] ovn: Start work on design documentation.

2015-02-19 Thread Russell Bryant
On 02/19/2015 04:20 PM, Thomas Graf wrote: > This is a first high level review. I'll be digging into the schema > next. > > On 02/19/15 at 11:16am, Ben Pfaff wrote: >> + >> + >> + The Cloud Management System, as defined above. >> + >> + >> + >> + >> +The OVN/CMS Plugin

Re: [ovs-dev] [neutron]?? [PATCH 8/8] [RFC] ovn: Start work on design Documentation.

2015-02-19 Thread Ben Pfaff
Thanks. It looks like openstack-dev only accepts posts from subscribers, so I've followed up to your more detailed feedback only on that list. For anyone following along at home, here's an archives link: http://lists.openstack.org/pipermail/openstack-dev/2015-February/057376.html On Thu, Feb 19,

Re: [ovs-dev] [PATCH v2 2/2] [RFC] ovn: Start work on design documentation.

2015-02-19 Thread Gurucharan Shetty
On Thu, Feb 19, 2015 at 11:16 AM, Ben Pfaff wrote: > This commit adds preliminary design documentation for Open Virtual Network, > or OVN, a new OVS-based project to add support for virtual networking to > OVS, initially with OpenStack integration. > > This initial design has been influenced by ma

Re: [ovs-dev] [PATCH v2 2/2] [RFC] ovn: Start work on design documentation.

2015-02-19 Thread Ben Pfaff
On Thu, Feb 19, 2015 at 10:20:13PM +0100, Thomas Graf wrote: > On 02/19/15 at 11:16am, Ben Pfaff wrote: > > + > > + > > + The Cloud Management System, as defined above. > > + > > + > > + > > + > > + The OVN/CMS Plugin is the component of the CMS that > > + interfaces to

Re: [ovs-dev] [PATCH v2 2/2] [RFC] ovn: Start work on design documentation.

2015-02-19 Thread Thomas Graf
On 02/19/15 at 11:16am, Ben Pfaff wrote: > diff --git a/ovn/ovn-nb.ovsschema b/ovn/ovn-nb.ovsschema > new file mode 100644 > index 000..4c29562 > --- /dev/null > +++ b/ovn/ovn-nb.ovsschema The schema below has some whitespace / tab mixups. [...] > @@ -0,0 +1,63 @@ > +{ > +"name": "OVN_No

Re: [ovs-dev] [PATCH v2 2/2] [RFC] ovn: Start work on design documentation.

2015-02-19 Thread Thomas Graf
On 02/19/15 at 02:36pm, Ben Pfaff wrote: > On Thu, Feb 19, 2015 at 10:20:13PM +0100, Thomas Graf wrote: > > Is this piece CMS specific as well or can we leverage libvirt to > > create some abstraction here and write the vif-id into OVSDB? > > I believe that libvirt already does this; see > virNetD

Re: [ovs-dev] [PATCH net] openvswitch: Fix net exit.

2015-02-19 Thread Thomas Graf
On 02/17/15 at 11:23am, Pravin B Shelar wrote: > Open vSwitch allows moving internal vport to different namespace > while still connected to the bridge. But when namespace deleted > OVS does not detach these vports, that results in dangling > pointer to netdevice which causes kernel panic as follow

[ovs-dev] [PATCH 06/14 v2] datapath: Enable OVS GSO to be used up to 3.18 if necessary.

2015-02-19 Thread Jesse Gross
There are two important GSO tunnel features that were introduced after the 3.12 cutoff for our current out of tree GSO implementation: * 3.16 introduced support for outer UDP checksums. * 3.18 introduced support for verifying hardware support for protocols other than VXLAN. In cases where the

Re: [ovs-dev] [PATCH 00/14] UDP tunneling backports

2015-02-19 Thread Jesse Gross
On Thu, Feb 19, 2015 at 12:02 PM, Jesse Gross wrote: > On Thu, Feb 19, 2015 at 11:29 AM, Pravin Shelar wrote: >> On Wed, Feb 18, 2015 at 7:02 PM, Jesse Gross wrote: >>> This series backports much of the UDP tunnel infrastructure, ultimately >>> in support of syncing Geneve with upstream and prov

Re: [ovs-dev] [PATCH 01/14] datapath: Remove compat vxlan_src_port().

2015-02-19 Thread Thomas Graf
On 02/18/15 at 07:02pm, Jesse Gross wrote: > vxlan_src_port() has been replaced with the more generic > udp_flow_src_port() upstream. We already have a backport for this and > it is used everywhere where this is needed, so we can remove the > dead vxlan_src_port() function. > > Signed-off-by: Jess

Re: [ovs-dev] [PATCH 02/14] datapath: Account for "udp: Add udp_sock_create for UDP tunnels to open listener socket"

2015-02-19 Thread Thomas Graf
On 02/18/15 at 07:02pm, Jesse Gross wrote: > Upstream commit: > udp: Add udp_sock_create for UDP tunnels to open listener socket > > Added udp_tunnel.c which can contain some common functions for UDP > tunnels. The first function in this is udp_sock_create which is used > to open t

Re: [ovs-dev] [PATCH 03/14] datapath: Account for "vxlan: Call udp_sock_create"

2015-02-19 Thread Thomas Graf
On 02/18/15 at 07:02pm, Jesse Gross wrote: > + if (ipv6) { > + udp_conf.family = AF_INET6; > + } else { > + udp_conf.family = AF_INET; > + udp_conf.local_ip.s_addr = htonl(INADDR_ANY); > + } Maybe leave a comment in the code here that the checksum fl

Re: [ovs-dev] [PATCH 04/14] datapath: Use udp_sock_create() for LISP.

2015-02-19 Thread Thomas Graf
On 02/18/15 at 07:02pm, Jesse Gross wrote: > Use the common udp_sock_create() for LISP, similar to what was > done for VXLAN. > > Signed-off-by: Jesse Gross Acked-by: Thomas Graf ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/

Re: [ovs-dev] [PATCH 03/14] datapath: Account for "vxlan: Call udp_sock_create"

2015-02-19 Thread Jesse Gross
On Thu, Feb 19, 2015 at 3:56 PM, Thomas Graf wrote: > On 02/18/15 at 07:02pm, Jesse Gross wrote: >> + if (ipv6) { >> + udp_conf.family = AF_INET6; >> + } else { >> + udp_conf.family = AF_INET; >> + udp_conf.local_ip.s_addr = htonl(INADDR_ANY); >> + }

Re: [ovs-dev] [PATCH 05/14] datapath: Account for "udp: Generic functions to set checksum"

2015-02-19 Thread Thomas Graf
On 02/18/15 at 07:02pm, Jesse Gross wrote: > Upstream commit: > udp: Generic functions to set checksum > > Added udp_set_csum and udp6_set_csum functions to set UDP checksums > in packets. These are for simple UDP packets such as those that might > be created in UDP tunnels. > >

Re: [ovs-dev] [PATCH 06/14 v2] datapath: Enable OVS GSO to be used up to 3.18 if necessary.

2015-02-19 Thread Pravin Shelar
On Thu, Feb 19, 2015 at 3:26 PM, Jesse Gross wrote: > There are two important GSO tunnel features that were introduced > after the 3.12 cutoff for our current out of tree GSO implementation: > * 3.16 introduced support for outer UDP checksums. > * 3.18 introduced support for verifying hardware s

Re: [ovs-dev] [PATCH v2 2/2] [RFC] ovn: Start work on design documentation.

2015-02-19 Thread Ben Pfaff
On Thu, Feb 19, 2015 at 04:52:44PM -0500, Russell Bryant wrote: > On 02/19/2015 04:20 PM, Thomas Graf wrote: > > This is a first high level review. I'll be digging into the schema > > next. > > > > On 02/19/15 at 11:16am, Ben Pfaff wrote: > >> + > >> + > >> + The Cloud Management System

Re: [ovs-dev] [PATCH v2 2/2] [RFC] ovn: Start work on design documentation.

2015-02-19 Thread Ben Pfaff
On Thu, Feb 19, 2015 at 11:52:51PM +0100, Thomas Graf wrote: > On 02/19/15 at 02:36pm, Ben Pfaff wrote: > > I thought about this a bit when I was working on the OVN database > > schema, but I didn't bother to write it up. Here's an incremental > > diff against the OVN schema. The first hunk is fo

Re: [ovs-dev] [PATCH v2 2/2] [RFC] ovn: Start work on design documentation.

2015-02-19 Thread Ben Pfaff
On Thu, Feb 19, 2015 at 11:45:08PM +0100, Thomas Graf wrote: > On 02/19/15 at 11:16am, Ben Pfaff wrote: > > diff --git a/ovn/ovn-nb.ovsschema b/ovn/ovn-nb.ovsschema > > new file mode 100644 > > index 000..4c29562 > > --- /dev/null > > +++ b/ovn/ovn-nb.ovsschema > > The schema below has some wh

Re: [ovs-dev] [PATCH net] openvswitch: Fix net exit.

2015-02-19 Thread Andy Zhou
On Tue, Feb 17, 2015 at 11:23 AM, Pravin B Shelar wrote: > Open vSwitch allows moving internal vport to different namespace > while still connected to the bridge. But when namespace deleted > OVS does not detach these vports, that results in dangling > pointer to netdevice which causes kernel pani

Re: [ovs-dev] [PATCH net] openvswitch: Fix net exit.

2015-02-19 Thread Pravin Shelar
On Thu, Feb 19, 2015 at 5:40 PM, Andy Zhou wrote: > On Tue, Feb 17, 2015 at 11:23 AM, Pravin B Shelar wrote: >> Open vSwitch allows moving internal vport to different namespace >> while still connected to the bridge. But when namespace deleted >> OVS does not detach these vports, that results in

Re: [ovs-dev] [PATCH v2 2/2] [RFC] ovn: Start work on design documentation.

2015-02-19 Thread Ben Pfaff
On Thu, Feb 19, 2015 at 02:25:18PM -0800, Gurucharan Shetty wrote: > On Thu, Feb 19, 2015 at 11:16 AM, Ben Pfaff wrote: > > This commit adds preliminary design documentation for Open Virtual Network, > > or OVN, a new OVS-based project to add support for virtual networking to > > OVS, initially wi

Re: [ovs-dev] [PATCH v2 2/2] [RFC] ovn: Start work on design documentation.

2015-02-19 Thread Ben Pfaff
On Thu, Feb 19, 2015 at 05:15:53PM -0800, Ben Pfaff wrote: > On Thu, Feb 19, 2015 at 11:45:08PM +0100, Thomas Graf wrote: > > On 02/19/15 at 11:16am, Ben Pfaff wrote: > > > diff --git a/ovn/ovn-nb.ovsschema b/ovn/ovn-nb.ovsschema > > > new file mode 100644 > > > index 000..4c29562 > > > --- /de

[ovs-dev] [PATCH v3] [RFC] ovn: Start work on design documentation.

2015-02-19 Thread Ben Pfaff
This commit adds preliminary design documentation for Open Virtual Network, or OVN, a new OVS-based project to add support for virtual networking to OVS, initially with OpenStack integration. This initial design has been influenced by many people, including (in alphabetical order) Aaron Rosen, Chr