[ovs-dev] [RFC net-next 1/4] openvswitch: Serialize acts with original netlink len.

2015-02-14 Thread Joe Stringer
Previously, we used the kernel-internal netlink actions length to calculate the size of messages to serialize back to userspace. However,the sw_flow_actions may not be formatted exactly the same as the actions on the wire, so store the original actions length when de-serializing and re-use the orig

[ovs-dev] [RFC net-next 0/4] OVS conntrack support

2015-02-14 Thread Joe Stringer
This is the latest in a series of RFCs for allowing OVS to send packets through the Linux kernel connection tracker, and subsequently match on fields populated by conntrack. As for outstanding comments from previous versions: - IP frag is not yet addressed. These packets are passed directly to con

[ovs-dev] [RFC net-next 2/4] openvswitch: Move MASKED* macros to datapath.h.

2015-02-14 Thread Joe Stringer
This will allow the ovs-conntrack code to reuse these macros. Signed-off-by: Joe Stringer --- net/openvswitch/actions.c | 52 +--- net/openvswitch/datapath.h |4 2 files changed, 29 insertions(+), 27 deletions(-) diff --git a/net/openvswitch/a

[ovs-dev] [RFC net-next 3/4] openvswitch: Add conntrack action.

2015-02-14 Thread Joe Stringer
From: Justin Pettit Expose the kernel connection tracker to OVS. Userspace components can make use of the "conntrack()" action, followed by "recirculate", to populate the conntracking state in the OVS flow key, and subsequently match on that state. IP fragment handling is yet to be addressed, fo

[ovs-dev] [RFC net-next 4/4] openvswitch: Allow matching on conntrack mark.

2015-02-14 Thread Joe Stringer
From: Justin Pettit Allow matching and setting the conntrack mark field. As with conntrack state and zone, these are populated by executing the conntrack() action. Unlike these, the conntrack mark is also a writable field. The set_field() action may be used to modify the mark, which will take eff

Re: [ovs-dev] [RFC net-next 3/4] openvswitch: Add conntrack action.

2015-02-14 Thread Joe Stringer
On 14 February 2015 at 00:13, Joe Stringer wrote: > From: Justin Pettit > > Expose the kernel connection tracker to OVS. Userspace components can > make use of the "conntrack()" action, followed by "recirculate", to > populate the conntracking state in the OVS flow key, and subsequently > match o

Re: [ovs-dev] [PATCH 6/6] ofproto: Add NXM_NX_TUN_GBP_ID and NXM_NX_TUN_GBP_FLAGS

2015-02-14 Thread Thomas Graf
On 02/13/15 at 01:30pm, Ben Pfaff wrote: > Thanks for being patient with me on this. > > meta-flow.h says that gbp_id is formatted in decimal and gbp_flags in > hex but ofp_print_packet_in() in ofp-print.c uses the opposite > convention. > > I'm sure you can work that out so: > Acked-by: Ben Pfaf

Re: [ovs-dev] [PATCH] ofproto: Fix MPLS multiple Push pop action.

2015-02-14 Thread Simon Horman
On Thu, Dec 18, 2014 at 10:31:43AM -0800, Pravin Shelar wrote: > On Tue, Dec 16, 2014 at 3:10 PM, Jarno Rajahalme > wrote: > > LGTM, > > > > With some comments below: > > > > Acked-by: Jarno Rajahalme > > > > Jarno > > > > On Dec 15, 2014, at 12:37 PM, Pravin B Shelar wrote: > > > >> vSwitchd

Re: [ovs-dev] [PATCH/RFC v2 2/8] Add types for NMX selection method

2015-02-14 Thread Simon Horman
On Fri, Feb 13, 2015 at 03:25:42PM -0800, Ben Pfaff wrote: > On Fri, Feb 13, 2015 at 06:20:40PM -0500, Simon Horman wrote: > > On Fri, Feb 13, 2015 at 01:51:54PM -0800, Ben Pfaff wrote: > > > On Fri, Jan 30, 2015 at 11:41:50AM +0900, Simon Horman wrote: > > > > NMX selection method > > > > Signed-o

Re: [ovs-dev] [RFC net-next 3/4] openvswitch: Add conntrack action.

2015-02-14 Thread Thomas Graf
On 02/14/15 at 12:13am, Joe Stringer wrote: [..] > +static bool skb_has_valid_nfct(const struct net *net, u16 zone, > +const struct sk_buff *skb) > +{ > + enum ip_conntrack_info ctinfo; > + struct nf_conn *ct = nf_ct_get(skb, &ctinfo); > + > + if (!ct) > +

Re: [ovs-dev] [PATCH/RFC v2 2/8] Add types for NMX selection method

2015-02-14 Thread Ben Pfaff
On Sat, Feb 14, 2015 at 02:21:01PM -0500, Simon Horman wrote: > On Fri, Feb 13, 2015 at 03:25:42PM -0800, Ben Pfaff wrote: > > On Fri, Feb 13, 2015 at 06:20:40PM -0500, Simon Horman wrote: > > > On Fri, Feb 13, 2015 at 01:51:54PM -0800, Ben Pfaff wrote: > > > > On Fri, Jan 30, 2015 at 11:41:50AM +0

Re: [ovs-dev] [PATCH/RFC v2 2/8] Add types for NMX selection method

2015-02-14 Thread Simon Horman
On Sat, Feb 14, 2015 at 01:21:16PM -0800, Ben Pfaff wrote: > On Sat, Feb 14, 2015 at 02:21:01PM -0500, Simon Horman wrote: > > On Fri, Feb 13, 2015 at 03:25:42PM -0800, Ben Pfaff wrote: > > > On Fri, Feb 13, 2015 at 06:20:40PM -0500, Simon Horman wrote: > > > > On Fri, Feb 13, 2015 at 01:51:54PM -0

Re: [ovs-dev] [RFC net-next 3/4] openvswitch: Add conntrack action.

2015-02-14 Thread Joe Stringer
On 14 February 2015 at 11:56, Thomas Graf wrote: > On 02/14/15 at 12:13am, Joe Stringer wrote: > > [..] > >> +static bool skb_has_valid_nfct(const struct net *net, u16 zone, >> +const struct sk_buff *skb) >> +{ >> + enum ip_conntrack_info ctinfo; >> + struct nf_