[ovs-dev] Table-desc: Vacancy Event Output

2014-11-26 Thread Hiteshi Madan
Dear Ovs team, We are working on Vacancy Events as specified in Openflow1.4 specs and planning to contribute for the same in Ovs. We need inputs for table-desc command output. table-desc command "ovs-ofctl -O Openflow14 dump-table-desc br0" has following kind of output for 255 tables: OFPST_TA

Re: [ovs-dev] [PATCH] ovs-ofctl: Implementation of eviction on the basis of Importance

2014-11-26 Thread Saloni Jain
Hi Ben, >ofptype_decode() and related functions check that the length of a >message agrees with the specification given in enum ofpraw in >ofp-msgs.h, so there is no need to do that again here. Thanks for the information, we will update it and will share the new patch. Thanks and Regards, Salon

[ovs-dev] hi dear

2014-11-26 Thread eliza babe
Hello My Dear. how are you, hope fine. My name is Eliza, am very glad to come across your email profile today, which i find interesting and wish to let you know that i will like to have a very good relationship with you, i hope you will welcome my friendship request? Please respond to my mail di

Re: [ovs-dev] [PATCH] datapath-windows: Fix BSOD when uninstalling driver

2014-11-26 Thread Alin Serdean
Hi Ben, I was just scratching the surface. I filled a bug under https://github.com/openvswitch/ovs-issues/issues/58. The true fix will be to hold a lock during the uninstall. Thx, Alin. -Mesaj original- De la: Ben Pfaff [mailto:b...@nicira.com] Trimis: Wednesday, November 26, 2014

Re: [ovs-dev] [PATCH] datapath/linux: add KCFLAGS var to modules Makefile.main.in

2014-11-26 Thread Alexandru Ardelean
Back with some findings. Could you please take a look at this Makefile ? https://github.com/openwrt/packages/blob/master/net/openvswitch/Makefile This is our package file that wraps the OpenWRT build system around OpenVSwitch. Starting at line 127, there's the Build/Compile make rule that's used

[ovs-dev] [PATCH] datapath: Use ccflags-y instead of deprecated EXTRA_CFLAGS

2014-11-26 Thread Thomas Graf
This allows users to pass in additional compiler flags through the environment variable EXTRA_CFLAGS, e.g. make EXTRA_CFLAGS=-Wno-error=foo V=1 Reported-by: Alexandru Ardelean Signed-off-by: Thomas Graf --- datapath/linux/Kbuild.in | 10 +- 1 file changed, 5 insertions(+), 5 deletio

Re: [ovs-dev] [PATCH] datapath/linux: add KCFLAGS var to modules Makefile.main.in

2014-11-26 Thread Thomas Graf
On 11/26/14 at 03:54pm, Alexandru Ardelean wrote: > Back with some findings. > > Could you please take a look at this Makefile ? > https://github.com/openwrt/packages/blob/master/net/openvswitch/Makefile > > This is our package file that wraps the OpenWRT build system around > OpenVSwitch. > Star

Re: [ovs-dev] [PATCH] datapath/linux: add KCFLAGS var to modules Makefile.main.in

2014-11-26 Thread Alexandru Ardelean
Just checked. That seems to have did it. I'll update the OpenWRT patches folder with this patch (remove my patch) and update the build rules. Thank you. On Wed, Nov 26, 2014 at 4:53 PM, Thomas Graf wrote: > On 11/26/14 at 03:54pm, Alexandru Ardelean wrote: > > Back with some findings. > > > >

[ovs-dev] Xmass Gift For You And Your Family

2014-11-26 Thread REGIE DES FETES
I'm making a free-will financial donation. Reply to partake mariae.schaeffl...@aol.com Maria Schaeffler​​ ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH] route-table: Remove Unregister.

2014-11-26 Thread Pravin Shelar
On Tue, Nov 25, 2014 at 8:19 PM, YAMAMOTO Takashi wrote: >> Since dpif registering for routing table at initialization >> there is no need to unregister it. Following patch removes >> support for turning routing table notifications on and off. >> Due to this change OVS always listens for these >>

[ovs-dev] [PATCH v2] route-table: Remove Unregister.

2014-11-26 Thread Pravin B Shelar
Since dpif registering for routing table at initialization there is no need to unregister it. Following patch removes support for turning routing table notifications on and off. Due to this change OVS always listens for these notifications. Reported-by: YAMAMOTO Takashi Signed-off-by: Pravin B Sh

Re: [ovs-dev] [PATCH] dpif-netdev: Fix a race.

2014-11-26 Thread Pravin Shelar
On Tue, Nov 25, 2014 at 4:01 PM, Alex Wang wrote: > On current master, the 'struct dp_netdev_port' is destroyed > immediately when the ref count reaches 0. However, non-pmd > threads calling the dpif_netdev_execute() for sending packets > could hold pointer to 'port' that is not ref-counted. Thu

Re: [ovs-dev] [PATCH] datapath-windows: Fix BSOD when uninstalling driver

2014-11-26 Thread Ben Pfaff
OK, I didn't understand that until now. It's nice to add "[RFC]" to the subject when you post a patch for discussion rather than for immediate application. Thanks for clarifying! On Wed, Nov 26, 2014 at 01:51:31PM +, Alin Serdean wrote: > Hi Ben, > > I was just scratching the surface. >

Re: [ovs-dev] [PATCH] datapath: Use ccflags-y instead of deprecated EXTRA_CFLAGS

2014-11-26 Thread Ben Pfaff
On Wed, Nov 26, 2014 at 03:52:31PM +0100, Thomas Graf wrote: > This allows users to pass in additional compiler flags through the > environment variable EXTRA_CFLAGS, e.g. > >make EXTRA_CFLAGS=-Wno-error=foo V=1 > > Reported-by: Alexandru Ardelean > Signed-off-by: Thomas Graf Thanks for th

Re: [ovs-dev] [PATCH] dpif-netdev: Fix a race.

2014-11-26 Thread Jarno Rajahalme
Alex, Did you consider simply taking a reference instead of the mutex? pros/cons? Jarno On Nov 25, 2014, at 4:01 PM, Alex Wang wrote: > On current master, the 'struct dp_netdev_port' is destroyed > immediately when the ref count reaches 0. However, non-pmd > threads calling the dpif_netdev

Re: [ovs-dev] [PATCH/RFC 0/9] Group Select: Selection Method Extension

2014-11-26 Thread Ben Pfaff
On Wed, Nov 26, 2014 at 10:37:16AM +0900, Simon Horman wrote: > On Tue, Nov 25, 2014 at 03:31:50PM -0800, Ben Pfaff wrote: > > On another note, the description of the extension at the end of this > > message is useful. Does one of the patches add it to the tree > > somewhere? > > No, but I'm happ

[ovs-dev] Question

2014-11-26 Thread Kevin Batchelor
can you make your coding on https://github.com/ ? can you add this to your website https://www.openaccessbutton.org/ if you have accept payments can you make bitcoin a option ? alot websites use https://bitpay.com/ or https://www.coinbase.com/ so people can donate on there website ___

Re: [ovs-dev] [PATCH] dpif-netdev: Fix a race.

2014-11-26 Thread Alex Wang
Yeah, If we take a ref count, then, there is possibility that threads like 'monitor' thread can take a reference when main thread is deleting the 'port' => delay the netdev_close => if main thread want to immediately recreate the port, it will fail... So, it is most safe to just acquire the lock

[ovs-dev] OFtest--time for a new run?

2014-11-26 Thread Ben Pfaff
I received an off-list report that OVS 2.3.0 fails a number of OFtest test cases. I don't know whether they are important failures or not. Anyone have some time to run a "make check-oftest" against the latest version of OFtest and do a little investigation? Much appreciated. Thanks, Ben. __

Re: [ovs-dev] [PATCH v5 11/13] datapath: Allow masks for set actions.

2014-11-26 Thread Jarno Rajahalme
On Nov 25, 2014, at 7:33 PM, Jesse Gross wrote: > On Fri, Sep 5, 2014 at 4:05 PM, Jarno Rajahalme wrote: >> Masked set action allows more megaflow wildcarding. Masked set action >> is now supported for all writeable key types, except for the tunnel >> key. >> >> The set tunnel action is an ex

Re: [ovs-dev] [PATCH v5 12/13] datapath: Relax flow set-up time validations.

2014-11-26 Thread Jarno Rajahalme
On Nov 25, 2014, at 10:21 PM, Jesse Gross wrote: > On Fri, Sep 5, 2014 at 4:05 PM, Jarno Rajahalme wrote: >> Allow setting of fields without matching on the same fields. Field >> existence check is done on set action execution time instead, using >> the extracted flow key. >> >> Signed-off-by

Re: [ovs-dev] [PATCH] dpif-netdev: Fix a race.

2014-11-26 Thread Jarno Rajahalme
On Nov 26, 2014, at 2:25 PM, Alex Wang wrote: > Yeah, > > If we take a ref count, then, there is possibility that threads like > 'monitor' > thread can take a reference when main thread is deleting the 'port' > => delay the netdev_close > => if main thread want to immediately recreate the por

Re: [ovs-dev] [PATCH 01/10] flow.h: Simplify MAP_FOR_EACH_INDEX()

2014-11-26 Thread Jarno Rajahalme
On Nov 25, 2014, at 3:35 PM, Ben Pfaff wrote: > On Thu, Nov 20, 2014 at 04:42:48PM -0800, Jarno Rajahalme wrote: >> Avoid comparing against specific values. >> >> Signed-off-by: Jarno Rajahalme > > Acked-by: Ben Pfaff Thanks for the review! Pushed to master, Jarno

Re: [ovs-dev] [PATCH 02/10] flow: Define MINIFLOW_GET__() to simplify code.

2014-11-26 Thread Jarno Rajahalme
On Nov 25, 2014, at 3:37 PM, Ben Pfaff wrote: > On Thu, Nov 20, 2014 at 04:42:49PM -0800, Jarno Rajahalme wrote: >> Signed-off-by: Jarno Rajahalme > > Can this be an inline function instead of a macro? I'd prefer that. Yes it can, I’ll make it so for the v2. Jarno ___

Re: [ovs-dev] [PATCH 03/10] flow.c: Improve minimask_equal() and minimask_has_extra().

2014-11-26 Thread Jarno Rajahalme
On Nov 25, 2014, at 3:43 PM, Ben Pfaff wrote: > On Thu, Nov 20, 2014 at 04:42:50PM -0800, Jarno Rajahalme wrote: >> minimask_equal() and minimask_has_extra() can take benefit from the >> fact that minimasks have no zero data. >> >> Signed-off-by: Jarno Rajahalme > > I suspect that the new mac

Re: [ovs-dev] [PATCH 04/10] lib: Use MAP_FOR_EACH_INDEX to improve readability.

2014-11-26 Thread Jarno Rajahalme
On Nov 25, 2014, at 4:19 PM, Ben Pfaff wrote: > On Thu, Nov 20, 2014 at 04:42:51PM -0800, Jarno Rajahalme wrote: >> Signed-off-by: Jarno Rajahalme > > In most of the cases this just improves readability and should not > change the generated code much if at all. In miniflow_hash(), though, > t

Re: [ovs-dev] [PATCH v2] route-table: Remove Unregister.

2014-11-26 Thread YAMAMOTO Takashi
> Since dpif registering for routing table at initialization > there is no need to unregister it. Following patch removes > support for turning routing table notifications on and off. > Due to this change OVS always listens for these > notifications. > > Reported-by: YAMAMOTO Takashi > Signed-off

Re: [ovs-dev] [PATCH/RFC 0/9] Group Select: Selection Method Extension

2014-11-26 Thread Simon Horman
On Wed, Nov 26, 2014 at 02:00:07PM -0800, Ben Pfaff wrote: > On Wed, Nov 26, 2014 at 10:37:16AM +0900, Simon Horman wrote: > > On Tue, Nov 25, 2014 at 03:31:50PM -0800, Ben Pfaff wrote: > > > On another note, the description of the extension at the end of this > > > message is useful. Does one of

Re: [ovs-dev] [PATCH/RFC 0/9] Group Select: Selection Method Extension

2014-11-26 Thread Ben Pfaff
I will review this version. If you like, you could send one more patch that adds the documentation. I will probably not review it until next week because of the Thanksgiving holiday. On November 26, 2014 6:54:16 PM PST, Simon Horman wrote: >On Wed, Nov 26, 2014 at 02:00:07PM -0800, Ben Pfaff

Re: [ovs-dev] [PATCH/RFC 0/9] Group Select: Selection Method Extension

2014-11-26 Thread Simon Horman
Thanks Ben, I think I'll hold off on the extra patch for now. Enjoy your holiday. On Wed, Nov 26, 2014 at 07:03:35PM -0800, Ben Pfaff wrote: > I will review this version. If you like, you could send one more patch that > adds the documentation. > > I will probably not review it until next week

Re: [ovs-dev] Clarification regarding Eviction mechanism on basis of Importance.

2014-11-26 Thread Shashwat Srivastava
Hi Ben, Thanks for the reply just wanted to confirm did you get any reply regarding the EXT-502 from ONF extensibility working group. Also can you please let me know what will happen if the new flow enters the switch with same importance as the lowest importance in the flow table. Considering