On Nov 25, 2014, at 4:19 PM, Ben Pfaff <b...@nicira.com> wrote:
> On Thu, Nov 20, 2014 at 04:42:51PM -0800, Jarno Rajahalme wrote:
>> Signed-off-by: Jarno Rajahalme <jrajaha...@nicira.com>
>
> In most of the cases this just improves readability and should not
> change the generated code much if at all. In miniflow_hash(), though,
> the previous code did not need to use raw_ctz(), which is relatively
> expensive when no machine-specific implementation is available, but
> the new version does use it. Maybe that is OK, but it is a trade-off
> that the other changes in this patch do not make.
>
> Ditto for miniflow_equal().
>
Thanks for noticing this. I reverted the change for these cases and pushed the
patch to master.
Jarno
> Acked-by: Ben Pfaff <b...@nicira.com>
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
