On 10/30/14 at 11:48am, Wang Sheng-Hui wrote:
> Hi,
>
> I used CentOS 6.5, and failed building the latest ovs:
>
> libtool: compile: gcc -std=gnu99 -DHAVE_CONFIG_H -I. -I ./include -I
> ./include -I ./lib -I ./lib -Wstrict-prototypes -Wall -Wextra
> -Wno-sign-compare -Wpointer-arith -Wno-forma
Hi Team,
I was going through openflow specs 1.4 and as mentioned in section
7.3.4.1. page no. 73 "If the flag OFPTMPEF_IMPORTANCE is the only flag
set, eviction will
be performed strictly in order of importance, that is flow entry with
lower importance will always be evicted before flow entry w
Signed-off-by: Thomas Graf
---
FAQ.md | 10 +-
INSTALL.Libvirt.md | 6 +++---
INSTALL.NetBSD.md| 3 ++-
INSTALL.SSL.md | 4 ++--
INSTALL.md | 16
INSTALL.userspace.md | 6 +++---
OPENFLOW-1.1+.md | 4 ++--
README.md
Thomas,
I really find this work of moving the documentation to Markdown very
useful, thanks for spending time on it!
I have two suggestions about the way files are linked.
First, I would use the new file name in the link, for example
[CONTRIBUTING.md](CONTRIBUTING.md) instead of
[CONTRIBUTI
On 10/29/14 at 11:46pm, Ben Pfaff wrote:
> A "conjunctive match" allows higher-level matches in the flow table, such
> as set membership matches, without causing a cross-product explosion for
> multidimensional matches. Please refer to the documentation that this
> commit adds to ovs-ofctl(8) for
On 10/30/14 at 12:55pm, Lori Jakab wrote:
> Second, to improve readability, I would only put "[CONTRIBUTING.md]" in the
> text without the second part "(CONTRIBUTING.md)" the to avoid duplication,
> and add the reference at the end of the file as "[CONTRIBUTING.md]:
> CONTRIBUTING.md" once. The las
Suggested-by: Lori Jakab
Signed-off-by: Thomas Graf
---
- Use reference section at end of document to allow adding references
by simpling surrounding file names with [] as suggested by Lori.
CONTRIBUTING.md | 10 ++
FAQ.md | 18 +++---
INSTALL.DPDK.md
Hi Ben,
As per your suggestion we tried setting up git send-email for the submissions
of the patches but due to internal company policies we were unable to set up
the same.
To move ahead we are attaching the patch file which contains all the 5 patches
related to setting of the importance
On Thu, Oct 30, 2014 at 01:04:14PM +0100, Thomas Graf wrote:
> Suggested-by: Lori Jakab
> Signed-off-by: Thomas Graf
> ---
Nice!
Reviewed-by: Flavio Leitner
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
On Thu, Oct 30, 2014 at 05:49:44PM +0530, Rishi Bamba wrote:
>
> Hi Ben,
>
>
> As per your suggestion we tried setting up git send-email for the
> submissions of the patches but due to internal company policies we
> were unable to set up the same.
git send-mail makes life easier for you to po
In my tests I came around a BSOD that happened when trying to
access pidHashLock from the gOvsSwitchContext, which was NULL.
The stop happened in OvsAcquirePidHashLock function.
Signed-off-by: Sorin Vinturis
---
datapath-windows/ovsext/BufferMgmt.c | 8 ++--
datapath-windows/ovsext/Datapat
Acked-by: Eitan Eliahu
-Original Message-
From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Nithin Raju
Sent: Wednesday, October 29, 2014 3:18 PM
To: dev@openvswitch.org
Subject: [ovs-dev] [PATCH 1/3] datapath-windows: nuke USE_NEW_VPORT_ADD_WORKFLOW
We were using USE_NEW_VPORT
On Thu, Oct 30, 2014 at 05:49:44PM +0530, Rishi Bamba wrote:
> To move ahead we are attaching the patch file which contains all the 5
> patches related to setting of the importance parameter in a rule and
> also enhancing the CLI's affected by the change.
If you're going to attach patches, attach
On Thu, Oct 30, 2014 at 01:04:14PM +0100, Thomas Graf wrote:
> Suggested-by: Lori Jakab
> Signed-off-by: Thomas Graf
Thanks for working on the documentation! I applied this to master.
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mai
On Thu, Oct 30, 2014 at 12:06:30PM +0100, Thomas Graf wrote:
> On 10/29/14 at 11:46pm, Ben Pfaff wrote:
> > A "conjunctive match" allows higher-level matches in the flow table, such
> > as set membership matches, without causing a cross-product explosion for
> > multidimensional matches. Please re
Hi Nithin,
Can you please revisit the locking sequence for the netdev handler?
It seems that OvsGetVportDumpNext() is called with the two locks, Dispatch and
Control held, (can we add a comment on it in the function header?).
But, the Control lock is released at line 1214.
Thanks,
Eitan
-Orig
On Thu, Oct 30, 2014 at 03:55:45PM +0530, Shashwat Srivastava wrote:
> I was going through openflow specs 1.4 and as mentioned in section
> 7.3.4.1. page no. 73 "If the flag OFPTMPEF_IMPORTANCE is the only flag
> set, eviction will
> be performed strictly in order of importance, that is flow entr
On Wed, Oct 29, 2014 at 11:41:47AM -0700, Jarno Rajahalme wrote:
> Subject: [ovs-dev] [PATCH 1/2] lib/list: Inline list functions.
There seems to be a new trend of writing directory names at the
beginning of subjects, e.g. "lib/list" instead of "list". I am not sure
where it came from. I've been
On Wed, Oct 29, 2014 at 11:41:48AM -0700, Jarno Rajahalme wrote:
> ./configure accepts --enable-ndebug option. Make ovs_assert() honor
> it, and make sure all test programs disable it.
>
> The order of include files in test programs is also made uniform:
>
> 1. #include
> 2. #undef NDEBUG
> 3.
On Oct 30, 2014, at 8:43 AM, Ben Pfaff wrote:
> On Wed, Oct 29, 2014 at 11:41:47AM -0700, Jarno Rajahalme wrote:
>> Subject: [ovs-dev] [PATCH 1/2] lib/list: Inline list functions.
>
> There seems to be a new trend of writing directory names at the
> beginning of subjects, e.g. "lib/list" instea
On Oct 30, 2014, at 8:43 AM, Ben Pfaff wrote:
> On Wed, Oct 29, 2014 at 11:41:48AM -0700, Jarno Rajahalme wrote:
>> ./configure accepts --enable-ndebug option. Make ovs_assert() honor
>> it, and make sure all test programs disable it.
>>
>> The order of include files in test programs is also m
On Oct 29, 2014, at 11:46 PM, Ben Pfaff wrote:
> I have mixed feelings about this change. I think it might be better to
> change the classifier priority type to "int", then document that negative
> values are reserved for use by the classifier.
>
I agree that using an “int” would be cleaner.
Commit 542cc9bb(doc: Convert docs to Markdown language) changes
the file name in root directory which causes the file exist check
fails in make sandbox. This commit fixes the issue.
Signed-off-by: Alex Wang
---
tutorial/ovs-sandbox |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff
On Oct 30, 2014, at 8:27 AM, Eitan Eliahu
wrote:
> Hi Nithin,
> Can you please revisit the locking sequence for the netdev handler?
> It seems that OvsGetVportDumpNext() is called with the two locks, Dispatch
> and Control held, (can we add a comment on it in the function header?).
> But, the C
On Thu, Oct 30, 2014 at 09:37:51AM -0700, Alex Wang wrote:
> Commit 542cc9bb(doc: Convert docs to Markdown language) changes
> the file name in root directory which causes the file exist check
> fails in make sandbox. This commit fixes the issue.
>
> Signed-off-by: Alex Wang
I think that Thomas
On Thu, Oct 30, 2014 at 08:37:14AM -0700, Ben Pfaff wrote:
> On Thu, Oct 30, 2014 at 03:55:45PM +0530, Shashwat Srivastava wrote:
> > I was going through openflow specs 1.4 and as mentioned in section
> > 7.3.4.1. page no. 73 "If the flag OFPTMPEF_IMPORTANCE is the only flag
> > set, eviction wil
Nithin,
It seems that the locking is done by the caller to OvsGetExtInfoIoctl() but
this function releases the control lock (Line 1214) which was acquired by the
caller.
if (vport == NULL || (vport->ovsState != OVS_STATE_CONNECTED &&
vport->ovsState != OVS_STATE_NI
Yeah, did not see that, I'll drop this patch
On Thu, Oct 30, 2014 at 10:14 AM, Ben Pfaff wrote:
> On Thu, Oct 30, 2014 at 09:37:51AM -0700, Alex Wang wrote:
> > Commit 542cc9bb(doc: Convert docs to Markdown language) changes
> > the file name in root directory which causes the file exist check
> -Original Message-
> From: Eitan Eliahu
> Sent: Thursday, October 30, 2014 10:18 AM
> To: Nithin Raju
> Cc: dev@openvswitch.org
> Subject: RE: [ovs-dev] [PATCH 2/3] datapath-windws: fix locking code in
> OvsGetNetdevCmdHandler()
>
> Nithin,
> It seems that the locking is done by the call
On Thu, Oct 30, 2014 at 09:29:25AM -0700, Jarno Rajahalme wrote:
>
> On Oct 29, 2014, at 11:46 PM, Ben Pfaff wrote:
>
> > I have mixed feelings about this change. I think it might be better to
> > change the classifier priority type to "int", then document that negative
> > values are reserved
On Thu, Oct 30, 2014 at 12:55:33PM +0800, Wang Sheng-Hui wrote:
> WHY-OVS has been renamed to WHY-OVS.md. Update the filenames in run-oftest
> and run-ryu scripts
>
> Signed-off-by: Wang Sheng-Hui
Applied, thanks.
___
dev mailing list
dev@openvswitch.o
We have to define our own with some kernel headers, so we might as well do
it everywhere, especially since there seems to be a problem with detecting
the presence of the definition with at least some kernels.
Reported-by: Wang Sheng-Hui
Signed-off-by: Ben Pfaff
---
configure.ac |2 --
On Thu, Oct 30, 2014 at 11:25:00AM +0100, Thomas Graf wrote:
> On 10/30/14 at 11:48am, Wang Sheng-Hui wrote:
> > Hi,
> >
> > I used CentOS 6.5, and failed building the latest ovs:
> >
> > libtool: compile: gcc -std=gnu99 -DHAVE_CONFIG_H -I. -I ./include -I
> > ./include -I ./lib -I ./lib -Wstri
Modified the NEWS and added the ovs-command-compgen.INSTALL.md~
Pushed to master
On Tue, Oct 28, 2014 at 6:47 PM, Alex Wang wrote:
>
>> This should come with at least some minimal documentation somewhere
>> explaining how to install it, and it should be mentioned in NEWS. I
>> think that the a
On Oct 29, 2014, at 11:46 PM, Ben Pfaff wrote:
> A "conjunctive match" allows higher-level matches in the flow table, such
> as set membership matches, without causing a cross-product explosion for
> multidimensional matches. Please refer to the documentation that this
> commit adds to ovs-ofct
Acked-by: Eitan Eliahu
Thanks,
Eitan
-Original Message-
From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Nithin Raju
Sent: Wednesday, October 29, 2014 3:18 PM
To: dev@openvswitch.org
Subject: [ovs-dev] [PATCH 3/3] datapath-windows: increase the maximum size of
port name
In u
On 30 October 2014 10:38, Ben Pfaff wrote:
> We have to define our own with some kernel headers, so we might as well do
> it everywhere, especially since there seems to be a problem with detecting
> the presence of the definition with at least some kernels.
>
> Reported-by: Wang Sheng-Hui
> Sign
On Thu, Oct 30, 2014 at 12:39:16PM -0700, Joe Stringer wrote:
> On 30 October 2014 10:38, Ben Pfaff wrote:
>
> > We have to define our own with some kernel headers, so we might as well do
> > it everywhere, especially since there seems to be a problem with detecting
> > the presence of the defini
We were acquiring locks twice, and forgotten to release a lock in an
error case.
Signed-off-by: Nithin Raju
---
datapath-windows/ovsext/Vport.c | 13 -
1 files changed, 8 insertions(+), 5 deletions(-)
diff --git a/datapath-windows/ovsext/Vport.c b/datapath-windows/ovsext/Vport.c
i
We were using USE_NEW_VPORT_ADD_WORKFLOW while transitioning from old
workflow for adding ports. We don't need it anymore.
Signed-off-by: Nithin Raju
Acked-by: Eitan Eliahu
---
datapath-windows/ovsext/Vport.c | 15 ---
1 files changed, 0 insertions(+), 15 deletions(-)
diff --git
In userspace, port name sizes are restricted to IFNAMSIZ which is
defined to IF_NAME_SIZE in:
C:\Program Files (x86)\Windows Kits\8.1\Include\shared\netioapi.h
In the kernel, since IFNAMSIZ was not available, we previously defined a
value of 16 for the kernel. This is restrictive for Openstack
int
Currently, if we receive an NBL with multiple NBs from NDIS, we just
ASSERT() and not do anything. The right thing to do obviously is to
process the NBL. This is a work in progress.
In the meantime, we should complete the NBL and not just leak it.
Signed-off-by: Nithin Raju
---
datapath-windows
On Thu, Oct 30, 2014 at 08:26:15AM -0700, Ben Pfaff wrote:
> On Thu, Oct 30, 2014 at 12:06:30PM +0100, Thomas Graf wrote:
> > On 10/29/14 at 11:46pm, Ben Pfaff wrote:
> > > A "conjunctive match" allows higher-level matches in the flow table, such
> > > as set membership matches, without causing a c
Commit 635e5bf55b (ofproto: Warn about excessive rule counts in OpenFlow
tables.) introduced an access of classifier_count() without taking the
corresponding locks first.
Found by clang.
Signed-off-by: Joe Stringer
---
Maybe this is not problematic, but clang refuses to compile without a
fix lik
On Oct 30, 2014, at 1:43 PM, Ben Pfaff wrote:
> On Thu, Oct 30, 2014 at 08:26:15AM -0700, Ben Pfaff wrote:
>> On Thu, Oct 30, 2014 at 12:06:30PM +0100, Thomas Graf wrote:
>>> On 10/29/14 at 11:46pm, Ben Pfaff wrote:
A "conjunctive match" allows higher-level matches in the flow table, such
>
Nithin,
Just assert on IRQL==DISPATCH_LEVEL in the beginning of OvsGetExtInfoIoctl()
and we are ready to go.
Thanks,
Eitan
LG otherwise.
Acked-by: Eitan Eliahu
-Original Message-
From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Nithin Raju
Sent: Thursday, October 30, 2014 1:1
We were using USE_NEW_VPORT_ADD_WORKFLOW while transitioning from old
workflow for adding ports. We don't need it anymore.
Signed-off-by: Nithin Raju
Acked-by: Eitan Eliahu
---
datapath-windows/ovsext/Vport.c | 15 ---
1 files changed, 0 insertions(+), 15 deletions(-)
diff --git
We were acquiring locks twice, and forgotten to release a lock in an
error case.
Signed-off-by: Nithin Raju
Acked-by: Eitan Eliahu
---
datapath-windows/ovsext/Vport.c | 14 +-
1 files changed, 9 insertions(+), 5 deletions(-)
diff --git a/datapath-windows/ovsext/Vport.c b/datapath
In userspace, port name sizes are restricted to IFNAMSIZ which is
defined to IF_NAME_SIZE in:
C:\Program Files (x86)\Windows Kits\8.1\Include\shared\netioapi.h
In the kernel, since IFNAMSIZ was not available, we previously defined a
value of 16 for the kernel. This is restrictive for Openstack
int
> -Original Message-
> From: Eitan Eliahu
> Sent: Thursday, October 30, 2014 1:52 PM
> To: Nithin Raju; dev@openvswitch.org
> Subject: RE: [ovs-dev] [PATCH 2/3 v2] datapath-windws: fix locking code in
> OvsGetNetdevCmdHandler()
>
> Nithin,
> Just assert on IRQL==DISPATCH_LEVEL in the begin
Acked-by: Eitan Eliahu
Thanks,
Eitan
-Original Message-
From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Nithin Raju
Sent: Thursday, October 30, 2014 1:18 PM
To: dev@openvswitch.org
Subject: [ovs-dev] [PATCH] datapath-windows: don't leak NBLs with multiple NBs
Currently, if w
Added a function Set-VMNetworkAdapterOVSPortDirect() to be called from
NOVA driver to set a name on the port of the first VNIC for the specified VM.
Usage example:
Set-VMNetworkAdapterOVSPortDirect -OVSPortName ovs-port-5 -VMName NoOS
To confirm that the name was set:
Get-VMNetworkAdapterByOVSPor
On Thu, Oct 30, 2014 at 01:50:38PM -0700, Jarno Rajahalme wrote:
>
> On Oct 30, 2014, at 1:43 PM, Ben Pfaff wrote:
>
> > On Thu, Oct 30, 2014 at 08:26:15AM -0700, Ben Pfaff wrote:
> >> On Thu, Oct 30, 2014 at 12:06:30PM +0100, Thomas Graf wrote:
> >>> On 10/29/14 at 11:46pm, Ben Pfaff wrote:
> >
On Thu, Oct 30, 2014 at 11:39:44AM -0700, Jarno Rajahalme wrote:
>
> On Oct 29, 2014, at 11:46 PM, Ben Pfaff wrote:
>
> > A "conjunctive match" allows higher-level matches in the flow table, such
> > as set membership matches, without causing a cross-product explosion for
> > multidimensional ma
A "conjunctive match" allows higher-level matches in the flow table, such
as set membership matches, without causing a cross-product explosion for
multidimensional matches. Please refer to the documentation that this
commit adds to ovs-ofctl(8) for a better explanation, including an example.
Issu
An upcoming commit will make classifier_lookup() sometimes modify its
'flow' argument temporarily during the lookup.
Signed-off-by: Ben Pfaff
---
v2: New patch.
---
lib/classifier.c |7 +--
lib/classifier.h |3 +--
ofproto/ofproto-dpif.c | 15 ++-
ofproto/of
OpenFlow has priorities in the 16-bit unsigned range, from 0 to 65535.
In the classifier, it is sometimes useful to be able to have values below
and above this range. With the 'unsigned int' type used for priorities
until now, there were no values below the range, so some code worked
around it by
On Tue, Oct 28, 2014 at 07:05:01PM -0700, Jarno Rajahalme wrote:
>
> > On Oct 28, 2014, at 4:36 PM, Ben Pfaff wrote:
> >
> >> On Fri, Oct 24, 2014 at 01:36:40PM -0700, Jarno Rajahalme wrote:
> >> Previously, accurate iteration required writers to be excluded during
> >> iteration. This patch ch
Acked-by: Jarno Rajahalme
On Oct 9, 2014, at 11:10 PM, Ben Pfaff wrote:
> actset_output, to be added in an upcoming commit, has one OXM assignment
> in OpenFlow 1.3 and another one in OpenFlow 1.5. This commit allows both
> of them to be supported in appropriate OpenFlow versions.
>
> This fe
With the following changes (some due to master changing in the meanwhile):
Acked-by: Jarno Rajahalme
---
lib/flow.c |9 ++---
lib/flow.h |1 +
2 files changed, 7 insertions(+), 3 deletions(-)
diff --git a/lib/flow.c b/lib/flow.c
index ecd580a..a742e23 100644
--- a/lib/flow.c
+++ b/
Acked-by: Jarno Rajahalme
On Oct 30, 2014, at 3:36 PM, Ben Pfaff wrote:
> OpenFlow has priorities in the 16-bit unsigned range, from 0 to 65535.
> In the classifier, it is sometimes useful to be able to have values below
> and above this range. With the 'unsigned int' type used for priorities
Acked-by: Jarno Rajahalme
On Oct 30, 2014, at 3:36 PM, Ben Pfaff wrote:
> An upcoming commit will make classifier_lookup() sometimes modify its
> 'flow' argument temporarily during the lookup.
>
> Signed-off-by: Ben Pfaff
> ---
> v2: New patch.
> ---
> lib/classifier.c |7 +--
>
On Oct 30, 2014, at 3:38 PM, Ben Pfaff wrote:
> On Tue, Oct 28, 2014 at 07:05:01PM -0700, Jarno Rajahalme wrote:
>>
>>> On Oct 28, 2014, at 4:36 PM, Ben Pfaff wrote:
>>>
On Fri, Oct 24, 2014 at 01:36:40PM -0700, Jarno Rajahalme wrote:
Previously, accurate iteration required writers
Hi, all
When I use the openvswitch in OpenStack, I find the log bellow and I want to
know why it happens. Why the tunnel ports is reconfiguring ? will this affect
the packet forwarding?
=
2014-10-30T23:22:41.285Z|167533|tunnel|DBG|reconfiguring vxlan-0a081849
2014-
On 2014年10月31日 03:47, Ben Pfaff wrote:
> On Thu, Oct 30, 2014 at 12:39:16PM -0700, Joe Stringer wrote:
>> On 30 October 2014 10:38, Ben Pfaff wrote:
>>
>>> We have to define our own with some kernel headers, so we might as well do
>>> it everywhere, especially since there seems to be a problem w
Thanks.
I think that this commit is a code cleanup on its own, so I applied this
to master.
On Thu, Oct 30, 2014 at 04:34:15PM -0700, Jarno Rajahalme wrote:
> Acked-by: Jarno Rajahalme
>
> On Oct 30, 2014, at 3:36 PM, Ben Pfaff wrote:
>
> > OpenFlow has priorities in the 16-bit unsigned range
Thanks.
I don't think this one is useful on its own, so I'll maintain it in this
series for now.
On Thu, Oct 30, 2014 at 04:35:25PM -0700, Jarno Rajahalme wrote:
> Acked-by: Jarno Rajahalme
>
> On Oct 30, 2014, at 3:36 PM, Ben Pfaff wrote:
>
> > An upcoming commit will make classifier_lookup(
On Fri, Oct 31, 2014 at 08:40:18AM +0800, Wang Sheng-Hui wrote:
>
>
> On 2014年10月31日 03:47, Ben Pfaff wrote:
> > On Thu, Oct 30, 2014 at 12:39:16PM -0700, Joe Stringer wrote:
> >> On 30 October 2014 10:38, Ben Pfaff wrote:
> >>
> >>> We have to define our own with some kernel headers, so we migh
Tested-by: Alin Gabriel Serdean
Acked-by: Alin Gabriel Serdean
-Mesaj original-
De la: dev [mailto:dev-boun...@openvswitch.org] În numele Nithin Raju
Trimis: Thursday, October 30, 2014 10:18 PM
Către: dev@openvswitch.org
Subiect: [ovs-dev] [PATCH] datapath-windows: don't leak NBLs with
www.Facebook.com
Herzlichen Glückwunsch,
Wie feiern unsere 10 Jahre Internet Reise- und globale
Kommunikation/Sozialisation wir danken, verkünden, dass Ihr Facebook
als Konto
Empfänger bis zum Jahresende von $1.000, 000 00usd in 2014 Facebook
nach dem Zufallsprinzip ausgewählt.
Heute
We're starting to receive some contributions to the website repo. Some
are from people who do not contribute code (notably, Scott Lowe). We
don't currently have a way to acknowledge these contributions, which are
in my opinion as valuable as any similar contribution to the source code
repository.
Sounds good to me. I think many of these contributions (such as from Scott)
will turn into essentially documentation improvements by way of configuration
examples.
--Justin
> On Oct 30, 2014, at 9:16 PM, Ben Pfaff wrote:
>
> We're starting to receive some contributions to the website repo.
On Oct 30, 2014, at 9:16 PM, Ben Pfaff wrote:
We're starting to receive some contributions to the website repo. Some
are from people who do not contribute code (notably, Scott Lowe). We
don't currently have a way to acknowledge these contributions, which are
in my opinion as valuable as any sim
Signed-off-by: Joe Stringer
---
lib/ofp-parse.c |3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/lib/ofp-parse.c b/lib/ofp-parse.c
index eed5a08..0473665 100644
--- a/lib/ofp-parse.c
+++ b/lib/ofp-parse.c
@@ -588,7 +588,8 @@ parse_ofp_meter_mod_str__(struct ofputil_meter_m
74 matches
Mail list logo
