dev+unsubscr...@openvswitch.org
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
Commit 9c537baf613a16e (bridge: Refactor the stats and status update.)
inadvertently changed the way that the status transaction is destroyed,
which could cause the main thread to constantly wake up.
The bug occurs when a transaction returns TXN_INCOMPLETE, then there are
no subsequent changes to
This function allows netlink attributes to be parsed more strictly,
to check for additional constraints beyond those that nla_parse() checks
for. Passing flags=0 to nla_parse_strict() implies the same behaviour as
nla_parse().
Signed-off-by: Joe Stringer
---
v3: Shift nla_parse_strict() from linu
Reduce duplicate code by using nla_policy and nla_parse_strict().
Signed-off-by: Joe Stringer
---
v3: Fix match_validate()
Make ovs_key_from_nlattrs(),metadata_from_nlattrs() not change the
attrs they are given
Remove extraneous check for duplicate attributes
Use NLA_FLAG, NLA_N
Currently, whenever there's a missed packet, the ovs driver allocates
memory and copies the packet even if there's no packet queue setup from
userspace. Then if there's no queue created, the packet is released and
dropped.
The solution was to check for the existence of the userspace queue before
t
It's for miniflow equalness check, not flow.
Signed-off-by: Wang Sheng-Hui
---
lib/flow.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/flow.c b/lib/flow.c
index b9f1820..4f22597 100644
--- a/lib/flow.c
+++ b/lib/flow.c
@@ -1770,7 +1770,7 @@ miniflow_get(const struct mi
On Sat, Sep 27, 2014 at 01:39:06AM -0700, Eitan Eliahu wrote:
> The Read event handler is executed when user mode issues a socket
> receive on an MC socket associated with the event queue. A new IOCTL
> READ command is used to differentiate between transaction based and packet
> miss sockets.
> An
On Thu, Sep 25, 2014 at 06:18:19AM +, Alin Serdean wrote:
> The following script leverage's the advantages of WMI infrastructure
> offered in Hyper-V.
>
> This scripts allows the user to change the
> Msvm_EthernetPortAllocationSettingData property of a VM network adapter
> connected to a Hyper
On Fri, Sep 26, 2014 at 06:38:16PM -0700, Nithin Raju wrote:
> While calculating the hash on a VPORT name, we don't include the NUL
> character.
> We should be doing the same while doing lookup as well.
>
> We set the required minimum length of the name to be 2 so that the string has
> at least o
On Fri, Sep 26, 2014 at 05:32:12PM -0700, Ankur Sharma wrote:
> Moved the structure OVS_MESSAGE to Netlink.h.
> This change is done for following reasons.
>
> a. Patch 2 in this series provides a generic API in Netlink.c
> for creating netlink message. That API needs OVS_MESSAGE.
> Including Datap
Could you try using `ovs-dpctl dump-flows` to see what the flow look like
when you start the iperf test?
I checked the radio, iperf test should work if you used that configuration,
Thanks,
Alex Wang,
On Sun, Sep 28, 2014 at 11:44 PM, Gheit Abomakhleb
wrote:
> Thanks for your quick reply
> Of c
On Mon, Sep 29, 2014 at 03:07:04PM +, Sorin Vinturis wrote:
> Currently, whenever there's a missed packet, the ovs driver allocates
> memory and copies the packet even if there's no packet queue setup from
> userspace. Then if there's no queue created, the packet is released and
> dropped.
>
>
If you can ping but cannot use iperf for TCP, one thing to do would be
to check iptables rules that block TCP connections in the VM (default
in Centos)
On Mon, Sep 29, 2014 at 9:07 AM, Alex Wang wrote:
> Could you try using `ovs-dpctl dump-flows` to see what the flow look like
> when you start th
On Mon, Sep 29, 2014 at 03:21:37PM +0800, Wang Sheng-Hui wrote:
> It's for miniflow equalness check, not flow.
>
> Signed-off-by: Wang Sheng-Hui
Applied, thanks!
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
Currently, whenever there's a missed packet, the ovs driver allocates
memory and copies the packet even if there's no packet queue setup from
userspace. Then if there's no queue created, the packet is released and
dropped.
The solution was to check for the existence of the userspace queue before
t
Can't seem to reach it now.
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
Recently we changed the signature of NlAttrParse.
Function OvsGetVport was not updated accordingly.
Fixed the same.
Signed-off-by: Ankur Sharma
---
datapath-windows/ovsext/Datapath.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/datapath-windows/ovsext/Datapath.c
b/datapath-windows/ovsex
Thx a lot for the fix, that was a bad move~
Acked-by: Alex Wang
On Mon, Sep 29, 2014 at 3:09 AM, Joe Stringer
wrote:
> Commit 9c537baf613a16e (bridge: Refactor the stats and status update.)
> inadvertently changed the way that the status transaction is destroyed,
> which could cause the main t
This patch implements the vhost-net offload API. It adds support for
a new port type to userspace datapath called dpdkvhost. This allows KVM
(QEMU) to offload the servicing of virtio-net devices to it's associated
dpdkvhost port. Instructions for use are in INSTALL.DPDK.
This has been tested on I
Acked-by: Eitan Eliahu
Thanks,
Eitan
-Original Message-
From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Ankur Sharma
Sent: Monday, September 29, 2014 10:13 AM
To: dev@openvswitch.org
Subject: [ovs-dev] [PATCH v1] datapath-windows: Build fix.
Recently we changed the signature
On Sep 29, 2014, at 10:13 AM, Ankur Sharma
wrote:
> Recently we changed the signature of NlAttrParse.
> Function OvsGetVport was not updated accordingly.
>
> Fixed the same.
>
> Signed-off-by: Ankur Sharma
Acked-by: Nithin Raju
___
dev mailing
Tested under Release/Debug.
Acked-by: Alin Gabriel Serdean
-Mesaj original-
De la: dev [mailto:dev-boun...@openvswitch.org] În numele Nithin Raju
Trimis: Monday, September 29, 2014 8:17 PM
Către: Ankur Sharma
Cc:
Subiect: Re: [ovs-dev] [PATCH v1] datapath-windows: Build fix.
On Sep 29
On Mon, Sep 29, 2014 at 10:13:00AM -0700, Ankur Sharma wrote:
> Recently we changed the signature of NlAttrParse.
> Function OvsGetVport was not updated accordingly.
>
> Fixed the same.
>
> Signed-off-by: Ankur Sharma
Applied, thanks everyone!
___
dev
We never released 2.2.0, so references to it are confusing.
Signed-off-by: Justin Pettit
---
FAQ |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/FAQ b/FAQ
index 175a5ac..9e74a3f 100644
--- a/FAQ
+++ b/FAQ
@@ -149,7 +149,7 @@ A: The following table lists the Linux kernel
On Mon, Sep 29, 2014 at 11:16 AM, Justin Pettit wrote:
> We never released 2.2.0, so references to it are confusing.
>
> Signed-off-by: Justin Pettit
Acked-by: Gurucharan Shetty
> ---
> FAQ |2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/FAQ b/FAQ
> index 175a5ac
User mode sends down three distinct Read ioctl commands for Events, Packet
Reads and Dumps. In case the Packet Read socket can not be distinguished a
Set function will be provided.
Signed-off-by: Eitan Eliahu
---
lib/netlink-socket.c | 12 +---
1 file changed, 9 insertions(+), 3 deletion
Thanks for review, I reworded the commit message and comment and pushed to
master:
Commit 9c537baf613a16e (bridge: Refactor the stats and status update.)
inadvertently changed the way that the status transaction is destroyed,
which could cause the main thread to constantly wake up.
We are hitting spurious CI failures. I assume it's due to the VM
running relatively slow and thus the current ovs-appctl time/warp not
being sufficient. I'm not familiar with all the tests cases, can we
just +50% on the current values to account for the slowness? Better
fix?
Thomas
___
On Fri, Sep 26, 2014 at 09:28:12PM +1200, Joe Stringer wrote:
> This just makes it a bit easier for someone coming in fresh to do some
> searches and figure out what the description means.
>
> Signed-off-by: Joe Stringer
> ---
> v6: First post.
Acked-by: Ben Pfaff
__
On Fri, Sep 26, 2014 at 09:28:05PM +1200, Joe Stringer wrote:
> We previously counted flows that have been installed during the current
> dump as duplicates, rather than recognising them as new flows. This
> patch separates the counters out for these two cases.
>
> Signed-off-by: Joe Stringer
> -
Thanks. Pushed.
--Justin
On September 29, 2014 at 11:26:11 AM, Gurucharan Shetty (shet...@nicira.com)
wrote:
> On Mon, Sep 29, 2014 at 11:16 AM, Justin Pettit wrote:
> > We never released 2.2.0, so references to it are confusing.
> >
> > Signed-off-by: Justin Pettit
> Acked-by: Gurucharan Sh
Looks a bit tidier, thanks!
>From the linked travis build, it seems like there's still a bit of
verbosity on the testsuite builds, because they do a 'make distcheck' after
the standard configure and make. Could we just run make distcheck in those
cases, and make sure it gets run with the silent fl
On Fri, Sep 26, 2014 at 09:28:13PM +1200, Joe Stringer wrote:
> Add the 128-bit murmurhash by Austin Appleby, r150 from:
> http://code.google.com/p/smhasher/source/browse/trunk/MurmurHash3.cpp
>
> Signed-off-by: Joe Stringer
> ---
> The x64 version is approximately 2x faster than x86 in the tests
Thanks for looking this over.
I don't understand the suggestion. Can you explain further?
One factor: I don't think automated builds should use
--enable-silent-rules, because for automated builds one wants as much
information as possible on failure. I do want it for my local
developer builds, w
Ah, I thought that you may have proposed/pushed the --enable-silent-rules
for travis build on master, rather than just using travis to test that this
patch works as intended. Misunderstanding on my part, so never mind.
On 30 September 2014 09:37, Ben Pfaff wrote:
> Thanks for looking this over.
On Fri, Sep 26, 2014 at 09:28:14PM +1200, Joe Stringer wrote:
> This patch shifts the responsibility for determining the hash for a flow
> from the revalidation logic down to the dpif layer. This assists in
> handling backward-compatibility for revalidation with the upcoming
> unique identifier "UI
On Fri, Sep 26, 2014 at 09:28:15PM +1200, Joe Stringer wrote:
> If a datapath is created with the flag OVS_DP_F_INDEX_BY_UID, then an
> additional table_instance is added to the flow_table, which is indexed
> by unique identifiers ("UID"). Userspace implementations can specify a
> UID of up to 128
On Fri, Sep 26, 2014 at 09:28:16PM +1200, Joe Stringer wrote:
> This patch modifies the dpif interface to allow flows to be manipulated
> using a 128-bit identifier. This allows revalidator threads to perform
> datapath operations faster, as they do not need to serialise the entire
> flow key for o
On Fri, Sep 26, 2014 at 09:28:17PM +1200, Joe Stringer wrote:
> One of the limiting factors on the number of flows that can be supported
> in the datapath is the overhead of assembling flow dump messages in the
> datapath. This patch modifies the flow_dump interface to allow
> revalidators to skip
On Fri, Sep 26, 2014 at 09:28:18PM +1200, Joe Stringer wrote:
> Previously we stored the netlink-formatted version of a flow key and
> mask in 'struct udpif_key'. This patch stores the original key,mask
> in the 'struct match' format, which reduces the size of a ukey from 1216
> bytes to 560. Furth
Great, thanks for the clarification.
Applied to master.
On Tue, Sep 30, 2014 at 09:44:46AM +1300, Joe Stringer wrote:
> Ah, I thought that you may have proposed/pushed the --enable-silent-rules
> for travis build on master, rather than just using travis to test that this
> patch works as intended
On Wed, Sep 24, 2014 at 09:06:15AM +0900, YAMAMOTO Takashi wrote:
> > Signed-off-by: Ben Pfaff
>
> Acked-by: YAMAMOTO Takashi
Applied, thanks!
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
On Wed, Sep 24, 2014 at 09:07:18AM +0900, YAMAMOTO Takashi wrote:
> > Signed-off-by: Ben Pfaff
>
> Acked-by: YAMAMOTO Takashi
Thanks, applied.
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
On Wed, Sep 24, 2014 at 09:16:58AM +0900, YAMAMOTO Takashi wrote:
> > A log message has warned that this was going to happen for some time, and
> > newer OpenFlow versions require this behavior.
> >
> > The test updates fix this behavior in our testsuite.
> >
> > Signed-off-by: Ben Pfaff
>
> Ac
On Wed, Sep 24, 2014 at 09:22:30AM +0900, YAMAMOTO Takashi wrote:
> > Following this change, only meta-flow.c uses any explicit NXM_* or OXM_*
> > constants. An upcoming commit will actually remove the definitions of
> > these constants, hiding them behind a functional interface, for better
> > ab
On Wed, Sep 24, 2014 at 09:27:19AM +0900, YAMAMOTO Takashi wrote:
> > dp_hash and recirc_id are specific to OVS, but that doesn't mean that we
> > shouldn't encode them into flow matches when OXM is used in OpenFlow 1.2
> > and later.
> >
> > Signed-off-by: Ben Pfaff
>
> Acked-by: YAMAMOTO Takas
On Wed, Sep 24, 2014 at 10:24:11AM +0900, YAMAMOTO Takashi wrote:
> > This is a first step toward improving the abstraction of OXM and NXM in the
> > tree. As an immediate improvement, this commit removes all of the
> > definitions of the OXM and NXM constants from the top-level header files,
> >
On Wed, Sep 24, 2014 at 10:33:21AM +0900, YAMAMOTO Takashi wrote:
> > This will acquire its first user in an upcoming commit.
> >
> > This implementation is not optimized at all but it doesn't matter for the
> > purpose for which I intend to initially use it.
> >
> > Signed-off-by: Ben Pfaff
> >
On Wed, Sep 24, 2014 at 10:37:45AM +0900, YAMAMOTO Takashi wrote:
> > NXM/OXM are only supposed to put 1-bits in a value if the corresponding bit
> > in the mask is a 1-bit, but in the case of cookie matching, e.g.
> > ovs-ofctl del-flows br0 cookie=0x3/0x1
> > ovs-ofctl would encode a bad OXM.
On Wed, Sep 24, 2014 at 10:40:14AM +0900, YAMAMOTO Takashi wrote:
> > The OpenFlow 1.5 (draft) Copy-Field action has two OXM headers, one after
> > the other. Until now, Open vSwitch has implemented these as a pair of
> > ovs_be32 membes, which meant that only 32-bit OXM could be supported. This
This commit updates the DPDK related documentation to reflect
the pmd thread multi-threading work.
Signed-off-by: Alex Wang
---
PATCH->V2:
- use present tense.
---
INSTALL.DPDK | 70 ++
vswitchd/vswitch.xml |5 ++--
2 files changed, 3
On 30 September 2014 09:30, Ben Pfaff wrote:
> On Fri, Sep 26, 2014 at 09:28:13PM +1200, Joe Stringer wrote:
> > Add the 128-bit murmurhash by Austin Appleby, r150 from:
> > http://code.google.com/p/smhasher/source/browse/trunk/MurmurHash3.cpp
> >
> > Signed-off-by: Joe Stringer
> > ---
> > The
In this series we have flow dump/get in datapath-windows.
We have added some additional APIs in Netlink that looked
to be useful.
Ankur Sharma (5):
datapath-windows: Netlink additional APIs.
datapath-windows: Added the API for getting unused space in nlbuf.
datapath-windows: Flow Dump ha
In this patch we have added following new APIs.
NlMsgAlignSize => Aligns the size of netlink message.
NlMsgSetSize => Sets the value of nlmsgLen.
Signed-off-by: Ankur Sharma
---
datapath-windows/ovsext/Netlink/Netlink.c | 54 +++
datapath-windows/ovsext/Netlink/Netli
Also, the boundary check in NlBufAt was a little weird.
Fixed the same.
Signed-off-by: Ankur Sharma
---
datapath-windows/ovsext/Datapath.c | 3 +--
datapath-windows/ovsext/Netlink/NetlinkBuf.c | 2 +-
datapath-windows/ovsext/Netlink/NetlinkBuf.h | 14 ++
3 files changed,
In this patch we have added basic changes for
handler registeration for FLOW_GET command.
Signed-off-by: Ankur Sharma
---
datapath-windows/include/OvsPub.h | 2 +-
datapath-windows/ovsext/Datapath.c | 25 +
datapath-windows/ovsext/Datapath.h | 14 --
datapat
In this patch we have implemented the flow get.
Signed-off-by: Ankur Sharma
---
datapath-windows/ovsext/Flow.c | 200 +
1 file changed, 184 insertions(+), 16 deletions(-)
diff --git a/datapath-windows/ovsext/Flow.c b/datapath-windows/ovsext/Flow.c
index e
In this patch we have implemented the flow dump.
Signed-off-by: Ankur Sharma
---
datapath-windows/ovsext/Flow.c | 635 -
1 file changed, 625 insertions(+), 10 deletions(-)
diff --git a/datapath-windows/ovsext/Flow.c b/datapath-windows/ovsext/Flow.c
index
On 30 September 2014 09:51, Ben Pfaff wrote:
> On Fri, Sep 26, 2014 at 09:28:14PM +1200, Joe Stringer wrote:
> > This patch shifts the responsibility for determining the hash for a flow
> > from the revalidation logic down to the dpif layer. This assists in
> > handling backward-compatibility for
> On Wed, Sep 24, 2014 at 10:24:11AM +0900, YAMAMOTO Takashi wrote:
>> > This is a first step toward improving the abstraction of OXM and NXM in the
>> > tree. As an immediate improvement, this commit removes all of the
>> > definitions of the OXM and NXM constants from the top-level header files,
On Tue, Sep 30, 2014 at 11:30:38AM +1300, Joe Stringer wrote:
> On 30 September 2014 09:30, Ben Pfaff wrote:
>
> > On Fri, Sep 26, 2014 at 09:28:13PM +1200, Joe Stringer wrote:
> > > Add the 128-bit murmurhash by Austin Appleby, r150 from:
> > > http://code.google.com/p/smhasher/source/browse/tru
On 30 September 2014 10:10, Ben Pfaff wrote:
> On Fri, Sep 26, 2014 at 09:28:15PM +1200, Joe Stringer wrote:
> > If a datapath is created with the flag OVS_DP_F_INDEX_BY_UID, then an
> > additional table_instance is added to the flow_table, which is indexed
> > by unique identifiers ("UID"). User
Signed-off-by: YAMAMOTO Takashi
---
CodingStyle | 5 +
1 file changed, 5 insertions(+)
diff --git a/CodingStyle b/CodingStyle
index c9b9989..d1ef65b 100644
--- a/CodingStyle
+++ b/CodingStyle
@@ -541,6 +541,11 @@ C DIALECT
* bool and , but don't assume that bool or _Bool can
only
> On Wed, Sep 24, 2014 at 10:33:21AM +0900, YAMAMOTO Takashi wrote:
>> > This will acquire its first user in an upcoming commit.
>> >
>> > This implementation is not optimized at all but it doesn't matter for the
>> > purpose for which I intend to initially use it.
>> >
>> > Signed-off-by: Ben Pf
>> On Wed, Sep 24, 2014 at 10:24:11AM +0900, YAMAMOTO Takashi wrote:
>>> > This is a first step toward improving the abstraction of OXM and NXM in
>>> > the
>>> > tree. As an immediate improvement, this commit removes all of the
>>> > definitions of the OXM and NXM constants from the top-level he
> This improves the general abstraction of OXM/NXM by eliminating direct
> knowledge of it from the meta-flow code and other places.
>
> Some function renaming might be called for; for example, mf_oxm_header()
> may not be the best name now that the function is implemented within
> nx-match. Howe
On Sep 29, 2014, at 7:16 PM, Eitan Eliahu
wrote:
> User mode sends down three distinct Read ioctl commands for Events, Packet
> Reads and Dumps. In case the Packet Read socket can not be distinguished a
> Set function will be provided.
>
> Signed-off-by: Eitan Eliahu
LG. Only comment I had wa
> This will make it easier to support 64-bit OXM experimenter fields.
>
> Signed-off-by: Ben Pfaff
> static void
> -nxm_put_ipv6(struct ofpbuf *b, uint32_t header,
> +nxm_put_ipv6(struct ofpbuf *b,
> + enum mf_field_id field, enum ofp_version version,
> const struct in
Hello, How are you, I hope you're well, my name is Martha, I'm medium height
and fair in complexion, i love,caring and I decided to contact you. I really
want to have a good relationship with you. Next I have a special something I
want to discuss with you and tell you more about my self. Hope h
On 30 September 2014 10:15, Ben Pfaff wrote:
> On Fri, Sep 26, 2014 at 09:28:16PM +1200, Joe Stringer wrote:
> > This patch modifies the dpif interface to allow flows to be manipulated
> > using a 128-bit identifier. This allows revalidator threads to perform
> > datapath operations faster, as th
On 30 September 2014 10:24, Ben Pfaff wrote:
> On Fri, Sep 26, 2014 at 09:28:17PM +1200, Joe Stringer wrote:
> > One of the limiting factors on the number of flows that can be supported
> > in the datapath is the overhead of assembling flow dump messages in the
> > datapath. This patch modifies t
On 30 September 2014 10:27, Ben Pfaff wrote:
> On Fri, Sep 26, 2014 at 09:28:18PM +1200, Joe Stringer wrote:
> > Previously we stored the netlink-formatted version of a flow key and
> > mask in 'struct udpif_key'. This patch stores the original key,mask
> > in the 'struct match' format, which red
Thanks, applied to master.
On 30 September 2014 08:54, Ben Pfaff wrote:
> On Fri, Sep 26, 2014 at 09:28:05PM +1200, Joe Stringer wrote:
> > We previously counted flows that have been installed during the current
> > dump as duplicates, rather than recognising them as new flows. This
> > patch se
Thanks, applied to master.
On 30 September 2014 08:57, Ben Pfaff wrote:
> On Fri, Sep 26, 2014 at 09:28:12PM +1200, Joe Stringer wrote:
> > This just makes it a bit easier for someone coming in fresh to do some
> > searches and figure out what the description means.
> >
> > Signed-off-by: Joe St
This patch mostly is related to tunnel API where RHEL 7
kernel API are not in-sync with newer linux kernel API. So
extra checks are required to check for parameters of API.
Signed-off-by: Pravin B Shelar
---
acinclude.m4 |7 +++
datapath/datapath.c
75 matches
Mail list logo
