Great, thanks for the clarification. Applied to master.
On Tue, Sep 30, 2014 at 09:44:46AM +1300, Joe Stringer wrote: > Ah, I thought that you may have proposed/pushed the --enable-silent-rules > for travis build on master, rather than just using travis to test that this > patch works as intended. Misunderstanding on my part, so never mind. > > On 30 September 2014 09:37, Ben Pfaff <b...@nicira.com> wrote: > > > Thanks for looking this over. > > > > I don't understand the suggestion. Can you explain further? > > > > One factor: I don't think automated builds should use > > --enable-silent-rules, because for automated builds one wants as much > > information as possible on failure. I do want it for my local > > developer builds, where if something fails in a way I don't understand > > I can just rerun with V=1. > > > > On Tue, Sep 30, 2014 at 09:30:23AM +1300, Joe Stringer wrote: > > > From the linked travis build, it seems like there's still a bit of > > > verbosity on the testsuite builds, because they do a 'make distcheck' > > after > > > the standard configure and make. Could we just run make distcheck in > > those > > > cases, and make sure it gets run with the silent flags? > > > > > > Acked-by: Joe Stringer <joestrin...@nicira.com> > > > > > > On 27 September 2014 06:02, Ben Pfaff <b...@nicira.com> wrote: > > > > > > > On Wed, Sep 03, 2014 at 10:28:39AM -0700, Ben Pfaff wrote: > > > > > The Open vSwitch "make" output was still pretty verbose even when > > > > > configured with --enable-silent-rules. This cleans it up. > > > > > > > > > > Signed-off-by: Ben Pfaff <b...@nicira.com> > > > > > --- > > > > > I tested that this yields good output with the following travis > > build: > > > > > https://travis-ci.org/openvswitch/ovs/builds/34310033 > > > > > Have I mentioned that travis is awesome? > > > > > > > > I'd appreciate it if someone would take a look at this. > > > > > > > > Thanks, > > > > > > > > Ben. > > > > _______________________________________________ > > > > dev mailing list > > > > dev@openvswitch.org > > > > http://openvswitch.org/mailman/listinfo/dev > > > > > > _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
