[ovs-dev] (no subject)

2014-07-11 Thread melanies
The message was undeliverable due to the following reason: Your message could not be delivered because the destination server was unreachable within the allowed queue period. The amount of time a message is queued before it is returned depends on local configura- tion parameters. Most likely ther

Re: [ovs-dev] [RFC 2/2] datapath: Cache netlink flow key, mask on flow_put.

2014-07-11 Thread Thomas Graf
On 07/11/14 at 11:22am, Joe Stringer wrote: > Thanks for the review, > > On 10 July 2014 21:13, Thomas Graf wrote: > > > If I understand the code correctly the gain is only visible on > > consecutive dumps of the same flow. How about constructing the cache > > when you require it for the first t

Re: [ovs-dev] [PATCH] datapath/flow_netlink: Fix NDP flow mask validation

2014-07-11 Thread Thomas Graf
On 07/10/14 at 09:32am, Daniele Di Proietto wrote: > This cannot set tp.src to htons(0x), because icmpv6_key->icmpv6_type is > __u8. > > The bug has always been there, since a1c564be (datapath: Mega flow > implementation). > > datapath/flow.c:201 > > if (match->mask && (match->mask->

[ovs-dev] [PATCH 2/3][RFC] Factor the ovsdb-server main loop into a new function

2014-07-11 Thread Eric Sesterhenn
commit b5431b8dcc8e02c335c388afaee4b606d3253204 Author: Eric Sesterhenn Date: Fri Jul 11 03:54:48 2014 -0500 Factor the ovsdb-server main loop into a new function This refactors the ovsdb-server main loop into a new function, which allows to call it from multiple places. Signe

[ovs-dev] [PATCH 0/3][RFC] Implement a chroot for ovsdb-server

2014-07-11 Thread Eric Sesterhenn
Hi, on my debian installation, the ovsdb-server is running as root. Since I prefer to add additional mitigations for running services, I was looking into putting the ovsdb-server into a chroot and implemented it in the following three patches. These patches are send as a request for comments, sin

[ovs-dev] [PATCH 1/3][RFC] Allow to open the urandom file descriptor in advance

2014-07-11 Thread Eric Sesterhenn
commit 70f2616745100c12004309e794a85bae95764845 Author: Eric Sesterhenn Date: Fri Jul 11 03:53:40 2014 -0500 Allow to open the urandom file descriptor in advance This is just an RFC at the moment, since it leaks one file descriptor per process. Signed-off-by: Eric Sesterhenn

[ovs-dev] [PATCH 3/3][RFC] Implement chrooting for ovsdb-server

2014-07-11 Thread Eric Sesterhenn
commit 9848adf57ce712c941dd41a6bf74a09d4b7e3555 Author: Eric Sesterhenn Date: Fri Jul 11 03:56:08 2014 -0500 Implement chrooting for ovsdb-server This adds the command line options --chroot-dir and --chroot-user to ovsdb-server, which allows to put the process into a chroot.

Re: [ovs-dev] [RFC 2/2] datapath: Cache netlink flow key, mask on flow_put.

2014-07-11 Thread Joe Stringer
On 11 July 2014 21:03, Thomas Graf wrote: > > Correct. My main concern with doing it the first time it is required, is > > how it's synchronised. Flow dump is RCU. I don't really know what the > > threadsafety requirements are for this code, or what options are > available > > to address this. Is

Re: [ovs-dev] [PATCH v3 7/7] lib/classifier: Lockless lookups.

2014-07-11 Thread Jarno Rajahalme
Series pushed to master, thanks for the reviews! On Jul 7, 2014, at 6:42 PM, YAMAMOTO Takashi wrote: > comments in ofproto-provider.h need an update. Done, thanks! > otherwise, looks good to me. > > how about unifying classifier and cls_classifier? > Good point. Earlier I had assumed I ne

[ovs-dev] [PATCH 4/4] lib/classifier: Clarify subtable skipping.

2014-07-11 Thread Jarno Rajahalme
Clarify comments for trie-based subtable skipping. Perform the cheaper check first. Signed-off-by: Jarno Rajahalme --- lib/classifier.c | 26 -- 1 file changed, 12 insertions(+), 14 deletions(-) diff --git a/lib/classifier.c b/lib/classifier.c index cd4de54..9a7b9fd 1

[ovs-dev] [PATCH 1/4] lib/classifier: Unify struct classifier and cls_classifier.

2014-07-11 Thread Jarno Rajahalme
Now that it is clear that struct cls_classifier itself does not need RCU indirection and pvector is defined in its own header, it is possible get rid of the indirection from struct classifier to struct cls_classifier. Suggested-by: YAMAMOTO Takashi Signed-off-by: Jarno Rajahalme --- lib/classif

[ovs-dev] [PATCH 2/4] lib/classifier: Change a variable name.

2014-07-11 Thread Jarno Rajahalme
This stylistic change makes the following patch a bit simpler. Signed-off-by: Jarno Rajahalme --- lib/classifier.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/lib/classifier.c b/lib/classifier.c index 723749a..d400180 100644 --- a/lib/classifier.c +++

[ovs-dev] [PATCH 3/4] lib/classifier: Return all matching prefix lengths from trie lookup.

2014-07-11 Thread Jarno Rajahalme
Previously we only returned the last matching prefix length encountered during a trie lookup, and skipped subtables that had prefixes longer than that. This patch changes the trie lookup functions to return all matching prefix lengths seen, so that all non-matching prefix lengths can be skipped.

Re: [ovs-dev] [RFC 2/2] datapath: Cache netlink flow key, mask on flow_put.

2014-07-11 Thread Flavio Leitner
On Fri, Jul 11, 2014 at 11:27:09AM +1200, Joe Stringer wrote: > On 11 July 2014 04:53, Flavio Leitner wrote: > > > Can we push the cache construction to later that it doesn't impact > > either flow setup or flow dump? I.e. like a workqueue? I don't know > > if we have such facility. > > > I'm o

[ovs-dev] [PATCH v2 1/1] netdev-dpdk: add dpdk rings to netdev-dpdk

2014-07-11 Thread maryam.tahhan
Shared memory ring patch This patch enables the client dpdk rings within the netdev-dpdk. It adds a new dpdk device called dpdkr (other naming suggestions?). This allows for the use of shared memory to communicate with other dpdk applications, on the host or within a virtual machine. Instructio

Re: [ovs-dev] [RFC 2/2] datapath: Cache netlink flow key, mask on flow_put.

2014-07-11 Thread Thomas Graf
On 07/11/14 at 11:29pm, Joe Stringer wrote: > I'm skeptical of taking the ovs_lock(). The current patch performs this > key/mask cache construction inside ovs_lock() as part of the critical > section for flow install. If we perform this during flow_dump, but extend > the ovs_lock to the entire flow

Re: [ovs-dev] [PATCH v2] lib/hash: Use CRC32 for hashing.

2014-07-11 Thread Jarno Rajahalme
Thanks for the review, pushed to master, Jarno On Jul 7, 2014, at 3:28 PM, Ben Pfaff wrote: > On Mon, Jul 07, 2014 at 01:16:59PM -0700, Jarno Rajahalme wrote: >> Use CRC32 intrinsics for hash computations when building for >> X86_64 with SSE4_2. >> >> Add a new hash_words64() and change hash

Re: [ovs-dev] [RFC 2/2] datapath: Cache netlink flow key, mask on flow_put.

2014-07-11 Thread Thomas Graf
On 07/11/14 at 09:28am, Flavio Leitner wrote: > On Fri, Jul 11, 2014 at 11:27:09AM +1200, Joe Stringer wrote: > > On 11 July 2014 04:53, Flavio Leitner wrote: > > > > > Can we push the cache construction to later that it doesn't impact > > > either flow setup or flow dump? I.e. like a workqueue?

[ovs-dev] Bug#754482: openvswitch: run dh-autoreconf to update config.{sub, guess} and {libtool, aclocal}.m4

2014-07-11 Thread Breno Leitao
Source: openvswitch Version: 2.1.0+git20140411 Severity: normal Tags: patch User: debian-powe...@lists.debian.org Usertags: ppc64el User: debian-de...@lists.debian.org Usertags: autoreconf Dear Maintainer, Currently this package FTBFS when compiled in new architectures (as ppc64el) that is not su

Re: [ovs-dev] [RFC v2] datapath/flow_netlink: Create right mask with disabled megaflows

2014-07-11 Thread Daniele Di Proietto
On Jul 10, 2014, at 6:59 PM, Joe Stringer wrote: > On 11 July 2014 11:29, Daniele Di Proietto wrote: > -static void sw_flow_mask_set(struct sw_flow_mask *mask, > -struct sw_flow_key_range *range, u8 val) > +/* We expect the nlattr stream to be already validated */ >

Re: [ovs-dev] [RFC v2] datapath/flow_netlink: Create right mask with disabled megaflows

2014-07-11 Thread Daniele Di Proietto
On Jul 10, 2014, at 5:27 PM, Pravin Shelar wrote: > On Thu, Jul 10, 2014 at 4:29 PM, Daniele Di Proietto > wrote: >> If megaflows are disabled, the userspace does not send the netlink attribute >> OVS_FLOW_ATTR_MASK, and the kernel must create an exact match mask. >> >> sw_flow_mask_set() sets

Re: [ovs-dev] [PATCH v2] datapath: Enable tunnel GSO features.

2014-07-11 Thread Pravin Shelar
On Thu, Jul 10, 2014 at 5:05 PM, Andy Zhou wrote: > The logic looks good. Patchcheck returns some warnings that may be > nice to fix up. > Otherwise, Acked-by: Andy Zhou > > > WARNING: LINUX_VERSION_CODE should be avoided, code should be for the > version to which it is merged > #29: FILE: data

[ovs-dev] [RFC v3] datapath/flow_netlink: Create right mask with disabled megaflows

2014-07-11 Thread Daniele Di Proietto
If megaflows are disabled, the userspace does not send the netlink attribute OVS_FLOW_ATTR_MASK, and the kernel must create an exact match mask. sw_flow_mask_set() sets every bytes (in 'range') of the mask to 0xff, even the bytes that represent padding for struct sw_flow, or the bytes that represe

Re: [ovs-dev] [RFC v2] datapath/flow_netlink: Create right mask with disabled megaflows

2014-07-11 Thread Pravin Shelar
On Fri, Jul 11, 2014 at 9:32 AM, Daniele Di Proietto wrote: > > On Jul 10, 2014, at 5:27 PM, Pravin Shelar wrote: > >> On Thu, Jul 10, 2014 at 4:29 PM, Daniele Di Proietto >> wrote: >>> If megaflows are disabled, the userspace does not send the netlink attribute >>> OVS_FLOW_ATTR_MASK, and the k

Re: [ovs-dev] [RFC v3] datapath/flow_netlink: Create right mask with disabled megaflows

2014-07-11 Thread Pravin Shelar
On Fri, Jul 11, 2014 at 10:01 AM, Daniele Di Proietto wrote: > If megaflows are disabled, the userspace does not send the netlink attribute > OVS_FLOW_ATTR_MASK, and the kernel must create an exact match mask. > > sw_flow_mask_set() sets every bytes (in 'range') of the mask to 0xff, even the > byt

Re: [ovs-dev] [RFC v3] datapath/flow_netlink: Create right mask with disabled megaflows

2014-07-11 Thread Daniele Di Proietto
Thanks, Daniele On Jul 11, 2014, at 10:25 AM, Pravin Shelar wrote: > On Fri, Jul 11, 2014 at 10:01 AM, Daniele Di Proietto > wrote: >> If megaflows are disabled, the userspace does not send the netlink attribute >> OVS_FLOW_ATTR_MASK, and the kernel must create an exact match mask. >> >> sw_f

Re: [ovs-dev] [PATCH] tests: Disable glibc memory checking under glibc <= 2.11.

2014-07-11 Thread Ben Pfaff
On Thu, Jul 10, 2014 at 03:39:53PM -0700, Gurucharan Shetty wrote: > On Thu, Jul 10, 2014 at 2:37 PM, Ben Pfaff wrote: > > On Thu, Jul 10, 2014 at 02:32:56PM -0700, Gurucharan Shetty wrote: > >> On Wed, Jul 9, 2014 at 3:45 PM, Ben Pfaff wrote: > >> > We noticed that the unit tests sometimes fail

Re: [ovs-dev] LAG support in OVS

2014-07-11 Thread Ben Pfaff
Bonds, also known as "teams" or "link aggregation groups" (LAGS), have the following significant aspects to their behavior: - Egress, that is, treatment of packets transmitted through the bond. The choice of a bond interface is the main question on egress. Bonds can drop packets

[ovs-dev] Windows installer for Open vSwitch.

2014-07-11 Thread Gurucharan Shetty
Hello Alin, Alessandro, I see that you guys at Cloudbase have created an installer for Open vSwitch. Is it something you created as an one time effort? Or is it a script and one can create a new installer by running a simple command for any code commit? In the OVS repo, we currently have the infr

[ovs-dev] [RFC] datapath/flow_netlink: Avoid wildcarding tunnel key with disabled megaflows

2014-07-11 Thread Daniele Di Proietto
If the userspace wants to match on a flow with tun_key.{tun_id, tun_flags, ipv4_tos} set to 0 it simply omits them in the netlink attributes stream. Since our wildcarding logic (when megaflows are disabled) is based on the attributes in the netlink stream, we set our mask incorrectly. This commit

Re: [ovs-dev] [PATCH 01/14] Add to changes lib/netlink.h

2014-07-11 Thread Ben Pfaff
On Fri, Jul 11, 2014 at 12:59:55AM +, Alin Serdean wrote: > > Add NETLINK defines for MSVC compiling > > Signed-off-by: Alin Gabriel Serdean > --- > lib/netlink.h | 32 > 1 file changed, 32 insertions(+) > > diff --git a/lib/netlink.h b/lib/netlink.h > inde

Re: [ovs-dev] [PATCH 02/14] Changes to lib/automake.mk

2014-07-11 Thread Ben Pfaff
On Fri, Jul 11, 2014 at 01:00:42AM +, Alin Serdean wrote: > > Add the NETLINK and DPIF objects to the openvswitch archive for windows. > > Signed-off-by: Alin Gabriel Serdean A commit should not break the build, even if a later commit fixes it. Do these compile on Windows as-is? If not, it

Re: [ovs-dev] [PATCH 03/14] Ignore epoll specific functions in case of MSVC

2014-07-11 Thread Ben Pfaff
On Fri, Jul 11, 2014 at 01:01:26AM +, Alin Serdean wrote: > Bypass epoll_ctl, epoll_create and epoll_wait functions on MSVC. > > Signed-off-by: Alin Gabriel Serdean What's the substitute for these on Windows? Maybe it was supposed to be in this hunk, which appears incomplete and wrong: > +#

Re: [ovs-dev] [PATCH 04/14] Initialize dpif_linux_class for MSVC as well

2014-07-11 Thread Ben Pfaff
On Fri, Jul 11, 2014 at 01:02:35AM +, Alin Serdean wrote: > Do not bypass dpif_linux_class for the creation of dpif_class when compiling > with MSVC. This will allow the code behind dpif-linux interface to run. > > Signed-off-by: Alin Gabriel Serdean Fair enough.

Re: [ovs-dev] [PATCH 06/14] Remove netlink padding for MSVC

2014-07-11 Thread Ben Pfaff
On Fri, Jul 11, 2014 at 01:03:56AM +, Alin Serdean wrote: > > Change the defines NLMSG_ALIGNTO and NLA_ALIGNTO defines to 0. > > Change the macros NLA_ALIGN and NLMSG_ALIGN to SIZE. > > Signed-off-by: Alin Gabriel Serdean Why? ___ dev mailing lis

Re: [ovs-dev] [PATCH 07/14] Initialize vlandev_linux_class for MSVC as well

2014-07-11 Thread Ben Pfaff
On Fri, Jul 11, 2014 at 01:04:32AM +, Alin Serdean wrote: > Change the vlandev_get_class to vlandev_linux_class instead of > vlandev_stub_class when compiling with MSVC. > > This will allow the code behind dpifnetdev-linuxlinux interface to run. > > Signed-off-by: Alin Gabriel Serdean Did y

Re: [ovs-dev] [PATCH 08/14] Ignore aligned cast and drains on MSVC

2014-07-11 Thread Ben Pfaff
On Fri, Jul 11, 2014 at 01:05:03AM +, Alin Serdean wrote: > Bypass ALIGNED_CAST on CMSG_DATA when compiling on MSVC. Ignore the code > behind netdev_linux_rxq_drain as well. > > Signed-off-by: Alin Gabriel Serdean > --- > lib/netdev-linux.c | 4 > 1 file changed, 4 insertions(+) > > di

Re: [ovs-dev] [PATCH 10/14] Ignore padding when compiling with MSVC

2014-07-11 Thread Ben Pfaff
On Fri, Jul 11, 2014 at 01:06:10AM +, Alin Serdean wrote: > Change the size of the padding to 0 in the function nl_msg_put_uninit. > > Signed-off-by: Alin Gabriel Serdean If it makes sense not to pad Netlink on Windows (I don't know why, yet), then I would squash this into the earlier patch

Re: [ovs-dev] [PATCH v2] Extend OVS IPFIX exporter to export tunnel headers

2014-07-11 Thread Pravin Shelar
On Sun, Jun 29, 2014 at 8:41 PM, Wenyu Zhang wrote: > Extend IPFIX exporter to export tunnel headers when both input and output > of the port. > Add three other_config options in IPFIX table: enable-input-sampling, > enable-output-sampling and enable-tunnel-sampling, to control whether > sampling

[ovs-dev] [PATCH] Fix documentation error that led user to wrong file to install dependency packages.

2014-07-11 Thread Kirkland Spector
Signed-off-by: Andrey Falko --- INSTALL.Debian | 15 --- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/INSTALL.Debian b/INSTALL.Debian index 68c12ac..34251a1 100644 --- a/INSTALL.Debian +++ b/INSTALL.Debian @@ -34,20 +34,21 @@ You do not need to be the superuser to b

Re: [ovs-dev] [RFC] datapath/flow_netlink: Avoid wildcarding tunnel key with disabled megaflows

2014-07-11 Thread Andy Zhou
On Fri, Jul 11, 2014 at 3:05 PM, Daniele Di Proietto wrote: > If the userspace wants to match on a flow with tun_key.{tun_id, tun_flags, > ipv4_tos} set to 0 it simply omits them in the netlink attributes stream. > Since our wildcarding logic (when megaflows are disabled) is based on the > attribu

Re: [ovs-dev] [RFC 2/2] datapath: Cache netlink flow key, mask on flow_put.

2014-07-11 Thread Joe Stringer
On 12 July 2014 00:55, Thomas Graf wrote: > > Another sidenote: > > > Looking at the code, OVS does not handle NLM_F_DUMP_INTR in user space > yet > > > and the kernel dump does not call genl_dump_check_consistent() yet to > > > provide > > > the flag. So what can currently happen even without y

Re: [ovs-dev] [PATCH v2] Extend OVS IPFIX exporter to export tunnel headers

2014-07-11 Thread Romain Lenglet
On 7/11/14, 3:53 PM, "Pravin Shelar" wrote: >On Sun, Jun 29, 2014 at 8:41 PM, Wenyu Zhang wrote: >> Extend IPFIX exporter to export tunnel headers when both input and >>output >> of the port. >> Add three other_config options in IPFIX table: enable-input-sampling, >> enable-output-sampling and

Re: [ovs-dev] [RFC 2/2] datapath: Cache netlink flow key, mask on flow_put.

2014-07-11 Thread Joe Stringer
On 12 July 2014 01:03, Thomas Graf wrote: > On 07/11/14 at 09:28am, Flavio Leitner wrote: > > On Fri, Jul 11, 2014 at 11:27:09AM +1200, Joe Stringer wrote: > > > On 11 July 2014 04:53, Flavio Leitner wrote: > > > > > > > Can we push the cache construction to later that it doesn't impact > > > >

Re: [ovs-dev] [PATCH v2] Extend OVS IPFIX exporter to export tunnel headers

2014-07-11 Thread Pravin Shelar
On Fri, Jul 11, 2014 at 4:31 PM, Romain Lenglet wrote: > On 7/11/14, 3:53 PM, "Pravin Shelar" wrote: > > >>On Sun, Jun 29, 2014 at 8:41 PM, Wenyu Zhang wrote: >>> Extend IPFIX exporter to export tunnel headers when both input and >>>output >>> of the port. >>> Add three other_config options in I

Re: [ovs-dev] [PATCH 11/14] Changes needed for netlink-socket.c

2014-07-11 Thread Ben Pfaff
On Fri, Jul 11, 2014 at 01:06:50AM +, Alin Serdean wrote: > Adding CreateFile, WriteFile, ReadFile and CloseHandle instead of linux > counterparts when compiling netlink-socket.c with MSVC. Also add socket pid > generation function that will later on will be needed in the kernel > extension. >

[ovs-dev] Returned mail: see transcript for details

2014-07-11 Thread Automatic Email Delivery Software
The original message was received at Sat, 12 Jul 2014 10:15:25 +0530 from openvswitch.org [35.104.71.34] - The following addresses had permanent fatal errors - ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/