On Sun, Jun 29, 2014 at 8:41 PM, Wenyu Zhang <wen...@vmware.com> wrote: > Extend IPFIX exporter to export tunnel headers when both input and output > of the port. > Add three other_config options in IPFIX table: enable-input-sampling, > enable-output-sampling and enable-tunnel-sampling, to control whether > sampling tunnel info, on which direction (input or output). > Insert sampling action before output action and the output tunnel port > is sent to datapath in the sampling action. > Make datapath collect output tunnel info and send it back to userpace > in upcall message with a new additional optional attribute. > Add a tunnel ports map to make the tunnel port lookup faster in sampling > upcalls in IPFIX exporter. Make the IPFIX exporter generate IPFIX template > sets with enterprise elements for the tunnel info, save the tunnel info > in IPFIX cache entries, and send IPFIX DATA with tunnel info. > Add flowDirection element in IPFIX templates. > > Signed-off-by: Wenyu Zhang <wen...@vmware.com> > Acked-by: Romain Lenglet <rleng...@vmware.com> > ---
I have not reviewed patch completely but I have high level comment about extra route lookup done for sampled packets. I think we can avoid it if we delay upcall and do it in vport->send() when we have all the data. Sample action can just flag the skb for sampling and let vport->send to actually do it. This is also more accurate because it is using same route that tunnel send would use compared to get_out_tun_key() which can use older skb->mark for route lookup. Also we can also avoid code duplication done for get_out_tun_key(). _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
