On Mon, May 19, 2014 at 11:14 PM, Ben Pfaff wrote:
> On Fri, May 09, 2014 at 07:35:21PM +0300, Alexandru Copot wrote:
>> On Fri, May 9, 2014 at 6:42 PM, Ben Pfaff wrote:
>> > On Tue, May 06, 2014 at 09:28:29PM +0300, Alexandru Copot wrote:
>> >> Allow port_mod messages in a bundle and apply them
Signed-off-by: YAMAMOTO Takashi
---
lib/netdev-bsd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/netdev-bsd.c b/lib/netdev-bsd.c
index 8291182..8dc33df 100644
--- a/lib/netdev-bsd.c
+++ b/lib/netdev-bsd.c
@@ -247,7 +247,7 @@ cache_notifier_ref(void)
if (!cache_n
Signed-off-by: YAMAMOTO Takashi
---
ofproto/ofproto.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/ofproto/ofproto.c b/ofproto/ofproto.c
index 9b26da7..e728921 100644
--- a/ofproto/ofproto.c
+++ b/ofproto/ofproto.c
@@ -2147,7 +2147,7 @@ dealloc_ofp_port(struct ofproto *
Signed-off-by: YAMAMOTO Takashi
---
FAQ | 11 +++
1 file changed, 11 insertions(+)
diff --git a/FAQ b/FAQ
index 7ef7eb4..cac9fcb 100644
--- a/FAQ
+++ b/FAQ
@@ -1558,6 +1558,17 @@ A: These flows drop the ARP packets that IP hosts use to
establish IP
priority=5,in_port=1,dl_dst=01:
Signed-off-by: Simon Horman
---
tests/ofproto-dpif.at | 4
1 file changed, 4 deletions(-)
diff --git a/tests/ofproto-dpif.at b/tests/ofproto-dpif.at
index 59d3c1b..6b90346 100644
--- a/tests/ofproto-dpif.at
+++ b/tests/ofproto-dpif.at
@@ -4501,10 +4501,6 @@ AT_CLEANUP
AT_SETUP([ofproto-d
This is in preparation for using the same helper as part of support
for using recirculation in conjunction series of actions including
with MPLS actions that are currently not able to be translated.
In that scenario the idle timeout will be used to expire internal
rules that are added to handle re
With recirculation in place this should be safe.
Signed-off-by: Simon Horman
---
v2 - v5
* No change
---
lib/ofp-actions.c | 6 --
1 file changed, 6 deletions(-)
diff --git a/lib/ofp-actions.c b/lib/ofp-actions.c
index cc1f9a0..119677e 100644
--- a/lib/ofp-actions.c
+++ b/lib/ofp-actions.c
The motivation of this series is to allow some sequences of actions
that include MPLS actions to be performed using recirculation.
Sequences of actions that could not previously be handled.
For example pop_mpls:0x0800,dec_ttl.
This uses recirculation after the pop_mpls action to allow access to L
This is in preparation for using this value
in ofproto-dpif-xlate.c when composing recirculation
actions added as a result of processing (MPLS) actions.
Signed-off-by: Simon Horman
---
v3 - v5
* No change
v2
* First post
---
ofproto/bond.c | 1 -
ofproto/ofproto-dpif.h | 3 +++
2 files
In some cases an pop MPLS action changes a packet to be a non-mpls packet.
In this case subsequent any L3+ actions require access to portions
of the packet which were not decoded as they were opaque when the
packet was MPLS. Allow such actions to be translated by
first recirculating the packet.
Si
This is to allow a recirculation id to be associated with a rule
in the case that its actions cause recirculation.
In such a case if the recirc_id field is non-zero then that value should be
used, otherwise a value should be obtained using
ofproto_dpif_alloc_recirc_id and saved in recirc_id field.
The motivation for this is to create a 16bit hole in struct ovs_gso_cb
which may be used for the inner_protocol field which is needed
for the proposed implementation of compatibility for MPLS GSO segmentation.
This should be safe as inner_network_header is now an offset to
the inner_mac_header rat
On Mon, May 19, 2014 at 06:34:05PM -0700, Jesse Gross wrote:
> I have some miscellaneous comments on things that I noticed, all of
> which are pretty small. I will probably have a few more tomorrow but
> my hope is that we can get this in soon.
>
> On Thu, May 15, 2014 at 4:07 PM, Simon Horman wr
Hi,
I have compiled and installed openvswitch-2.1.2 source code on Fedora machine
version 3.11.10-301.fc20.x86_64. As I can see gre module is getting loaded but
I need vxlan module to be loaded which is not coming.
Please help me out.
Following is the command which I am using to display module
This avoids causing failed assert(), when netflow_flow_clear() and
netflow_expire() are called together.
Signed-off-by: Anoob Soman
---
AUTHORS | 2 +-
ofproto/netflow.c | 3 +--
ofproto/ofproto-dpif-upcall.c | 2 --
3 files changed, 2 insertions(+), 5 deletions
On 05/20/2014 12:49 AM, Ben Pfaff wrote:
On Thu, Apr 10, 2014 at 12:50:11PM +0200, Thomas Graf wrote:
a425a102-c317-4743-b0ba-79d59ff04a74
Bridge "br0"
[...]
Port test
Interface test
type: vxlan
options: {unknown="1"}
On 05/20/14 at 07:02am, Simon Horman wrote:
> [PATCH] datapath: 16bit inner_network_header field in struct ovs_gso_cb
>
> The motivation for this is to create a 16bit hole in struct ovs_gso_cb
> which may be used for the inner_protocol field which is needed
> for the proposed implementation of com
On Tue, May 20, 2014 at 10:29:11AM +0900, YAMAMOTO Takashi wrote:
> > On Mon, Mar 31, 2014 at 08:37:48AM -0700, Ben Pfaff wrote:
> >> When openvswitch stops before libvirt shuts down VMs, it makes it hard for
> >> libvirt to remove virtual network interfaces (ovs-vsctl cannot access the
> >> databa
On Tue, May 20, 2014 at 04:14:34PM +0900, YAMAMOTO Takashi wrote:
> Signed-off-by: YAMAMOTO Takashi
Acked-by: Ben Pfaff
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
On Tue, May 20, 2014 at 04:14:35PM +0900, YAMAMOTO Takashi wrote:
> Signed-off-by: YAMAMOTO Takashi
Acked-by: Ben Pfaff
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
On Tue, May 20, 2014 at 04:14:36PM +0900, YAMAMOTO Takashi wrote:
> Signed-off-by: YAMAMOTO Takashi
Good point.
Acked-by: Ben Pfaff
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
On Tue, May 20, 2014 at 07:24:35AM -0700, Ben Pfaff wrote:
> On Tue, May 20, 2014 at 10:29:11AM +0900, YAMAMOTO Takashi wrote:
> > > On Mon, Mar 31, 2014 at 08:37:48AM -0700, Ben Pfaff wrote:
> > >> When openvswitch stops before libvirt shuts down VMs, it makes it hard
> > >> for
> > >> libvirt to
On Tue, May 20, 2014 at 4:26 AM, Ajay Singh (HM0001261)
wrote:
> Hi,
>
>
>
> I have compiled and installed openvswitch-2.1.2 source code on Fedora
> machine version 3.11.10-301.fc20.x86_64. As I can see gre module is getting
> loaded but I need vxlan module to be loaded which is not coming.
OVS d
On Tue, May 20, 2014 at 08:21:10AM -0700, Jesse Gross wrote:
> On Tue, May 20, 2014 at 4:26 AM, Ajay Singh (HM0001261)
> wrote:
> > Hi,
> >
> >
> >
> > I have compiled and installed openvswitch-2.1.2 source code on Fedora
> > machine version 3.11.10-301.fc20.x86_64. As I can see gre module is gett
On Fri, May 16, 2014 at 04:38:02PM -0700, Jarno Rajahalme wrote:
> Acked-by: Jarno Rajahalme
Thanks.
> Some comments below, though,
Responses below.
(It would be easier to spot your comments if you trimmed more
carefully.)
> On May 8, 2014, at 4:50 PM, Ben Pfaff wrote:
> > +/* The implementa
Did you have any further comments on v2?
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
On Tue, May 20, 2014 at 09:12:23AM -0700, Ben Pfaff wrote:
> On Fri, May 16, 2014 at 04:38:02PM -0700, Jarno Rajahalme wrote:
> > > +if (b->nodes[slot] == node) {
> > > +cmap_set_bucket(b, slot, cmap_node_next_protected(node), hash);
> >
> > ?hash? is not changing here, so could just s
On Tue, May 20, 2014 at 09:12:23AM -0700, Ben Pfaff wrote:
> On Fri, May 16, 2014 at 04:38:02PM -0700, Jarno Rajahalme wrote:
> > > +static bool
> > > +cmap_insert_dup(struct cmap_node *new_node, uint32_t hash,
> > > +struct cmap_bucket *b)
> > > +{
> > > +int i;
> > > +
> > > +
Per Alex's request, I ran a 10K internal port creation test (using batches of
500 ports at a time via ovs-vsctl) on my 8GB memory machine. Again RCU was
slightly faster:
master: real 3m28.301s
with RCU: real 3m21.489s
Also, the reason I don't simply batch all creation of ports together via —
s
On Tue, May 20, 2014 at 11:04 AM, Ryan Wilson 76511 wrote:
> Per Alex's request, I ran a 10K internal port creation test (using batches
> of 500 ports at a time via ovs-vsctl) on my 8GB memory machine. Again RCU
> was slightly faster:
>
> master: real 3m28.301s
> with RCU: real 3m21.489s
OK, that
On Tue, May 20, 2014 at 12:40:35PM +0100, Anoob Soman wrote:
> This avoids causing failed assert(), when netflow_flow_clear() and
> netflow_expire() are called together.
>
> Signed-off-by: Anoob Soman
I broke out the fix to the spelling of your name in AUTHORS (my fault,
sorry!) and pushed that.
On Mon, May 19, 2014 at 04:10:04PM +1200, Joe Stringer wrote:
> This looks much tidier, I like it. Particularly given the elimination of 4
> goto statements :-). Comments inline.
>
>
> On 17 May 2014 11:28, Ben Pfaff wrote:
> >
> > + * Notes
> > + * -
> > + *
> > + * All error reporting is d
Sorry, I should have made it clear in the commit message. In our testing,
occasionally ovs_assert(!nf_flow->packet_count) would fail, with the following
backtrace
#0 0x7f7d263ad265 in raise () from /lib64/libc.so.6
#1 0x7f7d263aed10 in abort () from /lib64/libc.so.6
#2 0x004a
Ben,
Minor comments below,
Jarno
Acked-by: Jarno Rajahalme
On May 8, 2014, at 4:50 PM, Ben Pfaff wrote:
> Signed-off-by: Ben Pfaff
> ---
> lib/dpif-netdev.c | 163 +++--
> 1 file changed, 82 insertions(+), 81 deletions(-)
>
> diff --git a/l
On May 20, 2014, at 9:15 AM, Ben Pfaff wrote:
> Did you have any further comments on v2?
I ran out of time on Friday(?) and then forgot about this, sorry. I just sent
an Acked-by with minor comments.
Jarno
___
dev mailing list
dev@openvswitch.org
This package has a pretty narrow audience. I think that it's more likely that
someone will install it by mistake than by intention, and if one really needs
it, it's easy to enable it.
On Mon, May 19, 2014 at 3:14 PM, David Yang wrote:
> If someone were to install this package, we'd expect that t
On Tue, May 13, 2014 at 03:45:49PM +1200, Joe Stringer wrote:
> Shift datapath flow test macros and "ofproto-dpif - dummy interface" out
> into a separate file.
>
> Signed-off-by: Joe Stringer
Acked-by: Ben Pfaff
___
dev mailing list
dev@openvswitch.o
On Tue, May 13, 2014 at 03:45:48PM +1200, Joe Stringer wrote:
> Signed-off-by: Joe Stringer
Acked-by: Ben Pfaff
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
On May 20, 2014, at 10:08 AM, Ben Pfaff wrote:
> On Tue, May 20, 2014 at 09:12:23AM -0700, Ben Pfaff wrote:
>> On Fri, May 16, 2014 at 04:38:02PM -0700, Jarno Rajahalme wrote:
+static bool
+cmap_insert_dup(struct cmap_node *new_node, uint32_t hash,
+struct cmap_buc
On Tue, May 20, 2014 at 3:41 AM, Simon Horman wrote:
> diff --git a/datapath/linux/compat/gso.h b/datapath/linux/compat/gso.h
> index b83a4c3..f459c18 100644
> --- a/datapath/linux/compat/gso.h
> +++ b/datapath/linux/compat/gso.h
> #ifdef NET_SKBUFF_DATA_USES_OFFSET
> -#define skb_inner_network_h
On Tue, May 13, 2014 at 03:45:50PM +1200, Joe Stringer wrote:
> Ensure that upcall key matches flow install and flow_dump for userspace
> datapath. This was previously assumed, but not tested. This makes the
> assumption more explicit.
>
> Signed-off-by: Joe Stringer
-A isn't a standard "grep" f
On Tue, May 20, 2014 at 12:40:20PM -0700, Jarno Rajahalme wrote:
>
> On May 20, 2014, at 10:08 AM, Ben Pfaff wrote:
>
> > On Tue, May 20, 2014 at 09:12:23AM -0700, Ben Pfaff wrote:
> >> On Fri, May 16, 2014 at 04:38:02PM -0700, Jarno Rajahalme wrote:
> +static bool
> +cmap_insert_dup(s
On Tue, May 20, 2014 at 12:25:50PM -0700, Jarno Rajahalme wrote:
> Acked-by: Jarno Rajahalme
Thanks.
> > @@ -733,7 +731,7 @@ do_add_port(struct dp_netdev *dp, const char *devname,
> > const char *type,
> > }
> > ovs_refcount_init(&port->ref_cnt);
> >
> > -hmap_insert(&dp->ports, &p
On May 20, 2014, at 9:48 AM, Ben Pfaff wrote:
> On Tue, May 20, 2014 at 09:12:23AM -0700, Ben Pfaff wrote:
>> On Fri, May 16, 2014 at 04:38:02PM -0700, Jarno Rajahalme wrote:
+if (b->nodes[slot] == node) {
+cmap_set_bucket(b, slot, cmap_node_next_protected(node), hash);
>>>
On May 20, 2014, at 1:03 PM, Ben Pfaff wrote:
> On Tue, May 20, 2014 at 12:40:20PM -0700, Jarno Rajahalme wrote:
>>
>> On May 20, 2014, at 10:08 AM, Ben Pfaff wrote:
>>
>>> On Tue, May 20, 2014 at 09:12:23AM -0700, Ben Pfaff wrote:
On Fri, May 16, 2014 at 04:38:02PM -0700, Jarno Rajahalm
On Tue, May 20, 2014 at 01:22:45PM -0700, Jarno Rajahalme wrote:
>
> On May 20, 2014, at 9:48 AM, Ben Pfaff wrote:
>
> > On Tue, May 20, 2014 at 09:12:23AM -0700, Ben Pfaff wrote:
> >> On Fri, May 16, 2014 at 04:38:02PM -0700, Jarno Rajahalme wrote:
> +if (b->nodes[slot] == node) {
> >>
On May 20, 2014, at 2:03 PM, Ben Pfaff wrote:
> On Tue, May 20, 2014 at 01:22:45PM -0700, Jarno Rajahalme wrote:
>>
>> On May 20, 2014, at 9:48 AM, Ben Pfaff wrote:
>>
>>> On Tue, May 20, 2014 at 09:12:23AM -0700, Ben Pfaff wrote:
On Fri, May 16, 2014 at 04:38:02PM -0700, Jarno Rajahalme
At a high level, ofgroup struct current has rwlock that essentially solving
the same problem as the ref count proposed in this patch. It would be better
it seems confusing if we use both method together.
Looking at the code, I'd think extending rwlock to cover xlate
fastpath is the most
straight
Since the removal of dispatcher thread, OVS creates 'n-handler-threads'
file descriptors for each bridge port. To allow more bridge ports
be supported, this commit raises the limit on the number of open file
descriptors from 7500 to 65535.
Bug #1254038.
Signed-off-by: Alex Wang
---
utilities/o
On Mon, May 19, 2014 at 6:20 AM, Ryan Wilson wrote:
> Signed-off-by: Ryan Wilson
>
> ---
> v2: Fixed bug with group stats all buckets, cleaned up ofgroup unref code,
> added Andy Zhou's test for more complete test coverage
> v3: Split group ref/unref, support for group and bucket stats, and A
On Fri, Apr 11, 2014 at 06:34:09PM -0300, Flavio Leitner wrote:
> This patch adds generic IPv4 library code to deal with
> igmp snooping that is implemented in follow-up patches.
>
> Signed-off-by: Cong Wang
> Signed-off-by: Daniel Borkmann
> Acked-by: Thomas Graf
> Signed-off-by: Flavio Leitne
Ah, sorry I should have replied to this series; Andy looked through a
separate posting of them and I applied them.
I'll prepare a patch to remove the "-A" from the grepping in these tests.
On 21 May 2014 07:56, Ben Pfaff wrote:
> On Tue, May 13, 2014 at 03:45:50PM +1200, Joe Stringer wrote:
>
On 21 May 2014 06:40, Ben Pfaff wrote:
>
> > I'm not sure whether you would want it in this in a separate patch, but
> it
> > appears that we only try to detect "already_dumped" for flows that
> haven't
> > been used before. Flows which have been used before and are duplicated
> will
> > execute
Hey Andy,
>At a high level, ofgroup struct current has rwlock that essentially
>solving
>the same problem as the ref count proposed in this patch. It would be
>better
>it seems confusing if we use both method together.
>
>Looking at the code, I'd think extending rwlock to cover xlate
>fastpath is
On Fri, Apr 11, 2014 at 06:34:10PM -0300, Flavio Leitner wrote:
> Signed-off-by: Flavio Leitner
I don't much like the #defines for igmp_type and igmp_code. We used
to do something like that for icmp_type and icmp_code, but in the end
it caused confusion, which is why we stopped. I would rather
On Fri, Apr 11, 2014 at 06:34:11PM -0300, Flavio Leitner wrote:
> This patch adds IGMP support to flow_compose and
> flow_extract.
>
> Acked-by: Daniel Borkmann
> Acked-by: Thomas Graf
> Signed-off-by: Flavio Leitner
Seems reasonable. Could be squashed with the previous patch.
___
On Fri, Apr 11, 2014 at 06:34:12PM -0300, Flavio Leitner wrote:
> Add a switch to enable or disable multicast snooping on
> the bridge. This feature is disabled by default.
>
> Acked-by: Thomas Graf
> Acked-by: Daniel Borkmann
> Signed-off-by: Flavio Leitner
Is it at all likely that we'll want
On Fri, Apr 11, 2014 at 06:34:16PM -0300, Flavio Leitner wrote:
> It follows mac learning, but since the multicast snooping
> feature can be disabled, the locking is handled in the
> library.
>
> Signed-off-by: Flavio Leitner
Looks good, thanks.
___
de
On Fri, Apr 11, 2014 at 06:34:17PM -0300, Flavio Leitner wrote:
> This patch adds the command 'ovs-appctl mdb/show bridge'
> to show learned groups on a bridge from the multicast
> snooping database.
>
> It also adds the command 'ovs-appctl mdb/flush [bridge]'
> to flush learned groups on a bridge
On Tue, May 20, 2014 at 02:38:08PM -0700, Ben Pfaff wrote:
> On Fri, Apr 11, 2014 at 06:34:09PM -0300, Flavio Leitner wrote:
> > This patch adds generic IPv4 library code to deal with
> > igmp snooping that is implemented in follow-up patches.
> >
> > Signed-off-by: Cong Wang
> > Signed-off-by: D
On 21 May 2014 10:05, Ryan Wilson 76511 wrote:
> Hey Andy,
>
> >At a high level, ofgroup struct current has rwlock that essentially
> >solving
> >the same problem as the ref count proposed in this patch. It would be
> >better
> >it seems confusing if we use both method together.
> >
> >Looking a
On Fri, Apr 11, 2014 at 06:34:18PM -0300, Flavio Leitner wrote:
> Acked-by: Thomas Graf
> Signed-off-by: Flavio Leitner
I think that the 'enabled' member of struct
ofproto_mcast_snooping_settings is unnecessary, because if snooping is
not to be enabled then a null pointer seems to be used instea
On Tue, May 20, 2014 at 07:26:31PM -0300, Flavio Leitner wrote:
> On Tue, May 20, 2014 at 02:38:08PM -0700, Ben Pfaff wrote:
> > On Fri, Apr 11, 2014 at 06:34:09PM -0300, Flavio Leitner wrote:
> > > This patch adds generic IPv4 library code to deal with
> > > igmp snooping that is implemented in fo
On Fri, Apr 11, 2014 at 06:34:19PM -0300, Flavio Leitner wrote:
> This patch adds the functions needed for multicast snooping
> in order to send the packets to the correct ports.
>
> They are marked as OVS_UNUSED for now.
>
> Acked-by: Thomas Graf
> Signed-off-by: Flavio Leitner
I think these
When adding support for Openflow group and bucket stats, a group entry is added
to the xlate cache. If the group is removed from ofproto configuration, we need
to guarantee the group exists in the case where stats are attributed to the
group by a handler thread and the xlate cache has not yet been
On Fri, Apr 11, 2014 at 06:34:20PM -0300, Flavio Leitner wrote:
> This patch adds the functions needed to update the multicast
> snooping database based on the Report/Leave/Query received.
>
> They are marked with OVS_UNUSED for now.
>
> Signed-off-by: Flavio Leitner
The body of the switch stat
On Tue, May 20, 2014 at 03:53:26PM -0700, Ben Pfaff wrote:
> On Fri, Apr 11, 2014 at 06:34:20PM -0300, Flavio Leitner wrote:
> > This patch adds the functions needed to update the multicast
> > snooping database based on the Report/Leave/Query received.
> >
> > They are marked with OVS_UNUSED for
Thanks for the review, Joe! I added a more clear description in 'struct
ofgroup' and the commit message to explain why the refcount is needed.
And Andy, none of my functions in the group patch need group->rw_lock since
they simply ref / unref group. There are functions in ofproto.c that seem to
On Tue, May 20, 2014 at 03:53:26PM -0700, Ben Pfaff wrote:
> I suspect that unconditionally taking the write-lock in
> update_mcast_snooping_table() is going to serialize flow translation,
> in practice. That's why update_learning_table() checks whether any
> change is needed under the read-lock f
On Tue, May 20, 2014 at 02:24:53PM -0700, Alex Wang wrote:
> Since the removal of dispatcher thread, OVS creates 'n-handler-threads'
> file descriptors for each bridge port. To allow more bridge ports
> be supported, this commit raises the limit on the number of open file
> descriptors from 7500 t
On Wed, May 21, 2014 at 09:43:22AM +1200, Joe Stringer wrote:
> Ah, sorry I should have replied to this series; Andy looked through a
> separate posting of them and I applied them.
>
> I'll prepare a patch to remove the "-A" from the grepping in these tests.
Oh.
In that case let's just leave it
On 21 May 2014 10:57, Ben Pfaff wrote:
> On Wed, May 21, 2014 at 09:43:22AM +1200, Joe Stringer wrote:
> > Ah, sorry I should have replied to this series; Andy looked through a
> > separate posting of them and I applied them.
> >
> > I'll prepare a patch to remove the "-A" from the grepping in th
On May 8, 2014, at 4:50 PM, Ben Pfaff wrote:
> Signed-off-by: Ben Pfaff
> ---
> lib/dpif-netdev.c | 163 +++--
> 1 file changed, 82 insertions(+), 81 deletions(-)
>
> diff --git a/lib/dpif-netdev.c b/lib/dpif-netdev.c
> index 55712dd..b682876 100
Thanks, pushed to master, branch-2.3, branch-2.2
Sorry, I forgot to append the Acked-by...
On Tue, May 20, 2014 at 3:56 PM, Ben Pfaff wrote:
> On Tue, May 20, 2014 at 02:24:53PM -0700, Alex Wang wrote:
> > Since the removal of dispatcher thread, OVS creates 'n-handler-threads'
> > file descrip
On Fri, Apr 11, 2014 at 06:34:21PM -0300, Flavio Leitner wrote:
> First check if the packet is a multicast and if the multicast
> snooping feature is enabled. If so, then update the multicast
> snooping database accordingly and send it to the correct ports.
>
> If the packet is not multicast, let
On May 20, 2014, at 4:03 PM, Jarno Rajahalme wrote:
>
> On May 8, 2014, at 4:50 PM, Ben Pfaff wrote:
>
>> Signed-off-by: Ben Pfaff
>> ---
>> lib/dpif-netdev.c | 163
>> +++--
>> 1 file changed, 82 insertions(+), 81 deletions(-)
>>
>> diff --g
On May 20, 2014, at 4:11 PM, Jarno Rajahalme wrote:
> unreeling
unreffing ___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
On Fri, Apr 11, 2014 at 06:34:22PM -0300, Flavio Leitner wrote:
> Fix bridge to create and configure multicast snooping.
>
> Acked-by: Thomas Graf
> Signed-off-by: Flavio Leitner
Code like this:
> +if (smap_get_bool(&br->cfg->other_config,
> + "mcast-snooping-fl
On Tue, May 20, 2014 at 12:54:32PM -0700, Jesse Gross wrote:
> On Tue, May 20, 2014 at 3:41 AM, Simon Horman wrote:
> > diff --git a/datapath/linux/compat/gso.h b/datapath/linux/compat/gso.h
> > index b83a4c3..f459c18 100644
> > --- a/datapath/linux/compat/gso.h
> > +++ b/datapath/linux/compat/gso
On Fri, Apr 11, 2014 at 06:34:23PM -0300, Flavio Leitner wrote:
> Acked-by: Thomas Graf
> Acked-by: Daniel Borkmann
> Signed-off-by: Flavio Leitner
Thanks for adding examples to the ovs-vsctl manpage!
I see two spelling errors in vswitch.xml: s/packers/packets/,
s/inconditionally/unconditional
On Tue, May 20, 2014 at 04:32:48PM -0700, Ben Pfaff wrote:
> On Fri, Apr 11, 2014 at 06:34:23PM -0300, Flavio Leitner wrote:
> > Acked-by: Thomas Graf
> > Acked-by: Daniel Borkmann
> > Signed-off-by: Flavio Leitner
>
> Thanks for adding examples to the ovs-vsctl manpage!
>
> I see two spelling
On Tue, May 20, 2014 at 04:02:52PM -0700, Alex Wang wrote:
> Sorry, I forgot to append the Acked-by...
No problem, I forget from time to time myself.
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
When adding support for Openflow group and bucket stats, a group entry is added
to the xlate cache. If the group is removed from ofproto configuration, we need
to guarantee the group exists in the case where stats are attributed to the
group by a handler thread and the xlate cache has not yet been
On Wed, May 21, 2014 at 11:01:43AM +1200, Joe Stringer wrote:
> On 21 May 2014 10:57, Ben Pfaff wrote:
>
> > On Wed, May 21, 2014 at 09:43:22AM +1200, Joe Stringer wrote:
> > In that case let's just leave it for the moment. If it causes trouble
> > in practice for any of the ports, we can fix it
On Tue, May 20, 2014 at 01:25:35PM -0700, Jarno Rajahalme wrote:
>
> On May 20, 2014, at 1:03 PM, Ben Pfaff wrote:
>
> > On Tue, May 20, 2014 at 12:40:20PM -0700, Jarno Rajahalme wrote:
> >>
> >> On May 20, 2014, at 10:08 AM, Ben Pfaff wrote:
> >>
> >>> On Tue, May 20, 2014 at 09:12:23AM -070
On Tue, May 20, 2014 at 02:13:58PM -0700, Jarno Rajahalme wrote:
>
> On May 20, 2014, at 2:03 PM, Ben Pfaff wrote:
>
> > On Tue, May 20, 2014 at 01:22:45PM -0700, Jarno Rajahalme wrote:
> >>
> >> On May 20, 2014, at 9:48 AM, Ben Pfaff wrote:
> >>
> >>> On Tue, May 20, 2014 at 09:12:23AM -0700
On Tue, May 20, 2014 at 04:03:20PM -0700, Jarno Rajahalme wrote:
>
> On May 8, 2014, at 4:50 PM, Ben Pfaff wrote:
>
> > Signed-off-by: Ben Pfaff
> > ---
> > lib/dpif-netdev.c | 163
> > +++--
> > 1 file changed, 82 insertions(+), 81 deletions(-)
When the last rxq is closed (which releases the rxq's internal reference
to its netdev) the next call to netdev_n_rxq() accesses freed memory.
Found by valgrind.
Signed-off-by: Ben Pfaff
Reported-by: Jarno Rajahalme
---
lib/dpif-netdev.c |4 +++-
1 file changed, 3 insertions(+), 1 deletion
Signed-off-by: Ben Pfaff
---
lib/dpif-netdev.c |1 +
1 file changed, 1 insertion(+)
diff --git a/lib/dpif-netdev.c b/lib/dpif-netdev.c
index a2e3308..a8e6a55 100644
--- a/lib/dpif-netdev.c
+++ b/lib/dpif-netdev.c
@@ -821,6 +821,7 @@ port_unref(struct dp_netdev_port *port)
for (i = 0
On Tue, May 20, 2014 at 05:03:59PM -0700, Ben Pfaff wrote:
> On Tue, May 20, 2014 at 04:03:20PM -0700, Jarno Rajahalme wrote:
> >
> > On May 8, 2014, at 4:50 PM, Ben Pfaff wrote:
> >
> > > Signed-off-by: Ben Pfaff
> > > ---
> > > lib/dpif-netdev.c | 163
> > > +++--
Signed-off-by: Ben Pfaff
Acked-by: Jarno Rajahalme
---
lib/dpif-netdev.c | 171 +++--
1 file changed, 87 insertions(+), 84 deletions(-)
diff --git a/lib/dpif-netdev.c b/lib/dpif-netdev.c
index a8e6a55..df62912 100644
--- a/lib/dpif-netdev.c
+++ b
On Tue, May 20, 2014 at 4:31 PM, Simon Horman wrote:
> On Tue, May 20, 2014 at 12:54:32PM -0700, Jesse Gross wrote:
>> On Tue, May 20, 2014 at 3:41 AM, Simon Horman wrote:
>> > diff --git a/datapath/linux/compat/gso.h b/datapath/linux/compat/gso.h
>> > index b83a4c3..f459c18 100644
>> > --- a/dat
On 21 May 2014 10:33, Joe Stringer wrote:
> On 21 May 2014 10:05, Ryan Wilson 76511 wrote:
>
> Hey Andy,
>>
>> >At a high level, ofgroup struct current has rwlock that essentially
>> >solving
>> >the same problem as the ref count proposed in this patch. It would be
>> >better
>> >it seems confu
On Tue, May 20, 2014 at 3:54 PM, Ryan Wilson 76511 wrote:
>
> Thanks for the review, Joe! I added a more clear description in 'struct
> ofgroup' and the commit message to explain why the refcount is needed.
That's good. Thanks for the improvement. I understand now the ref
count is for the fast
pat
On 21 May 2014 02:52, Ryan Wilson wrote:
> When adding support for Openflow group and bucket stats, a group entry is
> added
> to the xlate cache. If the group is removed from ofproto configuration, we
> need
> to guarantee the group exists in the case where stats are attributed to the
> group by
FYI, I just did a perf test on master and received the same error message as
before. So this appears to be an issue unrelated to this patch.
2014-05-20T16:42:48.435Z|3|dpif(revalidator109)|WARN|system@ovs-system:
failed to flow_del (No such file or directory)
dp_hash(0),recirc_id(0),skb_pri
On Tue, May 13, 2014 at 7:02 AM, Lorand Jakab wrote:
> Implementation of the pop_eth and push_eth actions in the kernel, and
> layer 3 flow support.
>
> Signed-off-by: Lorand Jakab
Lori, can you take a look at the thread with Thomas Morin and see if
the outcome is reasonable to you? It seems lik
On Tue, May 20, 2014 at 05:14:25PM -0700, Jesse Gross wrote:
> On Tue, May 20, 2014 at 4:31 PM, Simon Horman wrote:
> > On Tue, May 20, 2014 at 12:54:32PM -0700, Jesse Gross wrote:
> >> On Tue, May 20, 2014 at 3:41 AM, Simon Horman wrote:
> >> > diff --git a/datapath/linux/compat/gso.h b/datapath
>On Tue, May 20, 2014 at 3:54 PM, Ryan Wilson 76511
>wrote:
>>
>> Thanks for the review, Joe! I added a more clear description in 'struct
>> ofgroup' and the commit message to explain why the refcount is needed.
>That's good. Thanks for the improvement. I understand now the ref
>count is for the
On Tue, May 20, 2014 at 3:48 AM, Simon Horman wrote:
> On Mon, May 19, 2014 at 06:34:05PM -0700, Jesse Gross wrote:
>> On Thu, May 15, 2014 at 4:07 PM, Simon Horman wrote:
>> > diff --git a/datapath/actions.c b/datapath/actions.c
>> > index 603c7cb..7c3ae0c 100644
>> > --- a/datapath/actions.c
>>
1 - 100 of 120 matches
Mail list logo
