On Fri, Apr 11, 2014 at 06:34:10PM -0300, Flavio Leitner wrote: > Signed-off-by: Flavio Leitner <f...@redhat.com>
I don't much like the #defines for igmp_type and igmp_code. We used to do something like that for icmp_type and icmp_code, but in the end it caused confusion, which is why we stopped. I would rather not introduce the same thing again for IGMP. I'm not really a fan of the IGMP group as a single field in a union in a struct in struct flow. Let's just use a raw ovs_be32. If/when we introduce IGMPv6, we can do something more complicated. Thanks, Ben. _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev