Re: [ovs-dev] [PATCH 2/2] ovs-atomic: Remove atomic_{u,}int64_t

2014-05-13 Thread Simon Horman
On Mon, May 12, 2014 at 08:51:49AM -0700, Ben Pfaff wrote: > On Mon, May 12, 2014 at 08:56:37AM +0900, Simon Horman wrote: > > Some concern has been raised by Ben Pfaff that atomic_uint64_t may not > > be portable. In particular on 32bit platforms that do not have atomic > > 64bit integers. > > >

[ovs-dev] [PATCH v3 3/3] datapath: add layer 3 flow/port support

2014-05-13 Thread Lorand Jakab
Implementation of the pop_eth and push_eth actions in the kernel, and layer 3 flow support. Signed-off-by: Lorand Jakab --- datapath/actions.c| 35 + datapath/datapath.h | 1 + datapath/flow.c | 43 ++ datapath/flow

[ovs-dev] [PATCH v3 0/3] Support for layer 3 ports

2014-05-13 Thread Lorand Jakab
This series implements support for layer 3 ports, of which we have one example so far, the LISP vport. LISP support is currently implemented with a hack, by adding/removing the Ethernet header within the datapath/vport-lisp.c file. By removing the assumption that all packets/flows have Ethernet h

[ovs-dev] [PATCH v3 1/3] userspace: add support for pop_eth and push_eth actions

2014-05-13 Thread Lorand Jakab
These actions will allow L2->L3 and L3->L2 switching, and are supposed to be added to flows installed in the datapath transparently by ovs-vswitchd. Signed-off-by: Lorand Jakab --- include/linux/openvswitch.h | 16 ++-- lib/dpif-netdev.c | 2 ++ lib/dpif.c |

[ovs-dev] [PATCH v3 2/3] userspace: add layer 3 flow and switching support

2014-05-13 Thread Lorand Jakab
This commit relaxes the assumption that all packets have an Ethernet header, and adds support for layer 3 flows. For each packet received on the Linux kernel datapath the l2 and l3 members of struct ofpbuf are intialized appropriately, and some functions now expect this (notably flow_extract()), i

Re: [ovs-dev] [of1.5 v2 07/20] ofp-util: Implement OpenFlow 1.4 port status and port desc reply messages.

2014-05-13 Thread Alexandru Copot
On Tue, May 13, 2014 at 9:55 AM, Alexandru Copot wrote: > On Tue, May 13, 2014 at 4:18 AM, Ben Pfaff wrote: >> On Sun, May 11, 2014 at 09:39:32PM +0300, Alexandru Copot wrote: >>> On Sat, May 10, 2014 at 5:40 AM, Ben Pfaff wrote: >>> > Signed-off-by: Ben Pfaff >>> >>> > >>> > diff --git a/lib/o

[ovs-dev] [PATCH 02/10] timeval: Workaround strftime bug in VS 2013.

2014-05-13 Thread Gurucharan Shetty
Visual Studio 2013's behavior is to crash when 0 is passed as second argument to strftime. Signed-off-by: Gurucharan Shetty --- lib/timeval.c | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/lib/timeval.c b/lib/timeval.c index d2a4380..014fd7d 100644 --- a/lib/t

[ovs-dev] [PATCH 01/10] ovsdb: Open database in binary mode.

2014-05-13 Thread Gurucharan Shetty
Some ovsdb-tool related unit tests fail with bad checksum errors while reading transactions from database. It is most likely because of the CR at the end of line. Using binary mode solves the problem. Signed-off-by: Gurucharan Shetty --- ovsdb/log.c |3 +++ 1 file changed, 3 insertions(+) d

[ovs-dev] [PATCH 03/10] ovs-pki: Pass correct argument to 'sign' command.

2014-05-13 Thread Gurucharan Shetty
The first argument passed to 'sign' command is used as prefix for both req.pem and cert.pem. Signed-off-by: Gurucharan Shetty --- utilities/ovs-pki.in |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/utilities/ovs-pki.in b/utilities/ovs-pki.in index 501b06e..89af405 100755

[ovs-dev] [PATCH 10/10] tests: Change to parse dynamically allocated ports on windows.

2014-05-13 Thread Gurucharan Shetty
In Windows, we use kernel assigned TCP port for ssl/tcp and unixctl. In tests, we parse the log files of ovsdb-server.log, test-sflow.log and test-netflow.log to get this port. In all the above cases, tcp port is allocated first and then the unixctl port. So a 'head -1' on the result should be safe

[ovs-dev] [PATCH 09/10] ovsdb-server.at: Skip transient transaction tests for Windows.

2014-05-13 Thread Gurucharan Shetty
Windows port does not yet implement ovsdb-server's "--run" option. Till it is implemented, skip the tests. Signed-off-by: Gurucharan Shetty --- tests/ovsdb-server.at |1 + 1 file changed, 1 insertion(+) diff --git a/tests/ovsdb-server.at b/tests/ovsdb-server.at index 86179bd..08c56ca 100644

[ovs-dev] [PATCH 05/10] tests/library.at: Disable unix socket tests on Windows.

2014-05-13 Thread Gurucharan Shetty
Signed-off-by: Gurucharan Shetty --- tests/automake.mk |7 ++- tests/library.at |6 -- 2 files changed, 10 insertions(+), 3 deletions(-) diff --git a/tests/automake.mk b/tests/automake.mk index bf80702..c115289 100644 --- a/tests/automake.mk +++ b/tests/automake.mk @@ -233,10 +2

[ovs-dev] [PATCH 08/10] test-ovsdb: Fix setvbuf incompatibility on Windows.

2014-05-13 Thread Gurucharan Shetty
setvbuf() in Windows treats _IOLBF to be the same as _IOFBF. So we cannot have size as zero (otherwise, there is a crash). Workaround is to set _IONBF. I don't see unit test failures because of the change. Signed-off-by: Gurucharan Shetty --- tests/test-ovsdb.c |2 +- 1 file changed, 1 inse

[ovs-dev] [PATCH 07/10] util: set_program_name() can be called twice with different names.

2014-05-13 Thread Gurucharan Shetty
Ex: ovstest.c Signed-off-by: Gurucharan Shetty --- lib/util.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/util.c b/lib/util.c index 769558e..74dc889 100644 --- a/lib/util.c +++ b/lib/util.c @@ -461,7 +461,7 @@ set_program_name__(const char *argv0, const char *versi

[ovs-dev] [PATCH 06/10] util: Disable popups while asserting in windows.

2014-05-13 Thread Gurucharan Shetty
The default behavior for programs is to display a popup after an assert/abort etc. This is not an ideal behavior because this needs user intervention. set_program_name, though not an ideal place to disable this, is a useful place because it is called by all programs including unit test binaries.

[ovs-dev] [PATCH 04/10] ovs-pki: Workaround lack of /dev/stdin in Windows.

2014-05-13 Thread Gurucharan Shetty
This lets us generate certs for unit tests on Windows Signed-off-by: Gurucharan Shetty --- utilities/ovs-pki.in |5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/utilities/ovs-pki.in b/utilities/ovs-pki.in index 89af405..7f56b4e 100755 --- a/utilities/ovs-pki.in +++ b/u

Re: [ovs-dev] [PATCH v2 1/2] datapath: Free skb(s) on recirculation error

2014-05-13 Thread Jesse Gross
On Mon, May 12, 2014 at 10:46 PM, Simon Horman wrote: > On Mon, May 12, 2014 at 04:32:29PM -0700, Daniele Di Proietto wrote: >> You’re right, of course. >> >> Sorry I didn’t see it the first time. >> >> On May 12, 2014, at 4:28 PM, Jesse Gross wrote: >> >> > On Mon, May 12, 2014 at 4:06 PM, Danie

Re: [ovs-dev] [PATCH] [resend] net: get rid of SET_ETHTOOL_OPS

2014-05-13 Thread David Miller
From: Wilfried Klaebe Date: Sun, 11 May 2014 00:12:32 + > net: get rid of SET_ETHTOOL_OPS > > Dave Miller mentioned he'd like to see SET_ETHTOOL_OPS gone. > This does that. > > Mostly done via coccinelle script: > @@ > struct ethtool_ops *ops; > struct net_device *dev; > @@ > - SET_ET

[ovs-dev] [PATCH] dpif-netdev: removed hmap flow_table

2014-05-13 Thread Daniele Di Proietto
As suggested by others, we can use the classifier, instead of the hash table, as the only flow container in dpif-netdev Signed-off-by: Daniele Di Proietto --- lib/dpif-netdev.c | 68 +++ 1 file changed, 34 insertions(+), 34 deletions(-) diff -

Re: [ovs-dev] [of1.5 v2 20/20] meta-flow: Use OXM-defined constant for TCP flags in OpenFlow 1.5.

2014-05-13 Thread Jarno Rajahalme
One minor comment below, otherwise looks good to me, Jarno > On May 9, 2014, at 7:40 PM, Ben Pfaff wrote: > > This also adds the definitions of a few other OXM headers we didn't have > yet. > > EXT-109. > Signed-off-by: Ben Pfaff > --- > include/openflow/openflow-1.2.h | 15 +--

Re: [ovs-dev] [PATCH] [RFC] datapath: Implement vxlan-soe

2014-05-13 Thread Han Zhou
Repost it since the original one was blocked by some spam filters. @Jesse, could you help review it from technical point of view? If this looks good I can then make it optional and configurable. Thanks a lot! -Han On Mon, May 12, 2014 at 4:04 PM, Han Zhou wrote: > This patch implements vxlan-soe

Re: [ovs-dev] [bond megaflow v4 3/4] dpif-netdev: user space datapath recirculation

2014-05-13 Thread Joe Stringer
I suppose so. Does this affect finding rules when there's a new userspace and older kernel? On 13 May 2014 16:39, Andy Zhou wrote: > Their is no use case of partial mask in the user space. > > Now that both user space and kernel data path always export recirc_id > and dp_hash, may be we can drop

Re: [ovs-dev] [PATCH] [RFC] flow: Do not clear L3+ fields of flow in flow_push_mpls()

2014-05-13 Thread Simon Horman
On Wed, May 07, 2014 at 05:02:06PM +1200, Simon Horman wrote: > On Thu, May 01, 2014 at 08:24:21AM -0700, Ben Pfaff wrote: > > On Thu, May 01, 2014 at 08:21:36AM -0700, Jarno Rajahalme wrote: > > > > > > > On May 1, 2014, at 7:53 AM, Ben Pfaff wrote: > > > > > > > >> On Mon, Apr 28, 2014 at 03:5