Re: [ovs-dev] [PATCH] ovs-dpctl-top: Flow fields display content with mask applied.

2013-11-04 Thread Gurucharan Shetty
On Fri, Oct 25, 2013 at 4:10 PM, Mark Hamilton wrote: > From: Mark Hamilton > > For example, if the value is ipv4(src=192.168.0.1/255.255.0.0) > the output from top is ipv4(src=192.168.0.0/255.255.0.0). Prior > to this change, the original flow field content was shown > unaltered even though flow

Re: [ovs-dev] [PATCH] OPENFLOW-1.1+: Groups are now supported.

2013-11-04 Thread Joe Stringer
Has NEWS been updated as well? On 3 November 2013 16:54, Simon Horman wrote: > On Sat, Nov 02, 2013 at 07:36:29PM -0700, Ben Pfaff wrote: >> CC: Simon Horman >> Signed-off-by: Ben Pfaff > > Acked-by: Simon Horman > >> --- >> OPENFLOW-1.1+ | 17 - >> 1 file changed, 17 deleti

Re: [ovs-dev] [PATCH v1 2/6] dpif-netdev: Introduce a classifier in userspace datapath.

2013-11-04 Thread Ben Pfaff
On Sun, Nov 03, 2013 at 06:56:05PM -0800, Gurucharan Shetty wrote: > On Fri, Nov 1, 2013 at 1:21 PM, Ben Pfaff wrote: > > On Fri, Nov 01, 2013 at 02:15:13AM -0700, Gurucharan Shetty wrote: > >> Instead of an exact match flow table, we introduce a classifier. > >> This enables mega-flows in userspa

Re: [ovs-dev] [PATCH] OPENFLOW-1.1+: Groups are now supported.

2013-11-04 Thread Ben Pfaff
On Mon, Nov 04, 2013 at 09:54:36AM +0900, Simon Horman wrote: > On Sat, Nov 02, 2013 at 07:36:29PM -0700, Ben Pfaff wrote: > > CC: Simon Horman > > Signed-off-by: Ben Pfaff > > Acked-by: Simon Horman Thanks, applied! ___ dev mailing list dev@openvswi

Re: [ovs-dev] [PATCH] OPENFLOW-1.1+: Groups are now supported.

2013-11-04 Thread Ben Pfaff
I'm actually hoping to update NEWS soon with something like "All required OF1.1-OF1.3 features are now supported, with the following exceptions: ." The only exception I really want to have is support for 0x88a8 VLANs. On Mon, Nov 04, 2013 at 09:18:57AM -0800, Joe Stringer wrote: > Has NEWS been u

Re: [ovs-dev] [PATCH] Bond to use active-backup mode on LACP failure

2013-11-04 Thread Ben Pfaff
On Wed, Oct 30, 2013 at 08:06:18PM +, Ravi Kondamuru wrote: > Commit bdebeece5 on git.openvswitch.org (lacp: Require successful LACP > negotiations when configured.) makes successful LACP negotiation > mandatory for the bond to come UP. This patch provides a configuration > option to bring up t

Re: [ovs-dev] [PATCH] Bond to use active-backup mode on LACP failure

2013-11-04 Thread Ethan Jackson
Yep I'm looking at it. Ethan On Mon, Nov 4, 2013 at 11:34 AM, Ben Pfaff wrote: > On Wed, Oct 30, 2013 at 08:06:18PM +, Ravi Kondamuru wrote: >> Commit bdebeece5 on git.openvswitch.org (lacp: Require successful LACP >> negotiations when configured.) makes successful LACP negotiation >> mandat

Re: [ovs-dev] [PATCH] Bond to use active-backup mode on LACP failure

2013-11-04 Thread Ethan Jackson
This looks pretty much on track. Here's my code review. Please fix up the changes mentioned below and resend it. The first line of the commit message needs period. Could we change it to "bond: Use active-backup mode on LACP failure." to be more similar to the rest of our commit messages? There

Re: [ovs-dev] [GIT net-next] Open vSwitch

2013-11-04 Thread David Miller
From: Jesse Gross Date: Sat, 2 Nov 2013 00:43:39 -0700 > A set of updates for net-next/3.13. Major changes are: > * Restructure flow handling code to be more logically organized and >easier to read. > * Rehashing of the flow table is moved from a workqueue to flow >installation time. B

[ovs-dev] [PATCH 1/6] FAQ, NEWS: Notes on TCP flags matching.

2013-11-04 Thread Jarno Rajahalme
Add a FAQ categorry "Performance Problems". So far the only entry addresses the issue with using a new kernel module with an older (pre-megaflows) userspace. Signed-off-by: Jarno Rajahalme --- FAQ | 24 NEWS |5 + 2 files changed, 29 insertions(+) diff --git

[ovs-dev] [PATCH v2] bond: Use active-backup mode on LACP failure.

2013-11-04 Thread Ravi Kondamuru
Commit bdebeece5 (lacp: Require successful LACP negotiations when configured.) makes successful LACP negotiation mandatory for the bond to come UP. This patch provides a configuration option to bring up the bond by falling back to active-backup mode on LACP negotiation failure. Several of the phys

Re: [ovs-dev] [PATCH v1 2/6] dpif-netdev: Introduce a classifier in userspace datapath.

2013-11-04 Thread Gurucharan Shetty
On Mon, Nov 4, 2013 at 10:03 AM, Ben Pfaff wrote: > On Sun, Nov 03, 2013 at 06:56:05PM -0800, Gurucharan Shetty wrote: >> On Fri, Nov 1, 2013 at 1:21 PM, Ben Pfaff wrote: >> > On Fri, Nov 01, 2013 at 02:15:13AM -0700, Gurucharan Shetty wrote: >> >> Instead of an exact match flow table, we introdu

[ovs-dev] [PATCH v2] dpif-netdev: Introduce a classifier in userspace datapath.

2013-11-04 Thread Gurucharan Shetty
Instead of an exact match flow table, we introduce a classifier. This enables mega-flows in userspace datapath. Signed-off-by: Gurucharan Shetty --- lib/dpif-netdev.c | 129 +--- tests/ofproto-dpif.at | 142 +--

Re: [ovs-dev] [PATCH v8 07/16] ofproto: Advertise all supported OpenFlow actions in group features

2013-11-04 Thread Simon Horman
On Sat, Nov 02, 2013 at 11:53:11AM -0700, Ben Pfaff wrote: > On Wed, Oct 30, 2013 at 06:17:11PM +0900, Simon Horman wrote: > > Signed-off-by: Simon Horman > > The enums are consecutive integers, not bitwise masks, so I changed ENUM > to (1 << ENUM) here: > > +#define OFPAT11_ACTION(ENUM, STRUCT,

Re: [ovs-dev] [PATCH v8 11/16] ofproto: Add group desc and stats tests

2013-11-04 Thread Simon Horman
On Sat, Nov 02, 2013 at 05:56:09PM -0700, Ben Pfaff wrote: > On Wed, Oct 30, 2013 at 06:17:15PM +0900, Simon Horman wrote: > > Lightly exercise group desc and stats > > > > Signed-off-by: Simon Horman > > I was just thinking that we needed some tests here. > > These tests revealed an actual bug

Re: [ovs-dev] [PATCH v8 15/16] ofproto-dpif: Translation of select groups

2013-11-04 Thread Simon Horman
On Sat, Nov 02, 2013 at 07:19:41PM -0700, Ben Pfaff wrote: > On Wed, Oct 30, 2013 at 06:17:19PM +0900, Simon Horman wrote: > > Select bucket from those that are alive based on a hash of the destination > > ethernet address of the packet. > > > > Support for weights is proposed by a subsequent patc

Re: [ovs-dev] [PATCH 3/4] Add init/destroy funcs and handle Table Features msgs.

2013-11-04 Thread Simon Horman
On Fri, Nov 01, 2013 at 09:33:23PM +0800, Alexander Wu wrote: > On 01/11/2013 12:32, Simon Horman wrote: > >On Sat, Oct 26, 2013 at 06:15:30PM +0800, Alexander Wu wrote: > >>Add some functions to init table features(use ofp13_* struct > >> currently, change it to ofputil later). > >>Use the encode

Re: [ovs-dev] [PATCH 2/4] Implement the encode/decode Table Features functions

2013-11-04 Thread Simon Horman
On Fri, Nov 01, 2013 at 07:52:35PM +0800, Alexander Wu wrote: > Thanks for your reply! > > On 01/11/2013 12:29, Simon Horman wrote: > >On Sat, Oct 26, 2013 at 06:14:28PM +0800, Alexander Wu wrote: > >>Implement the encode/decode table features msgs function, and > >>NOTE that we implement the deco

[ovs-dev] [PATCH] ofproto: report the correct set of actions for group features

2013-11-04 Thread YAMAMOTO Takashi
do not report OF1.1 bits (set_dl_src etc) as group features is OF1.2+. Signed-off-by: YAMAMOTO Takashi --- ofproto/ofproto.c | 21 ++--- 1 file changed, 18 insertions(+), 3 deletions(-) diff --git a/ofproto/ofproto.c b/ofproto/ofproto.c index b88cd81..28b21ce 100644 --- a/ofprot

Re: [ovs-dev] [PATCH] ofproto: report the correct set of actions for group features

2013-11-04 Thread YAMAMOTO Takashi
> do not report OF1.1 bits (set_dl_src etc) as group features is OF1.2+. > > Signed-off-by: YAMAMOTO Takashi > --- > ofproto/ofproto.c | 21 ++--- > 1 file changed, 18 insertions(+), 3 deletions(-) > > diff --git a/ofproto/ofproto.c b/ofproto/ofproto.c > index b88cd81..28b21ce 1

[ovs-dev] [PATCH] ofproto: report the correct set of actions for group features

2013-11-04 Thread YAMAMOTO Takashi
do not report OF1.1 bits (set_dl_src etc) as group features is OF1.2+. LINC seems to use 1<<31 for experimenter action type but i failed to find it in the spec. Signed-off-by: YAMAMOTO Takashi --- ofproto/ofproto.c | 20 +--- 1 file changed, 17 insertions(+), 3 deletions(-) dif

Re: [ovs-dev] [PATCH 3/4] Add init/destroy funcs and handle Table Features msgs.

2013-11-04 Thread YAMAMOTO Takashi
thanks for working on this. > +static void > +table_oxm_init(struct ofputil_table_features *tf, > +enum ofputil_table_feature_prop_type type) > +{ > +int i = 0 ,olen = 0; > +const int OXM_NUM = get_oxm_num(); > +uint32_t *oxm_ids = NULL; > + > +olen = sizeof(uint32_

Re: [ovs-dev] [PATCH v8 11/16] ofproto: Add group desc and stats tests

2013-11-04 Thread Ben Pfaff
On Tue, Nov 05, 2013 at 09:39:29AM +0900, Simon Horman wrote: > Could you let me know how you ran the tests under valgrind? >From "Running the Testsuite" in INSTALL: If you have "valgrind" installed, then you can also run the testsuite under valgrind by using "make check-valgrind" in plac

Re: [ovs-dev] [PATCH] ofproto: report the correct set of actions for group features

2013-11-04 Thread Ben Pfaff
On Tue, Nov 05, 2013 at 12:38:19PM +0900, YAMAMOTO Takashi wrote: > do not report OF1.1 bits (set_dl_src etc) as group features is OF1.2+. > > LINC seems to use 1<<31 for experimenter action type but i failed to > find it in the spec. > > Signed-off-by: YAMAMOTO Takashi Thanks, applied. At fir

[ovs-dev] [meter-bugs 0/6] fix some bugs in meter protocol

2013-11-04 Thread Ben Pfaff
These are some early results from the ONF plugfest. Ben Pfaff (6): ofpbuf: Allow whitespace other than spaces in hex data. OPENFLOW-1.1+: Update item describing status of meters. ofp-actions: Allow meter actions in ofpacts_verify(). ofp-util: Report OFPMMFC_BAD_BAND for bad band type in me

[ovs-dev] [meter-bugs 1/6] ofpbuf: Allow whitespace other than spaces in hex data.

2013-11-04 Thread Ben Pfaff
It's easier to cut and paste lines of hexadecimal data into a command line if you don't have to worry about new-lines appearing in the command. Signed-off-by: Ben Pfaff --- lib/ofpbuf.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/ofpbuf.c b/lib/ofpbuf.c index f7145

[ovs-dev] [meter-bugs 6/6] ofp-util: Report OFPMMFC_BAD_FLAGS for bad band flags.

2013-11-04 Thread Ben Pfaff
It doesn't make sense to specify both kbps and pkt/s, because the two units are mutually exclusive. Signed-off-by: Ben Pfaff --- lib/ofp-util.c |4 tests/ofp-print.at | 10 ++ 2 files changed, 14 insertions(+) diff --git a/lib/ofp-util.c b/lib/ofp-util.c index 16b09f6..77

[ovs-dev] [meter-bugs 5/6] ofp-util: Report OFPMMFC_BAD_COMMAND for bad meter mod commands.

2013-11-04 Thread Ben Pfaff
Signed-off-by: Ben Pfaff --- lib/ofp-util.c |5 + tests/ofp-print.at |9 + 2 files changed, 14 insertions(+) diff --git a/lib/ofp-util.c b/lib/ofp-util.c index be632e9..16b09f6 100644 --- a/lib/ofp-util.c +++ b/lib/ofp-util.c @@ -1731,6 +1731,11 @@ ofputil_decode_meter_mo

[ovs-dev] [meter-bugs 4/6] ofp-util: Report OFPMMFC_BAD_BAND for bad band type in meter mod decoding.

2013-11-04 Thread Ben Pfaff
Signed-off-by: Ben Pfaff --- lib/ofp-util.c |3 +++ tests/ofp-print.at | 10 ++ 2 files changed, 13 insertions(+) diff --git a/lib/ofp-util.c b/lib/ofp-util.c index 9645e04..be632e9 100644 --- a/lib/ofp-util.c +++ b/lib/ofp-util.c @@ -1698,6 +1698,9 @@ ofputil_pull_bands(struct

[ovs-dev] [meter-bugs 2/6] OPENFLOW-1.1+: Update item describing status of meters.

2013-11-04 Thread Ben Pfaff
Signed-off-by: Ben Pfaff --- OPENFLOW-1.1+ |8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/OPENFLOW-1.1+ b/OPENFLOW-1.1+ index f978cb5..1bb5a81 100644 --- a/OPENFLOW-1.1+ +++ b/OPENFLOW-1.1+ @@ -119,11 +119,9 @@ didn't compare the specs carefully yet.) that i

[ovs-dev] [meter-bugs 3/6] ofp-actions: Allow meter actions in ofpacts_verify().

2013-11-04 Thread Ben Pfaff
Signed-off-by: Ben Pfaff --- lib/ofp-actions.c |9 + tests/ofp-print.at | 12 2 files changed, 17 insertions(+), 4 deletions(-) diff --git a/lib/ofp-actions.c b/lib/ofp-actions.c index bae479e..6c90d5c 100644 --- a/lib/ofp-actions.c +++ b/lib/ofp-actions.c @@ -2150,14