On Tue, Nov 05, 2013 at 12:38:19PM +0900, YAMAMOTO Takashi wrote:
> do not report OF1.1 bits (set_dl_src etc) as group features is OF1.2+.
>
> LINC seems to use 1<<31 for experimenter action type but i failed to
> find it in the spec.
>
> Signed-off-by: YAMAMOTO Takashi <[email protected]>
Thanks, applied.
At first I thought that this was really a bug in the group features
reply encoding function, but then I noticed that group features weren't
introduced until OF1.2, so I folded in these extra comments to make that
clear:
diff --git a/lib/ofp-util.h b/lib/ofp-util.h
index c66e65d..fef85e0 100644
--- a/lib/ofp-util.h
+++ b/lib/ofp-util.h
@@ -991,12 +991,16 @@ struct ofputil_group_stats {
struct bucket_counter *bucket_stats;
};
-/* Group features reply, independent of protocol. */
+/* Group features reply, independent of protocol.
+ *
+ * Only OF1.2 and later support group features replies. */
struct ofputil_group_features {
uint32_t types; /* Bitmap of OFPGT_* values supported. */
uint32_t capabilities; /* Bitmap of OFPGFC12_* capability supported. */
uint32_t max_groups[4]; /* Maximum number of groups for each type. */
- uint32_t actions[4]; /* Bitmaps of OFPAT_* that are supported. */
+
+ /* Bitmaps of OFPAT_* that are supported. OF1.2+ actions only. */
+ uint32_t actions[4];
};
/* Group desc reply, independent of protocol. */
_______________________________________________
dev mailing list
[email protected]
http://openvswitch.org/mailman/listinfo/dev
