Require liveness for fast-failover groups as it is mandated by OpenFlow1.3.
Allow livness for select groups which is in keeping with OpenFlow1.3.
Disallow liveness it for other group types.
Signed-off-by: Simon Horman
---
v8
* First post
---
lib/ofp-util.c | 29 -
l
It seems to make sense to set the reference count and number
of buckets at the protocol layer as it is known there.
Signed-off-by: Simon Horman
---
ofproto/ofproto.c | 31 +--
1 file changed, 29 insertions(+), 2 deletions(-)
diff --git a/ofproto/ofproto.c b/ofproto/o
As pert the OpenFlow1.3.2 specification, delete flows that
reference a group when it is deleted.
Signed-off-by: Simon Horman
---
v8
* First post
---
ofproto/ofproto.c | 50 ++
1 file changed, 34 insertions(+), 16 deletions(-)
diff --git a/ofprot
These values will be used by subsequent patches
Signed-off-by: Simon Horman
---
v8
* First post
---
include/openflow/openflow-common.h | 8
1 file changed, 8 insertions(+)
diff --git a/include/openflow/openflow-common.h
b/include/openflow/openflow-common.h
index 93cc2c4..a38f1e3 100
Lightly exercise group desc and stats
Signed-off-by: Simon Horman
---
v8
* First post
---
tests/ofproto.at | 37 +
1 file changed, 37 insertions(+)
diff --git a/tests/ofproto.at b/tests/ofproto.at
index 3652cf2..465daf5 100644
--- a/tests/ofproto.at
+++ b/t
Test that flow mod with groups succeeds only if the group exists.
Signed-off-by: Simon Horman
---
v8
* First post
---
tests/ofproto.at | 28
1 file changed, 28 insertions(+)
diff --git a/tests/ofproto.at b/tests/ofproto.at
index 6abbc56..9c36758 100644
--- a/tests
Lightly exercise del-groups
Signed-off-by: Simon Horman
---
* v8
First post
---
tests/ofproto.at | 82
1 file changed, 82 insertions(+)
diff --git a/tests/ofproto.at b/tests/ofproto.at
index 465daf5..6abbc56 100644
--- a/tests/ofproto.a
Break out resubmit resource checking into a helper function
xlate_resubmit_resource_check() and use this new function.
This is to allow the check to be re-used by a subsequent patch.
As suggested by Ben Pfaff
Signed-off-by: Simon Horman
---
v8
* First post
---
ofproto/ofproto-dpif-xlate.c | 1
Hi,
With these patches in place it is possible to use all group types
defined in OpenFlow1.3.
I previously indicated that I was not planning to implement select groups.
However, I thought better of it and this series includes an implementation.
In order to aid review the series is available in g
As per the OpenFlow1.3.2 specification, a flow mod should fail
if it references a non-existent group.
The change in this patch appears to be necessary to satisfy that
constraint. It is unclear to me whether or not is is sufficient.
Signed-off-by: Simon Horman
---
v8
* First post
---
ofproto/o
This is a first step towards implementing the dpif side of groups.
In order to be useful the action translation code needs
to be taught about groups.
Signed-off-by: Simon Horman
---
v8
* As suggested by Ben Pfaff
* group_get_stats(): Use ogs->bucket_stats in place of bogus calculation of
Select bucket from those that are alive based on a hash of the destination
ethernet address of the packet.
Support for weights is proposed by a subsequent patch.
The selection is based on a hash of the destination ethernet
address of the flow. It should be possible to extend
this to cover a hash
Signed-off-by: Simon Horman
---
v8
* First post
---
ofproto/ofproto.c | 4
1 file changed, 4 insertions(+)
diff --git a/ofproto/ofproto.c b/ofproto/ofproto.c
index 6ea7510..229fc55 100644
--- a/ofproto/ofproto.c
+++ b/ofproto/ofproto.c
@@ -528,6 +528,10 @@ ofproto_create(const char *datap
Signed-off-by: Simon Horman
---
v8
* First post
---
ofproto/ofproto-dpif-xlate.c | 24 ++--
ofproto/ofproto.c| 3 ++-
tests/ofproto-dpif.at| 12
tests/ofproto.at | 2 +-
4 files changed, 33 insertions(+), 8 deletions(-)
diff --
Allow translation of indirect and all groups. Also allow insertion of
indirect and all groups by changing the maximum permitted number in the
groups table from 0 to OFPG_MAX.
Implementation note:
After translating the actions for each bucket ctx->flow is reset to its
state prior to translation o
Fast failover groups use the actions in
the first bucket that is alive.
Signed-off-by: Simon Horman
---
v8
* Do not set xlate->exit in xlate_ff_group() if no bucket is alive.
The packet will be dropped anyway if there are no further actions
and if there are further actions they should be pr
Lightly exercise group features
Signed-off-by: Simon Horman
---
v8
* First post
---
tests/ofproto.at | 14 ++
1 file changed, 14 insertions(+)
diff --git a/tests/ofproto.at b/tests/ofproto.at
index cdd824e..03ad346 100644
--- a/tests/ofproto.at
+++ b/tests/ofproto.at
@@ -174,6 +17
--
Bonjour
Je m'excuse pour le dérangement, je voudrais faire
votre connaissance et lier une amitié sincère avec vous, prière de me
répondre. Je promets d'être honnête et de garder une bonne relation avec
vous.
Baisers,
Mlle Macoral Marriet.
___
de
On Tue, Oct 29, 2013 at 3:52 PM, Jesse Gross wrote:
> On Tue, Oct 29, 2013 at 10:12 AM, Pravin B Shelar wrote:
>> diff --git a/datapath/datapath.h b/datapath/datapath.h
>> index 879a830..5a89e0e 100644
>> --- a/datapath/datapath.h
>> +++ b/datapath/datapath.h
>> @@ -53,29 +53,29 @@
>> * up pe
Flow->hash can be used to detect hash collisions and avoid flow key
compare in flow lookup.
Signed-off-by: Pravin B Shelar
---
datapath/flow_table.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/datapath/flow_table.c b/datapath/flow_table.c
index c2a7aa5..ddb14da 1006
We should be looking at 'src_flow' instead of 'flow'. Otherwise,
parsing SCTP through odp_flow_key_to_mask will fail.
Signed-off-by: Gurucharan Shetty
---
lib/odp-util.c |8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/lib/odp-util.c b/lib/odp-util.c
index ce821c5..
On Wed, Oct 30, 2013 at 09:59:42AM -0700, Gurucharan Shetty wrote:
> We should be looking at 'src_flow' instead of 'flow'. Otherwise,
> parsing SCTP through odp_flow_key_to_mask will fail.
>
> Signed-off-by: Gurucharan Shetty
Good catch! Be sure to backport, if necessary.
Acked-by: Ben Pfaff
On Wed, Oct 30, 2013 at 10:33:31AM -0200, Flavio Leitner wrote:
> On Tue, Oct 29, 2013 at 11:13:17AM -0700, Ben Pfaff wrote:
> > On Tue, Oct 29, 2013 at 03:15:58PM -0200, Flavio Leitner wrote:
> > > On Tue, Oct 29, 2013 at 08:37:58AM -0700, Ben Pfaff wrote:
> > > > On Tue, Oct 29, 2013 at 10:51:02A
On Wed, Oct 30, 2013 at 9:43 AM, Pravin B Shelar wrote:
> Flow->hash can be used to detect hash collisions and avoid flow key
> compare in flow lookup.
>
> Signed-off-by: Pravin B Shelar
Acked-by: Jesse Gross
___
dev mailing list
dev@openvswitch.org
h
On Wed, Oct 30, 2013 at 10:28:31AM -0700, Ben Pfaff wrote:
> On Wed, Oct 30, 2013 at 10:33:31AM -0200, Flavio Leitner wrote:
> > On Tue, Oct 29, 2013 at 11:13:17AM -0700, Ben Pfaff wrote:
> > > On Tue, Oct 29, 2013 at 03:15:58PM -0200, Flavio Leitner wrote:
> > > > On Tue, Oct 29, 2013 at 08:37:58A
On Wed, Oct 30, 2013 at 04:15:05PM -0200, Flavio Leitner wrote:
> On Wed, Oct 30, 2013 at 10:28:31AM -0700, Ben Pfaff wrote:
> > On Wed, Oct 30, 2013 at 10:33:31AM -0200, Flavio Leitner wrote:
> > > On Tue, Oct 29, 2013 at 11:13:17AM -0700, Ben Pfaff wrote:
> > > > On Tue, Oct 29, 2013 at 03:15:58P
The netflow code has its tentacles all over the ofproto-dpif module.
This is fine today, but in future facets, which correspond roughly to
netflow_flows, will be retired. In preparation, this patch hides as
much implementation detail as possible inside the netflow module.
Signed-off-by: Ethan Jac
Commit bdebeece5 on git.openvswitch.org (lacp: Require successful LACP
negotiations when configured.) makes successful LACP negotiation
mandatory for the bond to come UP. This patch provides a configuration
option to bring up the bond by falling back to active-backup mode on
LACP negotiation failur
On Tue, Oct 29, 2013 at 6:16 PM, Alexei Starovoitov
wrote:
> On Tue, Oct 29, 2013 at 5:56 PM, Jesse Gross wrote:
>> On Tue, Oct 29, 2013 at 3:57 PM, Alexei Starovoitov
>> wrote:
>>> On Tue, Oct 29, 2013 at 3:00 PM, Jesse Gross wrote:
On Tue, Oct 29, 2013 at 11:19 AM, Alexei Starovoitov
>>>
Feature #20543.
Requested-by: Ronghua Zhang
Signed-off-by: Ben Pfaff
---
ofproto/ofproto-dpif.c | 123 ++-
ofproto/ofproto-unixctl.man | 57 +++-
tests/ofproto-dpif.at | 19 +++
3 files changed, 172 insertions(+), 27 del
Signed-off-by: Ben Pfaff
---
ofproto/ofproto-dpif.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/ofproto/ofproto-dpif.c b/ofproto/ofproto-dpif.c
index 7e1d057..d735507 100644
--- a/ofproto/ofproto-dpif.c
+++ b/ofproto/ofproto-dpif.c
@@ -5748,7 +5748,7 @@ ofproto_dpif_uni
This new function will have an additional caller in an upcoming commit.
Signed-off-by: Ben Pfaff
---
ofproto/ofproto-dpif.c | 109 +---
tests/ofproto-dpif.at |8 ++--
2 files changed, 70 insertions(+), 47 deletions(-)
diff --git a/ofproto/ofprot
'struct dp_netdev_flow' is currently being instantiated as 'flow'.
An upcoming commit introduces a classifier to dpif-netdev
which uses 'struct flow' at a few places and that can cause
confusion while reading code.
Signed-off-by: Gurucharan Shetty
---
lib/dpif-netdev.c | 135 +++
Instead of an exact match flow table, we introduce a classifier.
This enables mega-flows in userspace datapath.
Signed-off-by: Gurucharan Shetty
---
lib/dpif-netdev.c | 87 ++
tests/ofproto-dpif.at | 142 +
2 file
I pushed it to master.
Thanks.
On Wed, Oct 30, 2013 at 10:52 AM, Jesse Gross wrote:
> On Wed, Oct 30, 2013 at 9:43 AM, Pravin B Shelar wrote:
>> Flow->hash can be used to detect hash collisions and avoid flow key
>> compare in flow lookup.
>>
>> Signed-off-by: Pravin B Shelar
>
> Acked-by: Jes
This corrects what appears to be a typo by replacing
a duplicate icmp_type test with an icmp_code test.
Signed-off-by: Simon Horman
---
tests/ovs-ofctl.at | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/ovs-ofctl.at b/tests/ovs-ofctl.at
index 7bb5b6e..e399479 100644
---
Currently if a mask is supplied for an unmaskable match then NOT_REACHED()
is called. The effect of this for a user calling ovs-vsctl with a match
that includes a mask which is not permitted is to politely inform them of
the error of their ways by calling abort and segfaulting.
This patch takes an
Hi,
the primary purpose of this series is to return an error message rather
than segfaulting if ovs-ofctl add-flow is called with a mask for a match
that does not accept a mask. The second patch in the series does that
and updates the testsuite to exercise this.
The first patch in the series corr
38 matches
Mail list logo
