From: Edouard Bourguignon
Signed-off-by: Edouard Bourguignon
Signed-off-by: Gurucharan Shetty
---
AUTHORS |1 +
rhel/README.RHEL | 19 +++
rhel/etc_sysconfig_network-scripts_ifdown-ovs |2 +-
rhel/etc_
On Mon, Oct 14, 2013 at 07:29:34AM -0700, Gurucharan Shetty wrote:
> From: Edouard Bourguignon
>
> Signed-off-by: Edouard Bourguignon
> Signed-off-by: Gurucharan Shetty
Acked-by: Ben Pfaff
___
dev mailing list
dev@openvswitch.org
http://openvswitch.
On Wed, Oct 09, 2013 at 02:57:55PM -0700, Jarno Rajahalme wrote:
>
> On Oct 8, 2013, at 5:13 PM, Ben Pfaff wrote:
>
> > The issue is not the minimum Ethernet frame size but the minimum IP
> > fragment size. IP fragments are 8-byte aligned and a multiple of 8
> > bytes in length. One way to imp
On Mon, Oct 14, 2013 at 8:12 AM, Ben Pfaff wrote:
> On Wed, Oct 09, 2013 at 02:57:55PM -0700, Jarno Rajahalme wrote:
> >
> > On Oct 8, 2013, at 5:13 PM, Ben Pfaff wrote:
> >
> > > The issue is not the minimum Ethernet frame size but the minimum IP
> > > fragment size. IP fragments are 8-byte al
On Mon, Oct 14, 2013 at 8:06 AM, Ben Pfaff wrote:
> On Mon, Oct 14, 2013 at 07:29:34AM -0700, Gurucharan Shetty wrote:
>> From: Edouard Bourguignon
>>
>> Signed-off-by: Edouard Bourguignon
>> Signed-off-by: Gurucharan Shetty
>
> Acked-by: Ben Pfaff
Thanks. Applied to master.
__
Signed-off-by: Gurucharan Shetty
---
lib/odp-util.c |3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/lib/odp-util.c b/lib/odp-util.c
index c84f28f..3870e56 100644
--- a/lib/odp-util.c
+++ b/lib/odp-util.c
@@ -1411,7 +1411,8 @@ generate_all_wildcard_mask(struct ofpbuf *ofp,
With mega-flows, many flows in the kernel datapath are wildcarded.
For someone that is debugging a system and wants to find a particular
flow and its actions, it is a little hard to zero-in on the flow
because some fields are wildcarded.
With the filter='$filter' option, we can now filter on the o
Tabs and spaces got mixed up, making the code harder to read.
Signed-off-by: Gurucharan Shetty
---
lib/odp-util.c | 38 +++---
1 file changed, 19 insertions(+), 19 deletions(-)
diff --git a/lib/odp-util.c b/lib/odp-util.c
index 5c7ccfb..c84f28f 100644
--- a/lib
On Mon, Oct 14, 2013 at 08:23:58AM -0700, Gurucharan Shetty wrote:
> Tabs and spaces got mixed up, making the code harder to read.
>
> Signed-off-by: Gurucharan Shetty
I didn't really read this. I'm in favor of proper formatting.
Acked-by: Ben Pfaff
___
On Mon, Oct 14, 2013 at 08:23:59AM -0700, Gurucharan Shetty wrote:
> Signed-off-by: Gurucharan Shetty
Acked-by: Ben Pfaff
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
On Tue, Oct 8, 2013 at 1:46 PM, Mark Hamilton wrote:
> This facilitates adding filtering since limiting output based on the in_port
> is a natural first step.
>
> Script mode was not changed allowing output to be piped through grep to
> filter content.
I will need a Signed-off-by line.
(You don'
We have a least recently used algorithm for assigning ofport values
to newly created ports. i.e., when we don't have any unused ofport
numbers, we use ofport numbers from the oldest deleted port.
What this means is that after using ~65000 previously unused ofport
numbers, we will have to go through
On Fri, Oct 11, 2013 at 01:23:29PM +0900, Simon Horman wrote:
> Implementation note:
>
> All actions which modify a field are added to the action set
> at the point where "set" actions should be added. In general
> modifying a field many times is the same as only modifying it
> the last time so th
Kernel 3.11 has support for extended GRE API required for
OVS datapath, But vxlan still needs out of tree tunneling
compatibility. Therefore to simplify, all tunneling modules
are forced to use compat tunneling.
CC: James Page
Signed-off-by: Pravin B Shelar
---
FAQ
Sets mask bits for the given field and its prerequisite fields.
Needed for later patches.
Signed-off-by: Jarno Rajahalme
---
lib/meta-flow.c | 37 +
lib/meta-flow.h | 15 +--
2 files changed, 46 insertions(+), 6 deletions(-)
diff --git a/lib/m
Since at the datapath interface we do not have set actions for
individual fields, but larger sets of fields for a given protocol
layer, the set action will in practice only ever apply to exactly
matched flows for the given protocol layer. For example, if the
reg_load changes the IP TTL, the corres
These are auto-generated files, so it would be better not to keep them
inside Open vSwitch repository.
Behaviour before this patch was that if dot tool was not present on
the system, then ovs-vswitchd.conf.db.5 would have used pre-generated
vswitch.pic file that was already checked in the git repo
I forgot to mention that this function makes sense only for writeable fields.
Hence some of the cases could be changed to NOT_REACHED's, but maybe that is
not important.
Jarno
On Oct 14, 2013, at 3:57 PM, Jarno Rajahalme wrote:
> Sets mask bits for the given field and its prerequisite field
On 14 October 2013 15:55, Ansis Atteka wrote:
> These are auto-generated files, so it would be better not to keep them
> inside Open vSwitch repository.
>
> Behaviour before this patch was that if dot tool was not present on
> the system, then ovs-vswitchd.conf.db.5 would have used pre-generated
On Fri, Oct 11, 2013 at 02:17:13PM -0700, Alex Wang wrote:
> Commit 91d6cd12 (ofproto-dpif: Move send_packet() to ofproto-dpif-xlate
> module.) introduced the bug that frees the "struct ofpbuf" in 'xout' when
> the struct is not initialized. This commit fixes the bug.
>
> Reported-by: Simon Horma
These are auto-generated files, so it would be better not to keep them
inside Open vSwitch repository.
Behaviour before this patch was that if dot tool was not present on
the system, then ovs-vswitchd.conf.db.5 would have used pre-generated
vswitch.pic file that was already checked in the git repo
Thanks for your confirmation, ;D
On Mon, Oct 14, 2013 at 5:57 PM, Simon Horman wrote:
> On Fri, Oct 11, 2013 at 02:17:13PM -0700, Alex Wang wrote:
> > Commit 91d6cd12 (ofproto-dpif: Move send_packet() to ofproto-dpif-xlate
> > module.) introduced the bug that frees the "struct ofpbuf" in 'xout'
Looks close, just some nits.
> +/* latch that controls the exit of monitor thread. */
> +static struct latch monitor_exit_latch;
I'm not sure this comment is adding much that isn't clear from the
variable's type and name. But if you think it's necessary, perhaps it
would be better as simply "Cau
Acked-by: Ethan Jackson
(could you fold my acked into the commit message so I remember I've
reviewed it please?)
Ethan
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
Acked-by: Ethan Jackson
On Fri, Oct 11, 2013 at 5:16 PM, Alex Wang wrote:
> This commit adds a new function "bfd_wake_time()" that returns the
> next wakeup time associated with the "struct bfd".
>
> Signed-off-by: Alex Wang
> ---
>
> v3 -> v4:
> - rebase to master.
>
> v2 -> v3:
> - fix the c
Np, I'll do that in V5
On Mon, Oct 14, 2013 at 6:09 PM, Ethan Jackson wrote:
> Acked-by: Ethan Jackson
>
> (could you fold my acked into the commit message so I remember I've
> reviewed it please?)
>
> Ethan
>
___
dev mailing list
dev@openvswitch.org
Acked-by: Ethan Jackson
On Fri, Oct 11, 2013 at 5:16 PM, Alex Wang wrote:
> This commit adds a new function "cfm_wake_time()" that returns the
> next wakeup time associated with the "struct cfm".
>
> Signed-off-by: Alex Wang
>
> ---
>
> v3 -> v4:
> - rebase to master.
>
> v2 -> v3:
> - fix the
Thanks for the review!
> +/* latch that controls the exit of monitor thread. */
> > +static struct latch monitor_exit_latch;
>
> I'm not sure this comment is adding much that isn't clear from the
> variable's type and name. But if you think it's necessary, perhaps it
> would be better as simply
> On Wed, Oct 09, 2013 at 04:49:06PM +0900, YAMAMOTO Takashi wrote:
>> Signed-off-by: YAMAMOTO Takashi
>
> ...
>
>> + This requires the following.
>> + - Change the default table-miss action (in the absense of table-miss
>> +entry) from packet_in to drop for OF1.3+. Decide wha
On Mon, Oct 14, 2013 at 03:20:43PM -0700, Ben Pfaff wrote:
> On Fri, Oct 11, 2013 at 01:23:29PM +0900, Simon Horman wrote:
> > Implementation note:
> >
> > All actions which modify a field are added to the action set
> > at the point where "set" actions should be added. In general
> > modifying a
Looks good to me, just some nits.
In the commit message "iterated" => "iterated over". "adds a hugh" =>
"adds a huge". "uses heap" => "uses a heap". "of monitored port" =>
"of monitored ports". "ports that are timeout" => "ports that have
timed out".
> +heap_change(&monitor_heap, &mpor
> I can use a global value. but the tid is necessary in that we need to call
> "join()" and wait for the termination of monitor thread.
Yep, sorry I wasn't clear. You definitely need to keep the tid
around, it's just odd that we're heap allocating it.
Ethan
_
On Mon, Oct 14, 2013 at 6:27 PM, Ethan Jackson wrote:
> > I can use a global value. but the tid is necessary in that we need to
> call
> > "join()" and wait for the termination of monitor thread.
>
> Yep, sorry I wasn't clear. You definitely need to keep the tid
> around, it's just odd that we'
Thanks for the fix :)
On Mon, Oct 14, 2013 at 06:07:13PM -0700, Alex Wang wrote:
> Thanks for your confirmation, ;D
>
>
> On Mon, Oct 14, 2013 at 5:57 PM, Simon Horman wrote:
>
> > On Fri, Oct 11, 2013 at 02:17:13PM -0700, Alex Wang wrote:
> > > Commit 91d6cd12 (ofproto-dpif: Move send_packet(
Until now, the "ovsdb-server/add-remote and remove-remote with --monitor"
test killed ovsdb-server with SIGSEGV twice. Each time, the "--monitor"
option caused the supervisor process to restart the child, but the second
time it incurred a 10-second delay intended to prevent the daemon from
wasting
Hey Ben,
I just copied your commit log. Hope you are fine with this patch.
On Mon, Oct 14, 2013 at 6:35 PM, Alex Wang wrote:
> Until now, the "ovsdb-server/add-remote and remove-remote with --monitor"
> test killed ovsdb-server with SIGSEGV twice. Each time, the "--monitor"
> option caused t
On Tue, Oct 15, 2013 at 10:20:04AM +0900, YAMAMOTO Takashi wrote:
> > On Wed, Oct 09, 2013 at 04:49:06PM +0900, YAMAMOTO Takashi wrote:
> >> Signed-off-by: YAMAMOTO Takashi
> >> + This requires the following.
> >> + - Change the default table-miss action (in the absense of table-miss
> >
> On Tue, Oct 15, 2013 at 10:20:04AM +0900, YAMAMOTO Takashi wrote:
>> > On Wed, Oct 09, 2013 at 04:49:06PM +0900, YAMAMOTO Takashi wrote:
>> >> Signed-off-by: YAMAMOTO Takashi
>> >> + This requires the following.
>> >> + - Change the default table-miss action (in the absense of
>> >> t
On Mon, Oct 14, 2013 at 06:35:09PM -0700, Alex Wang wrote:
> Until now, the "ovsdb-server/add-remote and remove-remote with --monitor"
> test killed ovsdb-server with SIGSEGV twice. Each time, the "--monitor"
> option caused the supervisor process to restart the child, but the second
> time it inc
On Mon, Oct 14, 2013 at 05:56:40PM -0700, Ansis Atteka wrote:
> These are auto-generated files, so it would be better not to keep them
> inside Open vSwitch repository.
>
> Behaviour before this patch was that if dot tool was not present on
> the system, then ovs-vswitchd.conf.db.5 would have used
I forgot the signoff, will resend it, thx
On Mon, Oct 14, 2013 at 9:11 PM, Ben Pfaff wrote:
> On Mon, Oct 14, 2013 at 06:35:09PM -0700, Alex Wang wrote:
> > Until now, the "ovsdb-server/add-remote and remove-remote with --monitor"
> > test killed ovsdb-server with SIGSEGV twice. Each time, the
Until now, the "ovsdb-server/add-remote and remove-remote with --monitor"
test killed ovsdb-server with SIGSEGV twice. Each time, the "--monitor"
option caused the supervisor process to restart the child, but the second
time it incurred a 10-second delay intended to prevent the daemon from
wasting
On Mon, Oct 14, 2013 at 10:12:59PM -0700, Alex Wang wrote:
> Until now, the "ovsdb-server/add-remote and remove-remote with --monitor"
> test killed ovsdb-server with SIGSEGV twice. Each time, the "--monitor"
> option caused the supervisor process to restart the child, but the second
> time it inc
Thanks Ethan for the review,
In the commit message "iterated" => "iterated over". "adds a hugh" =>
> "adds a huge". "uses heap" => "uses a heap". "of monitored port" =>
> "of monitored ports". "ports that are timeout" => "ports that have
> timed out".
>
>
I'll fix these. Thanks,
> > +
44 matches
Mail list logo