On Thu, Sep 26, 2013 at 09:42:20AM +0900, Simon Horman wrote:
> On Wed, Sep 25, 2013 at 09:09:27AM -0700, Ben Pfaff wrote:
> > On Wed, Sep 25, 2013 at 01:31:07PM +0900, Simon Horman wrote:
> > > Rather than tracking the MPLS depth as a field in the
> > > flow, which is an entirely poor place for it
Thanks for the review,
On Wed, Sep 25, 2013 at 6:11 PM, Ethan Jackson wrote:
> Couple of high level questions about this.
>
> Instead of protecting coverage_run() with a mutex and calling it in
> time_poll(), why not just call it once at the beginning of the main
> thread's run loop? If we do t
ovs-flow rehash does not touch mega flow list. Following patch
moves it dp struct datapath. Avoid one extra indirection for
accessing mega-flow list head on every packet receive.
Signed-off-by: Pravin B Shelar
---
v2:
No change.
---
datapath/datapath.c | 81 +---
datapath/da
Hides mega-flow implementation in flow_table.c rather than
datapath.c. This also helps next patch.
Signed-off-by: Pravin B Shelar
---
v2:
No change.
---
datapath/datapath.c | 27 +++---
datapath/flow_table.c | 136 -
datapath/flow_table.h
Following patch breaks down ovs_mutex into multiple locks. This
patch specifically targets flow-install. By breaking down
ovs-locking parallel flow-installs are possible.
Signed-off-by: Pravin B Shelar
v2:
get rid of mask_list lock.
---
datapath/datapath.c | 90 +---
da
Following is Ethan's reply from a almost same RFC patch I sent just to him
earlier,
Repost it here, so that all following comments can be made on this thread.
"""
In xlate_send_packet() you aren't allow to hold the xlate_rwlock while
calling xlate_actions(). There are two options to deal with th
Using the latest clang I get a lot of warnings about unused variables
and functions. After a while it becomes difficult to locate genuine
warnings, so it is best to bet rid of these.
Signed-off-by: Jarno Rajahalme
---
v2: Address Ben's comments.
lib/aes128.c | 335 --
In xlate_send_packet() you aren't allow to hold the xlate_rwlock while
> calling xlate_actions(). There are two options to deal with this.
> (1) make a new xlate_actions_unsafe() function internal to
> ofproto-dpif-xlate which doesn't take the xlate_rwlock, and call that.
> (2) Take the xlate_rw
Signed-off-by: Gurucharan Shetty
---
utilities/ovs-ofctl.8.in |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/utilities/ovs-ofctl.8.in b/utilities/ovs-ofctl.8.in
index 526e12c..55547f1 100644
--- a/utilities/ovs-ofctl.8.in
+++ b/utilities/ovs-ofctl.8.in
@@ -1514,7 +1514,7 @
Following is Ethan's reply from a similar RFC patch I sent just to him
earlier,
Repost it here, so that all following comments can be made on this thread.
"""
At a high level, this looks much more in the direction I was hoping
for. I've got a couple of structural comments, some of which are
dire
On Thu, Sep 26, 2013 at 09:12:07AM -0700, Gurucharan Shetty wrote:
> Signed-off-by: Gurucharan Shetty
Acked-by: Ben Pfaff
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
> """
> At a high level, this looks much more in the direction I was hoping
> for. I've got a couple of structural comments, some of which are
> directly contradictory to things I told you earlier =) (sorry bout
> that).
>
> I'd ditch struct monitor and just deal with the hmap directly. It's
> no
On Wed, Sep 25, 2013 at 11:16:15PM +, Pritesh Kothari (pritkoth) wrote:
>
> On Sep 25, 2013, at 3:56 PM, Ben Pfaff wrote:
>
> > On Wed, Sep 25, 2013 at 01:28:33PM -0700, Justin Pettit wrote:
> >> Thanks for writing this up. I think the example may be clearer if
> >> you defined the flow in t
From: Jarno Rajahalme
These variables and functions are unused but we don't want to remove
their definitions.
Found by Clang.
Signed-off-by: Jarno Rajahalme
Signed-off-by: Ben Pfaff
---
lib/ofp-actions.c |6 +++---
lib/vlandev.c |2 +-
2 files changed, 4 insertions(+), 4 deletion
From: Jarno Rajahalme
Found by Clang.
Signed-off-by: Jarno Rajahalme
Signed-off-by: Ben Pfaff
---
lib/aes128.c | 335
lib/dpif.c |2 -
lib/flow.c |3 -
lib/lockfile.c |1 -
lib/mac-learning
On Thu, Sep 26, 2013 at 09:40:52AM -0700, Jarno Rajahalme wrote:
> Using the latest clang I get a lot of warnings about unused variables
> and functions. After a while it becomes difficult to locate genuine
> warnings, so it is best to bet rid of these.
>
> Signed-off-by: Jarno Rajahalme
> ---
>
Ethan writes:
> Ben, how do you feel about ditching ofproto_dpif's stats member? It
> doesn't seem like a particularly important feature to me, and I think
> it's going to be annoying to implement in a thread safe manner.
Isn't it trivial to throw a mutex around it? It's used in simple ways
and
On Thu, Sep 26, 2013 at 05:34:49PM +0900, Simon Horman wrote:
> On Thu, Sep 26, 2013 at 09:42:20AM +0900, Simon Horman wrote:
> > On Wed, Sep 25, 2013 at 09:09:27AM -0700, Ben Pfaff wrote:
> > > On Wed, Sep 25, 2013 at 01:31:07PM +0900, Simon Horman wrote:
> > > > Rather than tracking the MPLS dept
On Wed, Sep 25, 2013 at 10:50:13AM -0700, Gurucharan Shetty wrote:
> On Tue, Sep 24, 2013 at 10:52 AM, Ben Pfaff wrote:
> > On Mon, Aug 26, 2013 at 10:25:39AM -0700, Gurucharan Shetty wrote:
> >> If there is a lot of churn in creation and deletion of
> >> interfaces, we may end up recycling the of
On Wed, Sep 25, 2013 at 09:47:00AM -0700, Shih-Hao Li wrote:
> From: Shih-Hao Li
>
> When output to a file with "--unlimited" unset,
> only allow 90% of the free disk space to be used.
I applied this to master, thanks.
___
dev mailing list
dev@openvswi
Yeah it's trivial, I just think the feature is a bit odd/confusing.
But if you think it's useful we'll keep it. Alex could you just slap
a mutex around it?
Ethan
On Thu, Sep 26, 2013 at 12:32 PM, Ben Pfaff wrote:
> Ethan writes:
>> Ben, how do you feel about ditching ofproto_dpif's stats member
On Thu, Sep 26, 2013 at 12:59 PM, Ben Pfaff wrote:
> On Wed, Sep 25, 2013 at 10:50:13AM -0700, Gurucharan Shetty wrote:
>> On Tue, Sep 24, 2013 at 10:52 AM, Ben Pfaff wrote:
>> > On Mon, Aug 26, 2013 at 10:25:39AM -0700, Gurucharan Shetty wrote:
>> >> If there is a lot of churn in creation and de
>> Sure. How about this, then.
>
> --8<--cut here-->8--
>
> From: Ben Pfaff
> Date: Wed, 25 Sep 2013 15:56:21 -0700
> Subject: [PATCH] FAQ: Explain why allowing only IP traffic breaks IP
> connectivity.
>
> Signed-off-by: Ben Pfaff
> ---
> FAQ |
On Thu, Sep 26, 2013 at 01:16:10PM -0700, Ethan Jackson wrote:
> Yeah it's trivial, I just think the feature is a bit odd/confusing.
> But if you think it's useful we'll keep it.
Bug #7551, cited in the commit that introduced this feature, said:
Packets that are either synthesized or consumed
On Thu, Sep 26, 2013 at 08:21:33PM +, Pritesh Kothari (pritkoth) wrote:
> >> Sure. How about this, then.
> >
> > --8<--cut here-->8--
> >
> > From: Ben Pfaff
> > Date: Wed, 25 Sep 2013 15:56:21 -0700
> > Subject: [PATCH] FAQ: Explain why allow
From: Shih-Hao Li
Previously the log-days parameter can only support rotated logs
based on their numbered filename extension. Thus it can not be
used for other types of log filenames. This patch changes it to
be based on file last modification time.
Issue: #19671
---
utilities/bugtool/ovs-bugto
On Wed, Sep 25, 2013 at 06:11:12PM -0700, Ethan Jackson wrote:
> Ben, could we do the same for coverage_clear()? It seems a bit odd to
> me that time_poll() calls this stuff in a multithreaded environment.
> That said, perhaps we should leave it as it is, and do something more
> comprehensive to d
On Thu, Sep 26, 2013 at 12:24:56PM -0700, Ben Pfaff wrote:
> On Thu, Sep 26, 2013 at 05:34:49PM +0900, Simon Horman wrote:
> > On Thu, Sep 26, 2013 at 09:42:20AM +0900, Simon Horman wrote:
> > > On Wed, Sep 25, 2013 at 09:09:27AM -0700, Ben Pfaff wrote:
> > > > On Wed, Sep 25, 2013 at 01:31:07PM +0
Rather than tracking the MPLS depth as a field in the
flow, which is an entirely poor place for it, just track
the delta to the MPLS depth during translation.
This logic was developed while implementing recirculation
and intended to be used to detect when recirculation should
occur. This variant o
From: Joe Stringer
This patch adds a new compatibility enum for use with MPLS, so that the
differing behaviour between OpenFlow 1.2 and 1.3 can be implemented in
ofproto-dpif-xlate.
Signed-off-by: Joe Stringer
Signed-off-by: Simon Horman
---
v2.36 - v2.39
* No change
v2.35
* First post
---
Hi,
This series implements MPLS actions and matches based on work by
Ravi K, Leo Alterman, Yamahata-san and Joe Stringer.
This series provides two changes
* Patches 1 - 5
Provide user-space support for the VLAN/MPLS tag insertion order
up to and including OpenFlow 1.2, and the different ord
From: Joe Stringer
This patch modifies the push_mpls behaviour to follow the OpenFlow 1.3
specification in the presence of VLAN tagged packets. From the spec:
"Newly pushed tags should always be inserted as the outermost tag in the
outermost valid location for that tag. When a new VLAN tag is pu
Allow datapath to recognize and extract MPLS labels into flow keys
and execute actions which push, pop, and set labels on packets.
Based heavily on work by Leo Alterman, Ravi K, Isaku Yamahata and Joe Stringer.
Cc: Ravi K
Cc: Leo Alterman
Cc: Isaku Yamahata
Cc: Joe Stringer
Signed-off-by: Sim
From: Joe Stringer
This allows for future patches to pass different tci values to
commit_vlan_action() without passing an entire flow structure.
Signed-off-by: Joe Stringer
Signed-off-by: Simon Horman
---
v2.36 - v2.39
* No change
v2.35
* First post
---
lib/odp-util.c | 12 ++--
1
From: Joe Stringer
This patch adds new ofpact_from_openflow13() and
ofpacts_from_openflow13() functions parallel to the existing ofpact
handling code. In the OpenFlow 1.3 version, push_mpls is handled
differently, but all other actions are handled by the existing code.
For push_mpls, ofpact_push
Break out deacceleration portion of vlan_push into vlan_put
so that it may be re-used by mpls_push.
For both vlan_push and mpls_push if there is an accelerated VLAN tag
present then it should be deaccelerated, adding it to the data of
the skb, before the new tag is added.
Signed-off-by: Simon Hor
From: Joe Stringer
OpenFlow 1.2 and 1.3 differ on their handling of MPLS actions in the
presence of VLAN tags. To allow correct behaviour to be committed in
each situation, this patch adds a second round of VLAN tag action
handling to commit_odp_actions(), which occurs after MPLS actions. This
is
This field has always been fully maskable, but the comment here has always
said that it is non-maskable.
EXT-101.
CC: Jean Tourrilhes
Signed-off-by: Ben Pfaff
---
include/openflow/nicira-ext.h |5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/include/openflow/nicira-ex
Whoops, that was probably me.
Acked-by: Justin Pettit
Thanks,
--Justin
On Sep 26, 2013, at 9:33 PM, Ben Pfaff wrote:
> This field has always been fully maskable, but the comment here has always
> said that it is non-maskable.
>
> EXT-101.
> CC: Jean Tourrilhes
> Signed-off-by: Ben Pfaff
Further research indicates that I still had the story wrong. Initially
it was not maskable but Simon Horman made it maskable with commit
3245502404 (OXM: Allow masking of IPv6 Flow Label) without updating
the comment. I guess the OXM prefix on that commit message subject
means that he believe
40 matches
Mail list logo
