[ovs-dev] [PATCH] utilities: add ovs-dpctl-top to .gitignore

2013-09-19 Thread Lorand Jakab
Signed-off-by: Lorand Jakab --- utilities/.gitignore |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/utilities/.gitignore b/utilities/.gitignore index a0bd97f..4972685 100644 --- a/utilities/.gitignore +++ b/utilities/.gitignore @@ -13,6 +13,8 @@ /ovs-ctl /ovs-dpctl

[ovs-dev] [PATCH] datapath: add linux/utils.c to .gitignore

2013-09-19 Thread Lorand Jakab
Signed-off-by: Lorand Jakab --- datapath/linux/.gitignore |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/datapath/linux/.gitignore b/datapath/linux/.gitignore index 8748613..d74ad3c 100644 --- a/datapath/linux/.gitignore +++ b/datapath/linux/.gitignore @@ -34,6 +34,7 @@

Re: [ovs-dev] [PATCH v2.39 6/7] datapath: Break out deacceleration portion of vlan_push

2013-09-19 Thread Simon Horman
On Fri, Sep 13, 2013 at 03:07:12PM -0700, Jesse Gross wrote: > On Mon, Sep 9, 2013 at 12:20 AM, Simon Horman wrote: > > diff --git a/datapath/actions.c b/datapath/actions.c > > index 30ea1d2..6741d81 100644 > > --- a/datapath/actions.c > > +++ b/datapath/actions.c > > @@ -105,22 +105,29 @@ static

Re: [ovs-dev] [PATCH v2.39 7/7] datapath: Add basic MPLS support to kernel

2013-09-19 Thread Simon Horman
On Mon, Sep 16, 2013 at 03:38:21PM -0500, Jesse Gross wrote: > On Mon, Sep 9, 2013 at 12:20 AM, Simon Horman wrote: > > diff --git a/datapath/actions.c b/datapath/actions.c > > index 6741d81..2335014 100644 > > --- a/datapath/actions.c > > +++ b/datapath/actions.c > > +/* Push MPLS after the ether

Re: [ovs-dev] [PATCH v2.39 7/7] datapath: Add basic MPLS support to kernel

2013-09-19 Thread Jesse Gross
On Wed, Sep 18, 2013 at 5:07 PM, Simon Horman wrote: > On Tue, Sep 17, 2013 at 11:38:18AM -0700, Pravin Shelar wrote: >> On Mon, Sep 9, 2013 at 12:20 AM, Simon Horman wrote: >> > diff --git a/datapath/datapath.h b/datapath/datapath.h >> > index 5d50dd4..babae3b 100644 >> > --- a/datapath/datapath

Re: [ovs-dev] [PATCH] datapath: add linux/utils.c to .gitignore

2013-09-19 Thread Jesse Gross
On Thu, Sep 19, 2013 at 5:57 AM, Lorand Jakab wrote: > > Signed-off-by: Lorand Jakab Thanks, I applied this. ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH v2.39 7/7] datapath: Add basic MPLS support to kernel

2013-09-19 Thread Jesse Gross
On Thu, Sep 19, 2013 at 10:57 AM, Simon Horman wrote: > On Mon, Sep 16, 2013 at 03:38:21PM -0500, Jesse Gross wrote: >> On Mon, Sep 9, 2013 at 12:20 AM, Simon Horman wrote: >> > @@ -616,6 +736,13 @@ int ovs_execute_actions(struct datapath *dp, struct >> > sk_buff *skb) >> > goto

Re: [ovs-dev] [reordering v2 2/2] ofproto-dpif-upcall: Use correct actions for slow-pathed flows.

2013-09-19 Thread Ben Pfaff
On Tue, Sep 17, 2013 at 05:27:50PM -0700, Jarno Rajahalme wrote: > > On Sep 17, 2013, at 4:08 PM, Ben Pfaff wrote: > > > When a flow is slow-pathed, every packet needs to translated separately > > and treated accordingly. The code here (and the code that preceded it) > > did translate every pac

[ovs-dev] [PATCH] cfm: Prevent interval fault when demand mode is enabled on one end.

2013-09-19 Thread Alex Wang
This commit prevents cfm from raising 'interval' fault when demand mode is only enabled on one end of link. Signed-off-by: Alex Wang --- lib/cfm.c| 18 +--- tests/automake.mk|1 + tests/cfm.at | 57 ++ te

Re: [ovs-dev] [reordering v2 1/2] ofproto-dpif-upcall: Forward packets in order of arrival.

2013-09-19 Thread Ben Pfaff
On Tue, Sep 17, 2013 at 05:24:02PM -0700, Jarno Rajahalme wrote: > I like this! Much clearer, especially when comparing to the upcall > processing in the past monolithic ofproto-dpif. > > One small comment about a comment below, > > Jarno > > Acked-by: Jarno Rajahalme Thanks for the review,

Re: [ovs-dev] [PATCH v2 2/2] ofproto-dpif-upcall: Give each miss_handler thread a unique name.

2013-09-19 Thread Ben Pfaff
Thanks. Are you happy with patch 1 also? On Thu, Sep 19, 2013 at 12:42:00PM -0700, Ethan Jackson wrote: > Acked-by: Ethan Jackson > > > On Tue, Sep 17, 2013 at 10:02 AM, Ben Pfaff wrote: > > This may occasionally make debugging easier. > > > > Suggested-by: Keith Amidon > > Signed-off-by: Be

Re: [ovs-dev] [reordering v2 1/2] ofproto-dpif-upcall: Forward packets in order of arrival.

2013-09-19 Thread Jarno Rajahalme
Small typo on the first line of the new comment. Acked-by: Jarno Rajahalme On Sep 19, 2013, at 10:59 AM, Ben Pfaff wrote: > On Tue, Sep 17, 2013 at 05:24:02PM -0700, Jarno Rajahalme wrote: >> I like this! Much clearer, especially when comparing to the upcall >> processing in the past monolithi

Re: [ovs-dev] [reordering v2 1/2] ofproto-dpif-upcall: Forward packets in order of arrival.

2013-09-19 Thread Ben Pfaff
On Thu, Sep 19, 2013 at 12:48:19PM -0700, Jarno Rajahalme wrote: > Small typo on the first line of the new comment. Oops, fixed. > Acked-by: Jarno Rajahalme Thank you! ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/de

Re: [ovs-dev] [PATCH] cfm: Prevent interval fault when demand mode is enabled on one end.

2013-09-19 Thread Ethan Jackson
Why not just modify cfm_fault_interval() to check if demand mode is enabled and if so return MAX(cfm->ccm_interval, 500) * 7 / 2? Ethan On Thu, Sep 19, 2013 at 11:39 AM, Alex Wang wrote: > This commit prevents cfm from raising 'interval' fault when demand > mode is only enabled on one end of lin

Re: [ovs-dev] [PATCH v2 1/2] util: Allow set_subprogram_name() to take a printf() format string.

2013-09-19 Thread Ethan Jackson
Acked-by: Ethan Jackson On Tue, Sep 17, 2013 at 10:02 AM, Ben Pfaff wrote: > This will be convenient in an upcoming commit. > > I had to add -Wno-format-zero-length to suppress a GCC warning about a > zero-length format string in this monitor_daemon() call: > set_subprogram_name(""); > I do

Re: [ovs-dev] [PATCH v2 2/2] ofproto-dpif-upcall: Give each miss_handler thread a unique name.

2013-09-19 Thread Ethan Jackson
Oops missed it. Looks fine as well. On Thu, Sep 19, 2013 at 12:43 PM, Ben Pfaff wrote: > Thanks. > > Are you happy with patch 1 also? > > On Thu, Sep 19, 2013 at 12:42:00PM -0700, Ethan Jackson wrote: >> Acked-by: Ethan Jackson >> >> >> On Tue, Sep 17, 2013 at 10:02 AM, Ben Pfaff wrote: >> > T

Re: [ovs-dev] [PATCH] cfm: Prevent interval fault when demand mode is enabled on one end.

2013-09-19 Thread Alex Wang
Thanks Ethan, I really should do that. On Thu, Sep 19, 2013 at 1:27 PM, Ethan Jackson wrote: > Why not just modify cfm_fault_interval() to check if demand mode is > enabled and if so return MAX(cfm->ccm_interval, 500) * 7 / 2? > > Ethan > > On Thu, Sep 19, 2013 at 11:39 AM, Alex Wang wrote: >

Re: [ovs-dev] [PATCH] utilities: add ovs-dpctl-top to .gitignore

2013-09-19 Thread Ben Pfaff
On Thu, Sep 19, 2013 at 03:35:25AM -0700, Lorand Jakab wrote: > > Signed-off-by: Lorand Jakab Applied, thanks. ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

[ovs-dev] [PATCH V2] cfm: Prevent interval fault when demand mode is enabled on one end.

2013-09-19 Thread Alex Wang
This commit prevents cfm from raising 'interval' fault when demand mode is only enabled on one end of link. Signed-off-by: Alex Wang --- v1 -> v2: - simplify the code. --- lib/cfm.c| 12 +++ tests/automake.mk|1 + tests/cfm.at | 57 +

Re: [ovs-dev] [reordering v2 1/2] ofproto-dpif-upcall: Forward packets in order of arrival.

2013-09-19 Thread Ben Pfaff
On Thu, Sep 19, 2013 at 12:48:05PM -0700, Ben Pfaff wrote: > On Thu, Sep 19, 2013 at 12:48:19PM -0700, Jarno Rajahalme wrote: > > Small typo on the first line of the new comment. > > Oops, fixed. > > > Acked-by: Jarno Rajahalme > > Thank you! I applied this to master. Dmitry: This cause of pa

Re: [ovs-dev] [PATCH v2 2/2] ofproto-dpif-upcall: Give each miss_handler thread a unique name.

2013-09-19 Thread Ethan Jackson
Acked-by: Ethan Jackson On Tue, Sep 17, 2013 at 10:02 AM, Ben Pfaff wrote: > This may occasionally make debugging easier. > > Suggested-by: Keith Amidon > Signed-off-by: Ben Pfaff > --- > ofproto/ofproto-dpif-upcall.c |2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git

Re: [ovs-dev] [PATCH] Release Open vSwitch 1.11.1.

2013-09-19 Thread Ben Pfaff
On Wed, Sep 18, 2013 at 01:12:43PM -0700, Justin Pettit wrote: > Signed-off-by: Justin Pettit Acked-by: Ben Pfaff ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH v2.39 7/7] datapath: Add basic MPLS support to kernel

2013-09-19 Thread Simon Horman
On Wed, Sep 18, 2013 at 05:07:59PM -0500, Simon Horman wrote: > On Tue, Sep 17, 2013 at 11:38:18AM -0700, Pravin Shelar wrote: > > On Mon, Sep 9, 2013 at 12:20 AM, Simon Horman wrote: > > > Allow datapath to recognize and extract MPLS labels into flow keys > > > and execute actions which push, pop

Re: [ovs-dev] [PATCH V2] cfm: Prevent interval fault when demand mode is enabled on one end.

2013-09-19 Thread Ethan Jackson
Thanks, merged with some minor tweaks. Ethan On Thu, Sep 19, 2013 at 3:13 PM, Alex Wang wrote: > This commit prevents cfm from raising 'interval' fault when demand > mode is only enabled on one end of link. > > Signed-off-by: Alex Wang > > --- > > v1 -> v2: > - simplify the code. > > --- > lib

Re: [ovs-dev] [PATCH v2.39 7/7] datapath: Add basic MPLS support to kernel

2013-09-19 Thread Pravin Shelar
On Thu, Sep 19, 2013 at 1:45 PM, Simon Horman wrote: > On Wed, Sep 18, 2013 at 05:07:59PM -0500, Simon Horman wrote: >> On Tue, Sep 17, 2013 at 11:38:18AM -0700, Pravin Shelar wrote: >> > On Mon, Sep 9, 2013 at 12:20 AM, Simon Horman wrote: >> > > Allow datapath to recognize and extract MPLS labe

[ovs-dev] [RFC PATCH 3/3] Fix tcp_flags documentation.

2013-09-19 Thread Jarno Rajahalme
I had accidentally made corrections to the ovs-ofctl.8 instead of ovs-ofctl.8.in. Signed-off-by: Jarno Rajahalme --- utilities/ovs-ofctl.8.in | 26 +++--- 1 file changed, 15 insertions(+), 11 deletions(-) diff --git a/utilities/ovs-ofctl.8.in b/utilities/ovs-ofctl.8.in ind

[ovs-dev] [PATCH] fix memory leak

2013-09-19 Thread YAMAMOTO Takashi
plug upcall leak introduced by the commit "ofproto-dpif-upcall: Forward packets in order of arrival." (commit 04a19fb8f4b8ba19a9805906aac7b30b65b57206) Signed-off-by: YAMAMOTO Takashi --- ofproto/ofproto-dpif-upcall.c | 5 + 1 file changed, 5 insertions(+) diff --git a/ofproto/ofproto-dpif