On Aug 19, 2013 11:35 PM, "Justin Pettit" wrote:
>
> Great catch. Also, very cool with sleuthing with your malloc histogram
(as discussed off-list).
Thanks.
Did you look around to make sure that I didn't somehow overlook a free call
somewhere? This patch "feels right" but obviously it needs to
On Aug 20, 2013, at 12:01 AM, Ben Pfaff wrote:
>
> On Aug 19, 2013 11:35 PM, "Justin Pettit" wrote:
> >
> > Great catch. Also, very cool with sleuthing with your malloc histogram (as
> > discussed off-list).
>
> Thanks.
>
> Did you look around to make sure that I didn't somehow overlook a f
When there is no incoming data traffic at the interface for a period,
BFD decay allows the bfd session to increase the min_rx. This is
helpful in that some interfaces may usually be idle for a long time.
And cpu consumption can be reduced by processing fewer bfd control
packets.
Signed-off-by: Ale
This commit adds a new boolean option "forwarding_if_rx" to bfd.
When forwarding_if_rx is true, the forwarding field in "ovs-appctl
bfd/show" output will still be true as long as there are incoming
packets received. This is for indicating the link liveness when
the link is congested and consecutiv
From: Guolin Yang
With megaflow support, there is API to convert mask to nlattr key based
format. This change introduces API to do the reverse conversion. We
leverage the existing odp_flow_key_to_flow() API to resue the code.
Signed-off-by: Guolin Yang
---
lib/odp-util.c | 295 +++
On Tue, Aug 20, 2013 at 2:20 AM, Cong Wang wrote:
> From: Cong Wang
>
> Cc: Jesse Gross
> Cc: Pravin B Shelar
> Signed-off-by: Cong Wang
Applied, thanks Cong.
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
Without this patch, I get Clang warnings that I don't understand for each
of the non-static functions in dirs.c:
warning: control reaches end of non-void function
I get the same warning for this test program with "clang -c -Wall":
struct foo {
const char *y;
_Atomic(int)
Signed-off-by: Ben Pfaff
---
lib/ovs-atomic.h |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/ovs-atomic.h b/lib/ovs-atomic.h
index 3fc9dcb..3467f11 100644
--- a/lib/ovs-atomic.h
+++ b/lib/ovs-atomic.h
@@ -21,7 +21,7 @@
*
* This library implements atomic operations
With this implementation I get warnings with Clang on GNU/Linux when the
previous patch is not applied. This ought to make it easier to avoid
introducing new problems in the future even without building on FreeBSD.
Signed-off-by: Ben Pfaff
---
lib/automake.mk |2 +
lib/compile
C11 says that atomic_load() requires a non-const argument, and Clang
enforces that. This fixes warnings with FreeBSD that uses
the Clang extensions.
Reported-by: Ed Maste
Signed-off-by: Ben Pfaff
---
lib/bfd.c|4 +++-
lib/cfm.c| 14 --
lib/ovs-thread.h |2
On Tue, Aug 20, 2013 at 12:25:37AM -0700, Justin Pettit wrote:
> On Aug 20, 2013, at 12:01 AM, Ben Pfaff wrote:
>
> >
> > On Aug 19, 2013 11:35 PM, "Justin Pettit" wrote:
> > >
> > > Great catch. Also, very cool with sleuthing with your malloc histogram
> > > (as discussed off-list).
> >
> >
On Mon, Aug 19, 2013 at 05:31:36AM -0400, Ed Maste wrote:
> Commit 1514b275 introduces the use of atomic_read_explicit for
> once-only initializers. When using C11 atomics this becomes
> atomic_load_explicit, and the first argument needs to be non-const --
> with FreeBSD HEAD's in-tree clang 3.3 th
When user switches between using CFM and BFD, there will be a short
down time before the new protocol goes up. This can unintentionally
change the traffic pattern of the bundled ports. To prevent this,
it is proposed that user can enable both CFM and BFD before transition,
wait for the new protoc
We've seen a number of deadlocks in the tree since thread safety was
introduced. So far, all of these are self-deadlocks, that is, a single
thread acquiring a lock and then attempting to re-acquire the same lock
recursively. When this has happened, the process simply hung, and it was
somewhat dif
I defined a separate ovs_mutex_init_recursive(). I sent out a v2 in
case you want to look:
http://openvswitch.org/pipermail/dev/2013-August/030895.html
On Sat, Aug 17, 2013 at 05:21:41PM +0800, Ethan Jackson wrote:
> Oops yes you're right. It might be worth defining a separate function fo
On Mon, Aug 19, 2013 at 04:59:16PM -0700, Gurucharan Shetty wrote:
> We currently do not recycle ofport numbers from interfaces that are recently
> deleted by maintaining the maximum allocated ofport value and
> allocating new ofport numbers greater than the previous maximum.
> But after a restart
On Sun, Aug 18, 2013 at 02:56:55PM +1000, Simon Horman wrote:
> On Thu, Aug 08, 2013 at 02:37:48PM -0700, Ben Pfaff wrote:
> > On Thu, Aug 08, 2013 at 02:32:08PM -0700, Ethan Jackson wrote:
> > > > Simon presented numbers that showed it to be a valuable optimization
> > > > in some cases, otherwise
I skimmed it, looks fine to me.
Ethan
On Tue, Aug 20, 2013 at 11:25 AM, Ben Pfaff wrote:
> I defined a separate ovs_mutex_init_recursive(). I sent out a v2 in
> case you want to look:
> http://openvswitch.org/pipermail/dev/2013-August/030895.html
>
> On Sat, Aug 17, 2013 at 05:21:41PM +
I never removed it, just complained about it.
Ethan
On Tue, Aug 20, 2013 at 12:47 PM, Ben Pfaff wrote:
> On Sun, Aug 18, 2013 at 02:56:55PM +1000, Simon Horman wrote:
>> On Thu, Aug 08, 2013 at 02:37:48PM -0700, Ben Pfaff wrote:
>> > On Thu, Aug 08, 2013 at 02:32:08PM -0700, Ethan Jackson wrote:
On Mon, Aug 12, 2013 at 11:34:57AM -0700, Romain Lenglet wrote:
> Implement a per-exporter flow cache with active timeout expiration.
> Add columns "cache_active_timeout" and "cache_max_flows" into table
> "IPFIX" to configure each cache.
>
> Add per-flow elements "octetDeltaSumOfSquares",
> "mini
Ah.
Is it OK for us to keep complaining about you removing it though?
On Tue, Aug 20, 2013 at 01:10:06PM -0700, Ethan Jackson wrote:
> I never removed it, just complained about it.
>
> Ethan
>
> On Tue, Aug 20, 2013 at 12:47 PM, Ben Pfaff wrote:
> > On Sun, Aug 18, 2013 at 02:56:55PM +1000, Si
Thanks. Applied to master.
On Tue, Aug 20, 2013 at 01:09:42PM -0700, Ethan Jackson wrote:
> I skimmed it, looks fine to me.
>
> Ethan
>
> On Tue, Aug 20, 2013 at 11:25 AM, Ben Pfaff wrote:
> > I defined a separate ovs_mutex_init_recursive(). I sent out a v2 in
> > case you want to look:
> >
On Mon, Aug 19, 2013 at 12:32:06PM -0700, Alex Wang wrote:
> Just noticed, when compiling with sparse, it issues the warnings like:
>
> """
> lib/netdev-linux.c:76:1: warning: symbol 'counter_netdev_set_policing' was
> not declared. Should it be static?
> lib/netdev-linux.c:77:1: warning: symbol '
On Mon, Aug 19, 2013 at 08:08:37AM -0700, Alex Wang wrote:
> This looks good to me,
>
> The only issue may be that some comments need to be changed:
>
> -/* Sorts coverage counters in descending order by count, within equal
> counts
> - * alphabetically by name. */
> +/* Sorts coverage counters i
On Tue, Aug 13, 2013 at 11:15:58AM -0700, Casey Barker wrote:
> I've got a lot more code I can upstream, but I haven't seen any reviews for
> the first patch. Any comments? (Or did I submit it incorrectly?)
You sent it right but I've been buried in high-priority bugs for a
while. Sorry.
I didn't
On Sun, Aug 18, 2013 at 02:35:05PM +1000, Simon Horman wrote:
> On Sun, Aug 04, 2013 at 07:45:38PM -0700, Ben Pfaff wrote:
> > On Mon, Aug 05, 2013 at 11:38:57AM +0900, Simon Horman wrote:
> > > Hi,
> > >
> > > I would like to announce my intention to work on OF1.1+ Groups support for
> > > Open v
May I ask, what rule is this?
Should we always declare global variable before defining it? or just when
it is enclosed by macros?
Also, when the "!USE_LINKER_SECTIONS", we should modify the coverage.c the
same way. I'll send out a patch,
On Tue, Aug 20, 2013 at 1:44 PM, Ben Pfaff wrote:
> On
On 20 August 2013 14:10, Ben Pfaff wrote:
> Without this patch, I get Clang warnings that I don't understand for each
> of the non-static functions in dirs.c:
>
> warning: control reaches end of non-void function
This is a clang bug; in your example the call to bar() is omitted by
clang, and
On 20 August 2013 14:10, Ben Pfaff wrote:
> C11 says that atomic_load() requires a non-const argument, and Clang
> enforces that. This fixes warnings with FreeBSD that uses
> the Clang extensions.
Acked-by: Ed Maste
___
dev mailing list
dev@openvswit
Upstream vxlan implementation was changed according to few
comments. Following patch brings back those changes to out
of tree ovs module.
Signed-off-by: Pravin B Shelar
---
datapath/linux/compat/include/net/vxlan.h | 38 +++---
datapath/linux/compat/vxlan.c | 195
Hi Ben,
Thanks for your review!
My comments inline.
I'll send a revised patch shortly for review.
- Original Message -
> From: "Ben Pfaff"
> To: "Romain Lenglet"
> Cc: dev@openvswitch.org
> Sent: Tuesday, August 20, 2013 1:25:16 PM
> Subject: Re: [PATCH] ipfix: implement flow caching a
Merged. I changed the variable name from ctrl to ctl to be consistent
with the bfd spec's convention.
Ethan
On Tue, Aug 20, 2013 at 8:41 AM, Alex Wang wrote:
> When there is no incoming data traffic at the interface for a period,
> BFD decay allows the bfd session to increase the min_rx. This i
I found the answer from this thread:
http://openvswitch.org/pipermail/dev/2011-May/008608.html
On Tue, Aug 20, 2013 at 2:02 PM, Alex Wang wrote:
> May I ask, what rule is this?
>
> Should we always declare global variable before defining it? or just when
> it is enclosed by macros?
>
> Also, w
sparse warns if a non-static variable with external linkage has an
initializer at first declaration. This commit suppresses the
warnings issued when adding custom section is not supported by
compiler.
Signed-off-by: Alex Wang
---
lib/coverage.c |2 ++
lib/vlog.c |1 +
2 files change
Implement a per-exporter flow cache with active timeout expiration.
Add columns "cache_active_timeout" and "cache_max_flows" into table
"IPFIX" to configure each cache.
Add per-flow elements "octetDeltaSumOfSquares",
"minimumIpTotalLength", and "maximumIpTotalLength" to replace
"ethernetTotalLengt
Does this patch work while decay mode is on? Won't the fact that we
share rx_packets between the two features, and that it's set so
frequently by the forwarding_if_rx feature, break the decay mode
feature's assumption that it's the only one setting it? I'm surprised
this doesn't break the unit te
On Tue, Aug 20, 2013 at 02:34:40PM -0700, Romain Lenglet wrote:
> > From: "Ben Pfaff"
> > Perhaps on the same topic, this is the first time I've run into
> > timercmp(). ??It appears to be a nonstandard BSDism. ??Is there a reason
> > to use "struct timeval" instead of the "long long int as msecs
On Tue, Aug 20, 2013 at 05:05:26PM -0400, Ed Maste wrote:
> On 20 August 2013 14:10, Ben Pfaff wrote:
> > Without this patch, I get Clang warnings that I don't understand for each
> > of the non-static functions in dirs.c:
> >
> > warning: control reaches end of non-void function
>
> This is
Merged thanks.
Like an idiot I forgot to put my signed-off-by so I'll put it here.
Signed-off-by: Ethan Jackson
Ethan
On Tue, Aug 20, 2013 at 11:45 AM, Alex Wang wrote:
> When user switches between using CFM and BFD, there will be a short
> down time before the new protocol goes up. This can
Thanks a lot! ;D
On Tue, Aug 20, 2013 at 3:12 PM, Ethan Jackson wrote:
> Merged thanks.
>
> Like an idiot I forgot to put my signed-off-by so I'll put it here.
>
> Signed-off-by: Ethan Jackson
>
> Ethan
>
> On Tue, Aug 20, 2013 at 11:45 AM, Alex Wang wrote:
> > When user switches between usin
On Tue, Aug 20, 2013 at 05:09:43PM -0400, Ed Maste wrote:
> On 20 August 2013 14:10, Ben Pfaff wrote:
> > C11 says that atomic_load() requires a non-const argument, and Clang
> > enforces that. This fixes warnings with FreeBSD that uses
> > the Clang extensions.
>
> Acked-by: Ed Maste
Applied
OK, thanks. I'll send a follow-on with the provider header change that uses
the buckets later this week. (Likewise buried in high-priority bugs...)
On Tue, Aug 20, 2013 at 1:51 PM, Ben Pfaff wrote:
> On Tue, Aug 13, 2013 at 11:15:58AM -0700, Casey Barker wrote:
> > I've got a lot more code I
Thanks Ethan for the review,
On Tue, Aug 20, 2013 at 3:07 PM, Ethan Jackson wrote:
> Does this patch work while decay mode is on? Won't the fact that we
> share rx_packets between the two features, and that it's set so
> frequently by the forwarding_if_rx feature, break the decay mode
> featur
To expand on that, usually one defines a non-static variable, in a .c
file, only when an "extern" declaration of the same variable is
already visible from #including an .h file. A definition without a
previous declaration usually means that the .h file was forgotten.
On Tue, Aug 20, 2013 at 02:48
On Tue, Aug 20, 2013 at 03:24:19PM -0700, Alex Wang wrote:
> sparse warns if a non-static variable with external linkage has an
> initializer at first declaration. This commit suppresses the
> warnings issued when adding custom section is not supported by
> compiler.
>
> Signed-off-by: Alex Wang
> I don't understand. I have used a separate decay_rx_packets to record the
> rx_packets stats for bfd decay. So, rx_packets is not shared.
hmm I think you're right. I must have messed up rebasing.
Ethan
>
> But I'll definitely add an unit test running the two together.
>
>
>>
>> > +uint64_
Np, i'll adjust accordingly and send a v2 soon,
with the conjunction test.
On Tue, Aug 20, 2013 at 3:53 PM, Ethan Jackson wrote:
> > I don't understand. I have used a separate decay_rx_packets to record the
> > rx_packets stats for bfd decay. So, rx_packets is not shared.
>
> hmm I think you'r
On Tue, Aug 20, 2013 at 10:40:50AM -0700, gy...@nicira.com wrote:
> From: Guolin Yang
>
> With megaflow support, there is API to convert mask to nlattr key based
> format. This change introduces API to do the reverse conversion. We
> leverage the existing odp_flow_key_to_flow() API to
On Tue, Aug 20, 2013 at 03:02:47PM -0700, Romain Lenglet wrote:
> Implement a per-exporter flow cache with active timeout expiration.
> Add columns "cache_active_timeout" and "cache_max_flows" into table
> "IPFIX" to configure each cache.
>
> Add per-flow elements "octetDeltaSumOfSquares",
> "mini
Thanks for the insight.
On Tue, Aug 20, 2013 at 3:39 PM, Ben Pfaff wrote:
> To expand on that, usually one defines a non-static variable, in a .c
> file, only when an "extern" declaration of the same variable is
> already visible from #including an .h file. A definition without a
> previous de
- Original Message -
> From: "Ben Pfaff"
> To: "Romain Lenglet"
> Cc: dev@openvswitch.org
> Sent: Tuesday, August 20, 2013 5:08:02 PM
> Subject: Re: [PATCH] ipfix: implement flow caching and aggregation in exporter
>
> On Tue, Aug 20, 2013 at 03:02:47PM -0700, Romain Lenglet wrote:
> > I
Just an oversight. Feel free to fix it.
Ethan
On Mon, Aug 19, 2013 at 6:29 PM, Simon Horman wrote:
> On Sat, Aug 03, 2013 at 06:42:06PM -0700, Ethan Jackson wrote:
>> Signed-off-by: Ethan Jackson
>> ---
>> ofproto/ofproto-dpif.c | 69
>> +++-
>>
This commit adds a new boolean option "forwarding_if_rx" to bfd.
When forwarding_if_rx is true the interface will be considered
capabale of packet I/O as long as there is packet received at
interface. This is important in that when link becomes temporarily
conjested, consecutive BFD control packe
Implement a per-exporter flow cache with active timeout expiration.
Add columns "cache_active_timeout" and "cache_max_flows" into table
"IPFIX" to configure each cache.
Add per-flow elements "octetDeltaSumOfSquares",
"minimumIpTotalLength", and "maximumIpTotalLength" to replace
"ethernetTotalLengt
Remove push_vlan from an OF1.0 test, as it requires OF1.1+ support, but was
silently discarded.
Signed-off-by: Jarno Rajahalme
---
tests/ofproto-dpif.at |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/ofproto-dpif.at b/tests/ofproto-dpif.at
index 32e282d..7ef95db 100
Thanks, I feel better about my understanding of the code now.
I'll compose a patch in the not to distant future.
On Tue, Aug 20, 2013 at 05:44:49PM -0700, Ethan Jackson wrote:
> Just an oversight. Feel free to fix it.
>
> Ethan
>
> On Mon, Aug 19, 2013 at 6:29 PM, Simon Horman wrote:
> > On Sa
56 matches
Mail list logo
