On Mon, Aug 19, 2013 at 08:08:37AM -0700, Alex Wang wrote:
> This looks good to me,
>
> The only issue may be that some comments need to be changed:
>
> -/* Sorts coverage counters in descending order by count, within equal
> counts
> - * alphabetically by name. */
> +/* Sorts coverage counters in descending order by total count,
> + * within equal total counts alphabetically by name. */
> static int
> compare_coverage_counters(const void *a_, const void *b_)
> {
> @@ -108,7 +108,7 @@ coverage_hash(void)
> uint32_t hash = 0;
> int n_groups, i;
>
> - /* Sort coverage counters into groups with equal counts. */
> + /* Sort coverage counters into groups with equal total counts. */
> c = xmalloc(n_coverage_counters * sizeof *c);
> ovs_mutex_lock(&coverage_mutex);
> for (i = 0; i < n_coverage_counters; i++) {
That is a little clearer, thanks.
I'll apply this in a minute.
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
