[ovs-dev] [PATCH] loopback: set pkt_type to PACKET_HOST explicitly

Reset pkt_type to PACKET_HOST when loopback device receives packet before calling eth_type_trans() ip-encapsulated packets can be handled by localhost. But skb->pkt_type can be PACKET_OTHERHOST when packet comes into ip tunnel device. In that case, the packet is dropped by ip_rcv() because loopbac

[ovs-dev] [PATCH v2.34] datapath: Add basic MPLS support to kernel

Allow datapath to recognize and extract MPLS labels into flow keys and execute actions which push, pop, and set labels on packets. Based heavily on work by Leo Alterman, Ravi K, Isaku Yamahata and Joe Stringer. Cc: Ravi K Cc: Leo Alterman Cc: Isaku Yamahata Cc: Joe Stringer Signed-off-by: Sim

[ovs-dev] [PATCH 4/4] Add MPLS recirculation tests

From: Joe Stringer This patch introduces a python script to generate about 1500 tests for permutations of mpls_push,mpls_pop,dec_mpls_ttl,dec_ttl where recirculation occurs up to (and including) three times. Signed-off-by: Joe Stringer Signed-off-by: Simon Horman --- v14 * Allow testing remot

[ovs-dev] [PATCH 1/4] ofproto-dpif: Add 'force-miss-model' configuration

From: Joe Stringer This adds support for specifying flow miss handling behaviour at runtime, through a new "other-config" option in the Open_vSwitch table. This takes precedence over flow-eviction-threshold. By default, the behaviour is the same as before. If force-miss-model is set to 'with-fac

[ovs-dev] [PATCH v14 0/4] Add packet recirculation

Recirculation is a technique to allow a frame to re-enter frame processing. This is intended to be used after actions have been applied to the frame with modify the frame in some way that makes it possible for richer processing to occur. An example is and indeed targeted use case is MPLS. If an MP

Re: [ovs-dev] [PATCH] loopback: set pkt_type to PACKET_HOST explicitly

On Wed, 2013-06-26 at 16:34 +0900, Isaku Yamahata wrote: > Reset pkt_type to PACKET_HOST when loopback device receives packet > before calling eth_type_trans() > > ip-encapsulated packets can be handled by localhost. But skb->pkt_type > can be PACKET_OTHERHOST when packet comes into ip tunnel devi

[ovs-dev] Questions about ovs threads patches

Hi Ben, I noticed that you have sent out 01~09 of 11 patches on files named ovs-thread.c and ovs-thread.h. But I can't find the last two patch of them. Also the defined functions and data structures are not used in latest open vswitch codes from git repository. Is your work to make ovs multi-

Re: [ovs-dev] [PATCH] loopback: set pkt_type to PACKET_HOST explicitly

On Wed, Jun 26, 2013 at 01:40:22AM -0700, Eric Dumazet wrote: > On Wed, 2013-06-26 at 16:34 +0900, Isaku Yamahata wrote: > > Reset pkt_type to PACKET_HOST when loopback device receives packet > > before calling eth_type_trans() > > > > ip-encapsulated packets can be handled by localhost. But skb->

Re: [ovs-dev] [PATCH 2/2] datapath: Resolve external module dependencies.

On Jun 25, 2013, at 22:31 , ext Jesse Gross wrote: > The Open vSwitch kernel module now has dependencies on symbols > exported by other kernel modules (currently just for GRE). In > order for it to load, the dependencies must be correctly resolved > ahead of time. This runs depmod as part of the

Re: [ovs-dev] WARNING: "gre_add_protocol" [...] undefined!

On Jun 26, 2013, at 0:47 , ext Roam Pune wrote: ... i got same error, but then i found a way around it using following command: $ sudo insmod datapath/linux/openvswitch.ko insmod: error inserting 'datapath/linux/openvswitch.ko': -1 Unknown symbol in module $ sudo modprobe gre $ sudo insmod data

Re: [ovs-dev] [PATCH 2/2] datapath: Resolve external module dependencies.

On Wed, Jun 26, 2013 at 8:05 AM, Rajahalme, Jarno (NSN - FI/Espoo) wrote: > > On Jun 25, 2013, at 22:31 , ext Jesse Gross wrote: > >> The Open vSwitch kernel module now has dependencies on symbols >> exported by other kernel modules (currently just for GRE). In >> order for it to load, the depende

Re: [ovs-dev] Questions about ovs threads patches

On Wed, Jun 26, 2013 at 04:46:38PM +0800, jerry wrote: > I noticed that you have sent out 01~09 of 11 patches on files named > ovs-thread.c and ovs-thread.h. I sent all of them. > But I can't find the last two patch of them. Look in patchwork or in my "reviews" repository: https://githu

[ovs-dev] [PATCH] bridge: Don't log flow miss model on every reconfiguration.

Signed-off-by: Ben Pfaff --- vswitchd/bridge.c |5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/vswitchd/bridge.c b/vswitchd/bridge.c index 4ac2b26..578c678 100644 --- a/vswitchd/bridge.c +++ b/vswitchd/bridge.c @@ -816,11 +816,8 @@ bridge_configure_flow_miss_model(const

Re: [ovs-dev] [PATCH 1/4] ofproto-dpif: Add 'force-miss-model' configuration

On Wed, Jun 26, 2013 at 05:25:55PM +0900, Simon Horman wrote: > From: Joe Stringer > > This adds support for specifying flow miss handling behaviour at > runtime, through a new "other-config" option in the Open_vSwitch table. > This takes precedence over flow-eviction-threshold. > > By default,

[ovs-dev] Create and send new type message

I wolud like to create a new type message 'cause my aim is to have a bigger message. After the creation I would like to know wich files are involved in sending messages to enable the switch to send the message created by me. I use version 1.9 Thank you very much for you time and for you help. --

Re: [ovs-dev] [PATCH 2/2] datapath: Resolve external module dependencies.

On Jun 26, 2013, at 18:27 , ext Jesse Gross wrote: > On Wed, Jun 26, 2013 at 8:05 AM, Rajahalme, Jarno (NSN - FI/Espoo) > wrote: >> >> On Jun 25, 2013, at 22:31 , ext Jesse Gross wrote: >> >>> The Open vSwitch kernel module now has dependencies on symbols >>> exported by other kernel modules (

Re: [ovs-dev] [PATCH 2/2] datapath: Resolve external module dependencies.

On Wed, Jun 26, 2013 at 9:18 AM, Rajahalme, Jarno (NSN - FI/Espoo) wrote: > > On Jun 26, 2013, at 18:27 , ext Jesse Gross wrote: > >> On Wed, Jun 26, 2013 at 8:05 AM, Rajahalme, Jarno (NSN - FI/Espoo) >> wrote: >>> >>> On Jun 25, 2013, at 22:31 , ext Jesse Gross wrote: >>> The Open vSwitch k

Re: [ovs-dev] [xlate v1 01/18] ofproto-dpif: Handle dest mirrors in compose_output_action().

On Mon, Jun 24, 2013 at 06:59:15PM -0700, Ethan Jackson wrote: > Before this patch, the mirroring code would retroactively insert > actions for destination mirrors after actions were translated. > This relied on converting datapath output actions into ofports > which doesn't work for tunnels and pa

Re: [ovs-dev] [xlate v1 01/18] ofproto-dpif: Handle dest mirrors in compose_output_action().

On Wed, Jun 26, 2013 at 12:42:48PM -0700, Ben Pfaff wrote: > On Mon, Jun 24, 2013 at 06:59:15PM -0700, Ethan Jackson wrote: > > Before this patch, the mirroring code would retroactively insert > > actions for destination mirrors after actions were translated. > > This relied on converting datapath

Re: [ovs-dev] [RFC PATCH 4/8] ofproto: Implement OpenFlow 1.3 meter table.

Ben, On a related note, the patch that you already applied added a new ofp_flow_removed_reason code OFPRR_METER_DELETE (in openflow-common.h). I intended to have some discussion on it, but forgot to point it out. There is a corresponding OFPRR_GROUP_DELETE reason code, but the OF spec does not

Re: [ovs-dev] [RFC PATCH 4/8] ofproto: Implement OpenFlow 1.3 meter table.

In fact OpenFlow 1.4 adds such a code: /* Why was this flow removed? */ enum ofp_flow_removed_reason { OFPRR_IDLE_TIMEOUT = 0, /* Flow idle time exceeded idle_timeout. */ OFPRR_HARD_TIMEOUT = 1, /* Time exceeded hard_timeout. */ OFPRR_DELETE = 2, /* Evicted by a DELET

[ovs-dev] [PATCH vxlan v2 0/8] openvswitch: Add vxlan tunneling support.

Following patch series is against vxlan tree. First two patches fixes vxlan issues. Next two patches extends vxlan so that openvswitch can share vxlan udp port with vxlan module. Rest of patches refactors vxlan data plane so that ovs can share that code with vxlan module. Last patch adds vxlan-vp

[ovs-dev] [PATCH vxlan v2 5/8] vxlan: Factor out vxlan send api.

Following patch allows more code sharing between vxlan and ovs-vxlan. Signed-off-by: Pravin B Shelar --- v1-v2: - revert back to original names. --- drivers/net/vxlan.c | 91 ++- include/net/vxlan.h |7 2 files changed, 61 insertions(+

[ovs-dev] [PATCH vxlan v2 3/8] vxlan: Allow multiple receive handlers.

Following patch adds basic multiple vxlan protocol handlers. This does not change any functionality. This is required for openvswitch vxlan support. Signed-off-by: Pravin B Shelar --- v1-v2: - update patch against vxlan tree. --- drivers/net/vxlan.c | 318 ++

[ovs-dev] [PATCH vxlan v2 4/8] vxlan: Extend vxlan handlers for openvswitch.

Following patch adds data and priority fields to vxlan handlers and export vxlan handler api. vh->data is required to store private data per vxlan handler. vh->priority allows ovs to assign lower priority for ovs vxlan handler. So that vxlan device modules gets to look at vxlan packet before ovs.

[ovs-dev] [PATCH vxlan v2 2/8] vxlan: Fix vs->vni_list locking.

Use rtnl lock to protect vs->vni_list updates. Signed-off-by: Pravin B Shelar --- drivers/net/vxlan.c | 14 +++--- 1 files changed, 11 insertions(+), 3 deletions(-) diff --git a/drivers/net/vxlan.c b/drivers/net/vxlan.c index 0ba1e7e..f658d39 100644 --- a/drivers/net/vxlan.c +++ b/dri

[ovs-dev] [PATCH vxlan v2 1/8] vxlan: Fix module cleanup.

vxlan private per net object can be accessed in device unregister. therefore unregister pernet device at the end. Signed-off-by: Pravin B Shelar --- drivers/net/vxlan.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/net/vxlan.c b/drivers/net/vxlan.c index 227b5

[ovs-dev] [PATCH vxlan v2 8/8] openvswitch: Add vxlan tunneling support.

Following patch adds vxlan vport type for openvswitch using vxlan api. This patch adds vxlan dependency for openvswitch. CC: Jesse Gross Signed-off-by: Pravin B Shelar --- v1-v2: - removed NULL check in vxlan-rcv. - change vxlan-port create to look good. - Added Cisco copyright. --- include/

[ovs-dev] [PATCH vxlan v2 6/8] vxlan: Improve vxlan headroom calculation.

Rather than having static headroom calculation, adjust headroom according to target device. Signed-off-by: Pravin B Shelar --- drivers/net/vxlan.c | 13 + 1 files changed, 9 insertions(+), 4 deletions(-) diff --git a/drivers/net/vxlan.c b/drivers/net/vxlan.c index d642d4d..0125c57

[ovs-dev] [PATCH vxlan v2 7/8] vxlan: Add tx-vlan offload support.

Following patch allows transmit side vlan offload for vxlan devices. Signed-off-by: Pravin B Shelar --- drivers/net/vxlan.c | 15 ++- 1 files changed, 14 insertions(+), 1 deletions(-) diff --git a/drivers/net/vxlan.c b/drivers/net/vxlan.c index 0125c57..d573458 100644 --- a/driver

Re: [ovs-dev] [xlate v1 02/18] ofproto-dpif: Modularize mirror code.

On Mon, Jun 24, 2013 at 06:59:16PM -0700, Ethan Jackson wrote: > This code modularizes ofproto-dpif's mirror code by moving it to > ofproto-dpif-mirror. Not only does this shorten ofproto-dpif and > hide complexity, but its also necessary for future patches which > modularize ofproto-dpif-xlate in

Re: [ovs-dev] [xlate v1 03/18] cfm: Reference count 'struct cfm'.

On Mon, Jun 24, 2013 at 06:59:17PM -0700, Ethan Jackson wrote: > Signed-off-by: Ethan Jackson Acked-by: Ben Pfaff ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

[ovs-dev] [PATCH] bfd: Fix typo in comment.

Signed-off-by: Ben Pfaff --- lib/bfd.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/lib/bfd.c b/lib/bfd.c index 42d68ad..22c9cae 100644 --- a/lib/bfd.c +++ b/lib/bfd.c @@ -782,7 +782,7 @@ generate_discriminator(void) while (!disc) { struct bfd *bfd; -

Re: [ovs-dev] [xlate v1 04/18] bfd: Reference count 'struct bfd'.

On Mon, Jun 24, 2013 at 06:59:18PM -0700, Ethan Jackson wrote: > Signed-off-by: Ethan Jackson Acked-by: Ben Pfaff ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [xlate v1 05/18] lacp: Reference count 'struct lacp'.

On Mon, Jun 24, 2013 at 06:59:19PM -0700, Ethan Jackson wrote: > Signed-off-by: Ethan Jackson Acked-by: Ben Pfaff ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [xlate v1 06/18] bond: Reference count 'struct bond'.

On Mon, Jun 24, 2013 at 06:59:20PM -0700, Ethan Jackson wrote: > Signed-off-by: Ethan Jackson Acked-by: Ben Pfaff ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [xlate v1 07/18] mac-learning: Reference count 'struct mac_learning".

On Mon, Jun 24, 2013 at 06:59:21PM -0700, Ethan Jackson wrote: > Signed-off-by: Ethan Jackson Acked-by: Ben Pfaff ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [xlate v1 08/18] ofproto-dpif-sflow: Reference count 'struct dpif_sflow'.

On Mon, Jun 24, 2013 at 06:59:22PM -0700, Ethan Jackson wrote: > Signed-off-by: Ethan Jackson I believe I am slowly spotting a pattern in these patches... Acked-by: Ben Pfaff ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/list

Re: [ovs-dev] [xlate v1 08/18] ofproto-dpif-sflow: Reference count 'struct dpif_sflow'.

On Mon, Jun 24, 2013 at 06:59:22PM -0700, Ethan Jackson wrote: > Signed-off-by: Ethan Jackson Acked-by: Ben Pfaff ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [xlate v1 09/18] ofproto-dpif-ipfix: Reference count 'struct dpif_ipfix'.

On Mon, Jun 24, 2013 at 06:59:23PM -0700, Ethan Jackson wrote: > Signed-off-by: Ethan Jackson Acked-by: Ben Pfaff ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [xlate v1 10/18] ofproto-dpif: Remove 'has_bundle_action'.

On Mon, Jun 24, 2013 at 06:59:24PM -0700, Ethan Jackson wrote: > It requires ofproto-dpif-xlate to poke into 'struct ofproto-dpif' > which won't be allowed in future patches. It's also a case of > premature optimization. > > Signed-off-by: Ethan Jackson Acked-by: Ben Pfaff

Re: [ovs-dev] [xlate v1 11/18] netdev: Support null netdev argument in netdev_ref().

On Mon, Jun 24, 2013 at 06:59:25PM -0700, Ethan Jackson wrote: > This will be convenient in future patches. > > Signed-off-by: Ethan Jackson Acked-by: Ben Pfaff ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [xlate v1 12/18] connmgr: Remove connmgr_must_output_local().

On Mon, Jun 24, 2013 at 06:59:26PM -0700, Ethan Jackson wrote: > connmgr_must_output_local() requires a 'struct connmgr' handle, > when in principle, it should simply be enough to know whether or > not in_band is enabled. Breaking this up will allow > ofproto-dpif-xlate to disentangle itself from

Re: [ovs-dev] [PATCH] bfd: Fix typo in comment.

Acked-by: Justin Pettit On Jun 26, 2013, at 1:51 PM, Ben Pfaff wrote: > Signed-off-by: Ben Pfaff > --- > lib/bfd.c |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/lib/bfd.c b/lib/bfd.c > index 42d68ad..22c9cae 100644 > --- a/lib/bfd.c > +++ b/lib/bfd.c > @@ -782

Re: [ovs-dev] [xlate v1 12/18] connmgr: Remove connmgr_must_output_local().

On Wed, Jun 26, 2013 at 02:13:03PM -0700, Ben Pfaff wrote: > On Mon, Jun 24, 2013 at 06:59:26PM -0700, Ethan Jackson wrote: > > connmgr_must_output_local() requires a 'struct connmgr' handle, > > when in principle, it should simply be enough to know whether or > > not in_band is enabled. Breaking

Re: [ovs-dev] [xlate v1 13/18] ofproto-dpif: Move tag_the_flow() to ofproto-dpif.c

On Mon, Jun 24, 2013 at 06:59:27PM -0700, Ethan Jackson wrote: > This will help disentangle ofproto-dpif and ofproto-dpif-xlate. > > Signed-off-by: Ethan Jackson Acked-by: Ben Pfaff ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailm

Re: [ovs-dev] [RFC PATCH 4/8] ofproto: Implement OpenFlow 1.3 meter table.

On Jun 25, 2013, at 22:38 , ext Ben Pfaff wrote: ... > I'm not fond of the structure of the new ofpacts_check_ctx(). At a > minimum, I think that ofpacts_check() should be a trivial wrapper > around it (just change ofpacts_check_ctx() to ignore 'ctx' if it's > NULL). But the inversion of control

Re: [ovs-dev] [PATCH vxlan v2 1/8] vxlan: Fix module cleanup.

On Wed, 26 Jun 2013 13:13:29 -0700 Pravin B Shelar wrote: > vxlan private per net object can be accessed in device unregister. > therefore unregister pernet device at the end. > > Signed-off-by: Pravin B Shelar > --- > drivers/net/vxlan.c |2 +- > 1 files changed, 1 insertions(+), 1 deleti

Re: [ovs-dev] [xlate v1 14/18] bond: Handle unknown slaves in bond_check_admissibility().

On Mon, Jun 24, 2013 at 06:59:28PM -0700, Ethan Jackson wrote: > In future patches, ofproto-dpif-xlate may be temporarily out of > sync with ofproto-dpif and pass a non-bonded ofport into > bond_check_admissibility(). This patch handles that edge case > gracefully. > > Signed-off-by: Ethan Jackso

Re: [ovs-dev] [xlate v1 15/18] lacp: Handle unknown slaves in lacp_process_packet().

On Mon, Jun 24, 2013 at 06:59:29PM -0700, Ethan Jackson wrote: > In future patches, ofproto-dpif-xlate may be temporarily out of > sync with ofproto-dpif proper, and pass an unknown ofport to > lacp_process_packet(). This patch handles that edge case > gracefully. > > Signed-off-by: Ethan Jackson

Re: [ovs-dev] [xlate v1 16/18] tunnel: Use ofport_dpif instead of ofport.

On Mon, Jun 24, 2013 at 06:59:30PM -0700, Ethan Jackson wrote: > Necessary in a future patch. > > Signed-off-by: Ethan Jackson Acked-by: Ben Pfaff ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [xlate v1 17/18] tunnel: Hide 'struct tnl_port' internally.

On Mon, Jun 24, 2013 at 06:59:31PM -0700, Ethan Jackson wrote: > This simplifies the tunnel module's interface and prevents us from > having to sync 'struct tnl_port' once ofproto-dpif and > ofproto-dpif-xlate are disentangled. > > Signed-off-by: Ethan Jackson With this and the previous patch, i

Re: [ovs-dev] [PATCH] loopback: set pkt_type to PACKET_HOST explicitly

From: Isaku Yamahata Date: Wed, 26 Jun 2013 18:37:51 +0900 > veth does. vethb-peer in the above example. > (veth_xmit() -> dev_forward_skb() -> eth_type_trans()) > The destination mac address of arp reply is set to the one of > vetha (!= vethb-peer). So vethb-peer sets pkt_type to OTHERHOST. > br

[ovs-dev] [PATCH] INSTALL: Add db name to path in the example.

Signed-off-by: roampune --- INSTALL |8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/INSTALL b/INSTALL index 28bc1a0..9ec4763 100644 --- a/INSTALL +++ b/INSTALL @@ -286,10 +286,10 @@ any managers specified in the database itself, and to use the SSL configuration in

Re: [ovs-dev] [PATCH] INSTALL: Add db name to path in the example.

On Wed, Jun 26, 2013 at 03:32:16PM -0700, roampune wrote: > Signed-off-by: roampune Can we have a real name instead of a handle for the signoff? Thanks, Ben. ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

[ovs-dev] [PATCH 1/5] openflow-common: Change flow removal reason codes.

Swap places of OFPRR_METER_DELETE and OFPRR_EVICTION in enumeration to be compatible with OpenFlow 1.4. Prior to OpenFlow 1.4 OFPRR_EVICTION was a Nicira specific flow removal reason code. OpenFlow 1.3 added support for meters, which require dependent flow removal when meters are deleted. The re

[ovs-dev] [PATCH 3/5] ofp-util: Meter fixes.

Validate claimed message length for meter stats in ofp-util.c. Clean up meters in ofp-util.h. Fix the impossible duration values in ofp-print.at. Signed-off-by: Jarno Rajahalme --- lib/ofp-util.c | 19 +++ lib/ofp-util.h | 30 +++--- tests/ofp-

[ovs-dev] [PATCH 5/5] v2: dpif: Meter framework.

Signed-off-by: Jarno Rajahalme --- v2: Remove resetting of provider meter id on failure in dpif_meter_set(). --- include/linux/openvswitch.h |3 ++ lib/dpif-linux.c | 40 +++ lib/dpif-netdev.c| 43 - lib/dpif-provider.h

[ovs-dev] [PATCH 2/5] ofproto: Add 'reason' to delete_flow(s)__().

Add a reason parameter to delete_flow__() and delete_flows__() functions. Use OFPRR_EVICTION when add_flow() evicts an existing flow. Signed-off-by: Jarno Rajahalme --- ofproto/ofproto.c | 22 +- 1 file changed, 13 insertions(+), 9 deletions(-) diff --git a/ofproto/ofproto

Re: [ovs-dev] [RFC PATCH 8/8] ovs-ofctl: Add meter support.

On Jun 25, 2013, at 22:41 , ext Ben Pfaff wrote: > On Thu, Jun 20, 2013 at 05:26:23PM +0300, Jarno Rajahalme wrote: >> Adds commands add-meter, mod-meter, del-meter, del-meters, dump-meter, >> dump-meters, meter-stats, and meter-features. >> >> Syntax is as follows: >> >> add-meter meter= (kbp

[ovs-dev] [PATCH 4/5] v2: ofproto: Implement OpenFlow 1.3 meter table.

Signed-off-by: Jarno Rajahalme --- v2: Addresses comments by Ben. --- lib/ofp-actions.c | 20 +- lib/ofp-actions.h |2 + lib/rconn.c| 14 +- ofproto/ofproto-dpif.c |4 + ofproto/ofproto-provider.h | 49 - ofproto/ofproto.c | 490 +

Re: [ovs-dev] [xlate v1 18/18] ofproto-dpif: Modularize ofproto-dpif-xlate.

On Mon, Jun 24, 2013 at 06:59:32PM -0700, Ethan Jackson wrote: > This patch modularizes ofproto-dpif-xlate by disentangling it from > ofproto-dpif. Instead of poking around in ofproto-dpif's internal > data structures, ofproto-dpif-xlate is updated with a simple API > which can easily be made thre

Re: [ovs-dev] [RFC PATCH 3/8] ofp-util: Support for OpenFlow 1.3 meters.

On Jun 25, 2013, at 20:35 , ext Ben Pfaff wrote: > On Thu, Jun 20, 2013 at 05:26:18PM +0300, Jarno Rajahalme wrote: >> >> Signed-off-by: Jarno Rajahalme > > I'm applied this to master. I'm appending the incremental that I > folded in. Most of the changes are minor improvements (some just > s

Re: [ovs-dev] [PATCH] INSTALL: Add db name to path in the example.

On Wed, Jun 26, 2013 at 3:36 PM, Ben Pfaff wrote: > On Wed, Jun 26, 2013 at 03:32:16PM -0700, roampune wrote: > > Signed-off-by: roampune > > Can we have a real name instead of a handle for the signoff? > Sure, James P. Regards. > > Thanks, > > Ben. >

Re: [ovs-dev] [ovs-git] Open vSwitch: openflow-common: Change flow removal reason codes. (master)

On Wed, Jun 26, 2013 at 03:49:04PM -0700, dev@openvswitch.org wrote: > This is an automated email from the git hooks/post-receive script. It was > generated because a ref change was pushed to the repository containing > the project "Open vSwitch". Oops. Pushed a lot more than I intended. Fixed.

Re: [ovs-dev] [PATCH] INSTALL: Add db name to path in the example.

On Wed, Jun 26, 2013 at 03:50:28PM -0700, Roam Pune wrote: > On Wed, Jun 26, 2013 at 3:36 PM, Ben Pfaff wrote: > > > On Wed, Jun 26, 2013 at 03:32:16PM -0700, roampune wrote: > > > Signed-off-by: roampune > > > > Can we have a real name instead of a handle for the signoff? > > > > Sure, James P

Re: [ovs-dev] [PATCH] bfd: Fix typo in comment.

Thanks, applied to master. On Wed, Jun 26, 2013 at 02:26:58PM -0700, Justin Pettit wrote: > Acked-by: Justin Pettit > > > On Jun 26, 2013, at 1:51 PM, Ben Pfaff wrote: > > > Signed-off-by: Ben Pfaff > > --- > > lib/bfd.c |2 +- > > 1 files changed, 1 insertions(+), 1 deletions(-) > > > >

Re: [ovs-dev] [PATCH 1/5] openflow-common: Change flow removal reason codes.

On Thu, Jun 27, 2013 at 01:39:48AM +0300, Jarno Rajahalme wrote: > Swap places of OFPRR_METER_DELETE and OFPRR_EVICTION in enumeration to be > compatible with OpenFlow 1.4. > > Prior to OpenFlow 1.4 OFPRR_EVICTION was a Nicira specific flow removal reason > code. OpenFlow 1.3 added support for me

Re: [ovs-dev] [PATCH] INSTALL: Add db name to path in the example.

On Wed, Jun 26, 2013 at 3:53 PM, Ben Pfaff wrote: > On Wed, Jun 26, 2013 at 03:50:28PM -0700, Roam Pune wrote: > > On Wed, Jun 26, 2013 at 3:36 PM, Ben Pfaff wrote: > > > > > On Wed, Jun 26, 2013 at 03:32:16PM -0700, roampune wrote: > > > > Signed-off-by: roampune > > > > > > Can we have a real

Re: [ovs-dev] [PATCH 2/5] ofproto: Add 'reason' to delete_flow(s)__().

On Thu, Jun 27, 2013 at 01:39:49AM +0300, Jarno Rajahalme wrote: > Add a reason parameter to delete_flow__() and delete_flows__() functions. > Use OFPRR_EVICTION when add_flow() evicts an existing flow. > > Signed-off-by: Jarno Rajahalme >From the changelog, I didn't understand what problem this

Re: [ovs-dev] [RFC PATCH 3/8] ofp-util: Support for OpenFlow 1.3 meters.

On Wed, Jun 26, 2013 at 10:47:22PM +, Rajahalme, Jarno (NSN - FI/Espoo) wrote: > > On Jun 25, 2013, at 20:35 , ext Ben Pfaff wrote: > > > On Thu, Jun 20, 2013 at 05:26:18PM +0300, Jarno Rajahalme wrote: > >> > >> Signed-off-by: Jarno Rajahalme > > > > I'm applied this to master. I'm appe

Re: [ovs-dev] [PATCH 3/5] ofp-util: Meter fixes.

On Thu, Jun 27, 2013 at 01:39:50AM +0300, Jarno Rajahalme wrote: > Validate claimed message length for meter stats in ofp-util.c. > Clean up meters in ofp-util.h. > Fix the impossible duration values in ofp-print.at. > > Signed-off-by: Jarno Rajahalme I think that the check in ofputil_decode_met

Re: [ovs-dev] Questions about ovs threads patches

Thanks for your quickly reply. I have downloaded the codes of ovs-reviews-thread in your "reviews" repository and doing some test on new patches. In my test, the multithreaded feature doesn't work and there is no change on ovs-vswitchd threads. Some results of executing "ps -ef | grep ovs" as f

Re: [ovs-dev] Questions about ovs threads patches

The patches as sent don't create any threads. That's future work, for as-yet unposted patches. On Jun 26, 2013 7:24 PM, "jerry" wrote: > Thanks for your quickly reply. > > I have downloaded the codes of ovs-reviews-thread in your "reviews" > repository and doing some test on new patches. > > In m

Re: [ovs-dev] Questions about ovs threads patches

Thanks very much. When would you send the patches on creating threads in your plan? Regards, Jerry On 2013/6/27 10:39, Ben Pfaff wrote: > The patches as sent don't create any threads. That's future work, for as-yet > unposted patches. > > On Jun 26, 2013 7:24 PM, "jerry"

Re: [ovs-dev] Questions about ovs threads patches

I'm sending out patches in batches as each batch finishes getting reviewed. On Jun 26, 2013 8:09 PM, "jerry" wrote: > Thanks very much. > > When would you send the patches on creating threads in your plan? > > Regards, > Jerry > > On 2013/6/27 10:39, Ben Pfaff wrote: > > The patches as sent don't

Re: [ovs-dev] Questions about ovs threads patches

> When would you send the patches on creating threads in your plan? It's a massive project, so expect to see a lot of work in this area for quite some time. It's safe to bet that we'll have a basic multi threading implementation within the next year or so, possibly sooner. Ethan > > On 2013/6/2

Re: [ovs-dev] Questions about ovs threads patches

"Year"? "Possibly"? I have self doubt but not to that level. On Jun 26, 2013 8:54 PM, "Ethan Jackson" wrote: > > When would you send the patches on creating threads in your plan? > > It's a massive project, so expect to see a lot of work in this area > for quite some time. It's safe to bet that

Re: [ovs-dev] Questions about ovs threads patches

> "Year"? "Possibly"? I have self doubt but not to that level. As they say, under promise over deliver =) Ethan > > On Jun 26, 2013 8:54 PM, "Ethan Jackson" wrote: >> >> > When would you send the patches on creating threads in your plan? >> >> It's a massive project, so expect to see a lot of w

Re: [ovs-dev] [PATCH] datapath: Do not clear key in ovs_match_init()

On Mon, Jun 24, 2013 at 12:29:55PM -0700, Jesse Gross wrote: > On Sun, Jun 23, 2013 at 7:29 PM, Simon Horman wrote: > > It appears that in the case where vs_match_init() is called from > > ovs_flow_metadata_from_nlattrs() it is undesirable to set the flow key as > > some of its values are set earl

Re: [ovs-dev] [PATCH] datapath: Do not clear key in ovs_match_init()

On Wed, Jun 26, 2013 at 9:53 PM, Simon Horman wrote: > On Mon, Jun 24, 2013 at 12:29:55PM -0700, Jesse Gross wrote: >> On Sun, Jun 23, 2013 at 7:29 PM, Simon Horman wrote: >> > It appears that in the case where vs_match_init() is called from >> > ovs_flow_metadata_from_nlattrs() it is undesirable

Re: [ovs-dev] [PATCH vxlan v2 1/8] vxlan: Fix module cleanup.

On Wed, Jun 26, 2013 at 2:48 PM, Stephen Hemminger wrote: > On Wed, 26 Jun 2013 13:13:29 -0700 > Pravin B Shelar wrote: > >> vxlan private per net object can be accessed in device unregister. >> therefore unregister pernet device at the end. >> >> Signed-off-by: Pravin B Shelar >> --- >> driver

Re: [ovs-dev] [PATCH] loopback: set pkt_type to PACKET_HOST explicitly

On Wed, Jun 26, 2013 at 03:29:30PM -0700, David Miller wrote: > From: Isaku Yamahata > Date: Wed, 26 Jun 2013 18:37:51 +0900 > > > veth does. vethb-peer in the above example. > > (veth_xmit() -> dev_forward_skb() -> eth_type_trans()) > > The destination mac address of arp reply is set to the one

[ovs-dev] Possible regression in "datapath: Mega flow implementation"

Hi Jesse, Hi Andy, I have observed what seems to be a regression added by "datapath: Mega flow implementation" which is still present in master as of 7431e17196fdb1c3189d67e3aeed4adeab4cf479 ("ofproto-dpif: Always un-wildcard 'dl_type'."). The problem that I am observing is that in some cases ovs

Re: [ovs-dev] Possible regression in "datapath: Mega flow implementation"

I was noticing some similar IPv6 issues earlier this evening. I'm planning to dig into it more in the morning, so I may have additional information then. Simon, if you wanted to see the flow that triggered this, you could try starting OVS with the "dpif" logging set at "dbg". This will show t