On Tuesday 22 January 2013 22:26:33 Ben Pfaff wrote:
> On Tue, Jan 22, 2013 at 07:39:01PM +0100, Markus Schuster wrote:
> > Open vSwitch sends out the multicast frames on ALL physical interfaces
> > belonging to the SLB bond. That causes a lot of confusion on the physical
> > switches that XCP host
On Jan 22, 2013, at 20:36 , ext Kyle Mestery wrote:
> Add support to the tunneling code for a "pre_tunnel"
> function. This allows the tunneling code to perform
> operations on the packet before the outer IP header is
> added.
>
> A tunneling protocol such as LISP may require this, as it needs
>
Please find my comments below,
Jarno
On Jan 22, 2013, at 20:36 , ext Kyle Mestery wrote:
> From: Lorand Jakab
>
...
> +Flows on br0 are configured as follows:
> +
> +priority=3,dl_dst=02:00:00:00:00:00,action=mod_dl_dst:,NORMAL
> +priority=2,in_port=1,dl_type=0x0806,action=NORMAL
> +
On Wed, Jan 23, 2013 at 10:33:49AM +0100, Markus Schuster wrote:
> On Tuesday 22 January 2013 22:26:33 Ben Pfaff wrote:
> > On Tue, Jan 22, 2013 at 07:39:01PM +0100, Markus Schuster wrote:
> > > Open vSwitch sends out the multicast frames on ALL physical interfaces
> > > belonging to the SLB bond.
On Wednesday 23 January 2013 17:49:09 Ben Pfaff wrote:
> It looks like you have each interface on an SLB bond connected to two
> different switches.
Correct.
> That's not a supported configuration and won't work reliably.
OK, any explanation why? Or to say it the other way: I can't see any
Hi Jarno,
Thanks for reviewing! Replies inline:
On 01/23/13 16:32, Jarno Rajahalme wrote:
> Please find my comments below,
>
> Jarno
>
> On Jan 22, 2013, at 20:36 , ext Kyle Mestery wrote:
>
>> From: Lorand Jakab
>>
> ...
>> +Flows on br0 are configured as follows:
>> +
>> +priority=3,d
On 01/23/13 16:01, Jarno Rajahalme wrote:
>
> On Jan 22, 2013, at 20:36 , ext Kyle Mestery wrote:
>
>> Add support to the tunneling code for a "pre_tunnel"
>> function. This allows the tunneling code to perform
>> operations on the packet before the outer IP header is
>> added.
>>
>> A tunneling
On Tue, Jan 22, 2013 at 9:48 PM, Jarno Rajahalme
wrote:
> Add OVS_PACKET_ATTR_KEY_INFO to relieve userspace from re-computing
> data already computed within the kernel datapath. In the typical
> case of an upcall with perfect key fitness between kernel and
> userspace this eliminates flow_extract
On Thu, Jan 17, 2013 at 09:42:29AM +0900, Simon Horman wrote:
> On Wed, Jan 16, 2013 at 01:59:21PM -0800, Ben Pfaff wrote:
> > On Tue, Jan 15, 2013 at 01:20:57PM +0900, Simon Horman wrote:
> > > Optimise OpenFlow flow expiry by placing expirable flows on a list.
> > > This optimises scanning of flo
On Tue, Jan 22, 2013 at 10:36 AM, Kyle Mestery wrote:
> The following two patches provide support for the LISP tunneling protocol into
> Open vSwitch. See the latest IETF draft for LISP here:
>
> http://tools.ietf.org/html/draft-ietf-lisp-24
>
> Kyle Mestery (1):
> Add support to the tunneling c
Ben asked that I repost the entire series rebased against master.
The first patch of the series should be looked at again as it's
changed significantly. The third and fourth patches haven't been
reviewed yet.
Ben Pfaff (1):
netdev-dummy: Test LACP negotiation.
Ethan Jackson (3):
ofproto-dpif
As a matter of convenience, this patch refreshes the statistics
when ovs-appctl dpif/dump-flows is called. Hopefully this will
prevent users from being confused because statistics they were
expecting to see haven't made it from the datapath into the switch
yet.
Signed-off-by: Ethan Jackson
---
Before this patch, the "need_revalidate" flag and the
"revalidate_set" tag_set where maintained separately for each
ofproto. This won't work in future patches when a flow table
change in one ofproto can require revalidation in another entirely
separate ofproto. For this reason, this patch scopes
From: Ben Pfaff
Signed-off-by: Ben Pfaff
Signed-off-by: Ethan Jackson
---
tests/lacp.at | 430 +
1 file changed, 430 insertions(+)
diff --git a/tests/lacp.at b/tests/lacp.at
index 7d96143..870beb0 100644
--- a/tests/lacp.at
+++ b/tests/
This commit moves responsibility for implementing patch ports from
the datapath to ofproto-dpif. There are two main reasons to do
this.
The first is a matter of design: ofproto-dpif both has more
information than the datapath, and is better suited to handle the
complexity required to implement p
On Wed, Jan 23, 2013 at 06:18:52PM +0100, Markus Schuster wrote:
> On Wednesday 23 January 2013 17:49:09 Ben Pfaff wrote:
> > It looks like you have each interface on an SLB bond connected to two
> > different switches.
>
> Correct.
>
>
> > That's not a supported configuration and won't work
> /* Check the consistency of a random facet, to aid debugging. */
> -if (!hmap_is_empty(&ofproto->facets) && !ofproto->need_revalidate) {
> +if (!hmap_is_empty(&ofproto->facets) &&
> ofproto->backer->need_revalidate) {
Reid Price pointed out off list that I lost a "!" when making th
Modify equal_pathnames to return true when one string is
substring of the other(when a value smaller than SIZE_MAX
is supplied as stop_len)
---
vswitchd/bridge.c |4
1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/vswitchd/bridge.c b/vswitchd/bridge.c
index 82c3bff..792a131
On Wed, Jan 23, 2013 at 01:22:03PM -0800, Pavithra Ramesh wrote:
> Modify equal_pathnames to return true when one string is
> substring of the other(when a value smaller than SIZE_MAX
> is supplied as stop_len)
I think this change is correct only when b_stoplen == strlen(b).
That's the case for th
On Wed, Jan 23, 2013 at 12:56 PM, Ben Pfaff wrote:
> On Wed, Jan 23, 2013 at 06:18:52PM +0100, Markus Schuster wrote:
>> On Wednesday 23 January 2013 17:49:09 Ben Pfaff wrote:
>> > It looks like you have each interface on an SLB bond connected to two
>> > different switches.
>>
>> Correct.
>>
>>
>
Hi Ben,
Thanks for taking a look. This patch looks good.
Thanks,
Pavithra
- Original Message -
From: "Ben Pfaff"
To: "Pavithra Ramesh"
Cc: dev@openvswitch.org
Sent: Wednesday, January 23, 2013 1:29:49 PM
Subject: Re: [ovs-dev] [PATCH] bridge: Modify equal_pathnames function
On Wed, Ja
On 23 January 2013 15:51, Ethan Jackson wrote:
> diff --git a/FAQ b/FAQ
> index ab1c1cc..a466ca4 100644
> --- a/FAQ
> +++ b/FAQ
> @@ -172,17 +172,24 @@ A: The kernel module in upstream Linux 3.3 and later
> does not include
> vSwitch distribution instead of the upstream Linux kernel
>
On Wednesday 23 January 2013 22:31:45 Jesse Gross wrote:
> The behavior described seems odd though and not really related to the
> upstream switch configuration. Were there any modifications made to
> the flow table?
Not that I'm aware of - meaning we haven't modified it but I can't guarantee
fo
I applied it to master, thanks.
On Wed, Jan 23, 2013 at 02:00:14PM -0800, Pavithra Ramesh wrote:
> Hi Ben,
>
> Thanks for taking a look. This patch looks good.
>
> Thanks,
> Pavithra
>
> - Original Message -
> From: "Ben Pfaff"
> To: "Pavithra Ramesh"
> Cc: dev@openvswitch.org
> Sent:
On Wed, Jan 23, 2013 at 05:10:54PM -0500, Ed Maste wrote:
> On 23 January 2013 15:51, Ethan Jackson wrote:
> > diff --git a/FAQ b/FAQ
> > index ab1c1cc..a466ca4 100644
> > --- a/FAQ
> > +++ b/FAQ
> > @@ -172,17 +172,24 @@ A: The kernel module in upstream Linux 3.3 and later
> > does not include
>
I found one typo in testing:
diff --git a/FAQ b/FAQ
index ab4338e..72a1479 100644
--- a/FAQ
+++ b/FAQ
@@ -472,7 +472,7 @@ A: Suppose that you want to set up bridge br0 connected to
physical
add-port br0 vif1.0 -- set interface vif1.0 ofport_request=5 -- \
add-port br0 vif2.0
On Wed, Jan 23, 2013 at 12:51:10PM -0800, Ethan Jackson wrote:
> Before this patch, the "need_revalidate" flag and the
> "revalidate_set" tag_set where maintained separately for each
> ofproto. This won't work in future patches when a flow table
> change in one ofproto can require revalidation in
On Wed, Jan 23, 2013 at 12:51:11PM -0800, Ethan Jackson wrote:
> As a matter of convenience, this patch refreshes the statistics
> when ovs-appctl dpif/dump-flows is called. Hopefully this will
> prevent users from being confused because statistics they were
> expecting to see haven't made it from
On 23 January 2013 18:40, Ben Pfaff wrote:
> I think something got mixed up. Here's the change that I expected to
> see here:
>
> --
> diff --git a/FAQ b/FAQ
> index ab1c1cc..bd4d37e 100644
> --- a/FAQ
> +++ b/FAQ
> @@ -158,28 +1
On Wed, Jan 23, 2013 at 2:42 PM, Markus Schuster
wrote:
> On Wednesday 23 January 2013 22:31:45 Jesse Gross wrote:
>> The behavior described seems odd though and not really related to the
>> upstream switch configuration. Were there any modifications made to
>> the flow table?
>
> Not that I'm aw
On Wed, Jan 23, 2013 at 12:51:12PM -0800, Ethan Jackson wrote:
> This commit moves responsibility for implementing patch ports from
> the datapath to ofproto-dpif. There are two main reasons to do
> this.
>
> The first is a matter of design: ofproto-dpif both has more
> information than the data
On Wed, Jan 23, 2013 at 12:51:13PM -0800, Ethan Jackson wrote:
> From: Ben Pfaff
>
> Signed-off-by: Ben Pfaff
> Signed-off-by: Ethan Jackson
As long as it passes reliably for you I'm happy with this, thanks.
___
dev mailing list
dev@openvswitch.org
h
> 1. Saves copies of revalidate_set and need_revalidate.
> 2. Clears revalidate_set and need_revalidate.
> 3. Uses the copies to revalidate.
>
> The new version appears to:
>
> 1. Clear revalidate_set and need_revalidate.
> 2. Use the cleared original version
> set_patch_config() checks that the peer name is less than IFNAMSIZ
> bytes but I don't know why we care.
Good point, this is leftover from when patch ports were linux specific. Which
has me thinking, at some point we'll need to start building patch ports (and
possibly tunnels) on other platform
> --
> Q: What features are not available in the Open vSwitch kernel datapath
>that ships as part of the upstream Linux kernel?
>
> A: The kernel module in upstream Linux 3.3 and later does not include
>tunnel virtual ports
On Tue, Jan 22, 2013 at 10:47:17AM -0800, Ben Pfaff wrote:
> On Fri, Jan 18, 2013 at 09:27:55AM +0900, Simon Horman wrote:
> > This patch implements use-space datapath and non-datapath code
> > to match and use the datapath API set out in Leo Alterman's patch
> > "user-space datapath: Add basic MPL
On Wed, Jan 23, 2013 at 06:05:29PM -0800, Ethan Jackson wrote:
> > set_patch_config() checks that the peer name is less than IFNAMSIZ
> > bytes but I don't know why we care.
>
> Good point, this is leftover from when patch ports were linux specific. Which
> has me thinking, at some point we'll ne
Hi Simon,
Regarding this part in your mail:
>> push_mpls_lse() isn't documented as putting the new MPLS label before or
>> after the existing labels, but it appears to me that it puts the new
>> label after the existing labels. If I'm right about that, it's
>> surprising; one would
On Tue, Jan 22, 2013 at 03:41:37PM -0800, Ben Pfaff wrote:
> On Tue, Jan 22, 2013 at 10:47:17AM -0800, Ben Pfaff wrote:
> > On Fri, Jan 18, 2013 at 09:27:55AM +0900, Simon Horman wrote:
> > > This patch implements use-space datapath and non-datapath code
> > > to match and use the datapath API set
On Wed, Jan 23, 2013 at 10:31:52PM -0800, Andre Khan wrote:
>
> Hi Simon,
>
> Regarding this part in your mail:
>
>>> push_mpls_lse() isn't documented as putting the new MPLS label before or
>>> after the existing labels, but it appears to me that it puts the new
>>> label after the
Great! Thanks for clearing that up for me.
-Andre
- Original Message -
From: "Simon Horman"
To: "Andre Khan"
Cc: dev@openvswitch.org, "Isaku Yamahata" , "Ravi K"
, "Ben Pfaff"
Sent: Wednesday, January 23, 2013 11:00:11 PM
Subject: Re: [ovs-dev] [PATCH 01/16] User-Space MPLS actions
41 matches
Mail list logo
