[ovs-dev] [PATCH v3 2/4] Add Openflow 1.2 role request/reply processing, update OF 1.2 tests. Add struct ofputil_role_request and encode/decode functions for role request/reply.

2012-12-28 Thread Jarno Rajahalme
Signed-off-by: Jarno Rajahalme --- v3 makes ofputil_decode_role_request() handle also replies and check the validity of the role. Now also used in ofp-print.c. --- lib/ofp-msgs.h | 24 - lib/ofp-print.c| 46 + lib/ofp-util.c | 95 +

Re: [ovs-dev] [PATCH v3 2/4] Add Openflow 1.2 role request/reply processing, update OF 1.2 tests. Add struct ofputil_role_request and encode/decode functions for role request/reply.

2012-12-28 Thread Ben Pfaff
On Fri, Dec 28, 2012 at 06:28:49PM +0200, Jarno Rajahalme wrote: > > Signed-off-by: Jarno Rajahalme > --- > > v3 makes ofputil_decode_role_request() handle also replies and > check the validity of the role. Now also used in ofp-print.c. Thanks! I'm going to apply this in a minute, with a few

[ovs-dev] [PATCH] openflow: Print LOCAL when in_port is OFPP_LOCAL.

2012-12-28 Thread Gurucharan Shetty
Currently, when we add a flow with in_port=65534, we get the following warning. "ofp_util|WARN|referring to port LOCAL as 65534 is deprecated for compatibility with future versions of OpenFlow." But ovs-ofctl, while dumping flows uses 65534 instead of LOCAL. This patch corrects that. Bug #14118

Re: [ovs-dev] [PATCH v2] Allow configuration of null ports (flags, dst_port).

2012-12-28 Thread Jesse Gross
On Fri, Dec 21, 2012 at 2:40 PM, Jesse Gross wrote: > On Fri, Dec 21, 2012 at 7:44 AM, Jarno Rajahalme > wrote: >> Make all kernel tunnel configuration attributes optional. Attributes >> meaningful for null ports are processed first, and the rest are skipped for >> null ports. >> >> Signed-off-by

Re: [ovs-dev] [PATCH v3 2/4] Add Openflow 1.2 role request/reply processing, update OF 1.2 tests. Add struct ofputil_role_request and encode/decode functions for role request/reply.

2012-12-28 Thread Jarno Rajahalme
On Dec 28, 2012, at 19:22 , ext Ben Pfaff wrote: > On Fri, Dec 28, 2012 at 06:28:49PM +0200, Jarno Rajahalme wrote: >> >> Signed-off-by: Jarno Rajahalme >> --- >> >> v3 makes ofputil_decode_role_request() handle also replies and >> check the validity of the role. Now also used in ofp-print.c.

[ovs-dev] [PATCH v3] Make OVS_TUNNEL_ATTR_DST_IPV4 optional to allow configuration of null_ports.

2012-12-28 Thread Jarno Rajahalme
Signed-off-by: Jarno Rajahalme --- v3 restores compatibility with old userspace/kernel by unconditionally sending flags (as expected by old code), but making flags optional when received. --- datapath/tunnel.c| 39 +-- include/openvswitch/tunnel.