On Fri, Dec 21, 2012 at 2:40 PM, Jesse Gross <je...@nicira.com> wrote: > On Fri, Dec 21, 2012 at 7:44 AM, Jarno Rajahalme > <jarno.rajaha...@nsn.com> wrote: >> Make all kernel tunnel configuration attributes optional. Attributes >> meaningful for null ports are processed first, and the rest are skipped for >> null ports. >> >> Signed-off-by: Jarno Rajahalme <jarno.rajaha...@nsn.com> >> --- >> >> v2 makes also flags optional, avoids setting any key flags for null ports, >> and still requires remote IP to be configured on the API level as null ports >> are not yet functional. >> >> Not sure if any of the flags are useful for a null port, but it seems >> that at least the TNL_F_IPSEC could to be still needed. > > The plan is to start using skb mark for interaction with the IPsec > stack. This should be a little more flexible and provide better > interaction with other utilities. As a result, I don't think that any > of the flags are necessary in the null port case and we can skip > processing of those as well. > > We probably also want to unconditionally return the flags in > ovs_tnl_get_options() in the non-null port case again for > compatibility reasons. Similarly, we probably should unconditionally > send the flags from userspace (which is implicitly a non-null port > case).
Hi Jarno, Do you think you'll have time to update this patch in the near future? The reason I ask is that I'd like to get all the kernel tunneling changes into the upcoming release so that we'll have a smooth transition path. We're planning on releasing soon and this is the last thing that I know of, so I'd like to get it in soon. If you don't have time, then I can just make the few remaining changes. Thanks, Jesse _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
