Before waiting for the kernel to reject an invalid name, we
can actually check it before going into the kernel. The code
is stolen from linux kernel function dev_valid_name(),
but it should apply to non-Linux arch as well, because
IFNAMSIZ is POSIX and other errors are obvious.
After this patch I
On Oct 23, 2012, at 8:42 PM, Pravin B Shelar wrote:
> Datapath tunneling check for flag OVS_FLOW_TNL_F_KEY is failing,
> causing it to drop packet. This only happens on tunnels with
> zero key as vswitchd does not generate set-tunnel action. Set
> tunnel action sets this flags for given action. To
On Wed, Oct 24, 2012 at 05:45:36PM +0800, Cong Wang wrote:
> Before waiting for the kernel to reject an invalid name, we
> can actually check it before going into the kernel. The code
> is stolen from linux kernel function dev_valid_name(),
> but it should apply to non-Linux arch as well, because
>
Is anyone working on getting this kernel working with OVS? I've started looking
at this, as Fedora has moved to a 3.6.2 kernel, and it looks like the routing
code has changed such that the tunneling code in OVS needs an update. I can
continue to proceed down this path unless someone else is alre
This prepares for the introduction of a second user in the following
commit.
Signed-off-by: Ben Pfaff
---
lib/rconn.c | 15 +++
1 file changed, 11 insertions(+), 4 deletions(-)
diff --git a/lib/rconn.c b/lib/rconn.c
index ddf578c..5d7595f 100644
--- a/lib/rconn.c
+++ b/lib/rconn.c
Otherwise the command will time out after a while when there's no traffic,
which probably isn't what we want.
Reported-by: Henry Mai
Signed-off-by: Ben Pfaff
---
utilities/ovs-ofctl.c | 34 +++---
1 file changed, 27 insertions(+), 7 deletions(-)
diff --git a/utili
Otherwise, if a monitor connection happens to be talking to a (misguided?)
peer that sends it messages, such as replies to what the peer perceives as
echo requests meant for it, then the peer will eventually hang trying to
send data because the monitor connection never sinks it.
Signed-off-by: Ben
On Thu, Oct 18, 2012 at 02:58:04PM +0900, Simon Horman wrote:
> Allow encoding and decoding of version bitmap in hello messages
> as specified in Open Flow 1.3.1.
>
> Signed-off-by: Simon Horman
Thanks for doing this.
It looks like ofputil_decode_hello() only processes a single hello
element, o
Hi Kyle,
I have patches for 3.6 support. I will send it out after 1.8 release.
Thanks,
Pravin.
On Wed, Oct 24, 2012 at 9:19 AM, Kyle Mestery (kmestery)
wrote:
> Is anyone working on getting this kernel working with OVS? I've started
> looking at this, as Fedora has moved to a 3.6.2 kernel, and
On Oct 24, 2012, at 12:59 PM, Pravin Shelar wrote:
> Hi Kyle,
> I have patches for 3.6 support. I will send it out after 1.8 release.
>
Any chance you can send out the diff now? I'd like to run with it if it's ok
with you.
Thanks!
Kyle
> Thanks,
> Pravin.
>
> On Wed, Oct 24, 2012 at 9:19 AM, K
Actually, is there any reason these can't go in before 1.8 release? If not,
1.8 won't work with the latest Fedora, for example, without your patch.
Thanks,
Kyle
On Oct 24, 2012, at 12:59 PM, Pravin Shelar wrote:
> Hi Kyle,
> I have patches for 3.6 support. I will send it out after 1.8 release.
On Wed, Oct 24, 2012 at 11:02 AM, Kyle Mestery (kmestery)
wrote:
> On Oct 24, 2012, at 12:59 PM, Pravin Shelar wrote:
>> Hi Kyle,
>> I have patches for 3.6 support. I will send it out after 1.8 release.
>>
> Any chance you can send out the diff now? I'd like to run with it if it's ok
> with you.
Yesterday, while going through datapath changes on master, I
noticed that some bugfixes seem to be relevant and missing on
master. Here is a series of backports for review.
Thanks,
Ben.
Ansis Atteka (1):
datapath: Release rtnl_lock if ovs_vport_cmd_build_info() failed
Ben Pfaff (1):
datapa
When OVS_VPORT_ATTR_NAME is specified and dp_ifindex is nonzero, the
logical behavior would be for the vport name lookup scope to be limited
to the specified datapath, but in fact the dp_ifindex value was ignored.
This commit causes the search scope to be honored.
This is a crossport of commit 24c
From: Pravin B Shelar
Following patch fixes compilation error on older kernel.
This is a crossport of commit 08d19ca9fef29b23826f1fb52e2368a9077783ca
from master.
Signed-off-by: Pravin B Shelar
Acked-by: Jesse Gross
---
datapath/linux/compat/include/net/checksum.h |4
1 files change
From: Jesse Gross
When modifying IP addresses or ports on a UDP packet we don't
correctly follow the rules for unchecksummed packets. This meant
that packets without a checksum can be given a incorrect new checksum
and packets with a checksum can become marked as being unchecksummed.
This fixes
From: Jesse Gross
When collecting TCP flags we check that the IP header indicates that
a TCP header is present but not that the packet is actually long
enough to contain the header. This adds a check to prevent reading
off the end of the packet.
In practice, this is only likely to result in rea
From: Ansis Atteka
This patch fixes a possible lock-up bug where rtnl_lock might not
get released.
This is a crossport of commit 7a6c067d1ad65ae4abdb723b25a4ab591d1d2bc3
from master.
Acked-by: Jesse Gross
Signed-off-by: Ansis Atteka
---
datapath/datapath.c |5 ++---
1 files changed, 2 in
From: Pravin B Shelar
Use DSCP bits from ToS set on tunnel.
This is a crossport of commit 749ae9504293dbb695dd67402acbd47acbcbeb83
from master.
Bug #8822.
Signed-off-by: Pravin B Shelar
Acked-by: Jesse Gross
---
datapath/tunnel.c| 20
vswitchd/vswitch.xml |3 ++
On Thu, Oct 11, 2012 at 01:13:44AM +0200, Luigi Rizzo wrote:
> Anyways, let's see if we can find some agreement on how to
> proceed with a face-to-face meeting
Will you attend the ONF workday next week Tuesday in Santa Clara? It
is free to all ONF members (Google is one, so that's probably good
e
When a 'ovs-ctl restart' is executed and the userspace daemons
like ovsdb-server and ovs-vswitchd are not running, attempt to
save flows can wait forever. This also results in the daemons
from not getting started.
Signed-off-by: Gurucharan Shetty
---
utilities/ovs-ctl.in |8 +---
1 files
On Wed, Oct 24, 2012 at 01:19:24PM -0700, Gurucharan Shetty wrote:
> When a 'ovs-ctl restart' is executed and the userspace daemons
> like ovsdb-server and ovs-vswitchd are not running, attempt to
> save flows can wait forever. This also results in the daemons
> from not getting started.
>
> Signe
When a link is down, or when a link has no speed because it is not a
physical interface, Open vSwitch previously reported that its rate is 100
Mbps as a default. This is counterintuitive, however, so this commit
changes Open vSwitch behavior to report 0 Mbps when a link is down or its
speed is oth
With this patch, timeval will take a backtrace with each SIGALRM
allowing it to retrieve a profiling snapshot instantly. This will
be useful in future patches when backtraces are logged.
Signed-off-by: Ethan Jackson
---
lib/timeval.c | 68 ++
With this patch, `ovs-appctl backtrace` will return a unique list
of backtraces and a count of how many times it has been recorded.
This work had previously been done by ovs-parse-backtrace. However,
in future patches poll-loop will begin logging backtraces as a
matter of course. At this point, co
Often when debugging Open vSwitch, one will see in the logs that
CPU usage has been high for some period of time, but it's totally
unclear why. In an attempt to remedy the situation, this patch
logs backtraces taken at regular intervals as a poor man's
profiling alternative.
Signed-off-by: Ethan
ovs-ctl has a new command called "restart" which
saves and restores the openflow flows on bridges.
Use that command from the init scripts when doing
a "restart --save-flows=yes".
Feature #13555.
Signed-off-by: Gurucharan Shetty
---
debian/openvswitch-switch.init | 13 +++--
rhel/etc_i
When debian package for openvswitch-switch is upgraded,
restart the daemons using the "--save-flows=yes" flag.
This will save the openflow flows in vswitchd and
re-apply it after the upgrade.
Feature #13555.
Signed-off-by: Gurucharan Shetty
---
debian/openvswitch-switch.postinst | 14 +
On Tue, Oct 23, 2012 at 7:17 PM, Mehak Mahajan wrote:
> With this commit, the datapath will process the ARP header for
> RARP packets. It also fixes a bug whereby if the ARP opcode is
> something other than ARP request or reply, the key_len is not
> adjusted to include ARP info.
>
> Signed-off-by
Thanks for the review Jesse.
~ Mehak
On Wed, Oct 24, 2012 at 3:19 PM, Jesse Gross wrote:
> On Tue, Oct 23, 2012 at 7:17 PM, Mehak Mahajan
> wrote:
> > With this commit, the datapath will process the ARP header for
> > RARP packets. It also fixes a bug whereby if the ARP opcode is
> > somethin
On Wed, Oct 24, 2012 at 02:21:39PM -0700, Gurucharan Shetty wrote:
> ovs-ctl has a new command called "restart" which
> saves and restores the openflow flows on bridges.
> Use that command from the init scripts when doing
> a "restart --save-flows=yes".
>
> Feature #13555.
> Signed-off-by: Gurucha
On Wed, Oct 24, 2012 at 3:33 PM, Ben Pfaff wrote:
> On Wed, Oct 24, 2012 at 02:21:39PM -0700, Gurucharan Shetty wrote:
> > ovs-ctl has a new command called "restart" which
> > saves and restores the openflow flows on bridges.
> > Use that command from the init scripts when doing
> > a "restart --
On Tue, Oct 23, 2012 at 6:42 PM, Pravin B Shelar wrote:
> Datapath tunneling check for flag OVS_FLOW_TNL_F_KEY is failing,
> causing it to drop packet. This only happens on tunnels with
> zero key as vswitchd does not generate set-tunnel action. Set
> tunnel action sets this flags for given action
On Wed, Oct 24, 2012 at 02:21:40PM -0700, Gurucharan Shetty wrote:
> When debian package for openvswitch-switch is upgraded,
> restart the daemons using the "--save-flows=yes" flag.
> This will save the openflow flows in vswitchd and
> re-apply it after the upgrade.
>
> Feature #13555.
> Signed-of
On Wed, Oct 24, 2012 at 03:35:51PM -0700, Gurucharan Shetty wrote:
> On Wed, Oct 24, 2012 at 3:33 PM, Ben Pfaff wrote:
>
> > On Wed, Oct 24, 2012 at 02:21:39PM -0700, Gurucharan Shetty wrote:
> > > ovs-ctl has a new command called "restart" which
> > > saves and restores the openflow flows on bri
Signed-off-by: Ben Pfaff
---
This will be committed to master and be the branch point for a
new branch-1.9 branch also.
NEWS |4 ++--
configure.ac |2 +-
debian/changelog | 43 ---
3 files changed, 43 insertions(+), 6 deletions(-
Signed-off-by: Ben Pfaff
---
This will go to master only, not to branch-1.9.
NEWS |4
configure.ac |2 +-
debian/changelog |7 +++
3 files changed, 12 insertions(+), 1 deletions(-)
diff --git a/NEWS b/NEWS
index d04db25..3cb1bd3 100644
--- a/NEWS
+++ b/NEWS
The series looks good to me.
--Justin
On Oct 25, 2012, at 12:18 AM, Ben Pfaff wrote:
> Signed-off-by: Ben Pfaff
> ---
> This will go to master only, not to branch-1.9.
>
> NEWS |4
> configure.ac |2 +-
> debian/changelog |7 +++
> 3 files changed, 12 insert
On Wed, Oct 24, 2012 at 3:44 PM, Jesse Gross wrote:
> On Tue, Oct 23, 2012 at 6:42 PM, Pravin B Shelar wrote:
>> Datapath tunneling check for flag OVS_FLOW_TNL_F_KEY is failing,
>> causing it to drop packet. This only happens on tunnels with
>> zero key as vswitchd does not generate set-tunnel ac
ovs-ctl has a new command called "restart" which
saves and restores the openflow flows on bridges.
Use that command from the init scripts when doing
a "restart --save-flows=yes".
Also, the debian package postinst script can
set the variable OVS_RESTART_SAVE_FLOWS to "yes"
to ask for save and resto
When debian package for openvswitch-switch is upgraded,
export a variable, OVS_RESTART_SAVE_FLOWS=yes.
This will save the openflow flows in vswitchd and
re-apply it after the upgrade.
Feature #13555.
Signed-off-by: Gurucharan Shetty
---
debian/openvswitch-switch.postinst |4
1 file chan
Thanks, I pushed this to master and branch-1.9.
On Thu, Oct 25, 2012 at 12:21:52AM +0100, Justin Pettit wrote:
> The series looks good to me.
>
> --Justin
>
>
> On Oct 25, 2012, at 12:18 AM, Ben Pfaff wrote:
>
> > Signed-off-by: Ben Pfaff
> > ---
> > This will go to master only, not to branc
On Wed, Oct 24, 2012 at 3:45 PM, Ben Pfaff wrote:
> On Wed, Oct 24, 2012 at 02:21:40PM -0700, Gurucharan Shetty wrote:
> > When debian package for openvswitch-switch is upgraded,
> > restart the daemons using the "--save-flows=yes" flag.
> > This will save the openflow flows in vswitchd and
> > r
On Wed, Oct 24, 2012 at 04:20:39PM -0700, Gurucharan Shetty wrote:
> ovs-ctl has a new command called "restart" which
> saves and restores the openflow flows on bridges.
> Use that command from the init scripts when doing
> a "restart --save-flows=yes".
>
> Also, the debian package postinst script
On Wed, Oct 24, 2012 at 04:20:40PM -0700, Gurucharan Shetty wrote:
> When debian package for openvswitch-switch is upgraded,
> export a variable, OVS_RESTART_SAVE_FLOWS=yes.
> This will save the openflow flows in vswitchd and
> re-apply it after the upgrade.
>
> Feature #13555.
> Signed-off-by: Gu
On Wed, Oct 24, 2012 at 01:49:08PM -0700, Ethan Jackson wrote:
> With this patch, `ovs-appctl backtrace` will return a unique list
> of backtraces and a count of how many times it has been recorded.
> This work had previously been done by ovs-parse-backtrace. However,
> in future patches poll-loop
On Wed, Oct 24, 2012 at 01:49:07PM -0700, Ethan Jackson wrote:
> With this patch, timeval will take a backtrace with each SIGALRM
> allowing it to retrieve a profiling snapshot instantly. This will
> be useful in future patches when backtraces are logged.
>
> Signed-off-by: Ethan Jackson
Looks
On Wed, Oct 24, 2012 at 1:42 PM, Ben Pfaff wrote:
> On Wed, Oct 24, 2012 at 01:19:24PM -0700, Gurucharan Shetty wrote:
> > When a 'ovs-ctl restart' is executed and the userspace daemons
> > like ovsdb-server and ovs-vswitchd are not running, attempt to
> > save flows can wait forever. This also r
On Wed, Oct 24, 2012 at 4:29 PM, Ben Pfaff wrote:
> On Wed, Oct 24, 2012 at 04:20:40PM -0700, Gurucharan Shetty wrote:
> > When debian package for openvswitch-switch is upgraded,
> > export a variable, OVS_RESTART_SAVE_FLOWS=yes.
> > This will save the openflow flows in vswitchd and
> > re-apply
On Wed, Oct 24, 2012 at 01:49:09PM -0700, Ethan Jackson wrote:
> Often when debugging Open vSwitch, one will see in the logs that
> CPU usage has been high for some period of time, but it's totally
> unclear why. In an attempt to remedy the situation, this patch
> logs backtraces taken at regular
We've had a couple of requests for this over the years. It's easy to do,
so let's implement it.
Signed-off-by: Ben Pfaff
---
NEWS |1 +
lib/mac-learning.c | 24 ++---
lib/mac-learning.h |5 +++-
ofproto/ofproto-dpif.c |6 +++-
On Mon, Oct 22, 2012 at 12:40 PM, Ben Pfaff wrote:
> On Mon, Oct 22, 2012 at 10:10:10AM +0300, Ansis Atteka wrote:
>> This patch changes the default path MTU discovery value to
>> disabled.
>>
>> Signed-off-by: Ansis Atteka
>
> Jesse, Ansis says that this is at your request. Would you mind
> sup
On Tue, Oct 23, 2012 at 11:04:09PM -0700, Ben Pfaff wrote:
> On Wed, Oct 24, 2012 at 08:59:57AM +0900, Simon Horman wrote:
> > On Tue, Oct 23, 2012 at 09:00:42AM -0700, Ben Pfaff wrote:
> > > On Thu, Oct 18, 2012 at 02:58:01PM +0900, Simon Horman wrote:
> > > > The motivation for this is to avoid a
On Wed, Oct 24, 2012 at 10:14:30AM -0700, Ben Pfaff wrote:
> On Thu, Oct 18, 2012 at 02:58:04PM +0900, Simon Horman wrote:
> > Allow encoding and decoding of version bitmap in hello messages
> > as specified in Open Flow 1.3.1.
> >
> > Signed-off-by: Simon Horman
>
> Thanks for doing this.
>
>
On Wed, Oct 24, 2012 at 12:47 PM, Ben Pfaff wrote:
> From: Pravin B Shelar
>
> Following patch fixes compilation error on older kernel.
>
> This is a crossport of commit 08d19ca9fef29b23826f1fb52e2368a9077783ca
> from master.
>
> Signed-off-by: Pravin B Shelar
> Acked-by: Jesse Gross
I think t
On Wed, Oct 24, 2012 at 12:47 PM, Ben Pfaff wrote:
> Yesterday, while going through datapath changes on master, I
> noticed that some bugfixes seem to be relevant and missing on
> master. Here is a series of backports for review.
Thanks, other than the one patch that I commented on this series l
On Wed, Oct 24, 2012 at 05:43:29PM -0700, Jesse Gross wrote:
> On Mon, Oct 22, 2012 at 12:40 PM, Ben Pfaff wrote:
> > On Mon, Oct 22, 2012 at 10:10:10AM +0300, Ansis Atteka wrote:
> >> This patch changes the default path MTU discovery value to
> >> disabled.
> >>
> >> Signed-off-by: Ansis Atteka
This implementes push_vlan with 802.1Q.
NOTE: 802.1AD (QinQ) is not supported. It requires another effort.
Signed-off-by: Isaku Yamahata
---
lib/ofp-actions.c | 25 +
lib/ofp-actions.h |9 +
lib/ofp-parse.c| 13 +
lib/ofp-util
58 matches
Mail list logo
