On Wed, Oct 24, 2012 at 01:49:08PM -0700, Ethan Jackson wrote: > With this patch, `ovs-appctl backtrace` will return a unique list > of backtraces and a count of how many times it has been recorded. > This work had previously been done by ovs-parse-backtrace. However, > in future patches poll-loop will begin logging backtraces as a > matter of course. At this point, coalescing the backtraces will > help keep these log messages brief. > > Signed-off-by: Ethan Jackson <et...@nicira.com>
I think that trace_map_lookup() might need to be marked OVS_UNUSED because it looks like the only call to it is from an #if...#endif block. (Or, we could eliminate the #if...#endif blocks by writing no-op stubs for backtrace() and backtrace_symbols().) Otherwise this looks good. I didn't test it. I didn't look over ovs-parse-backtrace.in very well. Thanks, Ben. _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
