On Wed, Oct 10, 2012 at 12:16:15PM +0900, Isaku Yamahata wrote:
> On Tue, Oct 09, 2012 at 04:08:35PM +0900, Simon Horman wrote:
> > @@ -938,6 +990,15 @@ mf_is_value_valid(const struct mf_field *mf, const
> > union mf_value *value)
> > case MFF_IPV6_LABEL:
> > return !(value->be32 & ~
On Wed, Oct 10, 2012 at 11:59:26AM +0900, Isaku Yamahata wrote:
> On Tue, Oct 09, 2012 at 04:08:33PM +0900, Simon Horman wrote:
> > This is to match the kernel implementation in the
> > patch "datapath: Add basic MPLS support to kernel"
> > by Leo Alterman.
> >
> > Cc: Leo Alterman
> > Signed-off
On Wed, Oct 10, 2012 at 11:57:15AM +0900, Isaku Yamahata wrote:
> On Tue, Oct 09, 2012 at 04:08:32PM +0900, Simon Horman wrote:
> > +static int push_mpls(struct sk_buff *skb, const struct
> > ovs_action_push_mpls *mpls)
> > +{
> > + u32 l2_size;
> > + __be32 *new_mpls_label;
> > +
> > + if (
On 9 October 2012 18:07, Ben Pfaff wrote:
> On Tue, Oct 09, 2012 at 06:03:32PM -0400, Ed Maste wrote:
>>...
>>
>> Interesting - I didn't notice this code before.
>>
>> On FreeBSD we have setproctitle(const char *fmt, ...) for this
>> functionality, which has the same interface as proctitle_set.
>>
On Wed, Oct 10, 2012 at 09:34:29AM -0400, Ed Maste wrote:
> On 9 October 2012 18:07, Ben Pfaff wrote:
> > On Tue, Oct 09, 2012 at 06:03:32PM -0400, Ed Maste wrote:
> >>...
> >>
> >> Interesting - I didn't notice this code before.
> >>
> >> On FreeBSD we have setproctitle(const char *fmt, ...) for
On Oct 4, 2012, at 12:56 PM, Ben Pfaff wrote:
> Thanks, Ralf. I will add
>Signed-off-by: Ralf Spenneberg
> to the commit log.
>
Hi Ben:
Are you waiting for my feedback on this patch? Just curious as to it's state
and if you see anything else you would like me to address.
Thanks,
Kyle
More than anything I'd like to see an analysis, based on at least
simple measurements, probably including some conjecture, of the reason
or reasons that the threaded datapath yields performance that is so
much better. If it comes down to something not fundamental to having
threads, then we can tal
On Wed, Oct 10, 2012 at 03:19:47PM +, Kyle Mestery (kmestery) wrote:
> On Oct 4, 2012, at 12:56 PM, Ben Pfaff wrote:
> > Thanks, Ralf. I will add
> >Signed-off-by: Ralf Spenneberg
> > to the commit log.
> >
> Hi Ben:
>
> Are you waiting for my feedback on this patch? Just curious a
On Oct 10, 2012, at 11:47 AM, Ben Pfaff
wrote:
> On Wed, Oct 10, 2012 at 03:19:47PM +, Kyle Mestery (kmestery) wrote:
>> On Oct 4, 2012, at 12:56 PM, Ben Pfaff wrote:
>>> Thanks, Ralf. I will add
>>> Signed-off-by: Ralf Spenneberg
>>> to the commit log.
>>>
>> Hi Ben:
>>
>> Are you
On Sat, Oct 06, 2012 at 07:39:49PM +0900, Simon Horman wrote:
> On Thu, Oct 04, 2012 at 10:18:26AM -0700, Ben Pfaff wrote:
> > On Thu, Sep 20, 2012 at 01:10:41PM +0900, Simon Horman wrote:
> > > This allows for encoding and decoding Open Flow 1.1 and 1.2 Port Stats
> > > Request and Reply message
>
On Wed, Oct 10, 2012 at 09:20:19AM -0700, Ben Pfaff wrote:
> More than anything I'd like to see an analysis, based on at least
> simple measurements, probably including some conjecture, of the reason
> or reasons that the threaded datapath yields performance that is so
> much better. If it comes d
Patch looks good, I have few comments inlined.
On Tue, Oct 9, 2012 at 11:49 AM, Kyle Mestery wrote:
> This is a first pass at providing a tun_key which can be
> used as the basis for flow-based tunnelling. The
> tun_key includes and replaces the tun_id in both struct
> ovs_skb_cb and struct sw_t
* Pravin Shelar (pshe...@nicira.com) wrote:
> On Tue, Oct 9, 2012 at 11:49 AM, Kyle Mestery wrote:
> > @@ -458,6 +477,9 @@ int ovs_execute_actions(struct datapath *dp, struct
> > sk_buff *skb)
> > struct sw_flow_actions *acts =
> > rcu_dereference(OVS_CB(skb)->flow->sf_acts);
> >
On Wed, Oct 10, 2012 at 10:33:00AM -0700, Ben Pfaff wrote:
> On Sat, Oct 06, 2012 at 07:39:49PM +0900, Simon Horman wrote:
> > On Thu, Oct 04, 2012 at 10:18:26AM -0700, Ben Pfaff wrote:
> > > On Thu, Sep 20, 2012 at 01:10:41PM +0900, Simon Horman wrote:
> > > > This allows for encoding and decoding
On Wed, Oct 10, 2012 at 07:31:25PM +0900, Simon Horman wrote:
> On Wed, Oct 10, 2012 at 11:57:15AM +0900, Isaku Yamahata wrote:
> > On Tue, Oct 09, 2012 at 04:08:32PM +0900, Simon Horman wrote:
> > > +static int push_mpls(struct sk_buff *skb, const struct
> > > ovs_action_push_mpls *mpls)
> > > +{
Notifications always precede a barrier that follows a given flow_mod,
not a barrier that precedes a flow_mod as the text here previously claimed.
Also, the text about abbreviated notifications is equally applicable
to normal, unabbreviated notifications, so say that explicitly.
Reported-by: Jean
16 matches
Mail list logo
