At Wed, 4 Jul 2012 23:01:40 -0700,
Ben Pfaff wrote:
>
> On Thu, Jul 05, 2012 at 12:59:15PM +0900, Atzm Watanabe wrote:
> > Overwriting sequence number breaks replies (e.g. to brcompat).
> >
> > Signed-off-by: Atzm Watanabe
>
> Thanks for the patch. I don't really like how it treats zero as a
These functions do not appear to be used any more.
Signed-off-by: Simon Horman
---
lib/meta-flow.c | 82 +
lib/meta-flow.h | 4 ---
2 files changed, 1 insertion(+), 85 deletions(-)
diff --git a/lib/meta-flow.c b/lib/meta-flow.c
index 8e7d
Hi,
the purpose of this series is to:
* Add encoding of the OXM VLAN VID and VLAN PCP matches and;
* Correct the decoding of OXM VLAN VID and VLAN PCP matches
without breaking ovs-ofctl add-flows, which uses some of the
same code paths.
It is more or less a complete re-write of the first att
OXM VLAN VID matches may include the CFI bit.
It seems harmless enough to allow them for the other use of this code.
The other use is ovs-ofctl add-flow ... dl_vlan
Signed-off-by: Simon Horman
---
lib/meta-flow.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/meta-f
OpenFlow 1.2 specifies that a VLAN VID value of OFPVID12_NONE and
no mask should match only packets without a VLAN tag. This is the
same behaviour provided when calling mf_set_value for VLAN VID with
a value of OFP10_VLAN_NONE.
Signed-off-by: Simon Horman
---
lib/nx-match.c | 27
Signed-off-by: Simon Horman
---
lib/nx-match.c | 22 ++
tests/ovs-ofctl.at | 12
2 files changed, 30 insertions(+), 4 deletions(-)
diff --git a/lib/nx-match.c b/lib/nx-match.c
index 3e3b4c6..e2fc76c 100644
--- a/lib/nx-match.c
+++ b/lib/nx-match.c
@@ -510,10
* Remove duplicate definition of OFP_VLAN_NONE
* Rename OFP_VLAN_NONE as OFP10_VLAN_NONE as it appears to be
only used by OpenFlow 1.0.
As suggested by Ben Pfaff.
Signed-off-by: Simon Horman
---
include/openflow/openflow-1.0.h | 7 +--
lib/classifier.c| 2 +-
lib/flow.c
Signed-off-by: Simon Horman
---
lib/meta-flow.c| 4 +++-
lib/meta-flow.h| 1 +
tests/ovs-ofctl.at | 4
3 files changed, 8 insertions(+), 1 deletion(-)
diff --git a/lib/meta-flow.c b/lib/meta-flow.c
index b7f6fcc..b52db4d 100644
--- a/lib/meta-flow.c
+++ b/lib/meta-flow.c
@@ -170,7 +
Signed-off-by: Simon Horman
---
lib/classifier.c | 14 --
lib/classifier.h | 1 +
lib/meta-flow.c| 7 +--
tests/ovs-ofctl.at | 16
4 files changed, 34 insertions(+), 4 deletions(-)
diff --git a/lib/classifier.c b/lib/classifier.c
index 6e8f4d2..8bff7a4
On Thu, Jul 05, 2012 at 05:27:27PM +0900, Simon Horman wrote:
> * Remove duplicate definition of OFP_VLAN_NONE
> * Rename OFP_VLAN_NONE as OFP10_VLAN_NONE as it appears to be
> only used by OpenFlow 1.0.
>
> As suggested by Ben Pfaff.
>
> Signed-off-by: Simon Horman
> ---
> include/openflow/o
* Remove duplicate definition of OFP_VLAN_NONE
* Rename OFP_VLAN_NONE as OFP10_VLAN_NONE as it appears to be
only used by OpenFlow 1.0.
As suggested by Ben Pfaff.
Signed-off-by: Simon Horman
---
include/openflow/openflow-1.0.h | 7 +--
lib/classifier.c| 2 +-
lib/flow.c
Dear Mr Justin!
1 more question.
I would like to take the traffic statistic which is classified by vlan.
I would like to ask whether netflow can export that kind of information?
Thank you
Trinh Minh Tri
-
PhD Student, Department of Electrical E
I understand code review is time consuming and please note it's a bit time
consuming to me as well as I have to retest/rebase everytime and I am not
sure whether the amount of time I am spending on this is justifiable?
MPLS actions are implemented as per section 4.8 in OF 1.1 specification,
excerp
Dear Mr Justin!
One more small question:
When I export the netflow traffic to my ubuntu computer and using flow-capture
to capture it. I saw the result is like this:
srcIP dstIP prot srcPort dstPort octets packets
10.0.0.1 10.0.0.2 17 23335 123
This bug should now be fixed on branch-1.7 and master.
On Mon, Jun 25, 2012 at 08:08:25AM +0200, André Ruß wrote:
> Hi Justin,
>
> I am using the datapath and brcompat module that ships with the 1.7.90. It is
> running on a Debian. So the module-assistant datapath-source option was used.
> In t
On Thu, Jul 05, 2012 at 04:55:52PM +0900, Atzm Watanabe wrote:
>
> At Wed, 4 Jul 2012 23:01:40 -0700,
> Ben Pfaff wrote:
> >
> > On Thu, Jul 05, 2012 at 12:59:15PM +0900, Atzm Watanabe wrote:
> > > Overwriting sequence number breaks replies (e.g. to brcompat).
> > >
> > > Signed-off-by: Atzm Wat
On Thu, Jul 05, 2012 at 05:41:10PM +0900, Simon Horman wrote:
> * Remove duplicate definition of OFP_VLAN_NONE
> * Rename OFP_VLAN_NONE as OFP10_VLAN_NONE as it appears to be
> only used by OpenFlow 1.0.
>
> As suggested by Ben Pfaff.
>
> Signed-off-by: Simon Horman
>
> ---
Applied, thank yo
It isn't used anymore and keeping it up-to-date is error-prone.
Signed-off-by: Ben Pfaff
---
lib/nx-match.h | 40
1 files changed, 0 insertions(+), 40 deletions(-)
diff --git a/lib/nx-match.h b/lib/nx-match.h
index 6248b2a..161733f 100644
--- a/lib/nx-
It seemed like it could use one.
Signed-off-by: Ben Pfaff
---
lib/ofp-util.c | 10 ++
1 files changed, 10 insertions(+), 0 deletions(-)
diff --git a/lib/ofp-util.c b/lib/ofp-util.c
index d9a77f1..99f92a8 100644
--- a/lib/ofp-util.c
+++ b/lib/ofp-util.c
@@ -3392,6 +3392,16 @@ ofputil_a
Glad to see it go, thanks.
Ethan
On Thu, Jul 5, 2012 at 11:11 AM, Ben Pfaff wrote:
> It isn't used anymore and keeping it up-to-date is error-prone.
>
> Signed-off-by: Ben Pfaff
> ---
> lib/nx-match.h | 40
> 1 files changed, 0 insertions(+), 40 delet
Thank you. I pushed this to master.
On Thu, Jul 05, 2012 at 12:45:42PM -0700, Ethan Jackson wrote:
> Glad to see it go, thanks.
>
> Ethan
>
> On Thu, Jul 5, 2012 at 11:11 AM, Ben Pfaff wrote:
> > It isn't used anymore and keeping it up-to-date is error-prone.
> >
> > Signed-off-by: Ben Pfaff
Looks good, thanks.
On Thu, Jul 5, 2012 at 11:12 AM, Ben Pfaff wrote:
> It seemed like it could use one.
>
> Signed-off-by: Ben Pfaff
> ---
> lib/ofp-util.c | 10 ++
> 1 files changed, 10 insertions(+), 0 deletions(-)
>
> diff --git a/lib/ofp-util.c b/lib/ofp-util.c
> index d9a77f1..9
os.listdir("/proc/%d/fd" % pid) throws OSError if 'pid' died since the
list of pids was obtained.
Bug #12375.
Reported-by: Amey Bhide
Signed-off-by: Ben Pfaff
---
AUTHORS |1 +
utilities/ovs-check-dead-ifs.in |7 ++-
2 files changed, 7 insertions(+), 1 deleti
Looks good to me, thanks.
Ethan
On Thu, Jul 5, 2012 at 12:58 PM, Ben Pfaff wrote:
> os.listdir("/proc/%d/fd" % pid) throws OSError if 'pid' died since the
> list of pids was obtained.
>
> Bug #12375.
> Reported-by: Amey Bhide
> Signed-off-by: Ben Pfaff
> ---
> AUTHORS
Thank you. I pushed this to master.
On Thu, Jul 05, 2012 at 12:58:03PM -0700, Ethan Jackson wrote:
> Looks good, thanks.
>
> On Thu, Jul 5, 2012 at 11:12 AM, Ben Pfaff wrote:
> > It seemed like it could use one.
> >
> > Signed-off-by: Ben Pfaff
> > ---
> > lib/ofp-util.c | 10 ++
> >
Thanks, I pushed this to master and branch-1.7.
On Thu, Jul 05, 2012 at 12:59:56PM -0700, Ethan Jackson wrote:
> Looks good to me, thanks.
>
> Ethan
>
> On Thu, Jul 5, 2012 at 12:58 PM, Ben Pfaff wrote:
> > os.listdir("/proc/%d/fd" % pid) throws OSError if 'pid' died since the
> > list of pids
Looks good.
--Justin
On Jun 26, 2012, at 12:41 PM, Ben Pfaff wrote:
> Otherwise the log messages can be confusing when there's more than one
> bridge.
>
> Reported-by: Jacob Cherkas
> Signed-off-by: Ben Pfaff
> ---
> ofproto/ofproto.c | 62 +-
We have two Dell servers with multiple network interfaces and running
XenServer. We have one interface eth0 going to a physical switch and
interface eth2 cross cabled with the other system's eth2.
We want to direct some specific traffic {src-ip, src-port} from all VMs to
use eth2.
How do we configu
How about this?
bond: Sending learning packets on active-backup.
Suppose we have an active bond with two ports, eth1 and eth2,
attached to a standard L2 learning switch which does not know it's
participating in a bond (i.e. isn't running LACP). Suppose eth1 is
active and ther
Beautiful.
On Thu, Jul 05, 2012 at 02:30:55PM -0700, Ethan Jackson wrote:
> How about this?
>
> bond: Sending learning packets on active-backup.
>
> Suppose we have an active bond with two ports, eth1 and eth2,
> attached to a standard L2 learning switch which does not know it's
>
Thanks, I merged this.
Ethan
On Thu, Jul 5, 2012 at 2:54 PM, Ben Pfaff wrote:
> Beautiful.
>
> On Thu, Jul 05, 2012 at 02:30:55PM -0700, Ethan Jackson wrote:
>> How about this?
>>
>> bond: Sending learning packets on active-backup.
>>
>> Suppose we have an active bond with two ports, eth
Looks good to me.
--Justin
On Jun 26, 2012, at 2:43 PM, Ben Pfaff wrote:
> The layering between ofproto and ovs-vswitchd caused the datapath ID to be
> logged in a needlessly confusing way. First, ofproto would log its
> default datapath ID:
>
> using datapath ID 50540004
>
> the
Thanks, I'll push this soon.
On Thu, Jul 05, 2012 at 03:20:28PM -0700, Justin Pettit wrote:
> Looks good to me.
>
> --Justin
>
>
> On Jun 26, 2012, at 2:43 PM, Ben Pfaff wrote:
>
> > The layering between ofproto and ovs-vswitchd caused the datapath ID to be
> > logged in a needlessly confusing
Thanks, I'll push this soon.
On Thu, Jul 05, 2012 at 01:36:21PM -0700, Justin Pettit wrote:
> Looks good.
>
> --Justin
>
>
> On Jun 26, 2012, at 12:41 PM, Ben Pfaff wrote:
>
> > Otherwise the log messages can be confusing when there's more than one
> > bridge.
> >
> > Reported-by: Jacob Cherk
The ovs-lib strace wrapper requires the -D (run tracer process as a
detached grandchild, not as parent) option which does not exist in
older versions. This patch falls back to attaching to the running
process when the -D option does not exists.
Signed-off-by: Ethan Jackson
---
utilities/ovs-lib
On Thu, Jul 05, 2012 at 03:38:37PM -0700, Ethan Jackson wrote:
> The ovs-lib strace wrapper requires the -D (run tracer process as a
> detached grandchild, not as parent) option which does not exist in
> older versions. This patch falls back to attaching to the running
> process when the -D option
Looks good.
--Justin
On Jun 29, 2012, at 10:40 PM, Ben Pfaff wrote:
> This corrects the spelling of the OFOPERATION_* constants.
>
> Signed-off-by: Ben Pfaff
> ---
> ofproto/ofproto.c |6 +++---
> 1 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/ofproto/ofproto.c b/ofprot
Looks good.
--Justin
On Jun 29, 2012, at 10:40 PM, Ben Pfaff wrote:
> Signed-off-by: Ben Pfaff
> ---
> utilities/ovs-ofctl.8.in |6 +++---
> 1 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/utilities/ovs-ofctl.8.in b/utilities/ovs-ofctl.8.in
> index 9c4ea0c..3ca217b 100644
Looks good.
--Justin
On Jun 29, 2012, at 10:40 PM, Ben Pfaff wrote:
> The priority of exact-match flows is ignored only for the OF1.0 flow match
> format, never for NXM.
>
> Signed-off-by: Ben Pfaff
> ---
> include/openflow/nicira-ext.h |3 +--
> 1 files changed, 1 insertions(+), 2 deletio
Thanks.
By the way, I'm going to send out a new version of patches 10 and 11,
possibly today, so don't bother reviewing those yet. Patch 8 already
got committed earlier today (there was another series that depended on
it), so you can skip that one too. The rest of the series won't
really change.
> I'm worried about word-splitting on $logdir/$daemon.strace.log
> (e.g. if $logdir happens to contain a space). I think it would be
> better to write -o "$logdir/$daemon.strace.log" in the "set" and
> "strace" commands, just to be sure.
Could I just escape the quotes? i.e:
strace="strace -tt -T
On Thu, Jul 05, 2012 at 04:03:38PM -0700, Ethan Jackson wrote:
> > I'm worried about word-splitting on $logdir/$daemon.strace.log
> > (e.g. if $logdir happens to contain a space). I think it would be
> > better to write -o "$logdir/$daemon.strace.log" in the "set" and
> > "strace" commands, just t
On 7/5/12 12:26 PM, trinh tri wrote:
But in fact in my openvswitch, there are 3 physical ports. I would
like to ask how can I realize which physical port that the above flows
belong to
Try using sflow, I think it exports the port information.
More info:
http://blog.sflow.com/2011/10/compari
Gracias a la desinteresada ayuda de personas como Ud, hemos podido frenar
el desalojo del Hogar para niños de la Asociación Civil Sol Naciente,
donde viven
60 mamas con sus niños en situacion de calle (algunas con distintas
discapacidades), la mayoría con algun grado de de desnutricion y en
aband
On Thu, Jul 05, 2012 at 08:10:29PM -0300, Luiz Ozaki wrote:
> On 7/5/12 12:26 PM, trinh tri wrote:
> >
> >But in fact in my openvswitch, there are 3 physical ports. I would
> >like to ask how can I realize which physical port that the above
> >flows belong to
> Try using sflow, I think it exports t
Looks good.
--Justin
On Jun 29, 2012, at 10:40 PM, Ben Pfaff wrote:
> This seems like sensible return value semantics to me, even though the new
> operation is also available through rule->pending.
>
> This is a code cleanup only that should not affect behavior.
>
> Signed-off-by: Ben Pfaff
The ovs-lib strace wrapper requires the -D (run tracer process as a
detached grandchild, not as parent) option which does not exist in
older versions. This patch falls back to attaching to the running
process when the -D option does not exists.
Signed-off-by: Ethan Jackson
---
Here's another ve
On Thu, Jul 05, 2012 at 04:53:31PM -0700, Ethan Jackson wrote:
> The ovs-lib strace wrapper requires the -D (run tracer process as a
> detached grandchild, not as parent) option which does not exist in
> older versions. This patch falls back to attaching to the running
> process when the -D option
Dear Mr Luiz Ozaki and Mr Ben Pfaff!
Thank you vey much for you reply. I used flow-capture to capture flow
information. And the configure is like this:
/usr/bin/flow-capture -z0 -V5 -n 288 -N 0 -S1 -w /var/netflow/flows -E2G
0/0/ -R /usr/bin/flow-exporter
and the results:
flow-print < ft-v
On Thu, Jul 5, 2012 at 7:48 AM, ravi kerur wrote:
> I understand code review is time consuming and please note it's a bit time
> consuming to me as well as I have to retest/rebase everytime and I am not
> sure whether the amount of time I am spending on this is justifiable?
Reviewing this code is
On Thu, Jul 5, 2012 at 7:37 PM, Jesse Gross wrote:
> On Thu, Jul 5, 2012 at 7:48 AM, ravi kerur wrote:
> > I understand code review is time consuming and please note it's a bit
> time
> > consuming to me as well as I have to retest/rebase everytime and I am not
> > sure whether the amount of tim
Patches 1 through 4 are ready for final review.
I haven't really looked over patch 5. It's included only because
it was in the previous versions.
As before, this is available at git://benpfaff.org/openvswitch
in the of1.1 branch.
Thanks,
Ben.
Ben Pfaff (5):
ofp-msgs: New approach to encodin
It now duplicates ofp_aggregate_stats_reply except for alignment issues, so
we might as well unify the code.
Signed-off-by: Ben Pfaff
---
include/openflow/nicira-ext.h | 15 +++
lib/ofp-msgs.h|2 +-
lib/ofp-util.c| 57 +++---
Reviewed-by: Simon Horman
Signed-off-by: Ben Pfaff
---
include/openflow/openflow-1.0.h| 57 +++-
include/openflow/openflow-common.h | 23 ++
lib/ofp-msgs.c | 10 +++---
lib/ofp-msgs.h | 14
l
Signed-off-by: Ben Pfaff
---
v3->v4: Builds, passes unit tests.
---
include/openflow/nicira-ext.h |2 +-
include/openflow/openflow-1.0.h| 19 ---
include/openflow/openflow-common.h | 14 ++
lib/ofp-msgs.h |2 +-
lib/ofp-print.c
Signed-off-by: Ben Pfaff
---
v3->v4: Builds and passes unit tests. Somewhat incomplete, I think.
---
include/openflow/openflow-1.1.h| 17 ++--
include/openflow/openflow-common.h | 10 ++
lib/ofp-errors.h |3 +
lib/ofp-util.c | 181 ++
56 matches
Mail list logo
