[ovs-dev] Hello

2012-06-11 Thread Mrs Nana Tanko
Hello, My name is Mrs Nana Tanko,I'm contacting you for an important Investment proposal. Feel free to write me back for more details. Regards Mrs Nana Tanko___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/de

[ovs-dev] Greetings from Lisa

2012-06-11 Thread lisa slybert
    Greetings from Lisa   How are you today? I hope you are fine!I feel like making friends with you via this medium. My name is Lisa Slybert, female single 24 years of age and single.It will be my pleasure to know you and cultivate a healthy friendship with you.My interest centers in finding my l

Re: [ovs-dev] [PATCH] [PATCH v3] Add parsing and serialisation of OXM matches

2012-06-11 Thread Ben Pfaff
On Fri, Jun 08, 2012 at 04:02:45PM +0900, Simon Horman wrote: > This code, which leverages the existing NXM implementation, > adds parsing and serialisation of OXM matches. Test cases > have also been provided. > > This patch only implements parsing and serialisation of OXM fields that > are alrea

Re: [ovs-dev] [PATCH] ofproto: Update comment.

2012-06-11 Thread Ben Pfaff
Thanks, I pushed this. On Wed, May 30, 2012 at 02:00:22PM -0700, Ethan Jackson wrote: > Looks good, thanks. > > Ethan > > On Wed, May 30, 2012 at 1:15 PM, Ben Pfaff wrote: > > CC: Justin Pettit > > Signed-off-by: Ben Pfaff > > --- > >  ofproto/ofproto.c |    4 ++-- > >  1 files changed, 2 ins

[ovs-dev] [PATCH 1/2] ovs-ofctl: Fix handling of unexpected replies in dump_stats_transaction().

2012-06-11 Thread Ben Pfaff
dump_stats_transaction() ignored errors and other non-stats replies to its request and would continue to wait forever. This fixes the problem. Signed-off-by: Ben Pfaff --- utilities/ovs-ofctl.c | 17 ++--- 1 files changed, 14 insertions(+), 3 deletions(-) diff --git a/utilities/o

[ovs-dev] [PATCH 2/2] ofproto: Report nonexistent ports and queues as errors in queue stats.

2012-06-11 Thread Ben Pfaff
Until now, Open vSwitch has ignored missing ports and queues in most cases in queue stats requests, simply returning an empty set of statistics. It seems that it is better to report an error, so this commit does this. Reported-by: Prabina Pattnaik Signed-off-by: Ben Pfaff --- AUTHORS

Re: [ovs-dev] [token bucket 1/3] pinsched: Completely fill the token bucket at initialization.

2012-06-11 Thread Ethan Jackson
Looks good, thanks. Ethan On Wed, May 30, 2012 at 5:16 PM, Ben Pfaff wrote: > This code, which dates to August 2008, initially sets the packet-in > scheduler token buckets to 10% full, without any rationale.  I suspect > that this is just a typo for 100% full, which I think would be more > conve

Re: [ovs-dev] [token bucket 2/3] sat-math: Introduce macro version of SAT_MUL.

2012-06-11 Thread Ethan Jackson
Looks good, thanks. Ethan On Wed, May 30, 2012 at 5:16 PM, Ben Pfaff wrote: > The macro version can be used in a constant expression, such as an > initializer for a variable with static lifetime.  (Otherwise, it's better > to use the function.) > > Signed-off-by: Ben Pfaff > --- >  lib/sat-math

Re: [ovs-dev] [token bucket 3/3] token-bucket: New library for generic rate-limiting.

2012-06-11 Thread Ethan Jackson
Looks good, only minor nit picks. > +struct token_bucket { > +    /* Configuration settings. */ > +    unsigned int rate;          /* Tokens added per millisecond. */ > +    unsigned int burst;         /* Max cumulative tokens credit. */ > + > +    /* Current status. */ > +    unsigned int tokens;

[ovs-dev] [PATCH] Add a FAQ.

2012-06-11 Thread Ben Pfaff
Signed-off-by: Ben Pfaff --- FAQ| 308 Makefile.am|1 + NEWS |1 + debian/automake.mk |1 + debian/openvswitch-common.docs |1 + rhel/openvswitch.spec.in

[ovs-dev] [PATCH] datapath: Check correct return value from skb_gso_segment()

2012-06-11 Thread Pravin B Shelar
Fix return check typo. Signed-off-by: Pravin B Shelar Bug #11933 --- datapath/datapath.c |6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/datapath/datapath.c b/datapath/datapath.c index 605253d..7fb0cef 100644 --- a/datapath/datapath.c +++ b/datapath/datapath.c @@ -4

Re: [ovs-dev] [PATCH] datapath: Check correct return value from skb_gso_segment()

2012-06-11 Thread Ben Pfaff
Great catch! (This is not a review, since that's up to Jesse.) On Mon, Jun 11, 2012 at 06:13:19PM -0700, Pravin B Shelar wrote: > Fix return check typo. > > Signed-off-by: Pravin B Shelar > > Bug #11933 > --- > datapath/datapath.c |6 -- > 1 file changed, 4 insertions(+), 2 deletions(

Re: [ovs-dev] [PATCH] datapath: Check correct return value from skb_gso_segment()

2012-06-11 Thread Jesse Gross
On Jun 12, 2012, at 10:13 AM, Pravin B Shelar wrote: > Fix return check typo. > > Signed-off-by: Pravin B Shelar > > Bug #11933 > --- > datapath/datapath.c |6 -- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/datapath/datapath.c b/datapath/datapath.c > index 605253

Re: [ovs-dev] [PATCH] Add a FAQ.

2012-06-11 Thread Justin Pettit
This is great, Ben! Thank you for doing it! > + and as soon as I ran the "add-port" command I lost all connectivity > + through eth0. Help! I like the sense of urgency you've added. Maybe you missed your calling in fiction. "Fifty Shades of Overlay"? Networking fabric explores new terri