[ovs-dev] (no subject)

2012-02-03 Thread Simon Horman
Hi, this series contains the sole patch that I made to 1.4.0 when preparing to upload 1.4.0-1 to Debian. ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

[ovs-dev] [PATCH] debian: Add dependency on ${misc:Depends} to openvswitch-test

2012-02-03 Thread Simon Horman
This is necessary as openvswitch-test makes use of debhelper. As reported by lintian. Signed-off-by: Simon Horman --- debian/control |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/debian/control b/debian/control index 5861447..4f71465 100644 --- a/debian/control +++ b

[ovs-dev] Processing of openvswitch_1.4.0-1_amd64.changes

2012-02-03 Thread Debian FTP Masters
openvswitch_1.4.0-1_amd64.changes uploaded successfully to localhost along with the files: openvswitch_1.4.0-1.dsc openvswitch_1.4.0.orig.tar.gz openvswitch_1.4.0-1.debian.tar.gz openvswitch-common_1.4.0-1_amd64.deb openvswitch-switch_1.4.0-1_amd64.deb openvswitch-ipsec_1.4.0-1_amd64.de

Re: [ovs-dev] Bug#656448: [PATCH] debian: Delete log files correctly when packages are purged.

2012-02-03 Thread Simon Horman
Version: 1.4.0-1 On Tue, Jan 24, 2012 at 02:38:00PM -0800, Ben Pfaff wrote: > # Update Debian BTS. > tags 656448 + confirmed upstream fixed-upstream > thanks > > Thanks, I pushed this fix to master, branch-1.2, branch-1.3, > branch-1.4, branch-1.5. It will appear in the next Debian upload. I h

Re: [ovs-dev] Call for assistance: OpenFlow 1.1 and 1.2 support in Open vSwitch

2012-02-03 Thread Simon Horman
On Wed, Dec 07, 2011 at 08:22:28PM -0800, Ben Pfaff wrote: > OpenFlow 1.1 was released about 9 months ago. Open vSwitch doesn't > yet have support for this protocol version. Furthermore, OpenFlow 1.2 > will likely be released by the end of 2011. [snip] > How to contribute > - >

[ovs-dev] openvswitch_1.4.0-1_amd64.changes is NEW

2012-02-03 Thread Debian FTP Masters
openvswitch-brcompat_1.4.0-1_amd64.deb to main/o/openvswitch/openvswitch-brcompat_1.4.0-1_amd64.deb openvswitch-common_1.4.0-1_amd64.deb to main/o/openvswitch/openvswitch-common_1.4.0-1_amd64.deb openvswitch-controller_1.4.0-1_amd64.deb to main/o/openvswitch/openvswitch-controller_1.4.0-1_amd

[ovs-dev] Bug#637802: marked as done (Please add DKMS support)

2012-02-03 Thread Debian Bug Tracking System
Your message dated Fri, 3 Feb 2012 17:45:14 +0900 with message-id <20120203084513.gd17...@verge.net.au> and subject line Re: [ovs-dev] Bug#637802: Bug #637802: DKMS support now implemented upstream has caused the Debian Bug report #637802, regarding Please add DKMS support to be marked as done. T

[ovs-dev] Bug#651798: marked as done (Fails to build against Linux 3.1)

2012-02-03 Thread Debian Bug Tracking System
Your message dated Fri, 3 Feb 2012 17:38:48 +0900 with message-id <20120203083843.ga17...@verge.net.au> and subject line Re: [ovs-dev] Bug#651798: Bug#651798: Fails to build against Linux 3.1 has caused the Debian Bug report #651798, regarding Fails to build against Linux 3.1 to be marked as done.

[ovs-dev] Bug#656448: marked as done (openvswitch-pki: unowned files after purge (policy 6.8, 10.8))

2012-02-03 Thread Debian Bug Tracking System
Your message dated Fri, 3 Feb 2012 17:40:19 +0900 with message-id <20120203084018.gb17...@verge.net.au> and subject line Re: [ovs-dev] Bug#656448: [PATCH] debian: Delete log files correctly when packages are purged. has caused the Debian Bug report #656448, regarding openvswitch-pki: unowned files

[ovs-dev] Bug#657115: marked as done (openvswitch-datapath-dkms: Failed to compile with kernel 3.2)

2012-02-03 Thread Debian Bug Tracking System
Your message dated Fri, 3 Feb 2012 17:41:54 +0900 with message-id <20120203084154.gc17...@verge.net.au> and subject line Re: [ovs-dev] Bug#657115: Bug#657115: openvswitch-datapath-dkms: Failed to compile with kernel 3.2 has caused the Debian Bug report #657115, regarding openvswitch-datapath-dkms:

Re: [ovs-dev] [PATCH v4] rhel: Enable DHCP in redhat network scripts.

2012-02-03 Thread Alexey I. Froloff
On Tue, Jan 31, 2012 at 01:53:49PM -0800, Gurucharan Shetty wrote: > + case ${OVSDHCPINTERFACES} in > + ${OVSINTF#ifcfg-} | \ > + "${OVSINTF#ifcfg-},"* | \ > + *",${OVSINTF#ifcfg-}" | \ > +

Re: [ovs-dev] [PATCH 1/3] [bug 2462] flex-array: Flex arrays-cleanup.

2012-02-03 Thread Pravin Shelar
On Thu, Feb 2, 2012 at 7:05 PM, Jesse Gross wrote: > On Thu, Feb 2, 2012 at 6:58 AM, Pravin B Shelar wrote: >> cleanups: >>        - removes flex_array_shrink() as there is no caller. >>        - add flex_array_init() >>        - Add few 'const's. >> >> Signed-off-by: Pravin B Shelar > > Since w

Re: [ovs-dev] Call for assistance: OpenFlow 1.1 and 1.2 support in Open vSwitch

2012-02-03 Thread Ben Pfaff
On Fri, Feb 03, 2012 at 05:51:22PM +0900, Simon Horman wrote: > On Wed, Dec 07, 2011 at 08:22:28PM -0800, Ben Pfaff wrote: > > OpenFlow 1.1 was released about 9 months ago. Open vSwitch doesn't > > yet have support for this protocol version. Furthermore, OpenFlow 1.2 > > will likely be released b

Re: [ovs-dev] [PATCH] debian: Add dependency on ${misc:Depends} to openvswitch-test

2012-02-03 Thread Ben Pfaff
On Fri, Feb 03, 2012 at 05:34:17PM +0900, Simon Horman wrote: > This is necessary as openvswitch-test makes use of debhelper. > > As reported by lintian. > > Signed-off-by: Simon Horman Thanks. I pushed this to master, branch-1.5, branch-1.4. ___ dev

Re: [ovs-dev] your mail

2012-02-03 Thread Ben Pfaff
On Fri, Feb 03, 2012 at 05:34:16PM +0900, Simon Horman wrote: > this series contains the sole patch that I made to 1.4.0 > when preparing to upload 1.4.0-1 to Debian. Thank you very much for the upload, and for the patch. ___ dev mailing list dev@openvsw

[ovs-dev] [PATCH] rhel: Simplify ifup-ovs script use of "case".

2012-02-03 Thread Ben Pfaff
Suggested-by: "Alexey I. Froloff" Signed-off-by: Ben Pfaff --- Not tested, please scrutinize! rhel/etc_sysconfig_network-scripts_ifup-ovs |9 +++-- 1 files changed, 3 insertions(+), 6 deletions(-) diff --git a/rhel/etc_sysconfig_network-scripts_ifup-ovs b/rhel/etc_sysconfig_network-sc

Re: [ovs-dev] [PATCH v4] rhel: Enable DHCP in redhat network scripts.

2012-02-03 Thread Ben Pfaff
On Fri, Feb 03, 2012 at 04:30:36PM +0400, Alexey I. Froloff wrote: > On Tue, Jan 31, 2012 at 01:53:49PM -0800, Gurucharan Shetty wrote: > > + case ${OVSDHCPINTERFACES} in > > + ${OVSINTF#ifcfg-} | \ > > + "${OVSINTF#ifcfg-},"* |

Re: [ovs-dev] [port-ranges 3/3] Add support for bitwise matching on TCP and UDP ports.

2012-02-03 Thread Ben Pfaff
On Thu, Feb 02, 2012 at 05:51:22PM -0800, Justin Pettit wrote: > Ethan already covered the code part, but just a couple of questions on the > documentation: > > > +Bitwise matches on transport ports are rarely useful in isolation, but > > +a group of them can be used to reduce the number of flows

Re: [ovs-dev] [PATCH] rhel: Simplify ifup-ovs script use of "case".

2012-02-03 Thread Gurucharan Shetty
Looks good. On Fri, Feb 3, 2012 at 9:19 AM, Ben Pfaff wrote: > Suggested-by: "Alexey I. Froloff" > Signed-off-by: Ben Pfaff > --- > Not tested, please scrutinize! > > rhel/etc_sysconfig_network-scripts_ifup-ovs |9 +++-- > 1 files changed, 3 insertions(+), 6 deletions(-) > > diff --gi

Re: [ovs-dev] [PATCH] rhel: Simplify ifup-ovs script use of "case".

2012-02-03 Thread Ben Pfaff
Thanks. I dropped the update to the copyright notice (which happened accidentally) and pushed this. On Fri, Feb 03, 2012 at 09:33:11AM -0800, Gurucharan Shetty wrote: > Looks good. > > On Fri, Feb 3, 2012 at 9:19 AM, Ben Pfaff wrote: > > > Suggested-by: "Alexey I. Froloff" > > Signed-off-by:

Re: [ovs-dev] [PATCH v4] rhel: Enable DHCP in redhat network scripts.

2012-02-03 Thread Gurucharan Shetty
> > > Guru, should we make that change? I suggested a comma originally > because I though it would be easier to write the shell fragments (no > need for quotes) but I didn't realize that there was precedent for > spaces. > > For consistency, it may be a good idea. I will come up with the patch for

Re: [ovs-dev] [PATCH v4] rhel: Enable DHCP in redhat network scripts.

2012-02-03 Thread Ben Pfaff
On Fri, Feb 03, 2012 at 09:37:18AM -0800, Gurucharan Shetty wrote: > > > > > > Guru, should we make that change? I suggested a comma originally > > because I though it would be easier to write the shell fragments (no > > need for quotes) but I didn't realize that there was precedent for > > spaces

Re: [ovs-dev] [PATCH v4] rhel: Enable DHCP in redhat network scripts.

2012-02-03 Thread Alexey I. Froloff
On Fri, Feb 03, 2012 at 09:21:29AM -0800, Ben Pfaff wrote: > My understanding is that ordinary Linux bridges don't work that way > with the RHEL network scripts. Is that correct? I think that it is > a good idea for OVS and the Linux bridge to act the same way, to the > extent that it is possible

Re: [ovs-dev] [PATCH] flow: Rename 'tp_addr' field in flow_hash_symmetric_l4().

2012-02-03 Thread Ethan Jackson
> My intention in inventing the dl_, nw_, and tp_ prefixes in struct flow > way back when was for them to stand for "data link", "network", and > "transport", the names of layer 2 through 4.  So "tp" seems a little > truncated to me.  How about "tp_port"? Ahhh, I had thought tp stands for "transpo

[ovs-dev] Processed: tagging as pending bugs that are closed by packages in NEW

2012-02-03 Thread Debian Bug Tracking System
Processing commands for cont...@bugs.debian.org: > # Fri Feb 3 19:03:08 UTC 2012 > # Tagging as pending bugs that are closed by packages in NEW > # http://ftp-master.debian.org/new.html > # > # Source package in NEW: openvswitch > tags 653645 + pending Bug #653645 [openvswitch-common] openvswitch

Re: [ovs-dev] [PATCH] xenserver: Simplify RPM build instructions.

2012-02-03 Thread Ethan Jackson
There's a redundant newline at the end of xenserver/automake.mk Otherwise looks good to me assuming you tried the new instructions. Ethan On Thu, Feb 2, 2012 at 16:38, Ben Pfaff wrote: > I got tired of trying to follow them properly myself. > > Signed-off-by: Ben Pfaff > --- >  INSTALL.XenServ

[ovs-dev] [PATCH] rhel: Space separated list of DHCP interfaces in network scripts.

2012-02-03 Thread Gurucharan Shetty
Use space separated list of DHCP interfaces for OVSDHCPINTERFACES instead of comma separated list. This is done to maintain consistency with BOND_IFACES. Signed-off-by: Gurucharan Shetty --- rhel/README.RHEL|2 +- rhel/etc_sysconfig_network-scripts_ifup-ovs |8

Re: [ovs-dev] [PATCH] rhel: Space separated list of DHCP interfaces in network scripts.

2012-02-03 Thread Ben Pfaff
On Fri, Feb 03, 2012 at 12:27:37PM -0800, Gurucharan Shetty wrote: > Use space separated list of DHCP interfaces for OVSDHCPINTERFACES > instead of comma separated list. This is done to maintain > consistency with BOND_IFACES. > > Signed-off-by: Gurucharan Shetty Looks good to me. Thank you. __

[ovs-dev] [PATCH] ovs-ofctl: Fix minor memory leaks.

2012-02-03 Thread Ben Pfaff
Found by valgrind. Signed-off-by: Ben Pfaff --- utilities/ovs-ofctl.c |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/utilities/ovs-ofctl.c b/utilities/ovs-ofctl.c index 9b1a1b2..7df0a90 100644 --- a/utilities/ovs-ofctl.c +++ b/utilities/ovs-ofctl.c @@ -447,6 +447,8 @

Re: [ovs-dev] [PATCH] ovs-ofctl: Fix minor memory leaks.

2012-02-03 Thread Ethan Jackson
Looks good, Ethan On Fri, Feb 3, 2012 at 12:38, Ben Pfaff wrote: > Found by valgrind. > > Signed-off-by: Ben Pfaff > --- > utilities/ovs-ofctl.c |4 > 1 files changed, 4 insertions(+), 0 deletions(-) > > diff --git a/utilities/ovs-ofctl.c b/utilities/ovs-ofctl.c > index 9b1a1b2..7df0a

[ovs-dev] [of1.1 draft v2 0/7] of1.1 draft series rebased

2012-02-03 Thread Ben Pfaff
This is a revised version of the of1.1 draft series originally posted starting here: http://openvswitch.org/pipermail/dev/2011-December/013585.html A few of the original patches have since been polished up and committed, so those are not present here. This is also true of some parts of the conten

[ovs-dev] [of1.1 draft v2 3/7] Move content of openflow.h into openflow-1.0.h.

2012-02-03 Thread Ben Pfaff
This prepares for a gradual introduction of definitions from OpenFlow 1.1 and later, by making it clearer that the current definitions are specific to OpenFlow 1.0. --- build-aux/check-structs | 51 +- include/openflow/automake.mk| 26 +- include/ope

[ovs-dev] [of1.1 draft v2 4/7] Begin breaking openflow-1.0.h into common and version-specific definitions.

2012-02-03 Thread Ben Pfaff
The intention is that, as each OpenFlow 1.1 feature is added to Open vSwitch, the corresponding protocol definitions will be broken up this way: - Definitions that are the same in OF1.0 and OF1.1 will retain the "OFP" or "ofp" prefix and move to openflow-common.h. - Definitions that are s

[ovs-dev] [of1.1 draft v2 5/7] ofp-util: Add functions for working with OpenFlow 1.1 port numbers.

2012-02-03 Thread Ben Pfaff
OpenFlow 1.1 extends port numbers to 32 bits. Initially we plan to support only port numbers in the 16-bit range in Open vSwitch. However the OF1.1 reserved ports have high-valued fixed numbers that require translation to high fixed values in the 16-bit range for OF1.0. These new functions provi

[ovs-dev] [of1.1 draft v2 6/7] Break OFPT_* constants into common value and 1.0- and 1.1-specific values.

2012-02-03 Thread Ben Pfaff
--- include/openflow/openflow-1.0.h| 41 ++- include/openflow/openflow-1.1.h| 23 +++- include/openflow/openflow-common.h | 22 +++ lib/ofp-print.c| 18 lib/ofp-util.c

Re: [ovs-dev] [PATCH] ovs-ofctl: Fix minor memory leaks.

2012-02-03 Thread Ben Pfaff
Thank you. I pushed it. On Fri, Feb 03, 2012 at 12:40:06PM -0800, Ethan Jackson wrote: > Looks good, > > Ethan > > On Fri, Feb 3, 2012 at 12:38, Ben Pfaff wrote: > > Found by valgrind. > > > > Signed-off-by: Ben Pfaff > > --- > > utilities/ovs-ofctl.c |4 > > 1 files changed, 4 inse

[ovs-dev] Comments regarding openvswitch_1.4.0-1_amd64.changes

2012-02-03 Thread Luca Falavigna
Hi, please note openvswitch-test contains files for python2.4, which has not been a supported version for lots of time. Cheers, Luca ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

[ovs-dev] [PATCH] debian: Don't install Python modules for obsolete Python versions.

2012-02-03 Thread Ben Pfaff
Python 2.4 is obsolete, not present in Debian squeeze or sid, so don't install Python modules for it. It would be better to just put the files directly into /usr/share/pyshared/ovs/, instead of in site-packages for some specific Python version, but this causes problems for builds on squeeze, as do

Re: [ovs-dev] [PATCH] xenserver: Simplify RPM build instructions.

2012-02-03 Thread Ben Pfaff
On Fri, Feb 03, 2012 at 11:37:03AM -0800, Ethan Jackson wrote: > There's a redundant newline at the end of xenserver/automake.mk Thanks, I removed it. > Otherwise looks good to me assuming you tried the new instructions. They work for me. I'll push this soon. Thanks, Ben.

Re: [ovs-dev] Call for assistance: OpenFlow 1.1 and 1.2 support in Open vSwitch

2012-02-03 Thread Ben Pfaff
On Fri, Feb 03, 2012 at 07:56:56AM -0800, Ben Pfaff wrote: > On Fri, Feb 03, 2012 at 05:51:22PM +0900, Simon Horman wrote: > > On Wed, Dec 07, 2011 at 08:22:28PM -0800, Ben Pfaff wrote: > > > OpenFlow 1.1 was released about 9 months ago. Open vSwitch doesn't > > > yet have support for this protoco

Re: [ovs-dev] [PATCH] debian: Don't install Python modules for obsolete Python versions.

2012-02-03 Thread Ethan Jackson
Looks good, thanks. Ethan On Fri, Feb 3, 2012 at 13:33, Ben Pfaff wrote: > Python 2.4 is obsolete, not present in Debian squeeze or sid, so don't > install Python modules for it. > > It would be better to just put the files directly into > /usr/share/pyshared/ovs/, instead of in site-packages f

[ovs-dev] openvswitch_1.4.0-1_amd64.changes ACCEPTED into unstable

2012-02-03 Thread Debian FTP Masters
Accepted: openvswitch-brcompat_1.4.0-1_amd64.deb to main/o/openvswitch/openvswitch-brcompat_1.4.0-1_amd64.deb openvswitch-common_1.4.0-1_amd64.deb to main/o/openvswitch/openvswitch-common_1.4.0-1_amd64.deb openvswitch-controller_1.4.0-1_amd64.deb to main/o/openvswitch/openvswitch-controlle

[ovs-dev] Bug#653645: marked as done (openvswitch-common: Please depend on "python (>= 2.7) | python-argparse")

2012-02-03 Thread Debian Bug Tracking System
Your message dated Fri, 03 Feb 2012 21:42:41 + with message-id and subject line Bug#653645: fixed in openvswitch 1.4.0-1 has caused the Debian Bug report #653645, regarding openvswitch-common: Please depend on "python (>= 2.7) | python-argparse" to be marked as done. This means that you clai

Re: [ovs-dev] [PATCH] debian: Don't install Python modules for obsolete Python versions.

2012-02-03 Thread Ben Pfaff
Thank you for the review. I pushed this to "master". I'll push it to maintenance branches once the autobuilder gives me the thumbs-up. Thanks Ethan and Luca, Ben. On Fri, Feb 03, 2012 at 01:37:55PM -0800, Ethan Jackson wrote: > Looks good, thanks. > > Ethan > > On Fri, Feb 3, 2012 at 13:33,

[ovs-dev] [PATCH] xenserver: Remove dead code from ovs-xapi-sync.

2012-02-03 Thread Ben Pfaff
Nothing actually uses call_vsctl(), so remove it and its dependencies. Signed-off-by: Ben Pfaff --- .../usr_share_openvswitch_scripts_ovs-xapi-sync| 10 -- 1 files changed, 0 insertions(+), 10 deletions(-) diff --git a/xenserver/usr_share_openvswitch_scripts_ovs-xapi-sync b/xense

Re: [ovs-dev] [PATCH] xenserver: Remove dead code from ovs-xapi-sync.

2012-02-03 Thread Ethan Jackson
Looks good to me. Ethan On Fri, Feb 3, 2012 at 15:40, Ben Pfaff wrote: > Nothing actually uses call_vsctl(), so remove it and its dependencies. > > Signed-off-by: Ben Pfaff > --- > .../usr_share_openvswitch_scripts_ovs-xapi-sync| 10 -- > 1 files changed, 0 insertions(+), 10 del

[ovs-dev] [PATCH] coverage: Time out the coverage hash suppression once a day.

2012-02-03 Thread Ben Pfaff
Otherwise coverage log messages will eventually get rotated out of the system logs and never reappear (before restarting a given daemon). Bug #1452. Signed-off-by: Ben Pfaff --- lib/coverage.c | 13 +++-- 1 files changed, 11 insertions(+), 2 deletions(-) diff --git a/lib/coverage.c b/

Re: [ovs-dev] [async-msgs 01/13] ofproto: Allow service controllers to become masters and slaves.

2012-02-03 Thread Ethan Jackson
Seems fine to me. Ethan On Thu, Jan 26, 2012 at 15:53, Ben Pfaff wrote: > I don't remember why we disallow this. It seems reasonable to me to enable > it. A test in a upcoming commit relies upon the ability. > > Signed-off-by: Ben Pfaff > --- > ofproto/ofproto.c |4 > 1 files chang

Re: [ovs-dev] [PATCH 1/3] [bug 2462] flex-array: Flex arrays-cleanup.

2012-02-03 Thread Jesse Gross
On Fri, Feb 3, 2012 at 5:45 AM, Pravin Shelar wrote: > On Thu, Feb 2, 2012 at 7:05 PM, Jesse Gross wrote: >> It's not clear to me that flex_array_init() is that big of a win. >> struct flex_array stores the base array inside of it, so it is defined >> to be PAGE_SIZE.  Since it is so large, stori

Re: [ovs-dev] [async-msgs 02/13] DESIGN: Document the properties of flow_mods.

2012-02-03 Thread Ethan Jackson
I don't think the question marks add much and they look a bit funny. Don't feel strongly about it thought. OFPT_FLOW_MOD in->is confusing In the table "match on out port?" -> "match on out_port?" to be consistent with the description above. Otherwise looks good, Ethan On Thu, Jan 26, 2012 at