On Thu, Feb 02, 2012 at 05:51:22PM -0800, Justin Pettit wrote: > Ethan already covered the code part, but just a couple of questions on the > documentation: > > > +Bitwise matches on transport ports are rarely useful in isolation, but > > +a group of them can be used to reduce the number of flows required to > > +match on a range of transport ports. For example, suppose that the > > +goal is to match TCP source ports 1000 to 1999, inclusive. One way is > > +to insert 1001 flows, each of which matches on a single source port. > > I ran out of fingers to verify, but isn't that 1000 flows?
Oops. (The text started out as ports 1000 to 2000, then I changed my mind and forgot to change 1001 -> 1000). > > +Like the exact-match forms of \fBtp_src\fR and \fBtp_dst\fR described > > +above, the bitwise match forms apply only when When \fBdl_type\fR and > > > There are two "when"s here. Oops. I pushed the following to master: --8<--------------------------cut here-------------------------->8-- From: Ben Pfaff <b...@nicira.com> Date: Fri, 3 Feb 2012 09:23:44 -0800 Subject: [PATCH] ovs-ofctl: Fix typos in manpage. Reported-by: Justin Pettit <jpet...@nicira.com> Signed-off-by: Ben Pfaff <b...@nicira.com> --- utilities/ovs-ofctl.8.in | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/utilities/ovs-ofctl.8.in b/utilities/ovs-ofctl.8.in index 54db80d..1c1b709 100644 --- a/utilities/ovs-ofctl.8.in +++ b/utilities/ovs-ofctl.8.in @@ -463,7 +463,7 @@ Bitwise matches on transport ports are rarely useful in isolation, but a group of them can be used to reduce the number of flows required to match on a range of transport ports. For example, suppose that the goal is to match TCP source ports 1000 to 1999, inclusive. One way is -to insert 1001 flows, each of which matches on a single source port. +to insert 1000 flows, each of which matches on a single source port. Another way is to look at the binary representations of 1000 and 1999, as follows: .br @@ -509,7 +509,7 @@ Only Open vSwitch 1.6 and later supports bitwise matching on transport ports. .IP Like the exact-match forms of \fBtp_src\fR and \fBtp_dst\fR described -above, the bitwise match forms apply only when When \fBdl_type\fR and +above, the bitwise match forms apply only when \fBdl_type\fR and \fBnw_proto\fR specify TCP or UDP. . .IP \fBicmp_type=\fItype\fR -- 1.7.2.5 _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
