openvswitch_1.2.1-2_amd64.changes uploaded successfully to localhost
along with the files:
openvswitch_1.2.1-2.dsc
openvswitch_1.2.1-2.debian.tar.gz
openvswitch-common_1.2.1-2_amd64.deb
openvswitch-switch_1.2.1-2_amd64.deb
openvswitch-ipsec_1.2.1-2_amd64.deb
openvswitch-controller_1.2.1
Accepted:
openvswitch-brcompat_1.2.1-2_amd64.deb
to main/o/openvswitch/openvswitch-brcompat_1.2.1-2_amd64.deb
openvswitch-common_1.2.1-2_amd64.deb
to main/o/openvswitch/openvswitch-common_1.2.1-2_amd64.deb
openvswitch-controller_1.2.1-2_amd64.deb
to main/o/openvswitch/openvswitch-controlle
Hi,
I inadvertently included my previously posted changes
to transition to dh_python2 in the 1.2.1-1 upload.
Unfortunately this breaks openvswitch-ipsec as it
is no longer able to import ovs.db.
In order to limit the propagation of buggy packages
I have uploaded 1.2.1-2, this short series
reflec
---
debian/changelog | 14 ++
1 files changed, 14 insertions(+), 0 deletions(-)
diff --git a/debian/changelog b/debian/changelog
index 15dee08..3940891 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,16 @@
+openvswitch (1.2.1-2) unstable; urgency=low
+
+ * Install p
---
v2:
* Install python library in /usr/share/pyshared/python-openvswitch/ovs/
instead of /usr/share/pyshared/python-openvswitch/ovs/ to allow
the library to be found using the default sys.path as it could
be before this change.
* Remove PYTHONPATH from debian/openvswitch-ipsec.init as
On Fri, Aug 26, 2011 at 06:03:41PM +0900, Simon Horman wrote:
> I inadvertently included my previously posted changes
> to transition to dh_python2 in the 1.2.1-1 upload.
> Unfortunately this breaks openvswitch-ipsec as it
> is no longer able to import ovs.db.
>
> In order to limit the propagatio
On Thu, Aug 25, 2011 at 04:28:33PM -0700, Ethan Jackson wrote:
> The only rtnetlink specific functionality contained in the
> rtnetlink module is the use of the NETLINK_ROUTE protocol. This
> can easily be passed in by callers.
>
> In preparation for generalization, this patch renames
> rtnetlink
On Thu, Aug 25, 2011 at 04:28:34PM -0700, Ethan Jackson wrote:
> This patch renames the rtnetlink module's code to "nln" for
> "netlink notifier". Callers are now required to pass in the
> netlink protocol to he newly renamed nln_create() function.
Looks good, thank you.
_
On Thu, Aug 25, 2011 at 04:28:35PM -0700, Ethan Jackson wrote:
> This function will be helpful when the multicast group of a
> netlink-notifier isn't known at creation time.
I see that this gets used in the final commit in this series, but I
don't yet see why. Why can't dpif-linux determine the m
Looks good to me, thank you.
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
I did have a reason for doing it this way which may-or-may-not be
valid. I'm worried about the case where dpif_linux_init() fails, and
the nln handle is NULL. In this case, no new dpifs will be able to
register with this NULL nln. Then, if later on dpif_linux_init()
tries again and is successful,
dpif_linux_init() only ever tries once and either succeeds or fails
for all time. Maybe it should be more tolerant, but that's a separate
issue.
So I think that it's OK to do it the simple way.
On Fri, Aug 26, 2011 at 10:11:57AM -0700, Ethan Jackson wrote:
> I did have a reason for doing it this
On Thu, Aug 25, 2011 at 04:28:38PM -0700, Ethan Jackson wrote:
> Currently dpif-linux listens for vport change events using
> rtnetlink notifications. This patch switches to the ovs genl
> notification system.
>
> Feature #6809.
This looks fine to me.
Notifications are often subtle, so I hope t
Sounds good to me, I'll drop this patch and send out an incremental on
the final patch.
Ethan
On Fri, Aug 26, 2011 at 10:24, Ben Pfaff wrote:
> dpif_linux_init() only ever tries once and either succeeds or fails
> for all time. Maybe it should be more tolerant, but that's a separate
> issue.
>
Thanks for the review. Here is an incremental which I've applied to deal with
the deletion of nl_set_mcgroup().
---
lib/dpif-linux.c | 25 ++---
1 files changed, 14 insertions(+), 11 deletions(-)
diff --git a/lib/dpif-linux.c b/lib/dpif-linux.c
index 5f52e0b..a9bb36a 10064
On Fri, Aug 26, 2011 at 11:37:54AM -0700, Ethan Jackson wrote:
> Thanks for the review. Here is an incremental which I've applied to deal with
> the deletion of nl_set_mcgroup().
Thanks. It looks good.
I don't think that open_dpif() can be called if nln is NULL, so the
"if (nln)" in that functi
Ah, good point. I removed the check.
Ethan
On Fri, Aug 26, 2011 at 12:07, Ben Pfaff wrote:
> On Fri, Aug 26, 2011 at 11:37:54AM -0700, Ethan Jackson wrote:
>> Thanks for the review. Here is an incremental which I've applied to deal
>> with
>> the deletion of nl_set_mcgroup().
>
> Thanks. It
On Wed, Aug 24, 2011 at 03:56:31PM -0700, Ben Pfaff wrote:
> Philippe Jung reported that specifying a nonempty
> "trunks" column in the Port table didn't work as expected. This fixes
> the problem and adds tests to prevent regression.
>
> The dpif-netdev patch that leads off the series fixes a b
I've always intended this to work, but either I never tested it or the
support rotted.
This will soon be used in some tests that I will add.
---
lib/dpif-netdev.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/lib/dpif-netdev.c b/lib/dpif-netdev.c
index d0a50f3..a61da4e
This replaces the previous (unreviewed) "trunks" series.
Ben Pfaff (4):
dpif-netdev: Also allow "dummy" netdevs in a dpif-netdev.
ofproto-dpif: Fix behavior when a subset of VLANs is trunked.
ofproto-dpif: Add tests for VLAN handling.
bitmap: New function to allocate a bitmap initialized t
---
lib/bitmap.c | 21 -
lib/bitmap.h |2 ++
2 files changed, 22 insertions(+), 1 deletions(-)
diff --git a/lib/bitmap.c b/lib/bitmap.c
index df3c4eb..76a667a 100644
--- a/lib/bitmap.c
+++ b/lib/bitmap.c
@@ -1,5 +1,5 @@
/*
- * Copyright (c) 2008, 2009 Nicira Networks.
+
These tests would have caught the bug fixed in the previous commit
"ofproto-dpif: Fix behavior when a subset of VLANs is trunked."
---
tests/ofproto-dpif.at | 79 +++
tests/ofproto-macros.at | 43 +
2 files changed, 122 inse
Reported-by: Philippe Jung
---
ofproto/ofproto-dpif.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/ofproto/ofproto-dpif.c b/ofproto/ofproto-dpif.c
index f09c230..c05ca9e 100644
--- a/ofproto/ofproto-dpif.c
+++ b/ofproto/ofproto-dpif.c
@@ -1056,7 +1056,7 @@ bundle_set(
From: Philippe Jung
Significant updates by Ben Pfaff, including:
* Comment, coding style, indentation updates.
* Documentation improved.
* Added tests.
* Dropped PORT_VLAN_EMPTY.
---
NEWS |3 +
ofproto/ofproto-dpif.c | 123 -
If /dev/log doesn't exist or cannot be contacted, ovs-monitor-ipsec would
abort with an exception. This allows it to start up and run.
It's pretty common for a chroot used for testing not to have a syslogd
instance set up and running, so this limitation caused testing problems.
Reported-by: Simo
The use of eth_addr_is_multicast() to see if a reasonable address was
found always caused me momentary confusion. This commit uses a flag
instead, and also saves a bit of unnecessary array reading and writing.
---
vswitchd/bridge.c | 11 ++-
1 files changed, 6 insertions(+), 5 deletions
On Fri, Aug 26, 2011 at 03:10:54PM -0700, Justin Pettit wrote:
> The use of eth_addr_is_multicast() to see if a reasonable address was
> found always caused me momentary confusion. This commit uses a flag
> instead, and also saves a bit of unnecessary array reading and writing.
Looks good, thanks
On Aug 26, 2011, at 3:15 PM, Ben Pfaff wrote:
> On Fri, Aug 26, 2011 at 03:10:54PM -0700, Justin Pettit wrote:
>> The use of eth_addr_is_multicast() to see if a reasonable address was
>> found always caused me momentary confusion. This commit uses a flag
>> instead, and also saves a bit of unnece
On Fri, Aug 26, 2011 at 01:59:19PM -0700, Ben Pfaff wrote:
> If /dev/log doesn't exist or cannot be contacted, ovs-monitor-ipsec would
> abort with an exception. This allows it to start up and run.
>
> It's pretty common for a chroot used for testing not to have a syslogd
> instance set up and ru
On Sat, Aug 27, 2011 at 08:29:35AM +0900, Simon Horman wrote:
> On Fri, Aug 26, 2011 at 01:59:19PM -0700, Ben Pfaff wrote:
> > If /dev/log doesn't exist or cannot be contacted, ovs-monitor-ipsec would
> > abort with an exception. This allows it to start up and run.
> >
> > It's pretty common for
---
lib/socket-util.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/lib/socket-util.c b/lib/socket-util.c
index c436724..2d554ac 100644
--- a/lib/socket-util.c
+++ b/lib/socket-util.c
@@ -222,7 +222,7 @@ int
drain_rcvbuf(int fd)
{
socklen_t rcvbuf_len;
-size_
I guess that's really a valgrind bug, but the fix is OK with me.
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
I wonder if it's a bug with the syscall on my system or something? Is
it possible that getsockopt isn't initializing rcvbuf though it should
be?
Ethan
On Fri, Aug 26, 2011 at 17:03, Ben Pfaff wrote:
> I guess that's really a valgrind bug, but the fix is OK with me.
>
I doubt it's a kernel bug. valgrind probably just doesn't realize
that getsockopt initialized the variable.
On Fri, Aug 26, 2011 at 05:05:03PM -0700, Ethan Jackson wrote:
> I wonder if it's a bug with the syscall on my system or something? Is
> it possible that getsockopt isn't initializing rcvbu
Found with valgrind.
---
lib/cfm.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/lib/cfm.c b/lib/cfm.c
index e56ccab..dc55d4b 100644
--- a/lib/cfm.c
+++ b/lib/cfm.c
@@ -299,6 +299,7 @@ cfm_compose_ccm(struct cfm *cfm, struct ofpbuf *packet,
ccm->mpid = htons(cfm->mp
Looks good.
--Justin
On Aug 26, 2011, at 5:13 PM, Ethan Jackson wrote:
> Found with valgrind.
> ---
> lib/cfm.c |1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/lib/cfm.c b/lib/cfm.c
> index e56ccab..dc55d4b 100644
> --- a/lib/cfm.c
> +++ b/lib/cfm.c
> @@ -299,6 +29
On Aug 19, 2011, at 8:39 PM, Jesse Gross wrote:
> The final piece that I just thought of, is the relationship of the MTU
> check in vport_send() and skb_warn_if_lro(). The former will catch
> hardware LRO and interfaces with mismatched MTU and the later the
> deprecated (but still extant software
37 matches
Mail list logo