On Aug 19, 2011, at 8:39 PM, Jesse Gross wrote: > The final piece that I just thought of, is the relationship of the MTU > check in vport_send() and skb_warn_if_lro(). The former will catch > hardware LRO and interfaces with mismatched MTU and the later the > deprecated (but still extant software LRO, precursor to GRO). When > disabling LRO, we will turn off both the software and hardware > versions so there is some overlap. The checks are useful but they'll > trigger warnings if we start using LRO. That's not strictly a > backwards compatibility problem but it will still create a little bit > of a versioning mess. What if we just move all of them to > netdev_send(), which is where they are actually useful?
If I understand what you're proposing, I'm not entirely clear on the benefit. What's the benefit of putting those checks in netdev_send() as opposed to vport_send() and netdev_port_receive()? I may be misunderstanding what you're suggesting. Were you thinking something along the lines of the attached patch? --Justin
0001-datapath-Move-LRO-checks-to-netdev_send.patch
Description: Binary data
_______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
