[ovs-dev] [PATCH] configure: Improve error message when pkg-config is missing.

2011-07-13 Thread Ben Pfaff
Until now, when pkg-config is missing, Autoconf emitted this error: error: possibly undefined macro: PKG_CHECK_MODULES This commit changes the message to: error: Please install pkg-config. This should be easier for users to interpret. Suggested-by: Ethan Jackson --- m4/openvswitch.m4 |

Re: [ovs-dev] [PATCH] configure: Improve error message when pkg-config is missing.

2011-07-13 Thread Ethan Jackson
Looks good to me. Ethan On Wed, Jul 13, 2011 at 10:59, Ben Pfaff wrote: > Until now, when pkg-config is missing, Autoconf emitted this error: >    error: possibly undefined macro: PKG_CHECK_MODULES > This commit changes the message to: >    error: Please install pkg-config. > This should be easi

Re: [ovs-dev] [bugtool2] ovs-bugtool: Add plugins previously used only under XenServer.

2011-07-13 Thread Ethan Jackson
Looks Good. Ethan On Fri, Jul 1, 2011 at 16:59, Ben Pfaff wrote: > All of the xen-bugtool plugins that OVS has previously installed only under > XenServer are equally useful with Debian and other distributions, so > this commit installs and uses them everywhere. > --- >  Makefile.am            

Re: [ovs-dev] [bugtool3] ovs-bugtool: Add an OVSDB snapshot to ovs-bugtool output.

2011-07-13 Thread Ethan Jackson
Looks Good. Ethan On Wed, Jul 6, 2011 at 10:43, Ben Pfaff wrote: > The ovs-bugtool output already includes a copy of the configuration > database file, but this file omits many instantaneous details.  For > example, it does not include any information about controller connection > status or inte

Re: [ovs-dev] [bugtool4] ovs-bugtool: Include conf.db backups in bugtool output.

2011-07-13 Thread Ethan Jackson
Looks Good. Ethan On Thu, Jul 7, 2011 at 13:19, Ben Pfaff wrote: > When an upgrade or downgrade fails due to OVSDB issues, it is useful to > have the old versions of the database available. > --- >  utilities/bugtool/automake.mk                      |    1 + >  .../bugtool/plugins/system-logs/op

Re: [ovs-dev] [bugtool4] ovs-bugtool: Include conf.db backups in bugtool output.

2011-07-13 Thread Ben Pfaff
Thanks for the bugtool{2,3,4} reviews. I pushed these patches. On Wed, Jul 13, 2011 at 11:29:59AM -0700, Ethan Jackson wrote: > Looks Good. > > Ethan > > On Thu, Jul 7, 2011 at 13:19, Ben Pfaff wrote: > > When an upgrade or downgrade fails due to OVSDB issues, it is useful to > > have the old

Re: [ovs-dev] [nic-401] ofproto-dpif: Do not mirror L2 multicast switch protocols to VLANs.

2011-07-13 Thread Ben Pfaff
On Tue, Jul 12, 2011 at 06:36:21PM -0700, Andrew Evans wrote: > On Mon, Jul 11, 2011 at 3:37 PM, Ben Pfaff wrote: > > +/* Returns true if a packet with Ethernet destination MAC 'dst' may be > > mirrored > > + * to a VLAN. ?In general most packets may be mirrored but we want to drop > > + * protoc

[ovs-dev] [ab-vlan-maint] bond: Drop packets on backup slaves.

2011-07-13 Thread Ethan Jackson
Currently, OVS accepts incoming traffic on all slaves participating in a bond. In Linux active-backup bonding, all traffic which comes in on backup slaves is dropped. This patch causes OVS to do the same. Bug #6125. --- vswitchd/bridge.c | 15 +++ 1 files changed, 15 insertions(+)

[ovs-dev] [ab-vlan-maint] Backport active backup fix to vlan-maint.

2011-07-13 Thread Ethan Jackson
This patch backports Commit 7ba7dcf014 "bond: Drop packets on backup slaves." to the vlan-maint branch. Ethan Jackson (1): bond: Drop packets on backup slaves. vswitchd/bridge.c | 15 +++ 1 files changed, 15 insertions(+), 0 deletions(-) -- 1.7.6 __

Re: [ovs-dev] [ab-vlan-maint] Backport active backup fix to vlan-maint.

2011-07-13 Thread Ethan Jackson
Huh, strange. i expected this to come with a 0/1 prefix in the subject. You can ignore this message i suppose, it's just saying that the next patch is a backport from master to vlan-maint. Ethan On Wed, Jul 13, 2011 at 13:56, Ethan Jackson wrote: > This patch backports Commit 7ba7dcf014 "bond:

Re: [ovs-dev] [ab-vlan-maint] bond: Drop packets on backup slaves.

2011-07-13 Thread Ben Pfaff
On Wed, Jul 13, 2011 at 01:56:40PM -0700, Ethan Jackson wrote: > Currently, OVS accepts incoming traffic on all slaves participating > in a bond. In Linux active-backup bonding, all traffic which comes > in on backup slaves is dropped. This patch causes OVS to do the > same. > > Bug #6125. Look

Re: [ovs-dev] [ab-vlan-maint] bond: Drop packets on backup slaves.

2011-07-13 Thread Ethan Jackson
Thanks. Ethan On Wed, Jul 13, 2011 at 13:58, Ben Pfaff wrote: > On Wed, Jul 13, 2011 at 01:56:40PM -0700, Ethan Jackson wrote: >> Currently, OVS accepts incoming traffic on all slaves participating >> in a bond.  In Linux active-backup bonding, all traffic which comes >> in on backup slaves is d

Re: [ovs-dev] [ab-vlan-maint] bond: Drop packets on backup slaves.

2011-07-13 Thread Ethan Jackson
I've tested this and it works, so I merged it. Ethan On Wed, Jul 13, 2011 at 13:58, Ethan Jackson wrote: > Thanks. > > Ethan > > On Wed, Jul 13, 2011 at 13:58, Ben Pfaff wrote: >> On Wed, Jul 13, 2011 at 01:56:40PM -0700, Ethan Jackson wrote: >>> Currently, OVS accepts incoming traffic on all s

[ovs-dev] [PATCH] VLAN actions should use push/pop semantics

2011-07-13 Thread pravin shelar
From: pravin following patch changes OVS VLAN actions from MODIFY and STRIP to more generic PUSH and POP. As this patch replaces MODIFY with PUSH semantic , userapce is fixed accordingly. --- datapath/actions.c | 63 +- datapath/datapath.c

Re: [ovs-dev] [PATCH] VLAN actions should use push/pop semantics

2011-07-13 Thread Jesse Gross
On Wed, Jul 13, 2011 at 9:24 AM, pravin shelar wrote: > diff --git a/lib/dpif-netdev.c b/lib/dpif-netdev.c > index 3b93a4c..5c52ea6 100644 > --- a/lib/dpif-netdev.c > +++ b/lib/dpif-netdev.c > @@ -1304,11 +1304,11 @@ dp_netdev_execute_actions(struct dp_netdev *dp, >                                

[ovs-dev] [PATCH] VLAN actions should use push/pop semantics 2

2011-07-13 Thread pravin shelar
following patch changes OVS VLAN actions from MODIFY and STRIP to more generic PUSH and POP. As this patch replaces MODIFY with PUSH semantic, action mapping done in userpace is fixed accordingly. --- datapath/actions.c | 63 +- datapath/d

[ovs-dev] [PATCH 0/1] capwap key support, v4

2011-07-13 Thread Valient Gough
This improves on the previous patches by tightening packet header validation by checking most of the header fields before parsing the packet. Also ensures that all packets of a fragment stream have the same key by including the key as part of the fragment queue identifier (and the hash). Valient

[ovs-dev] [PATCH 1/1] datapath: add key support to CAPWAP tunnel

2011-07-13 Thread Valient Gough
Add tunnel key support to CAPWAP vport. Uses the optional WSI field in a CAPWAP header to store a 64bit key. It can also be used without keys, in which case it is backward compatible with the old code. Documentation about the WSI field format is in CAPWAP.txt. Signed-off-by: Valient Gough ---