On Tue, Jul 12, 2011 at 06:36:21PM -0700, Andrew Evans wrote: > On Mon, Jul 11, 2011 at 3:37 PM, Ben Pfaff <b...@nicira.com> wrote: > > +/* Returns true if a packet with Ethernet destination MAC 'dst' may be > > mirrored > > + * to a VLAN. ?In general most packets may be mirrored but we want to drop > > + * protocols that ?*/ > > Did you intend to write something more here?
Oops, I folded in this fix, thanks. diff --git a/ofproto/ofproto-dpif.c b/ofproto/ofproto-dpif.c index 5b663e1..f8af68c 100644 --- a/ofproto/ofproto-dpif.c +++ b/ofproto/ofproto-dpif.c @@ -3362,7 +3362,7 @@ vlan_is_mirrored(const struct ofmirror *m, int vlan) /* Returns true if a packet with Ethernet destination MAC 'dst' may be mirrored * to a VLAN. In general most packets may be mirrored but we want to drop - * protocols that */ + * protocols that may confuse switches. */ static bool eth_dst_may_rspan(const uint8_t dst[ETH_ADDR_LEN]) { _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev