Re: [ovs-dev] kernel module testing

2015-07-28 Thread Finucane, Stephen
> On 7/28/15 3:19 AM, Finucane, Stephen wrote: > For what it's worth, I also think that something like Gerrit would be > useful given the number of platforms that OVS is running on. Right > now, it's seems like we're doing the human-powered version, which is > Guru, Daniele, or

Re: [ovs-dev] kernel module testing

2015-07-28 Thread Thomas F Herbert
On 7/28/15 3:19 AM, Finucane, Stephen wrote: For what it's worth, I also think that something like Gerrit would be useful given the number of platforms that OVS is running on. Right now, it's seems like we're doing the human-powered version, which is Guru, Daniele, or Ben complain when something

Re: [ovs-dev] kernel module testing

2015-07-28 Thread Finucane, Stephen
> > > For what it's worth, I also think that something like Gerrit would be > > > useful given the number of platforms that OVS is running on. Right > > > now, it's seems like we're doing the human-powered version, which is > > > Guru, Daniele, or Ben complain when something breaks Windows, DPDK, >

Re: [ovs-dev] kernel module testing

2015-07-21 Thread Jesse Gross
On Sat, Jul 18, 2015 at 6:46 PM, Ben Pfaff wrote: > On Fri, Jul 17, 2015 at 04:18:08PM -0700, Jesse Gross wrote: >> On Thu, Jul 16, 2015 at 12:04 PM, Kyle Mestery wrote: >> > On Thu, Jul 16, 2015 at 12:55 PM, Ben Pfaff wrote: >> > >> >> On Tue, Jul 14, 2015 at 07:45:42AM +, Pritesh Kothari (

Re: [ovs-dev] kernel module testing

2015-07-18 Thread Pritesh Kothari (pritkoth)
> On Jul 18, 2015, at 9:46 AM, Ben Pfaff wrote: > > I'm happy to encourage people to submit changes via Github, as an > experiment. > > I don't know of a way to experiment with Gerrit, because Gerrit wants > exclusive access to your repository. There is a Gerrit service for There is actually

Re: [ovs-dev] kernel module testing

2015-07-18 Thread Ben Pfaff
On Fri, Jul 17, 2015 at 04:18:08PM -0700, Jesse Gross wrote: > On Thu, Jul 16, 2015 at 12:04 PM, Kyle Mestery wrote: > > On Thu, Jul 16, 2015 at 12:55 PM, Ben Pfaff wrote: > > > >> On Tue, Jul 14, 2015 at 07:45:42AM +, Pritesh Kothari (pritkoth) wrote: > >> > > >> > > On Jul 13, 2015, at 9:40

Re: [ovs-dev] kernel module testing

2015-07-17 Thread Jesse Gross
On Thu, Jul 16, 2015 at 12:04 PM, Kyle Mestery wrote: > On Thu, Jul 16, 2015 at 12:55 PM, Ben Pfaff wrote: > >> On Tue, Jul 14, 2015 at 07:45:42AM +, Pritesh Kothari (pritkoth) wrote: >> > >> > > On Jul 13, 2015, at 9:40 PM, Ben Pfaff wrote: >> > > >> > > On Tue, Jul 14, 2015 at 12:34:14AM +

Re: [ovs-dev] kernel module testing

2015-07-16 Thread Kyle Mestery
On Thu, Jul 16, 2015 at 12:55 PM, Ben Pfaff wrote: > On Tue, Jul 14, 2015 at 07:45:42AM +, Pritesh Kothari (pritkoth) wrote: > > > > > On Jul 13, 2015, at 9:40 PM, Ben Pfaff wrote: > > > > > > On Tue, Jul 14, 2015 at 12:34:14AM +, Pritesh Kothari (pritkoth) > wrote: > > >> How about auto

Re: [ovs-dev] kernel module testing

2015-07-16 Thread Ben Pfaff
On Tue, Jul 14, 2015 at 07:45:42AM +, Pritesh Kothari (pritkoth) wrote: > > > On Jul 13, 2015, at 9:40 PM, Ben Pfaff wrote: > > > > On Tue, Jul 14, 2015 at 12:34:14AM +, Pritesh Kothari (pritkoth) wrote: > >> How about automating this using travis and gerrit, so no commit gets in > >> un

Re: [ovs-dev] kernel module testing

2015-07-14 Thread Pritesh Kothari (pritkoth)
> On Jul 13, 2015, at 9:40 PM, Ben Pfaff wrote: > > On Tue, Jul 14, 2015 at 12:34:14AM +, Pritesh Kothari (pritkoth) wrote: >> How about automating this using travis and gerrit, so no commit gets in >> unless it passes sanity tests? This also simplifies review process as well. > > Travis do

Re: [ovs-dev] kernel module testing

2015-07-13 Thread Ben Pfaff
On Tue, Jul 14, 2015 at 12:34:14AM +, Pritesh Kothari (pritkoth) wrote: > How about automating this using travis and gerrit, so no commit gets in > unless it passes sanity tests? This also simplifies review process as well. Travis doesn't test the kernel module, and as far as I know it can't.

Re: [ovs-dev] kernel module testing

2015-07-13 Thread Pritesh Kothari (pritkoth)
Hi Ben, How about automating this using travis and gerrit, so no commit gets in unless it passes sanity tests? This also simplifies review process as well. Regards, Pritesh > On Jul 13, 2015, at 5:14 PM, Ben Pfaff wrote: > > Lately I've starting hearing about commits breaking the Windows kerne