Re: [ovs-dev] [RFC 3/3] ovs-vsctl-bashcomp: Documentation and unit tests.

2015-03-09 Thread Alex Wang
Thx Ben, I reposted the series as PATCH with your Acked-by in first and third patches. Could you have a look of the second (2/3)? Thanks, Alex Wang, On Mon, Mar 9, 2015 at 9:13 AM, Ben Pfaff wrote: > On Sun, Mar 08, 2015 at 05:30:19PM -0700, Alex Wang wrote: > > Sorry for the delayed reply, I

Re: [ovs-dev] [RFC 3/3] ovs-vsctl-bashcomp: Documentation and unit tests.

2015-03-09 Thread Ben Pfaff
On Sun, Mar 08, 2015 at 05:30:19PM -0700, Alex Wang wrote: > Sorry for the delayed reply, I tested it, & looked fine to me, > > So, Ben, what do you think about this workaround? Fine with me. If the tests pass without hanging when running in parallel: Acked-by: Ben Pfaff ___

Re: [ovs-dev] [RFC 3/3] ovs-vsctl-bashcomp: Documentation and unit tests.

2015-03-08 Thread Alex Wang
Sorry for the delayed reply, I tested it, & looked fine to me, So, Ben, what do you think about this workaround? Thanks, Alex Wang, On Fri, Mar 6, 2015 at 7:35 AM, Peter Amidon wrote: > On Thu, 05 Mar 2015 21:58:38 -0800: Ben Pfaff wrote: > > Without digging into it, it's not obvious to me

Re: [ovs-dev] [RFC 3/3] ovs-vsctl-bashcomp: Documentation and unit tests.

2015-03-06 Thread Peter Amidon
On Thu, 05 Mar 2015 21:58:38 -0800: Ben Pfaff wrote: > Without digging into it, it's not obvious to me why you need to know the > bash prompt. Can you just set a known prompt instead? In a few cases the script has to print some output to the user (e.g. if the user attempts to complete while

Re: [ovs-dev] [RFC 3/3] ovs-vsctl-bashcomp: Documentation and unit tests.

2015-03-05 Thread Ben Pfaff
On Thu, Mar 05, 2015 at 06:16:04PM -0800, Alex Wang wrote: > I found the issue but not the root cause, > > turns out, the autotest really does not like opening 'interactive shell' > inside the > AT_CHECK. The test hangs at (in function _ovs_vsctl_get_PS1): > > """ > v="$(bash --norc --noprofile

Re: [ovs-dev] [RFC 3/3] ovs-vsctl-bashcomp: Documentation and unit tests.

2015-03-05 Thread Alex Wang
I found the issue but not the root cause, turns out, the autotest really does not like opening 'interactive shell' inside the AT_CHECK. The test hangs at (in function _ovs_vsctl_get_PS1): """ v="$(bash --norc --noprofile -i 2>&1 <<< $'PS1=\"'"$myPS1"$'\" \n# Begin prompt\n# End prompt')" """ Un

Re: [ovs-dev] [RFC 3/3] ovs-vsctl-bashcomp: Documentation and unit tests.

2015-03-04 Thread Alex Wang
On Tue, Mar 3, 2015 at 9:51 PM, Ben Pfaff wrote: > On Mon, Feb 23, 2015 at 08:49:00AM -0800, Alex Wang wrote: > > This commit includes the unit tests for ovs-vsctl-bashcomp > > and refines the ovs-command-bashcomp.INSTALL.md to introduce > > the bash completion for ovs-vsctl. > > > > Signed-off-b

Re: [ovs-dev] [RFC 3/3] ovs-vsctl-bashcomp: Documentation and unit tests.

2015-03-03 Thread Ben Pfaff
On Mon, Feb 23, 2015 at 08:49:00AM -0800, Alex Wang wrote: > This commit includes the unit tests for ovs-vsctl-bashcomp > and refines the ovs-command-bashcomp.INSTALL.md to introduce > the bash completion for ovs-vsctl. > > Signed-off-by: Alex Wang It appears to me that there is something wrong