Re: [ovs-dev] [PATCHv2] dpif: Support flow_get in dpif_operate().

2014-08-13 Thread Ben Pfaff
Great, thanks. On Thu, Aug 14, 2014 at 09:43:27AM +1200, Joe Stringer wrote: > Thanks for the review, I plan to push with the following changes (I noticed > that the other dpif-linux operations - PUT,DEL have redundant memsets, so > deleting them too): > > diff --git a/lib/dpif-linux.c b/lib/dpif

Re: [ovs-dev] [PATCHv2] dpif: Support flow_get in dpif_operate().

2014-08-13 Thread Joe Stringer
Thanks for the review, I plan to push with the following changes (I noticed that the other dpif-linux operations - PUT,DEL have redundant memsets, so deleting them too): diff --git a/lib/dpif-linux.c b/lib/dpif-linux.c index e767d9f..c4420f4 100644 --- a/lib/dpif-linux.c +++ b/lib/dpif-linux.c @@

Re: [ovs-dev] [PATCHv2] dpif: Support flow_get in dpif_operate().

2014-08-13 Thread Ben Pfaff
On Wed, Aug 13, 2014 at 12:53:31PM +1200, Joe Stringer wrote: > This cleans up the dpif interface to make it more consistent with the > other dpif operations, and allows flows to be fetched in batches. > > Signed-off-by: Joe Stringer Thanks. I like it. I'd move this memset() in the error case