On Wed, Aug 13, 2014 at 12:53:31PM +1200, Joe Stringer wrote:
> This cleans up the dpif interface to make it more consistent with the
> other dpif operations, and allows flows to be fetched in batches.
>
> Signed-off-by: Joe Stringer <[email protected]>
Thanks. I like it.
I'd move this memset() in the error case in dpif_linux_operate__():
+ if (op->error) {
+ memset(get->flow, 0, sizeof *get->flow);
+ }
into the DPIF_OP_FLOW_GET error case in dpif_operate(), so that all of
the dpifs can take advantage of this logic (as the other DPIF_OP_*
cases do).
The comment in dpif.h says that DPIF_FLOW_BUFSIZE is a mandatory
size. I don't think the implementations rely on that.
Acked-by: Ben Pfaff <[email protected]>
_______________________________________________
dev mailing list
[email protected]
http://openvswitch.org/mailman/listinfo/dev
