n mailto:li...@vmware.com>>,
"dev@openvswitch.org<mailto:dev@openvswitch.org>"
mailto:dev@openvswitch.org>>
Subject: Re: [ovs-dev] [PATCH v6] datapath-windows: Add Geneve support
Thanks Alin and Nithin for the review and Jesse for the clarification.
I've addressed all
On Fri, Jun 17, 2016 at 5:10 PM, Yin Lin wrote:
> Thanks Alin and Nithin for the review and Jesse for the clarification.
>
> I've addressed all the comments except this one:
>
> "One general comment is that we are validating the tunnel options in the
> hot path - basically for each packet when we
Thanks Alin and Nithin for the review and Jesse for the clarification.
I've addressed all the comments except this one:
"One general comment is that we are validating the tunnel options in the
hot path - basically for each packet when we execute the actions for the
flow. Obvious solution for this
On Wed, Jun 15, 2016 at 10:12 PM, Nithin Raju wrote:
diff --git a/datapath-windows/ovsext/Geneve.c
b/datapath-windows/ovsext/Geneve.c
new file mode 100644
index 000..8190a15
--- /dev/null
+++ b/datapath-windows/ovsext/Geneve.c
>>[...]
+geneveHdr = (GeneveHdr *)(
Hi Jesse,
Thanks for the comments. My responses inlined.
>>> /* Number of packet attributes required to store OVS tunnel key. */
>>>-#define NUM_PKT_ATTR_REQUIRED 3
>>>+#define NUM_PKT_ATTR_REQUIRED 35
>>>+#define TUN_OPT_MAX_LEN 255
>>
>> Wouldn¹t it have been better for alignment purposes to hav
On Wed, Jun 15, 2016 at 3:43 PM, Nithin Raju wrote:
> -Original Message-
> From: Yin Lin
> Date: Monday, June 13, 2016 at 1:39 PM
> To: "dev@openvswitch.org" , Nithin Raju
>
> Subject: [PATCH v6] datapath-windows: Add Geneve suppor
>
>>diff --git a/datapath-windows/ovsext/DpInternal.h
>>
Hi Yin,
Thanks for the patch. The code looks good overall, but for the comments.
One general observation is that I saw a few instances where you were
declaring variables in the middle of a scope. While it is legal, IMO, it
makes the code ugly esp. if the code is not written in blocks. So, I¹d
requ
Hi Yin,
Thanks a lot for the patch, and welcome to the team :).
Please try to limit lines to 79 characters per coding style
(https://github.com/openvswitch/ovs/blob/master/datapath-windows/CodingStyle).
Your patch is dependent on a patch that Nithin sent
http://openvswitch.org/pipermail/dev/20
