Re: [ovs-dev] [PATCH v4] dpif-netdev: Implement batched flow dumping.

2014-06-25 Thread Ryan Wilson
> > > Thanks Ryan! > > I folded in this change to ensure that the caller could specify any > 'max_flows' that it likes. It doesn't make sense for the caller to > have to be aware of the implementation's limitations: > > I was debating between either using an assert or using the min of max_flows an

Re: [ovs-dev] [PATCH v4] dpif-netdev: Implement batched flow dumping.

2014-06-25 Thread Ben Pfaff
On Mon, Jun 23, 2014 at 12:36:11PM -0700, Ryan Wilson wrote: > Previously, flows were retrieved one by one when dumping flows for > datapaths of type 'netdev'. This increased contention for the dump's > mutex, negatively affecting revalidator performance. > > This patch retrieves batches of flows