Re: [ovs-dev] [PATCH v4] datapath: Add support for VXLAN tunnels to Open vSwitch

2012-11-28 Thread Chris Wright
* Kyle Mestery (kmestery) (kmest...@cisco.com) wrote: > On Nov 27, 2012, at 9:24 PM, Chris Wright wrote: > > * Kyle Mestery (kmest...@cisco.com) wrote: > >> + udp_encap_enable(); > > > > This is a new function, did you provide a fallback/noop (since it looks > > like it's meant to build back to

Re: [ovs-dev] [PATCH v4] datapath: Add support for VXLAN tunnels to Open vSwitch

2012-11-28 Thread Kyle Mestery (kmestery)
On Nov 27, 2012, at 9:24 PM, Chris Wright wrote: > * Kyle Mestery (kmest...@cisco.com) wrote: >> @@ -23,6 +23,7 @@ >> /kmemdup.c >> /loop_counter.c >> /modules.order >> +/net_namespace.c >> /netdevice.c >> /net_namespace.c >> /random32.c > > spurious change? > >> @@ -39,5 +40,6 @@ >> /vport-in

Re: [ovs-dev] [PATCH v4] datapath: Add support for VXLAN tunnels to Open vSwitch

2012-11-28 Thread Chris Wright
* Kyle Mestery (kmestery) (kmest...@cisco.com) wrote: > On Nov 28, 2012, at 11:01 AM, Chris Wright wrote: > > Right. OTV is commonly, but not exclusively, used now. Post draft > > we should expect a final port number. But it's a relatively small set > > of functionality to maintain to keep the

Re: [ovs-dev] [PATCH v4] datapath: Add support for VXLAN tunnels to Open vSwitch

2012-11-28 Thread Kyle Mestery (kmestery)
On Nov 28, 2012, at 11:01 AM, Chris Wright wrote: > * Kyle Mestery (kmestery) (kmest...@cisco.com) wrote: >> On Nov 28, 2012, at 10:34 AM, Chris Wright >> wrote: >>> * Kyle Mestery (kmestery) (kmest...@cisco.com) wrote: On Nov 27, 2012, at 9:24 PM, Chris Wright wrote: > * Kyle Mestery

Re: [ovs-dev] [PATCH v4] datapath: Add support for VXLAN tunnels to Open vSwitch

2012-11-28 Thread Chris Wright
* Kyle Mestery (kmestery) (kmest...@cisco.com) wrote: > On Nov 28, 2012, at 10:34 AM, Chris Wright > wrote: > > * Kyle Mestery (kmestery) (kmest...@cisco.com) wrote: > >> On Nov 27, 2012, at 9:24 PM, Chris Wright wrote: > >>> * Kyle Mestery (kmest...@cisco.com) wrote: > + > +vx

Re: [ovs-dev] [PATCH v4] datapath: Add support for VXLAN tunnels to Open vSwitch

2012-11-28 Thread Kyle Mestery (kmestery)
On Nov 28, 2012, at 10:34 AM, Chris Wright wrote: > * Kyle Mestery (kmestery) (kmest...@cisco.com) wrote: >> On Nov 27, 2012, at 9:24 PM, Chris Wright wrote: >>> * Kyle Mestery (kmest...@cisco.com) wrote: + + vxlan_port->port = dst_port; + vxlan_port->count++; + hlist_add_

Re: [ovs-dev] [PATCH v4] datapath: Add support for VXLAN tunnels to Open vSwitch

2012-11-28 Thread Chris Wright
* Kyle Mestery (kmestery) (kmest...@cisco.com) wrote: > On Nov 27, 2012, at 9:24 PM, Chris Wright wrote: > > * Kyle Mestery (kmest...@cisco.com) wrote: > >> + > >> + vxlan_port->port = dst_port; > >> + vxlan_port->count++; > >> + hlist_add_head(&vxlan_port->hash_node, > >> + vxl

Re: [ovs-dev] [PATCH v4] datapath: Add support for VXLAN tunnels to Open vSwitch

2012-11-28 Thread Kyle Mestery (kmestery)
On Nov 27, 2012, at 9:24 PM, Chris Wright wrote: > * Kyle Mestery (kmest...@cisco.com) wrote: >> @@ -23,6 +23,7 @@ >> /kmemdup.c >> /loop_counter.c >> /modules.order >> +/net_namespace.c >> /netdevice.c >> /net_namespace.c >> /random32.c > > spurious change? > >> @@ -39,5 +40,6 @@ >> /vport-in

Re: [ovs-dev] [PATCH v4] datapath: Add support for VXLAN tunnels to Open vSwitch

2012-11-28 Thread Kyle Mestery (kmestery)
On Nov 27, 2012, at 5:13 PM, Jesse Gross wrote: > On Tue, Nov 27, 2012 at 12:19 PM, Kyle Mestery wrote: >> Note: v4 of this patch removes VXLAN over IPSEC support, >> per an offline conversation with Jesse. >> >> Add support for VXLAN tunnels to Open vSwitch. Add support >> for setting the des

Re: [ovs-dev] [PATCH v4] datapath: Add support for VXLAN tunnels to Open vSwitch

2012-11-27 Thread Chris Wright
* Kyle Mestery (kmest...@cisco.com) wrote: > @@ -23,6 +23,7 @@ > /kmemdup.c > /loop_counter.c > /modules.order > +/net_namespace.c > /netdevice.c > /net_namespace.c > /random32.c spurious change? > @@ -39,5 +40,6 @@ > /vport-internal_dev.c > /vport-netdev.c > /vport-patch.c > +/vport-vxl

Re: [ovs-dev] [PATCH v4] datapath: Add support for VXLAN tunnels to Open vSwitch

2012-11-27 Thread Jesse Gross
On Tue, Nov 27, 2012 at 12:19 PM, Kyle Mestery wrote: > Note: v4 of this patch removes VXLAN over IPSEC support, > per an offline conversation with Jesse. > > Add support for VXLAN tunnels to Open vSwitch. Add support > for setting the destination UDP port on a per-port basis. > This is done by ad

Re: [ovs-dev] [PATCH v4] datapath: Add support for VXLAN tunnels to Open vSwitch

2012-11-27 Thread Kyle Mestery (kmestery)
On Nov 27, 2012, at 4:31 PM, Stephen Hemminger wrote: > On Tue, 27 Nov 2012 15:19:24 -0500 > Kyle Mestery wrote: > >> Note: v4 of this patch removes VXLAN over IPSEC support, >> per an offline conversation with Jesse. >> >> Add support for VXLAN tunnels to Open vSwitch. Add support >> for setti

Re: [ovs-dev] [PATCH v4] datapath: Add support for VXLAN tunnels to Open vSwitch

2012-11-27 Thread Stephen Hemminger
On Tue, 27 Nov 2012 15:19:24 -0500 Kyle Mestery wrote: > Note: v4 of this patch removes VXLAN over IPSEC support, > per an offline conversation with Jesse. > > Add support for VXLAN tunnels to Open vSwitch. Add support > for setting the destination UDP port on a per-port basis. > This is done by