Re: [ovs-dev] [PATCH v2] ovs-router: Report ovs/route/add errors as errors.

2015-11-23 Thread Ben Pfaff
On Wed, Nov 11, 2015 at 12:19:25PM -0200, Thadeu Lima de Souza Cascardo wrote: > On Tue, Nov 10, 2015 at 04:13:47PM -0800, Ben Pfaff wrote: > > The _error version should be used to report errors. > > > > Also, add missing return in one error case. > > > > Signed-off-by: Ben Pfaff > > --- > > v1-

Re: [ovs-dev] [PATCH v2] ovs-router: Report ovs/route/add errors as errors.

2015-11-11 Thread Thadeu Lima de Souza Cascardo
On Wed, Nov 11, 2015 at 12:19:25PM -0200, Thadeu Lima de Souza Cascardo wrote: > On Tue, Nov 10, 2015 at 04:13:47PM -0800, Ben Pfaff wrote: > > The _error version should be used to report errors. > > > > Also, add missing return in one error case. > > > > Signed-off-by: Ben Pfaff > > --- > > v1-

Re: [ovs-dev] [PATCH v2] ovs-router: Report ovs/route/add errors as errors.

2015-11-11 Thread Thadeu Lima de Souza Cascardo
On Tue, Nov 10, 2015 at 04:13:47PM -0800, Ben Pfaff wrote: > The _error version should be used to report errors. > > Also, add missing return in one error case. > > Signed-off-by: Ben Pfaff > --- > v1->v2: Add missing return in error case (thanks Cascardo!). > > lib/ovs-router.c | 12 +++--