On Wed, Nov 11, 2015 at 12:19:25PM -0200, Thadeu Lima de Souza Cascardo wrote:
> On Tue, Nov 10, 2015 at 04:13:47PM -0800, Ben Pfaff wrote:
> > The _error version should be used to report errors.
> >
> > Also, add missing return in one error case.
> >
> > Signed-off-by: Ben Pfaff <[email protected]>
> > ---
> > v1->v2: Add missing return in error case (thanks Cascardo!).
> >
> > lib/ovs-router.c | 12 +++++++-----
> > 1 file changed, 7 insertions(+), 5 deletions(-)
> >
All other uses are fine, when considering only the context of the function they
are called in. Many of them use the pattern of using return or goto out/exit in
the same block as calling unixctl_command_reply{,_error}. No use of return when
at the end of the function in a if/else if/else block.
Cascardo.
_______________________________________________
dev mailing list
[email protected]
http://openvswitch.org/mailman/listinfo/dev
