Re: [ovs-dev] [PATCH v2] Add configurable OpenFlow port name.

2016-04-21 Thread Takashi YAMAMOTO
i don't have any problem with Xiao's approach. just wanted to make sure alternatives considered. wrt implementation, Xiao, can you rebase it? On Fri, Apr 22, 2016 at 3:39 AM, Ben Pfaff wrote: > Yamamoto-san, I could really use your opinion here: do you think that > this should be done different

Re: [ovs-dev] [PATCH v2] Add configurable OpenFlow port name.

2016-04-21 Thread Ben Pfaff
Yamamoto-san, I could really use your opinion here: do you think that this should be done differently? If you do, then I will not accept it. But if you do not feel strongly about it, then I'll start properly reviewing it. Thanks, Ben. On Mon, Apr 18, 2016 at 07:05:52PM +0800, Xiao Liang wrote:

Re: [ovs-dev] [PATCH v2] Add configurable OpenFlow port name.

2016-04-18 Thread Xiao Liang
On Mon, Apr 18, 2016 at 5:46 PM, Takashi YAMAMOTO wrote: > for some reasons you want to change of_name without re-creating a port? > why? (just curious) > I don't have special use cases, just for convenience. > > On Mon, Apr 18, 2016 at 4:19 PM, Xiao Liang wrote: >> >> By introducing of_name, o

Re: [ovs-dev] [PATCH v2] Add configurable OpenFlow port name.

2016-04-18 Thread Takashi YAMAMOTO
for some reasons you want to change of_name without re-creating a port? why? (just curious) On Mon, Apr 18, 2016 at 4:19 PM, Xiao Liang wrote: > By introducing of_name, ovs_name serves as a key of ports which is > shared by ofproto and netdev. It's easier to find and convert ports > back and for

Re: [ovs-dev] [PATCH v2] Add configurable OpenFlow port name.

2016-04-18 Thread Xiao Liang
By introducing of_name, ovs_name serves as a key of ports which is shared by ofproto and netdev. It's easier to find and convert ports back and forth. of_name and kernel_name could be configured (if supported) independently of each other. On Mon, Apr 18, 2016 at 11:43 AM, Takashi YAMAMOTO wrote:

Re: [ovs-dev] [PATCH v2] Add configurable OpenFlow port name.

2016-04-17 Thread Takashi YAMAMOTO
let me explain what netdev-bsd does first. on some platform "tap" interfaces are always named automatically by kernel itself and there's no way to rename them. say, they always will have names like "tap0". so if you does "ovs-vsctl add-port br0 foo", ovs_name = "foo" kernel_name = "tap0" now,

Re: [ovs-dev] [PATCH v2] Add configurable OpenFlow port name.

2016-04-17 Thread Xiao Liang
Hi Ben, Yamamoto-san, Kindly remind you of this thread. Would like to hear your preference on the way to implement this feature. On Mon, Apr 11, 2016 at 11:18 PM, Ben Pfaff wrote: > On Mon, Apr 11, 2016 at 04:30:04PM +0800, Xiao Liang wrote: >> On Mon, Apr 11, 2016 at 3:42 PM, Takashi Yamamoto

Re: [ovs-dev] [PATCH v2] Add configurable OpenFlow port name.

2016-04-11 Thread Ben Pfaff
On Mon, Apr 11, 2016 at 04:30:04PM +0800, Xiao Liang wrote: > On Mon, Apr 11, 2016 at 3:42 PM, Takashi Yamamoto > wrote: > > hi, > > > > have you considered the opposite way? > > ie. have an ability to specify the device name. > > > > netdev-bsd already has a distinction between "kernel name" and

Re: [ovs-dev] [PATCH v2] Add configurable OpenFlow port name.

2016-04-11 Thread Xiao Liang
On Mon, Apr 11, 2016 at 3:42 PM, Takashi Yamamoto wrote: > hi, > > have you considered the opposite way? > ie. have an ability to specify the device name. > > netdev-bsd already has a distinction between "kernel name" and "ovs name". > Hi, I'm not familiar with netdev-bsd code, but I think this

Re: [ovs-dev] [PATCH v2] Add configurable OpenFlow port name.

2016-04-11 Thread Takashi Yamamoto
hi, have you considered the opposite way? ie. have an ability to specify the device name. netdev-bsd already has a distinction between "kernel name" and "ovs name". On Mon, Apr 11, 2016 at 4:23 PM, Xiao Liang wrote: > Add new column "ofname" in Interface table to configure port name reported >