Re: [ovs-dev] [PATCH v1 4/4] openvswitch: Userspace tunneling.

2014-11-03 Thread Pravin Shelar
On Mon, Nov 3, 2014 at 1:42 PM, Ben Pfaff wrote: > On Mon, Nov 3, 2014 at 1:33 PM, Pravin Shelar wrote: >> On Mon, Nov 3, 2014 at 12:31 PM, Ben Pfaff wrote: >>> ip_hdr() and gre_hdr() might be avoided if the ofpbuf's header support >>> were used. >>> >> ofpbuf header might not be set in all case

Re: [ovs-dev] [PATCH v1 4/4] openvswitch: Userspace tunneling.

2014-11-03 Thread Ben Pfaff
On Mon, Nov 3, 2014 at 1:33 PM, Pravin Shelar wrote: > On Mon, Nov 3, 2014 at 12:31 PM, Ben Pfaff wrote: >> ip_hdr() and gre_hdr() might be avoided if the ofpbuf's header support >> were used. >> > ofpbuf header might not be set in all cases. I think that ip_hdr() is used only in a function that

Re: [ovs-dev] [PATCH v1 4/4] openvswitch: Userspace tunneling.

2014-11-03 Thread Pravin Shelar
On Mon, Nov 3, 2014 at 12:31 PM, Ben Pfaff wrote: > On Fri, Oct 24, 2014 at 09:43:39AM -0700, Ben Pfaff wrote: >> On Thu, Oct 16, 2014 at 11:38:20AM -0700, Pravin B Shelar wrote: >> > Following patch adds support for userspace tunneling. Tunneling >> > needs three more component first is routing t

Re: [ovs-dev] [PATCH v1 4/4] openvswitch: Userspace tunneling.

2014-11-03 Thread Ben Pfaff
On Fri, Oct 24, 2014 at 09:43:39AM -0700, Ben Pfaff wrote: > On Thu, Oct 16, 2014 at 11:38:20AM -0700, Pravin B Shelar wrote: > > Following patch adds support for userspace tunneling. Tunneling > > needs three more component first is routing table which is configured by > > caching kernel routes an

Re: [ovs-dev] [PATCH v1 4/4] openvswitch: Userspace tunneling.

2014-10-27 Thread Jarno Rajahalme
With comments below: Acked-by: Jarno Rajahalme On Oct 16, 2014, at 11:38 AM, Pravin B Shelar wrote: > diff --git a/README-native-tunneling b/README-native-tunneling > new file mode 100644 > index 000..5cc17ec > --- /dev/null > +++ b/README-native-tunneling > @@ -0,0 +1,83 @@ > + > +Open vS

Re: [ovs-dev] [PATCH v1 4/4] openvswitch: Userspace tunneling.

2014-10-27 Thread David Christensen
> >> /** > >> * enum ovs_action_attr - Action types. > >> * > >> @@ -633,6 +642,10 @@ enum ovs_action_attr { > >> * data immediately followed by a > mask. > >> * The data must be zero for the > unmasked > >>

Re: [ovs-dev] [PATCH v1 4/4] openvswitch: Userspace tunneling.

2014-10-27 Thread Pravin Shelar
On Fri, Oct 24, 2014 at 3:16 PM, Thomas Graf wrote: > On 10/24/14 at 12:23pm, Pravin Shelar wrote: >> >> * enum ovs_action_attr - Action types. >> >> * >> >> @@ -633,6 +642,10 @@ enum ovs_action_attr { >> >> * data immediately followed by a >> >> mask. >>

Re: [ovs-dev] [PATCH v1 4/4] openvswitch: Userspace tunneling.

2014-10-27 Thread Pravin Shelar
On Fri, Oct 24, 2014 at 3:44 PM, Thomas Graf wrote: > On 10/24/14 at 01:43pm, Pravin Shelar wrote: >> On Fri, Oct 24, 2014 at 12:41 PM, Kyle Mestery wrote: >> > Neutron uses those for the physical bridge mappings when using the OVS >> > agent with the ML2 plugin [1] and VLANs. >> > >> > [1] >> >

Re: [ovs-dev] [PATCH v1 4/4] openvswitch: Userspace tunneling.

2014-10-24 Thread Thomas Graf
On 10/24/14 at 01:43pm, Pravin Shelar wrote: > On Fri, Oct 24, 2014 at 12:41 PM, Kyle Mestery wrote: > > Neutron uses those for the physical bridge mappings when using the OVS > > agent with the ML2 plugin [1] and VLANs. > > > > [1] > > http://docs.openstack.org/havana/install-guide/install/apt/c

Re: [ovs-dev] [PATCH v1 4/4] openvswitch: Userspace tunneling.

2014-10-24 Thread Thomas Graf
On 10/24/14 at 12:23pm, Pravin Shelar wrote: > >> * enum ovs_action_attr - Action types. > >> * > >> @@ -633,6 +642,10 @@ enum ovs_action_attr { > >> * data immediately followed by a mask. > >> * The data must be zero for

Re: [ovs-dev] [PATCH v1 4/4] openvswitch: Userspace tunneling.

2014-10-24 Thread Pravin Shelar
On Fri, Oct 24, 2014 at 12:41 PM, Kyle Mestery wrote: > On Fri, Oct 24, 2014 at 2:23 PM, Pravin Shelar wrote: >> On Fri, Oct 24, 2014 at 7:05 AM, Thomas Graf wrote: >>> First of all, great to see this work. This is awesome! I read through >>> the code a first time. Planning to do more reviewing

Re: [ovs-dev] [PATCH v1 4/4] openvswitch: Userspace tunneling.

2014-10-24 Thread Kyle Mestery
On Fri, Oct 24, 2014 at 2:23 PM, Pravin Shelar wrote: > On Fri, Oct 24, 2014 at 7:05 AM, Thomas Graf wrote: >> First of all, great to see this work. This is awesome! I read through >> the code a first time. Planning to do more reviewing but looks very >> sane already. >> >> On 10/16/14 at 11:38am

Re: [ovs-dev] [PATCH v1 4/4] openvswitch: Userspace tunneling.

2014-10-24 Thread Pravin Shelar
On Fri, Oct 24, 2014 at 9:43 AM, Ben Pfaff wrote: > On Thu, Oct 16, 2014 at 11:38:20AM -0700, Pravin B Shelar wrote: >> Following patch adds support for userspace tunneling. Tunneling >> needs three more component first is routing table which is configured by >> caching kernel routes and second is

Re: [ovs-dev] [PATCH v1 4/4] openvswitch: Userspace tunneling.

2014-10-24 Thread Pravin Shelar
On Fri, Oct 24, 2014 at 7:05 AM, Thomas Graf wrote: > First of all, great to see this work. This is awesome! I read through > the code a first time. Planning to do more reviewing but looks very > sane already. > > On 10/16/14 at 11:38am, Pravin B Shelar wrote: >> + 192.168.1.1/24 >> +

Re: [ovs-dev] [PATCH v1 4/4] openvswitch: Userspace tunneling.

2014-10-24 Thread Ben Pfaff
On Thu, Oct 16, 2014 at 11:38:20AM -0700, Pravin B Shelar wrote: > Following patch adds support for userspace tunneling. Tunneling > needs three more component first is routing table which is configured by > caching kernel routes and second is ARP cache which build automatically > by snooping arp.

Re: [ovs-dev] [PATCH v1 4/4] openvswitch: Userspace tunneling.

2014-10-24 Thread Thomas Graf
First of all, great to see this work. This is awesome! I read through the code a first time. Planning to do more reviewing but looks very sane already. On 10/16/14 at 11:38am, Pravin B Shelar wrote: > + 192.168.1.1/24 > + +--+ > + |int-br|