Alex,
Thanks, I just pushed this,
Jarno
On Dec 20, 2013, at 12:47 PM, Alex Wang wrote:
>
> Thanks Jarno for the review, please see my explanation below,
>
>
> On Fri, Dec 20, 2013 at 11:29 AM, Jarno Rajahalme
> wrote:
> mport. */
> > -next_wake_time = MIN(bfd_wake_time(mport->bf
Thanks Jarno for the review, please see my explanation below,
On Fri, Dec 20, 2013 at 11:29 AM, Jarno Rajahalme wrote:
> mport. */
> > -next_wake_time = MIN(bfd_wake_time(mport->bfd),
> cfm_wake_time(mport->cfm));
> > -heap_change(&monitor_heap, heap_max(&monitor_heap),
> > +
Alex,
I’m not familiar with the code, so I’ll ask you to explain some things below,
Jarno
On Dec 16, 2013, at 9:30 AM, Alex Wang wrote:
> Commit 307464a11 (ofproto-dpif-monitor: Use heap to order the mport
> wakeup time.) makes bfd only send packet at specified periodic instant.
> This fails
I have not reviewed the code, but I tested it once I run into the BFD decay
test persistently failing on me. Before, I had to wait about 1.5 secs for the
poll sequence to finish at around line 340 in tests/bfd.at, with this patch no
such delay is necessary, so it seems to work as advertised.
On Mon, Dec 16, 2013 at 09:30:11AM -0800, Alex Wang wrote:
> Commit 307464a11 (ofproto-dpif-monitor: Use heap to order the mport
> wakeup time.) makes bfd only send packet at specified periodic instant.
> This fails to meet the RFC5880 requirement, which requires bfd send
> FINAL immediately after
