I have not reviewed the code, but I tested it once I run into the BFD decay test persistently failing on me. Before, I had to wait about 1.5 secs for the poll sequence to finish at around line 340 in tests/bfd.at, with this patch no such delay is necessary, so it seems to work as advertised.
Jarno On Dec 17, 2013, at 3:46 PM, Ben Pfaff <b...@nicira.com> wrote: > On Mon, Dec 16, 2013 at 09:30:11AM -0800, Alex Wang wrote: >> Commit 307464a11 (ofproto-dpif-monitor: Use heap to order the mport >> wakeup time.) makes bfd only send packet at specified periodic instant. >> This fails to meet the RFC5880 requirement, which requires bfd send >> FINAL immediately after receiving POLL. >> >> This commit fixes the above issue by scheduling bfd to send FINAL >> within 100 ms after receiving POLL. >> >> Signed-off-by: Alex Wang <al...@nicira.com> > > Ethan, will you review this one? > _______________________________________________ > dev mailing list > dev@openvswitch.org > http://openvswitch.org/mailman/listinfo/dev _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
