On Tue, Aug 13, 2013 at 10:50 AM, Alex Wang wrote:
> I think the intention is right here, but it's a bit odd. For example,
>> if in_decay is true, we don't drop out of it with this logic in all
>> cases. How about we add a boolean to this function
>> "cfm_min_rx_changed" and set it to true here
Thanks very much for the review,
On Mon, Aug 12, 2013 at 11:47 PM, Ethan Jackson wrote:
>
> >>> +/* Always resets decay_min_rx when cfg_min_rx is updated. */
> >>> +bfd->decay_min_rx = 0;
> >>> +bfd_poll(bfd);
>
> I think the intention is right here, but it's a bit odd.
On Tue, Aug 13, 2013 at 02:47:43PM +0800, Ethan Jackson wrote:
> Thanks this version is much closer. Just some minor points which
> should be pretty easy to clean up. Ben, so we don't have a 12 hour
> review cycle on this, would you mind looking at the next version of
> this patch (which should b
Thanks this version is much closer. Just some minor points which
should be pretty easy to clean up. Ben, so we don't have a 12 hour
review cycle on this, would you mind looking at the next version of
this patch (which should be pretty much there) and applying it if it's
ready?
>>> +/* Al
> This is the newest version,
>
> I think I address most of issues, mentioned in your comments,
Ah ok I'll have a look at this one. Thanks.
Ethan
>
>
> On Tue, Aug 6, 2013 at 8:51 AM, Alex Wang wrote:
>>
>> When there is no incoming data traffic at the interface for a period,
>> BFD decay allo
Hey Ethan,
This is the newest version,
I think I address most of issues, mentioned in your comments,
Kind Regards,
Alex Wang,
On Tue, Aug 6, 2013 at 8:51 AM, Alex Wang wrote:
> When there is no incoming data traffic at the interface for a period,
> BFD decay allows the bfd session to increas
